Commit Graph

98749 Commits

Author SHA1 Message Date
Samuel Just
5c76f63078 vstart: add --redirect-output option to redirect output for --nodaemon
Useful for crimson which doesn't currently support writing directly
to a log file.

Signed-off-by: Samuel Just <sjust@redhat.com>
2019-05-31 14:05:44 -07:00
Samuel Just
e799b38aed crimson/osd: use configured ceph-osd uuid in mkfs
Signed-off-by: Samuel Just <sjust@redhat.com>
2019-05-31 14:05:44 -07:00
Samuel Just
d0dbb36e2e crimson/net/Connection: add peer_is_* helpers
Signed-off-by: Samuel Just <sjust@redhat.com>
2019-05-31 14:05:44 -07:00
Samuel Just
212593dac5 crimson/net/SocketMessenger: wait for accepter thread to die on shutdown
Otherwise, it ends up trying to operator<< *this after it's been
deleted.

Signed-off-by: Samuel Just <sjust@redhat.com>
2019-05-31 14:05:44 -07:00
Samuel Just
d07592eab7 crimson/mon/MonClient: handle mon client connection race
The first to establish a connection and close the others needs
to ensure that the others don't mess with broken state.  To that
end, leave a cleared pending_conns map while the conns are being
closed.  Also, take care to clean up outstanding promises and
fallout from conns disappearing.

Signed-off-by: Samuel Just <sjust@redhat.com>
2019-05-31 14:05:44 -07:00
Samuel Just
c839c2d42b crimson/os/cyan_store: run t.get_on_* contexts
PeeringState makes liberal use of those callbacks, run them
upon completion of do_transaction.

Signed-off-by: Samuel Just <sjust@redhat.com>
2019-05-31 14:05:44 -07:00
Samuel Just
382a649fa0 crimson/os/cyan_store: add some omap machinery
Adds transaction methods for PeeringState.

Mainly omap_set, but also a stub for collection hint and the other omap
update methods.  Also adds omap_get and debugging to dump the
transaction upon encountering a problem.

Also fixes up std and ceph::bufferlist namespace qualifications.

Signed-off-by: Samuel Just <sjust@redhat.com>
2019-05-31 14:05:44 -07:00
Samuel Just
201dd35656 os/cyan_collection: add pragma once
Signed-off-by: Samuel Just <sjust@redhat.com>
2019-05-31 14:05:44 -07:00
Samuel Just
b6e40a32cb osd/: move pg/osd state machinery into osd_types for use in crimson
Signed-off-by: Samuel Just <sjust@redhat.com>
2019-05-31 14:04:32 -07:00
Samuel Just
fdd38eabd6 PGLog: add cyan_store machinery for reading the log
Signed-off-by: Samuel Just <sjust@redhat.com>
2019-05-31 14:04:28 -07:00
Nathan Fish
46a9d1b78c doc: Add warning that the root directory cannot be fragmented
Documents: #39704

Signed-off-by: Nathan Fish <lordcirth@gmail.com>
2019-05-31 16:38:22 -04:00
Patrick Donnelly
d1ae3194d8
Merge PR #28199 into master
* refs/pull/28199/head:
	qa/tasks: upgrade the check for -c sudo option in vstart_runner.py

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-05-31 13:10:18 -07:00
Matt Benjamin
955c832df9
Merge pull request #28108 from linuxbox2/wip-rgwfile-reqid
Wip rgwfile reqid:  absorbs rgw_file: allocate new id for continued request #25664
2019-05-31 13:25:02 -04:00
Mykola Golub
4c5e9267ea
Merge pull request #28135 from dillaman/wip-39946
qa/workunits/rbd: remove 'fast-diff' from dynamic features test

Reviewed-by: Mykola Golub <mgolub@suse.com>
2019-05-31 17:16:46 +03:00
Mykola Golub
fa1bb804bf
Merge pull request #28295 from dillaman/wip-39952
librbd: do not unblock IO prior to growing object map during resize

Reviewed-by: Mykola Golub <mgolub@suse.com>
2019-05-31 15:56:02 +03:00
Jason Dillaman
d23bdb7931
Merge pull request #28296 from mcv21/doc-profile-rbd
doc: note explicitly that "profile rbd" allows blacklisting

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2019-05-31 08:29:21 -04:00
Radoslaw Zarzynski
f07c5dcb99 messages: MOSDPGCreate2 doesn't assume using namespace std.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2019-05-31 10:49:01 +02:00
Kefu Chai
714fbf64ae cmake/modules: replace ";" with " " in compile flags
as the flags should be a string, not a list

tested using

cmake -DCMAKE_LINKER=gold -DWITH_ASAN=ON -DWITH_ASAN_LEAK=ON \
-DCMAKE_BUILD_TYPE=Debug

on ubuntu xenial

without this change, cmake will fail with following warning:

CMake Error at src/CMakeLists.txt:112 (message):
  The compiler /usr/bin/c++ has no C++17 support.

-- Configuring incomplete, errors occurred!

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-05-31 16:19:08 +08:00
wujian
ae9cc1d723 mgr: remove unused variable pool_name
Signed-off-by: Alex Wu <wujian3659@163.com>
2019-05-31 04:05:59 -04:00
Kefu Chai
f3c9a47d6b
Merge pull request #28328 from tchaikov/wip-fix-ceph-helper-test
qa/standalone/ceph-helpers: resurrect all OSD before waiting for health

Reviewed-by: Sage Weil <sage@redhat.com>
2019-05-31 12:23:09 +08:00
Kefu Chai
52cdbfce4d
Merge pull request #28338 from Jing-Scott/dev/modify-scrub-comments
osd: update comment as sub_op_scrub_map has been removed

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-05-31 11:22:37 +08:00
Jing Wenjun
a1733da2c9 osd: the sub_op_scrub_map has been removed
sub_op_scrub_map replaced by do_replica_scrub_map, sync the comments.

Signed-off-by: Jing Wenjun <jingwenjun@cmss.chinamobile.com>
2019-05-31 10:16:08 +08:00
Kefu Chai
cc1af444d7
Merge pull request #25099 from Thingee/master
doc: Adding US-Mid-West Mirror to docs

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-05-31 09:56:20 +08:00
Patrick Donnelly
744f557106
Merge PR #25530 into master
* refs/pull/25530/head:
	mgr/diskprediction: Add diskprediction local plugin dependencies

Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Dan Mick <dmick@redhat.com>
2019-05-30 18:24:39 -07:00
Mike Perez
18048264e5 doc/install/mirrors: Adding US-Mid-West Mirror to docs
Signed-off-by: Mike Perez <thingee@gmail.com>
2019-05-31 09:06:55 +08:00
songweibin
32a044b091 rbd/action: fix error getting positional argument
Fixes: http://tracker.ceph.com/issues/40095

Signed-off-by: songweibin <song.weibin@zte.com.cn>
2019-05-31 07:51:32 +08:00
Sage Weil
8d137b9345 qa/suites/rados/multimon: create_rbd_pool: false
Signed-off-by: Sage Weil <sage@redhat.com>
2019-05-30 15:43:48 -05:00
Casey Bodley
0e2b6f5c1c
Merge pull request #27898 from alimaredia/wip-rgw-thread-yield-context-get-bucket-info
Thread optional yield context through  get_bucket_info call path

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2019-05-30 15:48:42 -04:00
Sage Weil
1991faaafe qa/suites/rados/multimon: no osds when skewing clock
Sometimes the clock skew prevents the mon quorum from making progress and
processing the osd boot messages.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-05-30 13:05:54 -05:00
Samuel Just
a90f2671ba PeeringState: permit init_from_disk_state to return a value
This way it can return a future.

Signed-off-by: Samuel Just <sjust@redhat.com>
2019-05-30 10:53:42 -07:00
Samuel Just
72a287bac0 PGPeeringEvent: move MLogRec constructor definition to .cc and add unique_ptr
Signed-off-by: Samuel Just <sjust@redhat.com>
2019-05-30 10:53:42 -07:00
Samuel Just
b3d1215847 src/osd/: add appropriate OSDMapRef defs for seastar to OSDMap,osd_types
Signed-off-by: Samuel Just <sjust@redhat.com>
2019-05-30 10:53:42 -07:00
Samuel Just
4320ed5ace PeeringState: modernize accept_buffered_messages
Signed-off-by: Samuel Just <sjust@redhat.com>
2019-05-30 10:53:42 -07:00
Samuel Just
3e776b524b osd/: Move PeeringCtx out of PeeringState to permit forward declaration
Signed-off-by: Samuel Just <sjust@redhat.com>
2019-05-30 10:53:42 -07:00
Samuel Just
33528143e9 crimson/os: Move CollectionRef out of CyanStore
This way, we don't need cyan_store.h to get CollectionRef

Signed-off-by: Samuel Just <sjust@redhat.com>
2019-05-30 10:53:42 -07:00
Sage Weil
c47b322bd3 Merge PR #27957 into master
* refs/pull/27957/head:
	json: JSONDecoder::err inherits from std::runtime_error
	rgw: RGWXMLDecoder::err inherits from std::runtime_error

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2019-05-30 12:26:17 -05:00
Kefu Chai
3cf14fcbe0
Merge pull request #28317 from tchaikov/wip-crimson-net-remove-redundant-move
crimson/net: remove redundant std::move()

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2019-05-31 01:16:26 +08:00
Kefu Chai
dea8e41930
Merge pull request #28289 from tchaikov/wip-kill-gcc-9-warnings
common,os: address string truncated warnings from GCC-9

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2019-05-30 23:56:41 +08:00
Kefu Chai
2953788f2a
Merge pull request #28055 from SUSE/wip-fix-39662
mgr/PyModuleRegistry: log error if we can't find any modules to load

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-05-30 23:56:02 +08:00
Kefu Chai
cdba0f1420 qa/standalone/ceph-helpers: resurrect all OSD before waiting for health
address the regression introduced by e62cfceb
in e62cfceb, we wanted to test the newly introduced TOO_FEW_OSDS
warning, so we increased the number of OSD to the size of pool, so if
the number of OSD is less than pool size, monitor will send a warning
message.

but we need to bring all OSDs back if we are expecting a healthy
cluster. in this change, all OSDs are resurrect before
`wait_for_health_ok`.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-05-30 23:52:36 +08:00
Kefu Chai
e5064b894c qa/run-standalone.sh: s/Makefile/CMakeCache.txt/
as we could use a generator other than Make, for instance ninja.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-05-30 23:52:36 +08:00
Jason Dillaman
c8ce520870 librbd: do not unblock IO prior to growing object map during resize
This could result in a small race condition where IO is able to write
beyond the current extent of the object map, resulting in an assertion
failure.

Fixes: http://tracker.ceph.com/issues/39952
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-05-30 10:32:20 -04:00
Casey Bodley
804bb853f1 rgw: parse_copy_location defers url-decode
don't url-decode until after we search for the ?, or we'll truncate
object names that contain a url-encoded ?

Fixes: http://tracker.ceph.com/issues/27217

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2019-05-30 10:24:14 -04:00
Kefu Chai
b300d60ffb crimson/net: remove redundant std::move()
see https://en.cppreference.com/w/cpp/language/copy_elision

it also silences warning like:

src/crimson/net/ProtocolV2.cc:146:26: warning: redundant move in return
statement [-Wredundant-move]
  146 |       return std::move(bl);
      |                          ^

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-05-30 22:06:46 +08:00
Kefu Chai
f6b022bdbe
Merge pull request #27806 from ashitakasam/add-osd-alarm
osd: Better error message when OSD count is less than osd_pool_default_size

Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-05-30 21:28:54 +08:00
Kefu Chai
b2019a164b
Merge pull request #28278 from tchaikov/wip-buffer-remove-advance-size_t
buffer.h: remove list::iterator_impl::advance(size_t)

Reviewed-by: James Page <james.page@ubuntu.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2019-05-30 21:26:27 +08:00
Kefu Chai
cca664e795
Merge pull request #28251 from xiexingguo/wip-balancer-new-osd-weight
mgr/balancer: fix initial weight-set value for newly created osds

Reviewed-by: Sage Weil <sage@redhat.com>
2019-05-30 21:23:44 +08:00
Kefu Chai
8b1e713254
Merge pull request #28107 from ifed01/wip-ifed-add-devices
os/bluestore: show device name in "osd metadata output"

Reviewed-by: Sage Weil <sage@redhat.com>
2019-05-30 21:20:15 +08:00
Kefu Chai
7a0d0f7285
Merge pull request #28277 from javacruft/32bit-compat-fixes
common: avoid use of size_t in options

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-05-30 21:18:43 +08:00
Jason Dillaman
d760291c2a
Merge pull request #28250 from tchaikov/wip-silence-warnings
mon,test: silence warnings from GCC and test

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2019-05-30 07:42:05 -04:00