Commit Graph

36367 Commits

Author SHA1 Message Date
Danny Al-Gaaf
c60a17075d test/librados/c_write_operations.cc: free ressources
Release completion as soon as no longer needed.

Fix for:

CID 1219593 (#1 of 1): Resource leak (RESOURCE_LEAK)
 leaked_storage: Variable completion going out of scope
 leaks the storage it points to.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2014-10-09 15:31:52 +02:00
Danny Al-Gaaf
042c5362bb rados_list_parallel.cc: cleanup before return from run()
Fix for another case of:

CID 717112 (#1 of 1): Resource leak (RESOURCE_LEAK)
 leaked_storage: Variable io_ctx going out of scope leaks
 the storage it points to.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2014-10-08 22:56:22 +02:00
Danny Al-Gaaf
3bba7ce800 test/librbd/fsx.c: fix potential unterminated string handling
In case of strncpy() make sure string is '\0' terminated. Before
usage of strcat() check if the destination has enough free space
to concat the char and to terminate the string to prevent illegal
memory access.

Fix for:

CID 1219459 (2 of 2): Buffer not null terminated (BUFFER_SIZE_WARNING)
 buffer_size_warning: Calling strncpy with a maximum size argument of
 1024 bytes on destination array goodfile of size 1024 bytes might
 leave the destination string unterminated.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2014-10-08 22:56:22 +02:00
Danny Al-Gaaf
b414b1dc87 ErasureCodeIsa.cc: reduce scope of variables
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2014-10-08 22:56:22 +02:00
Danny Al-Gaaf
557ca80ff2 SyntheticClient.cc: reduce scope of variables
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2014-10-08 22:56:22 +02:00
Danny Al-Gaaf
43c0d37b5c mds/flock.cc: reduce scope of some variables
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2014-10-08 22:56:22 +02:00
Danny Al-Gaaf
d75856bec7 osd/ReplicatedBackend.cc: prefer ++operator for non-primitive iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2014-10-08 22:56:22 +02:00
Danny Al-Gaaf
72e708c24a osd/OSDMap.cc: prefer ++operator for non-primitive iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2014-10-08 22:56:22 +02:00
Danny Al-Gaaf
46692332db mount.ceph.c: ensure '\0' terminated string
Reserve last char in array for '\0' to ensure termination
of the string.

Fix for:

CID 1128383 (#1 of 1): Buffer not null terminated (BUFFER_SIZE_WARNING)
 buffer_size_warning: Calling strncpy with a maximum size argument
 of 1000 bytes on destination array secret of size 1000 bytes might
 leave the destination string unterminated.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2014-10-08 22:56:22 +02:00
Sage Weil
0bbd879841 Merge pull request #2586 from ceph/wip-mon-status
mon: make health portion of ceph -s readable (multiple lines)

Reviewed-by: Joao Eduardo Luis <joao.luis@inktank.com>
2014-10-08 12:39:01 -07:00
Loic Dachary
a389ffa4e3 Merge pull request #2673 from dachary/wip-ceph-erasure-code-corpus
build: add ceph-erasure-code-corpus to gitmodule_mirrors

Reviewed-by: Sandon Van Ness <sandon@inktank.com>
2014-10-08 21:26:11 +02:00
Loic Dachary
865a0dc684 build: add ceph-erasure-code-corpus to gitmodule_mirrors
Signed-off-by: Loic Dachary <loic-201408@dachary.org>
2014-10-08 21:22:02 +02:00
Samuel Just
3d3389701b Merge remote-tracking branch 'upstream/giant' 2014-10-08 11:18:13 -07:00
Samuel Just
3bfb5fab41 Merge pull request #2616 from guangyy/wip-giant-9614
PG::actingset should be used when checking the number of acting OSDs for a given PG.

Backport: firefly
Reviewed-by: Samuel Just <sam.just@inktank.com>
2014-10-08 11:08:35 -07:00
Samuel Just
e0d37c55a3 Merge pull request #2663 from ceph/wip-9496
mon: PGMonitor: populate scrub timestamps with 'now' on pg creation

Reviewed-by: Samuel Just <sam.just@inktank.com>
2014-10-08 11:07:06 -07:00
Samuel Just
4a5af13912 Merge pull request #2650 from ceph/wip-9128
Add reset_tp_timeout in long loop in add_source_info for suicide timeout

Reviewed-by: Samuel Just <sam.just@inktank.com>
2014-10-08 11:04:42 -07:00
Samuel Just
e684abcb3f Merge pull request #2543 from ceph/wip-9419
Wip 9419

Reviewed-by: Samuel Just <sam.just@inktank.com>
2014-10-08 11:01:26 -07:00
John Spray
9f97c491f3 Merge pull request #2670 from dachary/wip-9700-cephtool-mon-osd
qa: move mon_mds tests last

Reviewed-by: John Spray <john.spray@redhat.com>
2014-10-08 15:45:29 +01:00
Loic Dachary
9b3d345d50 qa: move mon_mds tests last
Assuming they are more likely than others to leave OSD/MON in an
unstable state that could have undefined side effects on the tests
following it. A cleaner solution would be to run them in a separate
script that is run on an independent cluster.

http://tracker.ceph.com/issues/9700 Fixes: #9700

Signed-off-by: Loic Dachary <loic-201408@dachary.org>
2014-10-08 16:33:22 +02:00
John Spray
bf33e11944 Merge pull request #2569 from ceph/wip-9437
Implement `tell` in MDS

Reviewed-by: Reviewed-by: Greg Farnum <greg@inktank.com>
2014-10-08 15:28:01 +01:00
John Spray
e27cf4139f qa: cephtool tests for tell mds.X
Signed-off-by: John Spray <john.spray@redhat.com>
2014-10-08 12:01:21 +01:00
John Spray
620a722da3 qa: fixup cephtool test when MDS exists
We added MDS resetting code here a while back,
but the order of operations was such that a
"cluster up" was being run between a fail_all_mds
and the point at which we needed the map not to
be interfered with (testing setmap).

Also the new fs create/destroy cycles for testing
EC pool handling were missing calls to stop the
daemons before fs rm.

Signed-off-by: John Spray <john.spray@redhat.com>
2014-10-08 11:58:20 +01:00
John Spray
82ecf60b7b test: unit tests for MDSAuthCaps
Signed-off-by: John Spray <john.spray@redhat.com>
2014-10-08 11:58:20 +01:00
John Spray
d15ecafea4 vstart: create fewer pgs for fs pools
Just so that dev clusters come up more
quickly.

Signed-off-by: John Spray <john.spray@redhat.com>
2014-10-08 11:58:20 +01:00
John Spray
5f6589cb1f vstart: mds * auth caps
...so that the default client.admin identity
can call 'tell mds' things.

Signed-off-by: John Spray <john.spray@redhat.com>
2014-10-08 11:58:20 +01:00
John Spray
316660d539 mds: fix MDSAuthCap when cephx is disabled
Signed-off-by: John Spray <john.spray@redhat.com>
2014-10-08 11:58:20 +01:00
John Spray
92178bc015 pybind/ceph_argparse: implement 'tell mds'
Signed-off-by: John Spray <john.spray@redhat.com>
2014-10-08 11:58:19 +01:00
John Spray
44e8390f06 pybind/cephfs: implement mds_command
Signed-off-by: John Spray <john.spray@redhat.com>
2014-10-08 11:58:19 +01:00
John Spray
0909fe4faf pybind/cephfs: implement conf_parse_argv
So that when using `ceph` we can pass through
--debug-x args etc.

Signed-off-by: John Spray <john.spray@redhat.com>
2014-10-08 11:58:19 +01:00
John Spray
1eb93f5be4 pybind/rados: add conf/conf_defaults attributes
Store these from initialization so that given a Rados
object, we can read back config to initialize a
LibCephFS object.

Signed-off-by: John Spray <john.spray@redhat.com>
2014-10-08 11:58:19 +01:00
John Spray
fba3ede848 libcephfs: add ceph_mds_command
Wraps the equivalent fn in Client.

Signed-off-by: John Spray <john.spray@redhat.com>
2014-10-08 11:58:19 +01:00
John Spray
688396ac65 client: add mds_command operation
akin to Objecter::osd_command

Signed-off-by: John Spray <john.spray@redhat.com>
2014-10-08 11:58:19 +01:00
John Spray
b9c0ce4f4a osdc/Objecter: don't consume non-osd cmd replies
...so that Client can get command replies from MDSs.

Signed-off-by: John Spray <john.spray@redhat.com>
2014-10-08 11:58:19 +01:00
John Spray
e8f3f6b91c mds: introduce MDS auth caps
Signed-off-by: John Spray <john.spray@redhat.com>
2014-10-08 11:58:19 +01:00
John Spray
fad2865f96 mds: handle MCommand (mds tell)
Separate path to legacy MMonCommand, because MCommand
from the CLI sends JSON-style commands.

Signed-off-by: John Spray <john.spray@redhat.com>
2014-10-08 11:58:19 +01:00
John Spray
5e7cb60827 mds: deprecation-warn on numeric mds names
To be turned into strict check in post-hammer
release, so that we can always unambiguously
discriminate a string into one of name, rank, gid.

Signed-off-by: John Spray <john.spray@redhat.com>
2014-10-08 11:58:19 +01:00
John Spray
9552e8fc44 common: fix cmd_getval constness
...so that one can pass in a const cmdmap.

Signed-off-by: John Spray <john.spray@redhat.com>
2014-10-08 11:58:19 +01:00
John Spray
9610029d3e messages: fix constness in MCommand constructor
Signed-off-by: John Spray <john.spray@redhat.com>
2014-10-08 11:58:19 +01:00
John Spray
f93bf3853f mds: typedefs for rank and gid in MDSMap
Make it clearer what these numbers are where they appear.

Signed-off-by: John Spray <john.spray@redhat.com>
2014-10-08 11:58:18 +01:00
Loic Dachary
da074f02cd Merge pull request #2668 from theanalyst/fix/mailmap-again
Fix/mailmap again

Reviewed-by: Loic Dachary <loic-201408@dachary.org>
2014-10-08 12:11:02 +02:00
Abhishek Lekshmanan
90ca5e3c68 mailmap: João Eduardo Luís name normalization
Reported-by: Loic Dachary <loic@dachary.org>
Signed-off-by: Abhishek Lekshmanan <abhishek.lekshmanan@gmail.com>
2014-10-08 15:10:09 +05:30
Abhishek Lekshmanan
c967ced78d mailmap: Yongyue sun affiliation
Signed-off-by: Abhishek Lekshmanan <abhishek.lekshmanan@gmail.com>
2014-10-08 15:10:09 +05:30
Abhishek Lekshmanan
8149ac6328 mailmap: Andreas Peters name normalization
Reported-by: Loic Dachary <loic@dachary.org>
Signed-off-by: Abhishek Lekshmanan <abhishek.lekshmanan@gmail.com>
2014-10-08 15:10:09 +05:30
Loic Dachary
8be3446e86 Merge pull request #2665 from yuyuyu101/update-mailmap
mailmap: add yuandong to organizationmap

Reviewed-by: Loic Dachary <loic-201408@dachary.org>
2014-10-08 10:18:54 +02:00
Haomai Wang
cb36ccbbac mailmap: add yuandong to organizationmap
Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
2014-10-08 15:23:47 +08:00
Loic Dachary
66eb04664f Merge pull request #2661 from dachary/wip-9677-ioprio-class-giant
common: ceph_ioprio_string_to_class always returns -EINVAL
2014-10-08 08:44:08 +02:00
Gregory Farnum
1b7fae7b29 Merge pull request #2617 from ceph/wip-9628
mds: Add session to sessionmap when its state becomes opening

Reviewed-by: Greg Farnum <greg@inktank.com>
2014-10-07 19:26:20 -07:00
Joao Eduardo Luis
0dd3afd87e mon: PGMonitor: populate scrub timestamps with 'now' on pg creation
Fixes: #9496

Signed-off-by: Joao Eduardo Luis <joao@redhat.com>
2014-10-08 00:13:49 +01:00
Joao Eduardo Luis
ccdbfb441a mon: PGMonitor: prettify access to pg_stats_t in register_pg
Signed-off-by: Joao Eduardo Luis <joao@redhat.com>
2014-10-08 00:12:29 +01:00
Sage Weil
60de42c296 Merge pull request #2660 from athanatos/wip-9203
test/osd/Object: don't generate length of 0

Reviewed-by: Sage Weil <sage@redhat.com>
2014-10-07 14:08:39 -07:00