Commit Graph

99340 Commits

Author SHA1 Message Date
Lenz Grimmer
f90c111388 doc: Improved dashboard feature overview
Added some newly added features, improved wording.

Signed-off-by: Lenz Grimmer <lgrimmer@suse.com>
2019-06-27 09:25:25 +02:00
Ramana Raja
695c493257 mgr/volumes: fix incorrect VolumeException arguments
Fixes: http://tracker.ceph.com/issues/40429
Signed-off-by: Ramana Raja <rraja@redhat.com>
2019-06-27 02:07:58 +05:30
Ramana Raja
5c00cc30a1 mgr/volumes: allow setting mode
... of fs subvolumes and subvolume groups during their creation.

Fixes: https://tracker.ceph.com/issues/40299
Signed-off-by: Ramana Raja <rraja@redhat.com>
2019-06-27 02:07:56 +05:30
Ramana Raja
22ed891528 mgr/volumes: allow setting data pool layout
... of fs subvolumes and subvolume groups during their creation.

Fixes: https://tracker.ceph.com/issues/40431
Signed-off-by: Ramana Raja <rraja@redhat.com>
2019-06-27 01:36:33 +05:30
Kefu Chai
c86a27779b
Merge pull request #28593 from smithfarm/wip-40398
cmake: set empty INSTALL_RPATH on crypto shared libs

Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-06-26 23:33:45 +08:00
Jason Dillaman
5d6134fb35 librbd: prevent concurrent AIO callbacks to external clients
With the various threads and conditional IO paths within librbd, it was
possible for external AIO callbacks to be concurrently executed from
different librbd threads. These callbacks should be serialized to reduce
the unexpected potential for data corruption.

Fixes: http://tracker.ceph.com/issues/40417
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-06-26 09:07:22 -04:00
Kanika Murarka
a4d7bb29a3 mgr/dashboard: Separate file for icons for refering and reusing
Fixes: http://tracker.ceph.com/issues/39032
Signed-off-by: Kanika Murarka <kmurarka@redhat.com>
2019-06-26 13:56:13 +05:30
Kefu Chai
0b3f805f16
Merge pull request #28623 from cyx1231st/wip-seastar-msgr-socket
test/crimson: add unit-test for ceph::net::Socket

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-06-26 13:55:45 +08:00
Yingxin Cheng
901a56d1bc crimson/net: added support for new errors
connection_aborted and invalid_argument.

Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>
2019-06-26 18:05:58 +08:00
Yingxin Cheng
e5107964ad test/crimson: add unit-test for ceph::net::Socket
Added unittest_seastar_socket to make sure that seastar network layer
works as expected.

Added missing error code invalid_argument and address_in_use.

Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>
2019-06-26 18:05:50 +08:00
hydro-b
fa22b02694 doc/radosgw/compression.rst: fix typo
Signed-off-by: hydro-b <stefan@kooman.org>
2019-06-26 08:57:06 +08:00
Kefu Chai
60f449b36f
Merge pull request #28747 from tchaikov/wip-more-than-activate
crimson/osd: update peering_state in PG::on_activate_complete()

Reviewed-by: Samuel Just <sjust@redhat.com>
2019-06-26 08:53:20 +08:00
Neha Ojha
bfccdecb94 doc/rados/operations/erasure-code.rst: allow recovery below min_size
https://github.com/ceph/ceph/pull/17619 allows recovery below min_size
for EC pools starting in Octopus. Also mention that this wasn't allowed
earlier.

Fixes: https://tracker.ceph.com/issues/40488
Signed-off-by: Neha Ojha <nojha@redhat.com>
2019-06-25 15:48:48 -07:00
J. Eric Ivancich
fb86290920 rgw: minor code clean-up
Adding some const correctness and reformatting.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
2019-06-25 16:54:58 -04:00
J. Eric Ivancich
51aff62ac7 rgw: allow multipart upload abort to proceed
Cleaning up after aborting unfinished multipart uploads is a
best-effort process. Due to the history of the multipart upload, not
all components may be found and the process needs to be robust to
that.

Presently, if a component is not found after the final call to
list_bucket_multiparts, the error propogates to the caller, but not if
the component is not found in an earlier call. This change does not
propogate that error up ever.

Additional logging is also added to multipart-related functions.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
2019-06-25 16:54:03 -04:00
Mykola Golub
25a2336494 journal: fix race between player shut down and cache rebalance
Signed-off-by: Mykola Golub <mgolub@suse.com>
2019-06-25 18:02:49 +01:00
Kefu Chai
823b3404e6 crimson/osd: update peering_state in PG::on_activate_complete()
so that the PG can mark itself clean when it is activated and does not
need recovery.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-06-26 00:18:48 +08:00
Kefu Chai
b351ad55fd crimson/osd: use get_osdmap_epoch()
would be better to use the interfaces of the PG class, instead of
relying on its implementation.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-06-26 00:18:48 +08:00
Kefu Chai
7959e5075a mon/Monitor: no need to create a local variable for capturing it
just capture `changed` by value would suffice.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-06-25 22:42:26 +08:00
Kefu Chai
8e8db70317
Merge pull request #28634 from tchaikov/wip-22227
common, auth: use boost::spirit to parse ceph.conf, escape quotes in exported auths

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-06-25 19:28:54 +08:00
Kefu Chai
f02a47dd6a common/ConfUtils: implement trim helpers using boost
remove unused trim_whitespace() and its tests. as it is not used anymore

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-06-25 15:10:07 +08:00
Gu Zhongyan
73e88f7b72 qa/workunits: add auth caps allow command case
this case introduces multiple quotes in caps line
it will trigger the bug like http://tracker.ceph.com/issues/22227

Signed-off-by: Gu Zhongyan <guzhongyan@360.cn>
2019-06-25 15:10:07 +08:00
Kefu Chai
1f9e54ea00 auth/KeyRing: escape quotes around commands
so the exported auth can be re-imported.

Fixes: http://tracker.ceph.com/issues/22227
Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-06-25 15:10:07 +08:00
Kefu Chai
a19194a63d src/: parser returns up to one error
since config parser bails out at seeing the first error, there is no
need to offer the interfaces to report multiple errors.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-06-25 15:10:07 +08:00
Kefu Chai
b128929024 src: use spirit based ceph.conf parser
before this change, the ceph.conf parser was implemented using a
hand-written state machine. which works fine. but it's hard to
understand and hence difficult to maintain.

in this change, it's rewritten using boost::spirit. which well, is also
a state machine under the hood, but the declarative pattern matching
rules help the human readers to understand the machinary.

before this change, the state machine is able to skip the lines with
invalid syntax and spit a warning message for each of them. after this
change, the parser will just bail out when it fails to match the rules.

and the line continuation marker, i.e., "\" is simply skipped, so it's
allowed to have nothing after the backslash in the value of key-value
pair.

changes are listed as following:

* invalid UTF-8 key/value is now treated as an error
* backslash at the very end is now allowed
* repeated settings are tolerated, and no warnings will be printed.
  the last one wins. before this change, we will print out warning
  messages at seeing lines with duplicated keys.
* malformed section header is now an error
* a setting line which does not parse is now an error
* unmatched quotes in setting value is now an error
* "\" following an empty line is allowed now.
* the format of error message is changed, so the cli test is updated
  accordingly.
* [global] section is not added by default. unless there is a single
  line in the conf file. this is only for the convenience of testing.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-06-25 15:09:59 +08:00
Kefu Chai
9d1548bec4
Merge pull request #28695 from kamoltat/wip-mgr-progress-fix-bug-osd-in-out
mgr/progress: Bug fix complete event when OSD marked in

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2019-06-25 13:19:41 +08:00
Kefu Chai
2ba3925369
Merge pull request #28689 from tchaikov/wip-crimson-add-me-to-crush
crimson/osd: add osd to crush when it boots

Reviewed-by: Samuel Just <sjust@redhat.com>
2019-06-25 13:18:56 +08:00
Kefu Chai
183bcc66d7
Merge pull request #28688 from ifed01/wip-ifed-fix-no-compress
os/bluestore: load OSD all compression settings unconditionally.

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
2019-06-25 13:16:47 +08:00
Kefu Chai
f965d8f7e1
Merge pull request #28660 from liewegas/wip-40451
osd/PG: do not queue scrub if PG is not active when unblock

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
2019-06-25 13:15:33 +08:00
Kefu Chai
424933ab9a
Merge pull request #28601 from rzarzynski/wip-crimson-os-omit-block-write
os/memstore, crimson/os: introduce memstore_debug_omit_block_device_write

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-06-25 13:13:43 +08:00
Kefu Chai
072b09e920
Merge pull request #28510 from liuchang0812/fix-arg-parser
common: sort best-matched commond by req argument count

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-06-25 13:12:51 +08:00
Kefu Chai
b6fa043811
Merge pull request #28018 from hjwsm1989/wip-39625
mon: take the mon lock in handle_conf_change

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Sage Weil <sage@redhat.com>
2019-06-25 13:11:51 +08:00
Kefu Chai
b9be028397
Merge pull request #27627 from cxytt/fix-add-omap-tail
os/bluestore: create the tail when first set FLAG_OMAP

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
2019-06-25 13:10:01 +08:00
Jos Collin
55e790dc10
Merge pull request #28718 from varshar16/wip-cephfs-shell-typo-mounting
cephfs-shell: Fix typo for mounting

Reviewed-by: Jos Collin <jcollin@redhat.com>
2019-06-25 10:10:45 +05:30
Mykola Golub
2f35ab70a5 rbd-mirror: handle duplicates in image sync throttler queue
Fixes: http://tracker.ceph.com/issues/40519
Signed-off-by: Mykola Golub <mgolub@suse.com>
2019-06-25 05:38:37 +01:00
Kefu Chai
3eca36db53
Merge pull request #28703 from tchaikov/wip-ceph.in-asan
ceph.in: do not preload asan even if not needed

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2019-06-25 11:19:35 +08:00
Kefu Chai
11d2205c40
Merge pull request #28725 from cbodley/wip-cmake-ubsan
cmake: fix WITH_UBSAN

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-06-25 11:19:02 +08:00
Kefu Chai
6c929065a7
Merge pull request #28395 from athanatos/sjust/wip-crimson-op
Add structures for tracking in progress operations

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-06-25 10:46:20 +08:00
Samuel Just
b59694686f crimson: fix state machine operations in advance_pg_to and pg creation
Both pg creation and advance_pg_to process statemachine events and
therefore need to be under the pg process pipeline stage.

Signed-off-by: Samuel Just <sjust@redhat.com>
2019-06-24 18:00:47 -07:00
Jason Dillaman
1240f4900a
Merge pull request #27285 from shangdehao1/wip-librbd-shared-read-only-cache-hook
librbd: shared read-only cache hook 

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2019-06-24 18:46:04 -04:00
shangdehao1
762e57503f librbd: refine re-connect implement and init method
- add new status to OpenImageRequest, including
  send_parent_cache and handle_parent_cache.
- refine re-connect to remove race condition.
- fixed read error bug

Signed-off-by: Dehao Shang <dehao.shang@intel.com>
2019-06-24 17:36:54 -04:00
Yuan Zhou
c9dc97c4d0 doc: fix example command on creating ceph user
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
2019-06-24 17:36:54 -04:00
shangdehao1
345020c063 librbd: change init method of Parent cache to asynchronous
Signed-off-by: Dehao Shang <dehao.shang@intel.com>
2019-06-24 17:36:54 -04:00
shangdehao1
4c822cde3d librbd: add read_object method to ParentCache
Also remove SharedPersistentObjectCacher class

Signed-off-by: Dehao Shang <dehao.shang@intel.com>
2019-06-24 17:36:54 -04:00
shangdehao1
ad8f6477b2 librbd: refine hard code and remove dead code
Signed-off-by: Dehao Shang <dehao.shang@intel.com>
2019-06-24 17:36:54 -04:00
shangdehao1
5ce52a1cfb librbd: add lock to resovle race condition
possible race condition w/ multiple concurrent attempts to
re-create the cache session

Signed-off-by: Dehao Shang <dehao.shang@intel.com>
2019-06-24 17:36:54 -04:00
Yuan Zhou
38b94ef2f5 doc: better format for rbd persistent cache
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
2019-06-24 17:36:54 -04:00
shangdehao1
65eb28fbe4 librbd: remove parent cache config from ImageCtx
Signed-off-by: Dehao Shang <dehao.shang@intel.com>
2019-06-24 17:36:54 -04:00
shangdehao1
2fd3772495 librbd: cleanup parent cache
- remove compiler warning.
- add error log level.
- modify tool/immutable_obj_cache unit testing.

Signed-off-by: Dehao Shang <dehao.shang@intel.com>
2019-06-24 17:36:53 -04:00
shangdehao1
f50e084e09 librbd: modify Parent cache interface
follow the recent ObjectDispatchInterface to adjust parent cache hook

Signed-off-by: Dehao Shang <dehao.shang@intel.com>
2019-06-24 17:35:40 -04:00