otherwise we have to put something like
local_conf().template get_val<T>(name)
which is not quite convenient or readable.
Signed-off-by: Kefu Chai <kchai@redhat.com>
we should not redefine a default argument of a method of templated class.
this change also address following error from clang:
../src/crimson/os/seastore/onode_manager/staged-fltree/node.cc:621:30: error: template parameter redefines default argument
template <bool FORCE_MERGE = false>
^
../src/crimson/os/seastore/onode_manager/staged-fltree/node.h:438:32: note: previous default template argument defined here
template <bool FORCE_MERGE = false>
^
Signed-off-by: Kefu Chai <kchai@redhat.com>
merge_stage and merge_size are structured bindings, they are not
variables. so cannot be captured without defining variables in
capture list.
Signed-off-by: Kefu Chai <kchai@redhat.com>
The standalone tests need parameters to be passed as ceph_args to
override defaults.
This was just doubling the number of standalone tests being run in each rados
run with no effect!
Signed-off-by: Neha Ojha <nojha@redhat.com>
* refs/pull/41183/head:
cephadm: normalize image digest in 'ls' output too
Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
* refs/pull/41107/head:
mgr/cephadm: apply hostname/addr checks to 'orch host set-addr' too
mgr/cephadm: make 'host add' idempotent
mgr/cephadm: set host crush location based on HostSpec
python-common: add location property to HostSpec, + tests
Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
which allows us to use different scheme when defining an option,
without this change, if two options in different mgr module share the
same name we cannot differentiate them, after this change, their id
would prefixed with the module name.
Signed-off-by: Kefu Chai <kchai@redhat.com>
We're updating the Windows build scripts to use Boost 1.75, the same
as the Linux build.
We can now drop the custom Boost patches that were needed in order
to use mingw. Those have been merged upstream in the meantime.
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
We'll use a log file when building the Ceph dependencies. Also, we'll
log some details about the operation that's about to be performed.
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
The boost download location has changed, breaking the Windows build.
Ths commit updates the boost download url.
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
This PR rewrites the text in "Using Customized
Container Images" so that it is just a bit
clearer, and it also formats the prompt in the
text correctly.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
This PR fixes the prompts in this section and
makes the sentences a tiny bit less onerous for
the reader.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
rgw,test: Add even more DoutPrefixProvider's to the RGW codebase
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
mgr/dashboard: disable NFSv3 support in dashboard
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Alexandra Settle <asettle@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
