Commit Graph

118058 Commits

Author SHA1 Message Date
Ernesto Puerta
e8ec1848ec
Merge pull request #38316 from rhcs-dashboard/temporary-lockout
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2020-12-16 13:29:22 +01:00
Ernesto Puerta
63a5cd41c8
Merge pull request #38534 from votdev/issue_48542_rgw_status
mgr/dashboard: The /rgw/status endpoint does not check for running service

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2020-12-16 13:27:32 +01:00
Mykola Golub
0e9ffeb7cb
Merge pull request #38536 from dillaman/wip-48553
librbd/mirror: unlink the third snapshot when the limit is reached

Reviewed-by: Mykola Golub <mgolub@suse.com>
2020-12-16 13:20:38 +02:00
Nizamudeen A
3f50b05e25 mgr/dashboard: Updating the docs regarding the user lockout
Fixes: https://tracker.ceph.com/issues/40914
Signed-off-by: Nizamudeen A <nia@redhat.com>
2020-12-16 16:14:47 +05:30
Nizamudeen A
41941f0d28 mgr/dashboard: Temporary User Lockout if 10 Invalid Login attempts
Implemented a user lockout mechanism if the user enters 10 invalid attempts. The attempt count gets resetted to 0 once the user succesfully logins before getting disabled. Once the user gets disabled administrator has to manually enable the user which will also resets the number of attempts.

Fixes: https://tracker.ceph.com/issues/40914
Signed-off-by: Nizamudeen A <nia@redhat.com>
2020-12-16 16:14:47 +05:30
Ernesto Puerta
f649030c73
Merge pull request #38606 from rhcs-dashboard/log-e2e-fix
mgr/dashboard: Fixing dashboard logs e2e test

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2020-12-16 11:43:54 +01:00
Nizamudeen A
0b2b172930 mgr/dashboard: Fixing dashboard logs e2e test
Yesterday there were some changes went in which disables the logging of config set and config-key set to to be logged in mgr audit logs. Dashboard has an e2e test which checks for this config set and broke the current e2e jenkins job. This commit removes that certain test to fix the jenkins job.

Fixes: https://tracker.ceph.com/issues/48623
Signed-off-by: Nizamudeen A <nia@redhat.com>
2020-12-16 14:43:00 +05:30
Kefu Chai
8e4cf7cbc5 debian: install crimson-store-nbd with pkg.ceph.crimson profile
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-12-16 15:55:51 +08:00
Kefu Chai
5af17733c7 rpm: package crimson-store-nbd in ceph-test package
when building with seastar enabled, package crimson-store-ndb in
"ceph-test" package. "crimson-store-nbd" is a new tool for testing
seastore using nbd.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-12-16 15:55:48 +08:00
Kefu Chai
1085472893
Merge pull request #38581 from cyx1231st/wip-seastar-msgr-fix-test-preemptive-shutdown
crimson/net: fix test_preemptive_shutdown() failure

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-12-16 13:58:05 +08:00
Josh Durgin
8a74a937dd
Merge pull request #31358 from ideepika/wip-jaegertracing-in-ceph
jaegertracing build/ops integration

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2020-12-15 16:29:26 -08:00
Anthony D'Atri
21d68cf137 doc: standardize config option names to use interstitial underscores
Ceph config option names may use spaces, underscores, or by one reference hyphens
as interstitial separators. Most usage within the doc tree uses underscores,
though example conf files and especially structured lists of options mostly
use spaces. Mostly. Underscores help differentiate the config names from
surrounding text, and moreover facilitate scripting, grep, awk, etc and match
their form in src/common/options.cc.

This PR conforms these occurrences of option names to use interstitial underscores instead of spaces.

Fixes: https://tracker.ceph.com/issues/48301
Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
2020-12-15 13:55:38 -08:00
Josh Durgin
351960345a
Merge pull request #38479 from neha-ojha/wip-37503-2
Do not add sensitive information in Ceph log files

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2020-12-15 12:06:39 -08:00
Jason Dillaman
067dc85af4
Merge pull request #38514 from lixiaoy1/rbd_types_fix
librbd/cmake: Add missed PWL related types

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-12-15 14:53:48 -05:00
Ernesto Puerta
0280349fef
Merge pull request #38546 from rhcs-dashboard/round-button
mgr/dashboard: Making the edges of not rounded button rounded

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
2020-12-15 20:07:23 +01:00
Ernesto Puerta
0abb05d97e
Merge pull request #38269 from rhcs-dashboard/fix-44960-master
mgr/dashboard: replace cdCopy2ClipboardButton Directive with a component

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2020-12-15 19:51:45 +01:00
Ernesto Puerta
ba650bf561
Merge pull request #37937 from p-se/cd-alternative-grafana-fe-url
mgr/dashboard: enable different URL for users of browser to Grafana

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2020-12-15 19:47:30 +01:00
Ernesto Puerta
4c6bd8dd3b
github: add action to manage needs-rebase label
Fixes: https://tracker.ceph.com/issues/48570
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
2020-12-15 19:09:28 +01:00
Kefu Chai
c17c6c66eb ceph-conf: add --pid option
this change partially reverts 1f09b19665,
and add "--pid" option, so user can specify the pid to override the $pid
meta variable when expanding options.

Fixes: https://tracker.ceph.com/issues/47977
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-12-16 02:01:12 +08:00
Kefu Chai
caba1beaf9 ceph.in: extract get_admin_socket() out
will add retry support to this function, so we can use an alternative
name for the admin_socket path if the path is not a valid file.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-12-16 02:01:12 +08:00
Ernesto Puerta
9a71e9e363
Merge pull request #36715 from rhcs-dashboard/fix-39128-master
mgr/dashboard: new generic HTTP error page component

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2020-12-15 18:59:14 +01:00
Ernesto Puerta
4abf4d9a4a
Merge pull request #38456 from SMIL-Infra/fix-crush-map-viewer
mgr/dashboard: Fix CRUSH map viewer VirtualScroll

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2020-12-15 18:57:03 +01:00
Courtney Caldwell
065fbf9603 mgr/dashboard: replace cdCopy2ClipboardButton Directive with a component
Replaces Directive-Based copy2ClipboardButton with a Component-based version.
Further replaces all instances of Directive use with Component version.
Similar toastr logic used.
Fixes: https://tracker.ceph.com/issues/44960

Signed-off-by: Courtney Caldwell <ccaldwel@redhat.com>
2020-12-15 11:41:18 -05:00
Neha Ojha
9f80520670 mon, messages: use TOPNSPC::common for crimson compatibility
Signed-off-by: Neha Ojha <nojha@redhat.com>
2020-12-15 16:02:15 +00:00
Neha Ojha
f4b3d6b769 mgr/ActivePyModules.cc: don't log config value in get_typed_config
Signed-off-by: Neha Ojha <nojha@redhat.com>
2020-12-15 16:02:15 +00:00
Neha Ojha
77932ae49b mon/ConfigMonitor.cc: don't log config values in refresh_config
Signed-off-by: Neha Ojha <nojha@redhat.com>
2020-12-15 16:02:15 +00:00
Neha Ojha
19000fad57 mgr: don't add config values to mgr log in config_callback and module_config
The original code has been commented out and left for future debugging
purposes.

Signed-off-by: Neha Ojha <nojha@redhat.com>
2020-12-15 16:02:15 +00:00
Neha Ojha
a68b459778 mon/ConfigMonitor.cc: don't dump all keys and values in config map
Signed-off-by: Neha Ojha <nojha@redhat.com>
2020-12-15 16:02:15 +00:00
Neha Ojha
4b83dfb1f7 mon: don't log "config set" and "config-key set" dispatch and finished messages
Signed-off-by: Neha Ojha <nojha@redhat.com>
2020-12-15 16:02:15 +00:00
Neha Ojha
3d54660ca1 messages/MMonCommand, MMonCommandAck: don't log values for "config set" and "config-key set"
This acts like a big hammer to avoid adding sensitive information, like passwords
into mon/mgr/cluster logs when using "config set" and "config-key set" to set keys
whose values should be secure.

Fixes: https://tracker.ceph.com/issues/37503
Signed-off-by: Neha Ojha <nojha@redhat.com>
2020-12-15 16:02:06 +00:00
Casey Bodley
71b485f096
Merge pull request #38010 from cbodley/wip-rgw-doc-reshard-syncstop
doc/rgw: update reshard design regarding 'bucket sync disable'

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
2020-12-15 08:51:07 -05:00
Kefu Chai
32921b7003
Merge pull request #38585 from tchaikov/wip-doc-dev-errorator
doc/dev/crimson: highlight code blocks using C++ lexer

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-12-15 20:28:57 +08:00
Kefu Chai
28408bb50f
Merge pull request #38582 from tchaikov/wip-crimson-cleanup
crimson/osd: cleanups

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-12-15 20:26:52 +08:00
Kefu Chai
c03415caf1 doc/dev/crimson: quote inline codeblock using "``"
backquote is used for quoting italic typed text.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-12-15 17:50:43 +08:00
Kefu Chai
370f04fa82 doc/dev/crimson: highlight code blocks using C++ lexer
also remove redundant ":", normally "::" would suffice to start a
codeblock.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-12-15 17:48:02 +08:00
Kefu Chai
cc9a63ab57 crimson/osd: handle error using handle_error()
no need to use safe_then() for this purpose.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-12-15 17:21:10 +08:00
Kefu Chai
7ab794971d crimson/osd: do not use __func__ in lambda
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-12-15 17:15:17 +08:00
Kefu Chai
474ddbfe27 crimson/osd: drop log messages only for debugging
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-12-15 17:15:17 +08:00
Kefu Chai
5b1b050750 crimson/osd: do not capture dup variable
first can be deduced by variable already captured, so store it as a
local variable. it's less expensive than storing it as a captured
variable.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-12-15 17:15:17 +08:00
Kefu Chai
feea66b30b crimson/osd: do not use do_with() unless necessary
in this change, a seastar::do_with() is removed, as the captured
variables are passed to submit_push_data() by value. so no need to keep
them alive after the call.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-12-15 17:15:17 +08:00
Kefu Chai
e683404caf crimson/osd: let trim_pushed_data() return extents
trim_pushed_data() is responsible for building up the extents to be used
for pushing. so let it return the extents.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-12-15 17:15:17 +08:00
Kefu Chai
d346c526b1 crimson/osd: use range-based for loop
also add comment explaining
ReplicatedRecoveryBackend::trim_pushed_data()

and move the definition of local variable closer to where it is used.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-12-15 17:15:17 +08:00
Mykola Golub
6828213a11
Merge pull request #38539 from dillaman/wip-48526
librbd/object_map: don't assert if a snapshot doesn't exist

Reviewed-by: Mykola Golub <mgolub@suse.com>
2020-12-15 11:00:08 +02:00
Yuval Lifshitz
f5dd15e021 rgw/lua: allow for multiple RGWs to install packages in the same host
each RGW will install the luarocks packages in its own directory

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
2020-12-15 10:27:42 +02:00
Yingxin Cheng
2015d5b3da crimson/net: abort on-going v1 protocol when closed
Fixes: http://tracker.ceph.com/issues/48108
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2020-12-15 15:55:05 +08:00
Yingxin Cheng
9cb8f90307 crimson/net: track closing connections for v1
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2020-12-15 15:51:01 +08:00
Yingxin Cheng
9856769098 crimson/net: report unexpected exceptions during closing
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2020-12-15 15:48:43 +08:00
Yingxin Cheng
eabd41ac2c crimson/net: assert connection gate is not unexpectedly closed
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2020-12-15 15:45:52 +08:00
Yingxin Cheng
795dca10f2 crimson/net: fix test error report
Report unexpected exceptions before destructing the tests.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2020-12-15 15:42:02 +08:00
Kefu Chai
0b03c58b24
Merge pull request #38570 from rzarzynski/wip-crimson-recover_missing-noopt
crimson/osd: recover_missing() doesn't return std::optional anymore.

Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-12-15 15:14:53 +08:00