Commit Graph

131363 Commits

Author SHA1 Message Date
Adam King
aeaa0b5fd8 mgr/cephadm: make UpgradeState from_json a bit safer
This way, for downgrades to whatever versions
this lands in onward, having added new parameters to
UpgradeState shouldn't break anything. Can't do much
about downgrades to older versions from this one
but this should help in the future.

Signed-off-by: Adam King <adking@redhat.com>
2022-05-19 17:24:56 -04:00
Adam King
e6b0fe0e48 mgr/cephadm: add new args and validation for staggered upgrade
Signed-off-by: Adam King <adking@redhat.com>
2022-05-19 17:24:56 -04:00
Adam King
7b83c51fe6 mgr/cephadm: split _do_upgrade into sub functions
This function was around 500 lines and difficult to work
with. Splitting it into sub functions should hopefully make
it a bit easier to understand and make changes to.

Signed-off-by: Adam King <adking@redhat.com>
2022-05-19 17:24:56 -04:00
Adam King
6aa34044b5
Merge pull request #45425 from rkachach/fix_issue_54309
mgr/cephadm: Adding prometheus service discovery endpoints

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Paul Cuzner <pcuzner@redhat.com>
2022-05-19 17:03:05 -04:00
Adam King
12f33984ec
Merge pull request #46301 from rkachach/fix_issue_55685
mgr/cephadm: adding support to copy ceph conf to per fsid config location

Reviewed-by: Adam King <adking@redhat.com>
2022-05-19 16:08:21 -04:00
Adam King
148edd764d
Merge pull request #46054 from rkachach/fix_issue_55466
mgr/cephadm: fix unit.stop for ceph daemons

Reviewed-by: Adam King <adking@redhat.com>
2022-05-19 15:42:27 -04:00
Adam King
367808b473
Merge pull request #46129 from rkachach/fix_issue_ssh
mgr/cephadm: Adding an early ssh connectivity check during bootsrap

Reviewed-by: Adam King <adking@redhat.com>
2022-05-19 14:19:17 -04:00
Ernesto Puerta
4edef77f2f
Merge pull request #45951 from rhcs-dashboard/feature-set-login-banner
mgr/dashboard: customizable log-in page text/banner

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2022-05-19 20:11:42 +02:00
Rishabh Dave
ff86ae7556 cephfs-shell: check version before importing Cmd2ArgparseError
Cmd2ArgparseError is available only cmd2 version 1.0.1 onwards. Before
that, SystemExit(2) is raised. This commit creates an empty class
Cmd2ArgparseError for earlier version so that similar error won't creep
up again.

Fixes: https://tracker.ceph.com/issues/55716
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2022-05-19 21:03:54 +05:30
Casey Bodley
a997d73920
Merge pull request #46067 from sumedhak27/fix/user-policy/response-correction
rgw_rest_user_policy: Fix GetUserPolicy & ListUserPolicies responses

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Pritha Srivastava <prsrivas@redhat.com>
2022-05-19 10:37:50 -04:00
Rishabh Dave
c7306b7df6 cephfs-shell: set exit code when Cmd2ArgparseError is caught
Not doing so, sets the exit code to zero which is not desired in case of
a command failure.

Fixes: https://tracker.ceph.com/issues/55710
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2022-05-19 18:07:39 +05:30
Soumya Koduri
aafa3d173f
Merge pull request #46008 from soumyakoduri/wip-skoduri-cloudtier-tests
rgw/qa: enable s3-tests related to cloud-transition feature

Reviewed-by: casey Bodley <cbodley@redhat.com>
Reviewed-by: Maredia, Ali <amaredia@redhat.com>
2022-05-19 15:53:54 +05:30
Yingxin Cheng
6a4f0e356c crimson/os/seastore: increase journal size and decrease rewrite-dirty size
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-05-19 17:03:47 +08:00
Yingxin
c0cccccbbf
Merge pull request #46334 from athanatos/sjust/wip-55706
crimson: clarify use of tm_make_config_t

Reviewed-by: Myoungwon Oh <myoungwon.oh@samsung.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-05-19 16:40:15 +08:00
Soumya Koduri
fa86d2ea42 rgw/qa: Run tests on multiple cloudtier config
Run cloudtier tests with parameter 'retain_head_object'
set to true and false.

However having multiple cloudtier storage classes in the same task
is increasing the transition time and resulting in spurious failures.
Hence until there is a consistent way of running the tests, without
having to depend on lc_debug_interval, disabled one of the config for
now.

Signed-off-by: Soumya Koduri <skoduri@redhat.com>
2022-05-19 13:57:46 +05:30
Samuel Just
249bcfb928 crimson: generalize journal_seq_t to tolerate different paddr_t types
Introduced: bdc1c1490ff11269c7808e762893fcbdea3a0503
Fixes: https://tracker.ceph.com/issues/55706
Signed-off-by: Samuel Just <sjust@redhat.com>
2022-05-19 07:26:42 +00:00
Yingxin Cheng
74c853034e crimson/onode-staged-tree: fix unaligned reference to shard_pool_t::pool
../src/crimson/os/seastore/onode_manager/staged-fltree/stages/key_layout.h:844:44:
runtime error: reference binding to misaligned address 0x6250013ee905
for type 'const crimson::os::seastore::onode::pool_t' (aka 'const
  long'), which requires 8 byte alignment

from UndefinedBehaviorSanitizer

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-05-19 15:16:41 +08:00
Samuel Just
b19b802cbe crimson: clarify use of tm_make_config_t
Fixes: https://tracker.ceph.com/issues/55706
Introduced: 9fe59429fc2ef17e2bec329109713eb63ffc74c9
Signed-off-by: Samuel Just <sjust@redhat.com>
2022-05-19 05:29:05 +00:00
Ronen Friedman
30a2e863ca test/osd: unit-tests for the scrubber scheduler
Adding unittest_scrub_sched, testing the way scrubs are scheduled.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2022-05-19 05:07:50 +00:00
David Galloway
09111a691b
Merge pull request #46329 from ceph/1629
doc: 16.2.9 Release notes
2022-05-19 00:17:54 -04:00
Samuel Just
eef79d3911
Merge pull request #44233 from myoungwon/wip-add-rbm-inline-outline-alloc
seastore: add CircularBoundedJournal

Reviewed-by: Samuel Just <sjust@redhat.com>
2022-05-18 21:05:02 -07:00
myoungwon
56429b0b8d seastore/cbjournal: add a log if crc is mismatched
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-05-19 09:52:47 +09:00
myoungwon oh
b8ee3353bd seastore/cbjournal: add assert(initialized), revmoving open_device_read_header()
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-05-19 09:52:36 +09:00
myoungwon oh
9bf204190b seastore/cbjournal: rename init to initialized
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-05-19 09:52:20 +09:00
myoungwon oh
22f604a3a8 seastore/cbjournal: move written_to from the header to CBJournal
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-05-19 09:52:00 +09:00
myoungwon oh
08adf84fab seastore/cbjournal: remove header_checksum field and add calculating header checkksum
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-05-19 09:51:55 +09:00
myoungwon oh
80806a1b55 seastore: use config value and avoid passing a hint
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-05-19 09:51:49 +09:00
myoungwon oh
e95bb11afd seastore: rename journal_type to journal_type_t
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-05-19 09:51:43 +09:00
myoungwon oh
8841166573 test/cbjournal: do rb_device.reset() unconditionally
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-05-19 09:51:36 +09:00
myoungwon oh
9fe59429fc test/seastore: use tm_make_config_t to get default_placement_hint
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-05-19 09:51:28 +09:00
myoungwon oh
18322f5698 test/seastore: return journal type with less lines
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-05-19 09:51:22 +09:00
myoungwon oh
54705adddd seastore: add a log line after set_disable_trim is called
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-05-19 09:51:15 +09:00
myoungwon oh
8260c7d8a6 seastore: add the comment to explain disable_trim
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-05-19 09:51:08 +09:00
myoungwon oh
593543d0a7 seastore: add space between ) and {
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-05-19 09:51:03 +09:00
myoungwon oh
b45b03a759 seastore: add a comment (blk_paddr_t is absolute)
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-05-19 09:50:54 +09:00
myoungwon oh
0ff35731e9 seastore: do assert if paddr type is not SEGMENT in add_relative
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-05-19 09:50:43 +09:00
myoungwon oh
ffcb5f4e80 seastore: rollback a change (paddr_t -> auto)
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-05-19 09:50:35 +09:00
myoungwon oh
1518a06790 seastore/cbjournal: fix comment to explain the condition in detail
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-05-19 09:49:54 +09:00
myoungwon oh
954102b445 seastore/cbjournal: make open_device_read_header not to be called if init is true
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-05-19 09:49:48 +09:00
myoungwon oh
459159626e seastore/cbjournal: rename open_for_write to open_device_read_header
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-05-19 09:49:40 +09:00
myoungwon oh
1804695ff9 seastore/cbjournal: add comment to explain initialized
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-05-19 09:49:33 +09:00
myoungwon oh
e40a1792a4 seastore/cbjournal: remove unused field
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-05-19 09:49:28 +09:00
myoungwon oh
5590291673 seastore/cbjournal: add writev to submit writes with aligned buffers
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-05-19 09:49:22 +09:00
myoungwon oh
f4b1129f25 seastore/cbjournal: use journal_tail instead of applied_to to track journal tail
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-05-19 09:49:17 +09:00
myoungwon oh
3449595c92 seastore/cbjournal: remove start and end fields in cbjournal header
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-05-19 09:49:12 +09:00
myoungwon oh
0631f37176 seastore/cbjournal: remove error field
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-05-19 09:49:04 +09:00
myoungwon oh
621b5df8ea seastore/cbjournal: change comment for block_size
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-05-19 09:48:50 +09:00
myoungwon oh
d520e5e70a test/cbjournal: fix wrong device id
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-05-19 09:48:44 +09:00
myoungwon oh
35de684fc9 seastore/cbjournal: remove used_size in header
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-05-19 09:48:33 +09:00
myoungwon oh
8b178a0765 seastore/cbjournal: rename csum to header_checksum and remove csum_type
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-05-19 09:48:26 +09:00