RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2024-12-25 21:03:31 +00:00
Code Issues Packages Projects Releases Wiki Activity
38,077 Commits 211 Branches 394 Tags 1.3 GiB
bea2d4a8f7
Commit Graph

38077 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Sage Weil
bba4d35760 librados: init last_objver 
*** CID 1258788:  Uninitialized scalar field  (UNINIT_CTOR)
/librados/IoCtxImpl.cc: 44 in
librados::IoCtxImpl::IoCtxImpl(librados::RadosClient *, Objecter *, int, const
char *, snapid_t)()
38       : ref_cnt(0), client(c), poolid(poolid), pool_name(pool_name),
snap_seq(s),
39         assert_ver(0), notify_timeout(c->cct->_conf->client_notify_timeout),
40         oloc(poolid),
41         aio_write_list_lock("librados::IoCtxImpl::aio_write_list_lock"),
42         aio_write_seq(0), objecter(objecter)
43     {
>>>     CID 1258788:  Uninitialized scalar field  (UNINIT_CTOR)
>>>     Non-static class member "last_objver" is not initialized in this
constructor nor in any functions that it calls.
44     }
45
46     void librados::IoCtxImpl::set_snap_read(snapid_t s)
47     {
48       if (!s)
49         s = CEPH_NOSNAP;

Signed-off-by: Sage Weil <sage@redhat.com>
 2014-12-18 06:32:23 -08:00
Sage Weil
2cd9dc0804 messages/MClientCaps: init peer.flags 
*** CID 1258789:  Uninitialized scalar field  (UNINIT_CTOR)
/messages/MClientCaps.h: 132 in MClientCaps::MClientCaps(int, inodeno_t,
inodeno_t, unsigned long, int, unsigned int)()
126         head.ino = ino;
127         head.realm = realm;
128         head.cap_id = id;
129         head.migrate_seq = mseq;
130         peer.cap_id = 0;
131         inline_version = 0;
>>>     CID 1258789:  Uninitialized scalar field  (UNINIT_CTOR)
>>>     Non-static class member field "peer.flags" is not initialized in this
constructor nor in any functions that it calls.
132       }
133     private:
134       ~MClientCaps() {}
135
136     public:
137       const char *get_type_name() const { return "Cfcap";}

Signed-off-by: Sage Weil <sage@redhat.com>
 2014-12-18 06:29:40 -08:00
Sage Weil
679652ab36 osd: fix leaked OSDMap 
*** CID 1258787:  Resource leak  (RESOURCE_LEAK)
/osd/OSD.cc: 6118 in OSD::handle_osd_map(MOSDMap *)()
6112                    << dendl;
6113            clog->warn() << "failed to encode map e" << e << " with expecte
crc\n";
6114            MMonGetOSDMap *req = new MMonGetOSDMap;
6115            req->request_full(e, last);
6116            monc->send_mon_message(req);
6117            last = e - 1;
>>>     CID 1258787:  Resource leak  (RESOURCE_LEAK)
>>>     Variable "o" going out of scope leaks the storage it points to.
6118            break;
6119           }
6120
6121
6122           hobject_t fulloid = get_osdmap_pobject_name(e);
6123           t.write(META_COLL, fulloid, 0, fbl.length(), fbl);

Signed-off-by: Sage Weil <sage@redhat.com>
 2014-12-18 06:24:49 -08:00
Haomai Wang
001ea29386 Messenger: Create an Messenger implementation by name. 
Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
 2014-12-18 21:51:12 +08:00
Yan, Zheng
2d76bc2d98 Merge pull request #3202 from ceph/wip-fix-asok 
mds: fix asok on rank 0
 2014-12-18 20:22:40 +08:00
John Spray
3a2cb7148a mds: fix asok on rank 0 
Broken by:
1b2b34431 (MDS: do not allow invocation of most commands on an inactive MDS)

MDS::whoami is a rank, so check for inactive is <0, not <=0

Signed-off-by: John Spray <john.spray@redhat.com>
 2014-12-18 12:16:13 +00:00
Nilamdyuti Goswami
8de9a0f437 doc: Adds updated man page for ceph under man/ 
Signed-off-by: Nilamdyuti Goswami <ngoswami@redhat.com>
 2014-12-18 17:13:27 +05:30
Nilamdyuti Goswami
8b79617306 doc: Changes format style in ceph to improve readability as html. 
Signed-off-by: Nilamdyuti Goswami <ngoswami@redhat.com>
 2014-12-18 17:11:22 +05:30
Nilamdyuti Goswami
7093cb3725 doc: Adds updated man page for ceph-disk under man/ 
Signed-off-by: Nilamdyuti Goswami <ngoswami@redhat.com>
 2014-12-18 16:50:22 +05:30
Nilamdyuti Goswami
62b3fcdd24 doc: Updates man page for ceph-disk with suggested changes. 
Signed-off-by: Nilamdyuti Goswami <ngoswami@redhat.com>
 2014-12-18 16:48:50 +05:30
Nilamdyuti Goswami
2862a49483 doc: Adds updated man page for ceph-disk under man/ 
Signed-off-by: Nilamdyuti Goswami <ngoswami@redhat.com>
 2014-12-18 16:31:35 +05:30
Nilamdyuti Goswami
3f6be22f64 doc: Updates man page for ceph-disk. 
Changes format style to improve readability as html.

Signed-off-by: Nilamdyuti Goswami <ngoswami@redhat.com>
 2014-12-18 16:31:35 +05:30
Wido den Hollander
883e1aea96 doc: Show how new data pools can be added to CephFS for file layouts 2014-12-18 10:59:31 +01:00
Nilamdyuti Goswami
2b577cef00 packaging: package ceph-deploy(8) 
Fixes merge conflict.

Signed-off-by: Nilamdyuti Goswami <ngoswami@redhat.com>
 2014-12-18 14:32:05 +05:30
Nilamdyuti Goswami
c664818892 doc: Adds updated man page for ceph-deploy under man/ 
Signed-off-by: Nilamdyuti Goswami <ngoswami@redhat.com>
 2014-12-18 13:51:46 +05:30
Nilamdyuti Goswami
e638469b58 doc: Updates man page for ceph-deploy. 
Changes format style in ceph-deploy to improve readability as html.

Signed-off-by: Nilamdyuti Goswami <ngoswami@redhat.com>
 2014-12-18 13:51:46 +05:30
Yan, Zheng
a806778322 qa: test zero size xattr 
Signed-off-by: Yan, Zheng <zyan@redhat.com>
 2014-12-18 14:43:54 +08:00
Yan, Zheng
bfa4acf26e Merge pull request #3198 from ceph/wip-10335 
MDS: do not allow invocation of most commands on an inactive MDS
 2014-12-18 10:32:31 +08:00
David Zafman
4f72ba545e ceph_objectstore_tool: Rename generated binary to ceph-objectstore-tool 
Signed-off-by: David Zafman <dzafman@redhat.com>
 2014-12-17 17:09:09 -08:00
Greg Farnum
1b2b344313 MDS: do not allow invocation of most commands on an inactive MDS 
They just cause all kinds of trouble!

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
 2014-12-17 15:32:23 -08:00
Gregory Farnum
be7b2f8a30 Merge pull request #2836 from ceph/wip-7317 
#7317 ENOSPC and OSD epoch barrier handling

Reviewed-by: Yan, Zheng <zyan@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
 2014-12-17 14:12:51 -08:00
Loic Dachary
65be519b03 Merge pull request #3197 from ktdreyer/rpm-spec-comment 
ceph.spec.in: quote %files macro in comment

Reviewed-by: Loic Dachary <ldachary@redhat.com>
 2014-12-17 22:00:53 +01:00
Ken Dreyer
69fa5329ce ceph.spec.in: quote %files macro in comment 
Prior to this commit, RPM would expand the %files macro that was present
in the comment.

Use a double percent sign to quote the macro so that RPM will not expand
it.

This fixes an rpmlint warning, "W: macro-in-comment %files"

More information from rpmlint's "-I" (help) command:

  $ rpmlint -I macro-in-comment
  macro-in-comment:
  There is a unescaped macro after a shell style comment in the
  specfile.  Macros are expanded everywhere, so check if it can cause a
  problem in this case and escape the macro with another leading % if
  appropriate.

Signed-off-by: Ken Dreyer <kdreyer@redhat.com>
 2014-12-17 13:06:58 -07:00
Loic Dachary
38768da1b6 Merge pull request #3171 from tchaikov/refactor-rados-class 
python-rados: refactor class Rados a little bit

Reviewed-by: Josh During <jdurgin@redhat.com>
Reviewed-by: Loic Dachary <ldachary@redhat.com>
 2014-12-17 19:32:34 +01:00
Kefu Chai
378ebb79d0 python-rados: refactor class Rados a little bit 
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
 2014-12-18 02:05:32 +08:00
Xiaoxi Chen
59b70fe20b Cleanup: Drop hobject_incorrect_pool 
This field in MOSDSubOp, used to support very old version
OSD(MOSDSubOp header version < 7, which was introduced in
mid 2012 by commit 2fe9816305)

Now since two years pasted, we don't need it anymore.

Signed-off-by: Xiaoxi Chen <xiaoxi.chen@intel.com>
 2014-12-17 21:50:07 +08:00
Wido den Hollander
0c9d55d404 pybind/cephfs: Fix setxattr function. Pass value as character pointer 
This passes the value of the xattr correctly and makes it work.
 2014-12-17 14:01:44 +01:00
Loic Dachary
9b73c76209 Merge pull request #3190 from dachary/wip-test-helpers 
tests: ignore xmlstarlet extra empty lines
 2014-12-17 09:00:42 +01:00
Loic Dachary
023a8aca8c tests: ignore xmlstarlet extra empty lines 
With xmlstarlet 1.3.0 (which is on Ubuntu precise)

xmlstarlet sel -t -m '//pg_stat/state[(contains(.,'\''active'\'') and
contains(.,'\''clean'\'') and not(contains(.,'\''stale'\'')))]' -v . -n

will output an extra empty line which does not show on xmlstarlet
1.5.0 (which is on Ubuntu trusty and Fedora 20).

Signed-off-by: Loic Dachary <ldachary@redhat.com>
 2014-12-17 08:02:17 +01:00
Sage Weil
e582135c57 os/FileStore: better debug on omap_setkeys 
Signed-off-by: Sage Weil <sage@redhat.com>
 2014-12-16 17:07:59 -08:00
Sage Weil
f6ca2bcb74 os/FileStore: better debug on unlink 
Signed-off-by: Sage Weil <sage@redhat.com>
 2014-12-16 17:07:59 -08:00
Sage Weil
43f0bcb19f os/MemStore: drop support for collection attrs 
Signed-off-by: Sage Weil <sage@redhat.com>
 2014-12-16 17:07:59 -08:00
Sage Weil
17e4e1974a os/ObjectStore: deprecated collection_getattr et al 
Drop the functional tests for this too.

Return EOPNOTSUPP by default, and tolerate this in the callers.

Signed-off-by: Sage Weil <sage@redhat.com>
 2014-12-16 17:07:59 -08:00
Sage Weil
56232d96cf ceph_test_objectstore_workloadgen: set pgmeta omap instead of collection xattr 
Signed-off-by: Sage Weil <sage@redhat.com>
 2014-12-16 17:07:59 -08:00
Sage Weil
82f452cc7d osd/PG: drop PG/collection attrs from ScrubMap 
The collection attrs are often version specific.  We should compare the
semantic PG metadata, if anything, not these!

Signed-off-by: Sage Weil <sage@redhat.com>
 2014-12-16 17:07:59 -08:00
Sage Weil
a1a3e156b6 os/ObjectStore: deprecated collection attr operations 
Signed-off-by: Sage Weil <sage@redhat.com>
 2014-12-16 17:07:58 -08:00
Sage Weil
db3daaf11b osd/PG: drop PG::read_info support for ancient PGs 
This is rewritten regularly by any vaguely-active OSD; no need for this
any more.

Signed-off-by: Sage Weil <sage@redhat.com>
 2014-12-16 17:07:58 -08:00
Sage Weil
880135abfb osd: drop snap_collections 
This is obsolete since cuttlefish.

Signed-off-by: Sage Weil <sage@redhat.com>
 2014-12-16 17:07:58 -08:00
Sage Weil
5877c069f6 osd: drop infos_oid arg from PG::read_info() 
Only needed for legacy.

Signed-off-by: Sage Weil <sage@redhat.com>
 2014-12-16 17:07:58 -08:00
Sage Weil
a599d88615 osd: drop legacy arg to PG::peek_map_epoch 
The function can figure it out itself, and it's only needed for legacy.

Signed-off-by: Sage Weil <sage@redhat.com>
 2014-12-16 17:07:58 -08:00
Sage Weil
f93b293775 ceph_objectstore_tool: use '_remove' pgmeta omap key to indicate removal too 
We could conceivably mark the PG for backfill, but to do this correctly
we have to do the log rollback, which uses various methods in PG to update
snap metadata that we simply don't have access to from this tool.

Signed-off-by: Sage Weil <sage@redhat.com>
 2014-12-16 17:07:58 -08:00
Sage Weil
cd462d173c osd: move pg removal flag into a static helper 
Signed-off-by: Sage Weil <sage@redhat.com>
 2014-12-16 17:07:58 -08:00
David Zafman
f056bdf939 ceph_objectstore_tool: Prevent tool from transitioning struct_v on rm-past-intervals 
Signed-off-by: David Zafman <dzafman@redhat.com>
 2014-12-16 17:07:58 -08:00
David Zafman
fbf6408964 ceph_objectstore_tool: Clean-up unused struct_ver in tool's metadata section 
Exported struct_ver not used by write_info() or write_pg()

Signed-off-by: David Zafman <dzafman@redhat.com>
 2014-12-16 17:07:58 -08:00
Sage Weil
d6df6eabab osd: retire meta/infos object entirely 
Do not create it; remove it on upgrade.

Signed-off-by: Sage Weil <sage@redhat.com>
 2014-12-16 17:07:57 -08:00
Sage Weil
9d1466cb6e osd: prevent upgrade from older than v7 
Signed-off-by: Sage Weil <sage@redhat.com>
 2014-12-16 17:07:57 -08:00
Sage Weil
d1973f3ba0 osd/PGLog: drop support for ancient logs 
Assume that users have at least upgraded to dumpling first.

Signed-off-by: Sage Weil <sage@redhat.com>
 2014-12-16 17:07:57 -08:00
Sage Weil
8cb25cbdd6 test/osd/osd-test-helper.sh: enable filestore log 
Signed-off-by: Sage Weil <sage@redhat.com>
 2014-12-16 17:07:57 -08:00
Sage Weil
6074bdd155 osd: move pg log and info to a per-pg object 
Move all PG metadata (info, biginfo, epoch, and log) to a single per-PG
object.  This should make it easier for ObjectStore implementations to
avoid lock contention in the write path.

Signed-off-by: Sage Weil <sage@redhat.com>
 2014-12-16 17:07:57 -08:00
Sage Weil
8fa94071f9 osd/PGLog: explicitly pass log_oid collection 
Do not assume the log_oid is ine the 'meta' collection.

Signed-off-by: Sage Weil <sage@redhat.com>
 2014-12-16 17:07:57 -08:00