Commit Graph

100403 Commits

Author SHA1 Message Date
Mykola Golub
05b6923e48
Merge pull request #29054 from dillaman/wip-40621
mgr/rbd_support: support scheduling long-running background operations

Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
2019-07-27 09:32:35 +03:00
Kefu Chai
db20513eb6
Merge pull request #29361 from tchaikov/wip-qa-osd-pause
qa: fixes

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-07-27 10:26:43 +08:00
Patrick Donnelly
6b83f43ba0
qa: wait for kernel client death
After sending the reboot command, we need to wait briefly for it to be
rebooted so that the kernel client doesn't voluntarily give up its Fb
cap.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2019-07-26 15:34:17 -07:00
Patrick Donnelly
b75544be86
qa: use hard_reset to reboot kclient
power_off may allow the mounts to gracefully unmount. We don't want this if the
kclient is stuck or we desire the client to "disappear" and come back.

Fixes: http://tracker.ceph.com/issues/37681
Depends-on: https://github.com/ceph/teuthology/pull/1296
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2019-07-26 15:34:00 -07:00
Patrick Donnelly
94bcc45561
common: add comment about pod memory requests/limits
Written in private correspondence by Travis Nielson.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2019-07-26 15:27:32 -07:00
Patrick Donnelly
14e7e518e0
Merge PR #28685 into master
* refs/pull/28685/head:
	client: more precise CEPH_CLIENT_CAPS_PENDING_CAPSNAP
	client: unify kicking cap flushes and kicking snapcap flushes
	client: define helper function that sends flushsnap message
	client: cleanup tracking of early kicked flushing caps

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-07-26 15:18:13 -07:00
Patrick Donnelly
02eace72e2
Merge PR #28793 into master
* refs/pull/28793/head:
	qa/cephfs: make run_shell() accept args as str too
	qa/vstart_runner.py: ignores when source and destination are same
	test_cephfs_shell: add a test for cd with arguments
	test_cephfs_shell: add a test for cd with no arguments
	test_cephfs_shell: group test methods
	test_cephfs_shell: add a new method to return script output
	test_cephfs_shell: allow running CephFS shell script
	cephfs-shell: cd with no args shouldn't print an error message

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-07-26 15:15:19 -07:00
Patrick Donnelly
088e00a6e9
Merge PR #29064 into master
* refs/pull/29064/head:
	mds: execute PurgeQueue on_error handler in finisher

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-07-26 15:13:59 -07:00
Patrick Donnelly
a68dd73a0e
Merge PR #29302 into master
* refs/pull/29302/head:
	cephfs: fix a memory leak

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-07-26 15:13:08 -07:00
Patrick Donnelly
511cf15c57
Merge PR #29066 into master
* refs/pull/29066/head:
	mds: Move inline functions with loops or switch statements to CInode.cc
	mds: Reorganize class members in CInode header

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-07-26 15:12:19 -07:00
Patrick Donnelly
200e3fb5cc
Merge PR #29336 into master
* refs/pull/29336/head:
	qa: wait for MDS to come back after removing it

Reviewed-by: Jos Collin <jcollin@redhat.com>
2019-07-26 15:09:14 -07:00
Sage Weil
4beb83c22f qa/suites/kcephfs/recovery/failover.yaml: disable RECENT_CRASH
Signed-off-by: Sage Weil <sage@redhat.com>
2019-07-26 15:52:31 -05:00
Patrick Donnelly
5e08dac8c1
qa: ignore expected MDS_CLIENT_LATE_RELEASE warning
Fixes: http://tracker.ceph.com/issues/40968
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2019-07-26 13:37:23 -07:00
Sage Weil
2c87a46364 qa/suites/fs/multifs/tasks/failover.yaml: disable RECENT_CRASH
This test deliberately crashes daemons.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-07-26 15:00:11 -05:00
Casey Bodley
6fb258c691
Merge pull request #29359 from jmunhoz/wip-msite-az-tests
rgw: az: add archive zone tests

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2019-07-26 15:29:55 -04:00
Kefu Chai
d6170e70b6 mgr/dashboard/qa: add more fields to report
to be in sync with #28847

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-07-27 01:50:33 +08:00
Kefu Chai
0a8c11d172 qa/suites/rados/rest/mgr-restful: whitelist OSDMAP_FLAGS
`rest/test-restful.sh` calls `test_mgr_rest_api.py`, which in turn
calls

```
    ('patch',  '/config/osd', {'pause': True}),
```

and rest module translates it to `ceph osd set key=pause`

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-07-27 01:29:05 +08:00
Javier M. Mellid
2e92b48a32 rgw: az: add archive zone tests
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
2019-07-26 17:53:20 +02:00
Sage Weil
107ab12f02 mgr/telemetry: salt osd ids too
Better to fully obfuscate here.

This has a nice side-effect of assigning entity names that are *globally*
unique across the full telemetry data set, since the salts are unique and
sha1 is (sufficiently) collision-free.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-07-26 10:17:22 -05:00
Sage Weil
58135db317 mgr/telemetry: separate out cluster config vs running daemons
This indirectly tells us whether the cluster config is being used (vs
ceph.conf).

Signed-off-by: Sage Weil <sage@redhat.com>
2019-07-26 10:05:52 -05:00
Sage Weil
fce9fe87df mgr/telemetry: include any config options that are customized
This does not reveal the value of the options, only which options have
been customized.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-07-26 08:17:58 -05:00
Sage Weil
a4e8eb922f Merge PR #29330 into master
* refs/pull/29330/head:
	mgr/telemetry: obscure entity_name with a salt

Reviewed-by: Dan Mick <dmick@redhat.com>
2019-07-26 07:32:30 -05:00
Adam King
e2b8bb1200 mgr/dashboard: Explicitly type page variables
Explicitly gives a type to page variables.
Helps make better use of Typescript's static type checking.
Undoes mistake from #29070.

Fixes: https://tracker.ceph.com/issues/40961

Signed-off-by: Adam King <adking@redhat.com>
Signed-off-by: Rafael Quintero <rquinter@redhat.com>
2019-07-26 08:29:52 -04:00
Sebastian Wagner
ca830c95a6 mgr: Reduce logging noise when handling commands
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-07-26 14:06:35 +02:00
Ricardo Marques
db4e11b34f
Merge pull request #29237 from adk3798/usertest
mgr/dashboard: RGW user E2E Tests

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
2019-07-26 12:53:04 +01:00
Ricardo Marques
02bc599f3f
Merge pull request #29192 from ceph/dependabot/npm_and_yarn/src/pybind/mgr/dashboard/frontend/lodash-4.17.13
build(deps): bump lodash from 4.17.11 to 4.17.13 in /src/pybind/mgr/dashboard/frontend

Reviewed-by: Tiago Melo <tmelo@suse.com>
2019-07-26 12:41:33 +01:00
Nathan Cutler
7929af71d9 rpm: put librgw lttng SOs in the librgw-devel package
Shared objects belong in the devel package.

Fixes: http://tracker.ceph.com/issues/40975
Signed-off-by: Nathan Cutler <ncutler@suse.com>
2019-07-26 13:10:03 +02:00
Jason Dillaman
7ccf0b3229 pybind/mgr: don't log exception when cannot find RBD task by id
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-07-26 07:01:59 -04:00
Nathan Cutler
ea40019c5c rpm: improve ceph-mgr plugin package summaries
Fixes: http://tracker.ceph.com/issues/40974
Signed-off-by: Nathan Cutler <ncutler@suse.com>
2019-07-26 13:01:05 +02:00
Nathan Cutler
876d6bf6dc rpm: fdupes in SUSE builds to conform with packaging guidelines
Quoting from https://en.opensuse.org/openSUSE:Packaging_Conventions_RPM_Macros

"%fdupes is generally safe for use on /bin, /lib*, /usr (= %_prefix) and /sbin.
Do note however that files with same content but different ownership, when
hardlinked, will get the ownership of any of its content siblings."

Fixes: http://tracker.ceph.com/issues/40973
Signed-off-by: Nathan Cutler <ncutler@suse.com>
2019-07-26 12:42:09 +02:00
myoungwon oh
5badc4bd47 osd: fix wrong arguments when dropping refcount
Signed-off-by: Myoungwon Oh <omwmw@sk.com>
2019-07-26 19:40:31 +09:00
Ricardo Marques
1043154123
Merge pull request #29198 from rhcs-dashboard/e2e-ci
mgr/dashboard: run e2e tests against prod build (jenkins job)

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2019-07-26 11:22:00 +01:00
Kefu Chai
de9a04027f cmake/modules/Distutils: do not add ${name}-clone if already added
if `distutils_install_module("foo" ...)` is called mutiple times with
different python version, `foo-clone` will be added multiple times as a
custom target. which is not allowed:

add_custom_target cannot create target "foo-clone" because another
target with the same name already exists.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-07-26 12:11:25 +02:00
Sebastian Wagner
ea15a67b98 ceph.spec, debian: Add python-common to ceph-common
Co-authored-by: Tim Serong <tserong@suse.com>
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-07-26 12:10:52 +02:00
Jeff Layton
bc0f7e18d5 client: don't report any vxattrs to listxattr
The convention with kernel filesystems is to not report vxattrs when
listxattr is called. Doing this can throw a wrench to archiving tools
that will attempt to restore files with xattrs intact, only to find
that some of them can't be stored.

Remove the code that prints out vxattrs in listxattr. With this we
also don't need the "hidden" flag in the vxattr definitions.

Also fix up the existing testcases to account for the change in
behavior.

Fixes: https://tracker.ceph.com/issues/40965
Signed-off-by: Jeff Layton <jlayton@redhat.com>
2019-07-26 06:09:54 -04:00
Sebastian Wagner
0b5cd18bee cmake: Add python-common
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
Co-authored-by: Kefu Chai <kchai@redhat.com>
2019-07-26 12:07:58 +02:00
Sebastian Wagner
04254df56d python-common: Move Drive Group tests
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-07-26 12:05:35 +02:00
Sebastian Wagner
8c50be5df6 vstart: Add python-common
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-07-26 12:04:58 +02:00
Sebastian Wagner
7077cb1ba5 python-common: Fix imports
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-07-26 12:00:33 +02:00
Sebastian Wagner
c4625d86c4 python-common: Reference it in the docs
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-07-26 12:00:33 +02:00
Sebastian Wagner
74977b17b9 python-common: Initialize package structure
This package is supposed to contain common Python code usable by all modules and tools.

It is also supposed to contain code to deploy ceph clutsers.

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-07-26 12:00:33 +02:00
Ricardo Marques
0bcbcb9d01
Merge pull request #29280 from rhcs-dashboard/bucket-tests
mgr/dashboard: RGW bucket creation when no placement target received

Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
2019-07-26 10:39:14 +01:00
Volker Theile
2c95333903 mgr/dashboard: Various UI issues related to CephFS
* Check if data is accessible, otherwise set grafanaId to undefined.
* Catch errors in 'Clients' tab and stop loading spinner. Display ViewCacheStatus Exception.
* Render the 'Enabled' column using the checkIcon cell template as other lists do.

Fixes: https://tracker.ceph.com/issues/40925

Signed-off-by: Volker Theile <vtheile@suse.com>
2019-07-26 11:29:41 +02:00
Jianpeng Ma
44dbc2eec5 os/bluestore: avoid unnecessary notify.
Add parameter count waiting list for Onode::flush to avoid unnecessary
notify.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
2019-07-26 15:46:29 +08:00
songweibin
5e8c412e63 common,tools: make sure the destination buffer can handle the size of the string
fix klocwork issues:
Width is not specified for 's' conversion specifier.
This can result in an overflow of the buffer
provided in argument 3 of a call to 'sscanf'

Signed-off-by: songweibin <song.weibin@zte.com.cn>
2019-07-26 14:27:02 +08:00
songweibin
1428c6e447 src/tools: initialize variables before the goto statement
CID 172143 (#15 of 15): Branch past initialization (PW.BRANCH_PAST_INITIALIZATION)
1. branch_past_initialization:
2. name_at_decl_position: variable "oid" (declared at line 220)
3. name_at_decl_position: variable "exkeys" (declared at line 241)
4. name_at_decl_position: variable "exvals" (declared at line 242)
5. name_at_decl_position: variable "safe" (declared at line 278)

Signed-off-by: songweibin <song.weibin@zte.com.cn>
2019-07-26 14:27:02 +08:00
songweibin
b737cc4248 src/mount: check before dereference buf
CID 180671 (#1 of 1): Dereference null return value (NULL_RETURNS)

Signed-off-by: songweibin <song.weibin@zte.com.cn>
2019-07-26 14:27:02 +08:00
songweibin
e027012117 src/crush: check before dereference out2
CID 174874 (#2 of 2): Dereference after null check (FORWARD_NULL)
30. var_deref_op: Dereference null pointer out2.

Signed-off-by: songweibin <song.weibin@zte.com.cn>
2019-07-26 14:27:02 +08:00
Kefu Chai
d5ed1eaa1b
Merge pull request #29264 from rjfd/wip-dashboard-fix-qa-rbd
mgr/dashboard: qa: fix RBD test when matching error strings

Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-07-26 14:25:35 +08:00
Zhi Zhang
2c312614a7 mds: delay exporting directory whose pin value exceeds max rank id
Currently we allow to set ceph.dir.pin value to any number. If it is
larger than current max id, this dir will stay in export_pin_queue all
the time and every tick migrator will try to handle it but never export
it successfully.

Fixes: http://tracker.ceph.com/issues/40603

Signed-off-by: Zhi Zhang <zhangz.david@outlook.com>
2019-07-26 12:01:08 +08:00