Lenz Grimmer
d9ff2782c5
Merge pull request #23802 from votdev/unique_validator
...
mgr/dashboard: Add unique validator
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2018-08-31 11:13:00 +02:00
Kefu Chai
f8985aa579
Merge pull request #23629 from wangxiaoguang/fix_deep_scrub
...
os/bluestore: fix deep-scrub operation againest disk silent errors
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: David Zafman <dzafman@redhat.com>
2018-08-31 16:54:07 +08:00
Lenz Grimmer
9f1b6fae78
Merge pull request #23555 from tspmelo/wip-task-refactor
...
mgr/dashboard: Extract/Refactor Task merge
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2018-08-31 10:49:46 +02:00
xie xingguo
22786cffa8
osd/PG: force auth_log_shard to be primary when appropriate
...
So if there are a lot fo missing objects on primary, we can
make use of auth_log_shard to restore client I/O quickly.
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
2018-08-31 16:29:25 +08:00
Xiaoguang Wang
a7f1af25dd
os/bluestore: fix deep-scrub operation againest disk silent errors
...
Say a object who has data caches, but in a while later, caches' underlying
physical device has silent disk erros accidentally, then caches and physical
data are not same. In such case, deep-scrub operation still tries to read
caches firstly and won't do crc checksum, then deep-scrub won't find such
data corruptions timely.
Here introduce a new flag 'CEPH_OSD_OP_FLAG_BYPASS_CLEAN_CACHE' which tells
deep-scrub to bypass object caches. Note that we only bypass cache who is in
STATE_CLEAN state. For STATE_WRITING caches, currently they are not written
to physical device, so deep-scrub operation can not read physical device and
can read these dirty caches safely. Once they are in STATE_CLEAN state(or not
added to bluestore cache), next round deep-scurb can check them correctly.
As to above discussions, I refactor BlueStore::BufferSpace::read sightly,
adding a new 'flags' argument, whose value will be 0 or:
enum {
BYPASS_CLEAN_CACHE = 0x1, // bypass clean cache
};
flags 0: normal read, do not bypass clean or dirty cache
flags BYPASS_CLEAN_CACHE: bypass clean cache, currently only for deep-scrube
operation
Test:
I deliberately corrupt a object with cache, with this patch, deep-scrub
can find data error very timely.
Signed-off-by: Xiaoguang Wang <xiaoguang.wang@easystack.cn>
2018-08-31 14:11:18 +08:00
xie xingguo
7de35629f5
osd/PG: make num_objects_missing can trace missing objects correctly
...
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
2018-08-31 13:51:04 +08:00
xie xingguo
8c6837cfc2
osd/osd_types: kill overlaps_with() of pg_info_t
...
Which has no consumers.
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
2018-08-31 13:51:04 +08:00
xie xingguo
0801640520
osd/PG: clear calc_replicated_acting a bit
...
- kill usable, use want->size instead
- introduce a (separate) lambda function for sorting
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
2018-08-31 13:51:04 +08:00
xie xingguo
af84517332
osd/PG: move comments to the proper place
...
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
2018-08-31 13:51:04 +08:00
xie xingguo
4068e724ce
osd/PG: find_best_info - add completeness as the preferred option
...
Async recovery peers usually have a relative complete
log history but may exist a lot of missing objects. Choosing them
as auth_log_shard and further as primary if current up_primary is
unrecoverable, say, could have a bigger chance to block client I/Os.
Among peers with identical new log history, we now consider those
who are now complete (having no missing objects) as the preferred
ones when determining auth_log_shard.
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
2018-08-31 13:51:04 +08:00
Kefu Chai
2250b4cc91
Merge pull request #23546 from xiexingguo/wip-complete-to
...
osd/PGLog: trim - avoid dereferencing invalid iter
Reviewed-by: Yan Jun <yan.jun8@zte.com.cn>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2018-08-30 23:23:48 +08:00
Kefu Chai
ea72d7deb2
Merge pull request #23800 from rjfd/wip-fix-crash-mgr-module
...
mgr/crash: fix python3 invalid syntax problems
Reviewed-by: Nathan Cutler <ncutler@suse.com>
Reviewed-by: Noah Watkins <nwatkins@redhat.com>
2018-08-30 23:08:36 +08:00
Kefu Chai
99e95e4c9f
Merge pull request #23803 from tchaikov/wip-ceph_assert
...
include/buffer.h: do not use ceph_assert() unless __CEPH__ is defined
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2018-08-30 23:03:29 +08:00
Lenz Grimmer
03739c149c
Merge pull request #23820 from LenzGr/nautilus-404-page
...
mgr/dashboard: Updated image on 404 page
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2018-08-30 16:22:12 +02:00
Tiago Melo
2614805706
mgr/dashboard: Extract/Refactor Task merge
...
Signed-off-by: Stephan Müller <smueller@suse.com>
Signed-off-by: Tiago Melo <tmelo@suse.com>
2018-08-30 15:15:27 +01:00
Andrew Schoen
8a72f812d5
Merge pull request #23785 from alfredodeza/wip-rm34309
...
ceph-volume: update batch documentation to explain filestore strategies
Reviewed-by: Andrew Schoen <aschoen@redhat.com>
2018-08-30 09:14:36 -05:00
Mykola Golub
e93472cec5
librbd: option to limit in-flight appends
...
Signed-off-by: Mykola Golub <mgolub@suse.com>
2018-08-30 17:07:39 +03:00
Mykola Golub
46159af76c
journal: limit in-flight appends
...
Signed-off-by: Mykola Golub <mgolub@suse.com>
2018-08-30 17:07:38 +03:00
Sage Weil
1249e6e842
Merge PR #23509 into master
...
* refs/pull/23509/head:
OSD: add recovery bytes counter to osd logger
Reviewed-by: Sage Weil <sage@redhat.com>
2018-08-30 08:52:49 -05:00
Sage Weil
85083f39b5
Merge PR #23572 into master
...
* refs/pull/23572/head:
qa/standalone/osd/osd-force-create-pg: add force-create-pg test
mon/MonCommands: fix 'osd force-create-pg'
Reviewed-by: Kefu Chai <kchai@redhat.com>
2018-08-30 08:52:44 -05:00
Sage Weil
84335576b7
Merge PR #23611 into master
...
* refs/pull/23611/head:
mgr/devicehealth: fix exceptions
doc/mgr/devicehealth: update docs
mgr/devicehealth: leave health monitoring off by default
mgr/devicehealth: add 'device monitoring {on,off}' commands
mgr/devicehealth: 10m wakeup interval is sufficient
mgr/devicehealth: scrape at scrape_interval intervals
mgr/devicehealth: UTC everywhere
mgr/devicehealth: fix sleep_interval configurable
2018-08-30 08:52:39 -05:00
Sage Weil
92c198f92c
Merge PR #23633 into master
...
* refs/pull/23633/head:
osd/PrimaryLogPG.cc: limit trimming at can_rollback_to
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2018-08-30 08:52:32 -05:00
Volker Theile
631a9c9844
mgr/dashboard: Add unique validator
...
Relocate an already existing async validator into a separate validator that can be reused by every other form. This validator is useful to check immediately after typing if an entered value, e.g. username, already exists.
The API request will be triggered after a delay of 500ms (can be modified). During this delay, every keystroke will reset the timer, so the REST API is not flooded with request.
Signed-off-by: Volker Theile <vtheile@suse.com>
2018-08-30 15:43:37 +02:00
Lenz Grimmer
f59a673cae
Merge pull request #23712 from tspmelo/wip-browser-support
...
mgr/dashboard: Add documentation about supported browsers
Reviewed-by: Volker Theile <vtheile@suse.com>
2018-08-30 13:53:27 +02:00
songweibin
f7f1b37c32
rbd: minor cleanup for rbd namespace
...
Signed-off-by: songweibin <song.weibin@zte.com.cn>
2018-08-30 18:32:00 +08:00
songweibin
a2c9a622e6
rbd: verify the specified namespace before set
...
Signed-off-by: songweibin <song.weibin@zte.com.cn>
2018-08-30 18:31:59 +08:00
songweibin
aebd6ed964
rbd: add new librbd method to assert namespace exists
...
Signed-off-by: songweibin <song.weibin@zte.com.cn>
2018-08-30 18:18:14 +08:00
Lenz Grimmer
816a0b9271
Merge pull request #23796 from votdev/fix_form_button_layout
...
mgr/dashboard: Add gap between panel footer buttons
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
2018-08-30 12:00:06 +02:00
Lenz Grimmer
40c73ca4c4
mgr/dashboard: Updated image on 404 page
...
Replaced the image of a Mimic octopus with a Nautilus octopus in
preparation for the new major release code name.
The image was taken from Flickr (https://www.flickr.com/photos/146401137@N06/40335060661 ) and is
licensed under the Creative Commons "Attribution 2.0 Generic"
(CC BY 2.0) license.
Fixes: https://tracker.ceph.com/issues/24489
Signed-off-by: Lenz Grimmer <lgrimmer@suse.com>
2018-08-30 11:16:39 +02:00
Tiago Melo
8d73f62032
mgr/dashboard: Add documentation about supported browsers
...
Fixes: http://tracker.ceph.com/issues/27207
Signed-off-by: Tiago Melo <tmelo@suse.com>
2018-08-30 09:57:17 +01:00
Xie Xingguo
e2e1dbcf3c
Merge pull request #23814 from joke-lee/doc_rgw_period_root_pool_long_description
...
doc: fix long description error for rgw_period_root_pool
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
2018-08-30 12:12:07 +08:00
Kefu Chai
8748d27130
Merge pull request #23767 from tchaikov/wip-operator-insertion-ADL
...
include/types: move operator<< into the proper namespace
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2018-08-30 11:04:43 +08:00
Kefu Chai
5608b1901c
Merge pull request #23795 from tchaikov/wip-cmake-definitions-cleanup
...
cmake: no need to add "-D" before definitions
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Ali Maredia <amaredia@redhat.com>
2018-08-30 10:36:30 +08:00
Kefu Chai
04504f42bc
Merge pull request #23774 from tchaikov/wip-include-cleanup
...
auth,common: include cleanups
Reviewed-by: Noah Watkins <nwatkins@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
2018-08-30 10:32:41 +08:00
Xiaoguang Wang
2c862ce6e9
core: add missing flag name for CEPH_OSD_OP_FLAG_WITH_REFERENCE
...
Signed-off-by: Xiaoguang Wang <xiaoguang.wang@easystack.cn>
2018-08-30 10:24:30 +08:00
yuliyang
1c65a52bfb
doc: fix long description error for rgw_period_root_pool
...
Signed-off-by: yuliyang <yuliyang@cmss.chinamobile.com>
2018-08-30 08:04:06 +08:00
Mykola Golub
9f9b525a03
Merge pull request #23733 from dillaman/wip-migration-parent
...
librbd: always open first parent image if it exists for a snapshot
Reviewed-by: Mykola Golub <mgolub@suse.com>
2018-08-29 21:45:08 +03:00
Andrew Schoen
bd82967b76
Merge pull request #23788 from alfredodeza/wip-rm34311
...
ceph-volume: tests.functional inherit SSH_ARGS from ansible
Reviewed-by: Andrew Schoen <aschoen@redhat.com>
2018-08-29 13:18:48 -05:00
Alfredo Deza
7a076f5e4f
ceph-volume tests.functional use Debian ansible os family in deploy.yml
...
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2018-08-29 10:32:55 -07:00
Sage Weil
5a62ca53f1
mgr/devicehealth: fix exceptions
...
Signed-off-by: Sage Weil <sage@redhat.com>
2018-08-29 12:30:24 -05:00
Sage Weil
df71738d79
doc/mgr/devicehealth: update docs
...
- several new commands weren't documented
Signed-off-by: Sage Weil <sage@redhat.com>
2018-08-29 12:30:24 -05:00
Sage Weil
8af0ffe9e1
mgr/devicehealth: leave health monitoring off by default
...
For now at least.. unless all of the tests have been adjusted accordingly
to expect a device_health_metrics pool.
Signed-off-by: Sage Weil <sage@redhat.com>
2018-08-29 12:30:24 -05:00
Sage Weil
51e4eb7791
Merge PR #23742 into master
...
* refs/pull/23742/head:
mon/OSDMonitor: don't change in-memory state on prune
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
2018-08-29 12:25:23 -05:00
Alfredo Deza
b2a62c2b13
ceph-volume lvm.batch use the abspath attribute for Device objects in bluestore
...
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2018-08-29 09:56:21 -07:00
Alfredo Deza
6f3094449f
ceph-volume lvm.batch remove usage of non-existent method
...
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2018-08-29 09:55:31 -07:00
Alfredo Deza
379cc26db5
Merge pull request #23801 from alfredodeza/wip-rm34317
...
doc/rados update invalid bash on bluestore migration
Reviewed-by: Kefu Chai <kchai@redhat.com>
2018-08-29 09:32:15 -07:00
Alfredo Deza
8e6269336f
ceph-volume tests.functional inherit SSH_ARGS from ansible with synchronize module
...
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2018-08-29 09:14:42 -07:00
Andrew Schoen
b5c3082d4e
Merge pull request #23787 from alfredodeza/wip-rm34310
...
ceph-volume lvm.batch remove non-existent sys_api property
Reviewed-by: Andrew Schoen <aschoen@redhat.com>
2018-08-29 11:12:37 -05:00
Kefu Chai
c682176daa
Merge pull request #23741 from liewegas/wip-protect-monmap
...
mon: only share monmap after authenticating
Reviewed-by: Joao Eduardo Luis <joao@suse.de>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2018-08-29 23:36:31 +08:00
Kefu Chai
8d1b253f97
Merge pull request #23738 from dmick/wip-fix-crashdump
...
global/signal_handler.cc: report assert_file as correct name
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2018-08-29 23:26:46 +08:00