Commit Graph

102858 Commits

Author SHA1 Message Date
Venky Shankar
ba5e7042fc doc: document mds journal event types
Fixes: http://tracker.ceph.com/issues/42190
Signed-off-by: Venky Shankar <vshankar@redhat.com>
2019-10-07 16:39:31 +05:30
Kefu Chai
20c8007c26
Merge pull request #30736 from tchaikov/wip-crimson/osd/cleanups
crimson/osd: cleanups

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2019-10-07 17:38:47 +08:00
Lenz Grimmer
ed16537a63
mgr/dashboard: Unify Tasks and Notifications into a sidebar (#29706)
mgr/dashboard: Unify Tasks and Notifications into a sidebar

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2019-10-07 08:55:27 +00:00
Lenz Grimmer
9154026c59
Merge pull request #30720 from rhcs-dashboard/fix-constraints-backend-api-tests
mgr/dashboard: fix missing constraints file in backend API tests

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2019-10-07 08:48:14 +00:00
Mykola Golub
8ec5f6c8d7
Merge pull request #30711 from dillaman/wip-41938
librbd: v1 clones are restricted to the same namespace

Reviewed-by: Mykola Golub <mgolub@suse.com>
2019-10-07 11:30:02 +03:00
Kefu Chai
73ee20ea26
Merge pull request #30656 from tchaikov/wip-install-deps-for-el8
install-deps.sh: enable PowerTool repo for EL8

Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-10-07 16:06:30 +08:00
Kefu Chai
20773e01e5
Merge pull request #30693 from rzarzynski/wip-msg-fix-comments-std_set
msg: fix comments in Messenger.h after the set -> std::set switch.

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-10-07 15:15:42 +08:00
Kefu Chai
1509825926
Merge pull request #30719 from pdvian/wip-fix-sign-compare-warning
client/Client : Fix sign compare compiler warning

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-10-07 13:25:03 +08:00
Prashant D
af41fae4df client/Client : Fix sign compare compiler warning
introduced by 394720ca6b

Signed-off-by: Prashant D <pdhange@redhat.com>
2019-10-06 23:46:42 -04:00
Ali Maredia
d4872ce97a
Merge pull request #29783 from scarvalhojr/ssevault
rgw: add SSE-KMS with Vault using token auth
2019-10-06 22:33:36 -04:00
Sage Weil
bbc7bb5a22 Merge PR #30217 into master
* refs/pull/30217/head:
	crimson: common/admin_socket kludge so that it builds
	mon/MonClient: fix sending mon command to a specific rank
	src/.gitignore: ignore .tox
	mon/MonClient: interpret numeric mon target name as rank
	mgr,mgr/MgrClient: use fsid to signal mon-mgr vs cli MCommands
	qa/workunits/cephtool: fix errpr checks for 'ceph daemon' commands
	common/ceph_context: make 'config unset' idempotent
	qa/tasks/dump_stuck: mon.a, not mon.0
	qa/suites/rados/singleton/all/admin-socket: fix test
	common/config: EPERM setting config option after startup
	qa/workunits/cephtool/test.sh: fix tell output error check
	common/admin_socket: pass Formatter from generic infrastructure
	common/admin_socket: pass ostream to call() for error output
	os/bluestore: fix asok hook return value
	rgw: fix asok return value
	common/ceph_context: return error code from asok commands
	test/pybind/test_rados: fix accidental mon tell test
	mon: print entity_name along with caps to debug log
	PendingReleaseNotes: notes about asok changes
	mgr/MgrClient: empty target string for 'tell' means active mgr
	common/admin_socket: report error code as part of output string
	osd: change trigger_[deep_]scrub tommands to a pg tell command
	osd: remove old command workqueue, threadpool
	osd: drop MMonCommand handling
	osdc/Objecter: resend OSD tell commands on EAGAIN
	osd: route tell commands to asok; migrate commands
	osd: use unique_ptr<Formatter> for asok_command
	common/ceph_context: add generic asok 'injectargs'
	common/admin_socket: allow dup prefixes
	common/admin_socket: refactor with sync and async execute_command variants
	common/admin_socket: pass input bufferlist
	osd: transition to call_async() for asok
	common/admin_socket: support alternative call_async()
	mon/MonClient: send tell commands out of band via MCommand
	mon: accept tell commands via MCommand and send them to asok handler
	common/admin_socket: return int from hook call()
	mgr/DaemonServer: route MCommand (for octopus+) to asok commands
	do not use 'ceph tell mgr'
	pybind/ceph_argparse: disambiguate mgr tell and CLI commands
	ceph: make 'ceph tell mgr.*' send to the active mgr
	ceph: send 'ceph tell mgr.X' to the right mgr
	librados: add rados_mgr_command_target
	mgr/MgrClient: add start_command variant that takes a target
	common/admin_socket: drop unregister_command(); use per-hook variant
	common/admin_socket: drop explicit prefix arg to register_command
	common/admin_socket: simplify command routing
	common/admin_socket: add ability to process MCommand via asok queue
	common/admin_socket: pass cmdvec to execute_command
	common/admin_socket: use pipe for general wakeup
	include/compat: add flags arg to pipe_cloexec
	common/admin_socket: drop unused args

Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-10-06 09:08:28 -05:00
Sage Weil
18e45ca3a1 Merge PR #30715 into master
* refs/pull/30715/head:
	osd/PrimaryLogPG: skip obcs that don't exist during backfill scan_range

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-10-06 09:05:27 -05:00
Sage Weil
19a1d0dd68 Merge PR #30721 into master
* refs/pull/30721/head:
	osd/PeeringState: base lease support checks on features, not require_osd_release

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-10-06 08:58:32 -05:00
Kefu Chai
44a11595d1 crimson/osd: ignore returned futures
the peering events are handled in the background, we need to make sure
the these continuations won't outlive the PG before destroying it
though.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-10-06 17:20:28 +08:00
Kefu Chai
7ef1c007c4 crimson/osd: should return ostream in operator<<()
Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-10-06 17:20:28 +08:00
Kefu Chai
b819821ee3 crimson/osd: #include necessary header file
for using `seastar::sleep()`, we need to include sleep.hh

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-10-06 17:20:28 +08:00
Sage Weil
878178f2b4 Merge PR #29035 into master
* refs/pull/29035/head:
	mgr/pg_autoscaler: changes made reflect jdurgin's request
	mgr/pg_autoscaler: current pg_num compared to distance between the last initial_pg_num
	mgr/progress & mgr/pg_autoscaler: changes reflect liewegas' comment
	mgr/pg_autoscaler: get rid of white space
	mgr/progress: change threshold value to origin
	mgr/progress: cleaning up for pg_autoscaler
	mgr/progress: Added Pg Autoscaler Event

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2019-10-04 20:42:07 -05:00
Sage Weil
8d6652f4fb Merge PR #30679 into master
* refs/pull/30679/head:
	common/safe_io: pass mode to safe_io; use 0600, not 0644
	kv/RocksDBStore: tell rocksdb to set mode to 0600, not 0644

Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-10-04 20:41:51 -05:00
Sage Weil
2355b227ed Merge PR #30712 into master
* refs/pull/30712/head:
	osd: set affinity for *all* threads

Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-10-04 20:41:28 -05:00
Sage Weil
11212487b9 Merge PR #30716 into master
* refs/pull/30716/head:
	osd/PrimaryLogPG: fix warning

Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-10-04 20:41:15 -05:00
David Zafman
fdf93add0b
Merge pull request #30714 from dzafman/wip-41743
test: Ignore OSD_SLOW_PING_TIME* if injecting socket failures

Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-10-04 18:28:48 -07:00
Sage Weil
eb006b3150 Merge PR #29781 into master
* refs/pull/29781/head:
	telemetry/tables.txt: drop stack_weak_sig column
	telemetry/tables.txt: drop drop tables lines
	telemetry/server/tables.txt: add device_report table
	telemetry: misc scripts

Reviewed-by: Dan Mick <dmick@redhat.com>
2019-10-04 16:01:08 -05:00
sage@newdream.net
785ceabdf6 telemetry/tables.txt: drop stack_weak_sig column
Signed-off-by: sage@newdream.net <sage@telemetry.ceph.com>
2019-10-04 20:55:32 +00:00
sage@newdream.net
660293bf93 telemetry/tables.txt: drop drop tables lines
Signed-off-by: sage@newdream.net <sage@telemetry.ceph.com>
2019-10-04 20:55:32 +00:00
user.email
fbf4ca99c9 telemetry/server/tables.txt: add device_report table
Signed-off-by: Sage Weil <sage@newdream.net>
2019-10-04 20:55:32 +00:00
Sage Weil
d5b1698c9e telemetry: misc scripts
Signed-off-by: Sage Weil <sage@newdream.net>
2019-10-04 20:55:32 +00:00
Jason Dillaman
547ebccaf9 librbd: v1 clones are restricted to the same namespace
Therefore the v1 parent spec should not attempt to populate the
namespace.

Fixes: https://tracker.ceph.com/issues/41938
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-10-04 13:27:50 -04:00
Sergio de Carvalho
7b216bab3d rgw: add SSE-KMS with Vault using token auth
Clarify supported secret engine in the Vault documentation.

Signed-off-by: Andrea Baglioni <andrea.baglioni@workday.com>
Signed-off-by: Sergio de Carvalho <sergio.carvalho@workday.com>
2019-10-04 15:55:51 +01:00
Sage Weil
4629e4d799 osd/PeeringState: base lease support checks on features, not require_osd_release
The require_osd_release value will change at an arbitrary point in time,
midway through a peering interval.  That can leave us in a state where
we are midway through an interval and suddenly enforcing checks on leases
we don't have.

In contrast, the upacting features change at an interval boundary, which
lets us adjust our behavior for the whole interval.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-04 09:49:43 -05:00
Sage Weil
a17e889b22 crimson: common/admin_socket kludge so that it builds
Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-04 09:07:03 -05:00
Sage Weil
dbb53e68c4 mon/MonClient: fix sending mon command to a specific rank
The target_name check was triggering when target_name was empty (and
target_rank >= 0).

Fixes 4ef0502da5

Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-04 09:07:03 -05:00
Sage Weil
cc8bd47824 src/.gitignore: ignore .tox
Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-04 09:07:03 -05:00
Sage Weil
62f33d5978 mon/MonClient: interpret numeric mon target name as rank
This allows us to behave when a rank is passed to mon_command(..., target=),
which will call rados_mon_command_target() -> MonClient::start_mon_command
with a (string) target name.

We could make an integer variant of rados_mon_command_target, and do the
int vs string differentiation in python, but this is much easier.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-04 09:07:03 -05:00
Sage Weil
6f35d28352 mgr,mgr/MgrClient: use fsid to signal mon-mgr vs cli MCommands
We can't use the feature bit for the MCommand connection to tell whether
it is a tell or CLI command because new clients may have to send CLI
commands via MCommand for old clusters, and they don't always know whether
this mgr is new or old yet.

Prior to octopus, MCommand contained a mon/mgr CLI command, and did not
have the fsid field set.  Start populating the fsid field, and use this
to signal whether a client is a new MgrClient that knows MCommand vs
MMgrCommand.  If we get an MCommand with the fsid set, that means it is
a tell command; otherwise, it's an old client sending a CLI command.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-04 09:07:03 -05:00
Sage Weil
99f940641f qa/workunits/cephtool: fix errpr checks for 'ceph daemon' commands
Error output has changed slightly.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-04 09:07:03 -05:00
Sage Weil
9585dd0e0f common/ceph_context: make 'config unset' idempotent
Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-04 09:07:03 -05:00
Sage Weil
4a4897414d qa/tasks/dump_stuck: mon.a, not mon.0
Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-04 09:07:03 -05:00
Sage Weil
7b644f599b qa/suites/rados/singleton/all/admin-socket: fix test
We can't set the filestore setting because filestore isn't active and so
the option isn't observed, so it isn't changeable.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-04 09:07:03 -05:00
Sage Weil
0f47d10bab common/config: EPERM setting config option after startup
Not sure why ENOSYS was chosen before...

Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-04 09:07:03 -05:00
Sage Weil
05bc99f82e qa/workunits/cephtool/test.sh: fix tell output error check
It goes to stderr instead of stdout now.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-04 09:07:03 -05:00
Sage Weil
adf1486e46 common/admin_socket: pass Formatter from generic infrastructure
The implementation can choose to either use the provided Formatter, or
put something directly into outbl.  The implementation may choose to
flush the formatter to the output buffer|stream, or let the caller do it
for them (usually the latter).

Lots of fiddling/cleanup in the implementations to make this build,
including dropping the (seeminlyg unused?) ostream& output mode for
the librbd asok implementations.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-04 09:07:03 -05:00
Sage Weil
a4c07734bf common/admin_socket: pass ostream to call() for error output
This separates the error stream from the output stream for the synchronous
hook.

This patch includes misc cleanup in the various implementations to make
use of the new stream for errors.

Add a test to unittest_context to ensure we're getting the error stream.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-04 09:07:02 -05:00
Sage Weil
7aab81c97c os/bluestore: fix asok hook return value
Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-04 09:07:02 -05:00
Sage Weil
ee4ba58275 rgw: fix asok return value
Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-04 09:07:02 -05:00
Sage Weil
02115141ad common/ceph_context: return error code from asok commands
Several of these commands (config set, injectargs, etc.) can return errors.
Do so.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-04 09:07:02 -05:00
Sage Weil
215d267fa6 test/pybind/test_rados: fix accidental mon tell test
This test assumed 'mon dump' (a CLI command) would work when targetted at
a specific mon (i.e., a tell command).

Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-04 09:07:02 -05:00
Sage Weil
e1163b445b mon: print entity_name along with caps to debug log
Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-04 09:07:02 -05:00
Sage Weil
5d4fe85b74 PendingReleaseNotes: notes about asok changes
Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-04 09:07:02 -05:00
Sage Weil
22b0a99de7 mgr/MgrClient: empty target string for 'tell' means active mgr
This lets the caller say "tell the active mgr", whoever it may be.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-04 09:07:02 -05:00
Sage Weil
7e84910cfb common/admin_socket: report error code as part of output string
This isn't ideal, but it's better than nothing.

Net behavior change here is that calling an non-existant command now
succeeds with an error message instead of exiting with an error code
and no informative output.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-04 09:07:02 -05:00