A recent PR made sure that a bucket listing could not request too many
entries at once. It also did a minimum computation for number of
entries. For ordered listing the minimum was 0, as required to pass
all unit tests. However the minimum for unordered listing was left at
1. In order to make ordered and unordered listing behave the same --
with the exception of ordering -- the minimum for unordered listing is
modified to 0.
Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
osd/MissingLoc.cc: do not rely on missing_loc_sources only
Reviewed-by: David Zafman <dzafman@redhat.com>
Reviewed By: Xie Xingguo <xie.xingguo@zte.com.cn>
These are streamlined to only include the information we need for the
peering events, as reflected by the old handle_fast_pg_{notify,query,info}
messages.
Signed-off-by: Sage Weil <sage@redhat.com>
Queue up separate message for each.
Note that even though we are currenting sending this via a pg_notify_t,
not all of those fields are needed or consumed on the other end (notably,
PastIntervals is not used by handle_fast_pg_info). Only pass the fields
we need to send_info() so that we can improve the transport to be less
weird later.
Signed-off-by: Sage Weil <sage@redhat.com>
Right now we tell whether discover_all_missing did something by looking
at whether query_map is empty. Instead, use an explicit return value.
Signed-off-by: Sage Weil <sage@redhat.com>
The ref can be either a raw BufferedRecoveryMessages (buffering) or
a PeeringCtx (child class, no buffering). This avoids the need for a
member ref, and also means that we can (later) make methods take the
BufferedRecoveryMessages ref as a general interface to consume for both
buffered and non-buffered work that is outside of PeeringState.
Signed-off-by: Sage Weil <sage@redhat.com>
Have a generalized map of messages that are queued to be sent out. Send
them when we dispatch the PeeringCtx.
Signed-off-by: Sage Weil <sage@redhat.com>
* refs/pull/30220/head:
test: Allow fractional milliseconds to make test possible
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Since the parent form-group was not assigned to any field and was never invalid,
the invalid-feedback element was never displayed.
Signed-off-by: Tiago Melo <tmelo@suse.com>
the bucket index prepare step no longer writes a bilog entry, so the
tests were expecting more entries
Fixes: https://tracker.ceph.com/issues/41719
Signed-off-by: Casey Bodley <cbodley@redhat.com>
after #30061, extents returned by sparse read will always be
an empty map as long as the extents to be read is empty or the extent(s)
in it are empty, even of the objectstorage does not support sparse read.
Fixes: https://tracker.ceph.com/issues/41721
Signed-off-by: Kefu Chai <kchai@redhat.com>
osd: fix the missing default value m=2 of reed_sol_r6_op in profile
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
save the default value of m to profile so that it could be dumped
in command 'ceph osd erasure-code-profile get xxx', which is more
useful and friendly to user.
Signed-off-by: Yan Jun <yan.jun8@zte.com.cn>
Currently always-on modules are not marked as enabled in the WebUI and can be disabled. This PR will fix that.
Note, this PR will NOT implement code that will prevent a developer from trying to disable an always-on module through the REST API. The Mgr Python extension will throw an adequate exception.
This PR will also do:
* Remove old code fragments from a previous Mgr Module management UI that is obsolete now.
* Cleanup code in BaseMgrModule code.
Fixes: https://tracker.ceph.com/issues/41648
Signed-off-by: Volker Theile <vtheile@suse.com>
This prevents bluefs from trying to acquire more space than
it actually needs, e.g., due to batch deletion of user data.
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
In 624ade487e, we relied on missing_loc_sources
to check for strays and remove an OSD from missing_loc. However, it is
possible that missing_loc_sources is empty while there are still OSDs
present in missing_loc. Since the aim is to just remove a stray OSD from
missing_loc, we do not need to rely on missing_loc_sources. We still
clean missing_loc_sources if any stray is present in it.
Signed-off-by: Neha Ojha <nojha@redhat.com>
