Commit Graph

130504 Commits

Author SHA1 Message Date
Radosław Zarzyński
c976e67e3a crimson/common: avoid unnecessary throwing in stateful_error_t
This is an optimization for the flexible-but-slow `stateful_error_t`
error family of errorator. It's used infrequently.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
2022-03-30 14:21:25 +02:00
Koen Kooi
b7b381fe91 debian/control: fix python3-cherrypy*3* dependency
The trailing '3' was missed in one instance, ceph-mgr-cephadm, leading to:

	Some packages could not be installed. This may mean that you have
	requested an impossible situation or if you are using the unstable
	distribution that some required packages have not yet been created
	or been moved out of Incoming.
	The following information may help to resolve the situation:

	The following packages have unmet dependencies:
	 ceph-mgr-cephadm : Depends: python3-cherrypy but it is not installable

Which makes the installation fail.

Fixes: 78983ad0d0
Signed-off-by: Koen Kooi <koen@softiron.com>
2022-03-30 05:18:51 -07:00
Ernesto Puerta
043f7953d8
Merge pull request #45335 from rhcs-dashboard/fix-54513-master
mgr/dashboard: Pool overall performance shows multiple entries of same pool in pool overview

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: sunilangadi2 <NOT@FOUND>
2022-03-30 14:05:38 +02:00
Ernesto Puerta
751d3df47b
Merge pull request #45559 from rhcs-dashboard/existing-host-test-fix
mgr/dashboard: fix 01-hosts.e2e test error

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2022-03-30 13:00:36 +02:00
Anthony D'Atri
39e8ec9389
Merge pull request #45701 from inspur-wyq/wip-doc-typos
doc/radosgw/sync-modules.rst: fix typos
2022-03-29 23:54:42 -07:00
Anthony D'Atri
2df627751b
Merge pull request #45702 from inspur-wyq/wip-doc-my-typos
doc/cephadm/operations.rst: fix typos
2022-03-29 23:43:46 -07:00
Tim Serong
94ad178bdc ceph.spec.in: remove build directory in %clean, not %install
Removing the build directory at the end of %install is too soon,
and means we get rid of a bunch of stuff needed to correctly
create debuginfo/debugsource packages, which happens automatically
right after %install.  So, let's put it where it really belongs, in
the %clean section.

Fixes: aa18cb1200
Fixes: https://tracker.ceph.com/issues/55079
Signed-off-by: Tim Serong <tserong@suse.com>
2022-03-30 16:25:34 +11:00
Samuel Just
b73ed7bb39
Merge pull request #45630 from liu-chunmei/crimson-omap-cmp
crimson: add omap cmp

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2022-03-29 21:40:49 -07:00
wangyunqing
92eb799a95 doc/cephadm/operations.rst: fix typos
Signed-off-by: wangyunqing <wangyunqing@inspur.com>
2022-03-30 11:58:43 +08:00
wangyunqing
07584628d6 doc/radosgw/sync-modules.rst: fix typos
Signed-off-by: wangyunqing <wangyunqing@inspur.com>
2022-03-30 11:53:57 +08:00
Samuel Just
32ee47a864
Merge pull request #45526 from xxhdx1985126/wip-coordinate-segment-seq
crimson/os/seastore: coordinate segment seq of journal and ool segments

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2022-03-29 20:53:30 -07:00
Chunmei Liu
7244b80956 crimson: return 0 in osd_op.rval when enodata
Signed-off-by: Chunmei Liu <chunmei.liu@intel.com>
2022-03-29 17:44:54 -07:00
Chunmei Liu
019c4128cb crimson: add OP_OMAP_CLEAR support
Signed-off-by: Chunmei Liu <chunmei.liu@intel.com>
2022-03-29 17:44:40 -07:00
Chunmei Liu
3414b28278 crimson:add OMAP_CMP support
Signed-off-by: Chunmei Liu <chunmei.liu@intel.com>
2022-03-29 17:38:17 -07:00
Casey Bodley
90662cad56 cmake: WITH_SYSTEM_UTF8PROC defaults to OFF
change the default value of WITH_SYSTEM_UTF8PROC from ON to OFF, so that
centos/rhel users can build with the default cmake configuration. no other
WITH_SYSTEM_* variable in ceph defaults to ON, so this is consistent
with other bundled libraries like boost and rocksdb

unfortunately, this also means that users that do have system packages
must opt-in to using them with -DWITH_SYSTEM_UTF8PROC=ON

both deb and rpm builds dependended on the previous default value, so
their logic was negated to match the new default

Fixes: https://tracker.ceph.com/issues/55114

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2022-03-29 17:49:18 -04:00
Aishwarya Mathuria
3532b78901 osd/osd_types: Increasing decode version of scrub_duration in pg stats
All new fields added to pg stats after quincy RC need to have the decode field bumped up to avoid decoding errors during an upgrade from quincy RC to the quincy stable version

Fixes: https://tracker.ceph.com/issues/53923
Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
2022-03-29 23:40:54 +05:30
Redouane Kachach
19c07de820
mgr/cephadm: fallback to normal sorted if cannot import natsorted
Fixes: https://tracker.ceph.com/issues/55113

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2022-03-29 19:08:10 +02:00
Ernesto Puerta
64c6bb394b
Merge pull request #45563 from rhcs-dashboard/fix-54991-master
mgr/dashboard:  don't log 3xx as errors

Reviewed-by: Sarthak0702 <NOT@FOUND>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2022-03-29 19:03:49 +02:00
Yuval Lifshitz
44b5827050 multisite/test: running the multisite test script with multiple RGWs per zone
the RGW_PER_ZONE environment variables should be set to allow that
if not set, we assume 1 RGW per zone

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
2022-03-29 16:21:46 +03:00
Boris Ranto
f1d17b04e4
Merge pull request #45295 from lbausch/tweak_mgr_alerts_mail
mgr/alerts: Add Message-Id and Date header to sent emails

Reviewed-by: Boris Ranto <branto@redhat.com>
2022-03-29 13:55:14 +02:00
Ernesto Puerta
406e54d8c4
mgr/dashboard: don't log 3xx as errors
Let's avoid printing these ugly/misleading/redundant messages:

```
0 [dashboard DEBUG controllers.home] frontend language from headers: ['en-us']
0 [dashboard DEBUG controllers.home] found directory for language 'en-us'
0 [dashboard DEBUG controllers.home] serving static content: /home/jenkins-build/build/workspace/ceph-dashboard-pull-requests/build/src/pybind/mgr/dashboard/frontend/dist/en-US/styles.css
0 [dashboard ERROR exception] Internal Server Error
Traceback (most recent call last):
  File "/home/jenkins-build/build/workspace/ceph-dashboard-pull-requests/src/pybind/mgr/dashboard/services/exception.py", line 47, in dashboard_exception_handler
    return handler(*args, **kwargs)
  File "/usr/lib/python3/dist-packages/cherrypy/_cpdispatch.py", line 60, in __call__
    return self.callable(*self.args, **self.kwargs)
  File "/home/jenkins-build/build/workspace/ceph-dashboard-pull-requests/src/pybind/mgr/dashboard/controllers/home.py", line 134, in __call__
    return serve_file(full_path)
  File "/usr/lib/python3/dist-packages/cherrypy/lib/static.py", line 70, in serve_file
    cptools.validate_since()
  File "/usr/lib/python3/dist-packages/cherrypy/lib/cptools.py", line 117, in validate_since
    raise cherrypy.HTTPRedirect([], 304)
cherrypy._cperror.HTTPRedirect: ([], 304)
```

Fixes: https://tracker.ceph.com/issues/54991
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
2022-03-29 11:52:18 +02:00
Kefu Chai
1651ce5b03
Merge pull request #45676 from rzarzynski/wip-crimson-toolset-10
ceph.spec.in: use gcc-toolset-10 for building crimson

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-03-29 17:03:14 +08:00
Ernesto Puerta
729e956855
Merge pull request #44014 from rhcs-dashboard/host-detail-service-column
mgr/dashboard: extend daemon actions to host details 

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: sunilangadi2 <NOT@FOUND>
2022-03-29 10:49:31 +02:00
Yuval Lifshitz
cd96c07c6f
Merge pull request #45537 from yuvalif/wip-yuval-multisite-test-devices
multisite/test: running the multisite test script with custom devices
2022-03-29 10:35:57 +03:00
Tim Serong
01359f7905
Merge pull request #45666 from SUSE/wip-fix-55087
ceph.spec.in: Use libthrift-devel on SUSE distros

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-03-29 18:01:46 +11:00
Tim Serong
c454eeae35
Merge pull request #45664 from SUSE/wip-fix-55079
ceph.spec.in: remove build directory at end of %install

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-03-29 17:08:09 +11:00
Radosław Zarzyński
30f7514317 ceph.spec.in: use gcc-toolset-10 for building crimson
This commit bumps up the toolset version but only to build crimson.
That is, the classical OSD stays unaffected.

The reason behind the upgrade is the following FTBFS:

```
[ 32%] Building CXX object src/seastar/CMakeFiles/seastar.dir/src/core/reactor.cc.o
/home/jenkins-build/build/workspace/ceph-dev-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-11345-ga3bb1485/rpm/el8/BUILD/ceph-17.0.0-11345-ga3bb1485/src/seastar/src/core/reactor.cc: In constructor ‘seastar::reactor::reactor(std::shared_ptr<seastar::smp>, seastar:👽:instance&, unsigned int, seastar::reactor_backend_selector, seastar::reactor_config)’:
/home/jenkins-build/build/workspace/ceph-dev-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-11345-ga3bb1485/rpm/el8/BUILD/ceph-17.0.0-11345-ga3bb1485/src/seastar/src/core/reactor.cc:926:90: error: use of deleted function ‘seastar::condition_variable::condition_variable()’
  926 |     , _thread_pool(std::make_unique<thread_pool>(this, seastar::format("syscall-{}", id))) {
      |                                                                                          ^
In file included from /home/jenkins-build/build/workspace/ceph-dev-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-11345-ga3bb1485/rpm/el8/BUILD/ceph-17.0.0-11345-ga3bb1485/src/seastar/include/seastar/core/reactor.hh:74,
                 from /home/jenkins-build/build/workspace/ceph-dev-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-11345-ga3bb1485/rpm/el8/BUILD/ceph-17.0.0-11345-ga3bb1485/src/seastar/src/core/reactor.cc:32:
/home/jenkins-build/build/workspace/ceph-dev-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-11345-ga3bb1485/rpm/el8/BUILD/ceph-17.0.0-11345-ga3bb1485/src/seastar/include/seastar/core/condition-variable.hh:157:5: note: ‘seastar::condition_variable::condition_variable() noexcept’ is implicitly deleted because its exception-specification does not match the implicit exception-specification ‘’
  157 |     condition_variable() noexcept = default;
```

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
2022-03-28 21:03:01 +02:00
Ernesto Puerta
2022a56646
Merge pull request #45647 from rhcs-dashboard/fix-55060-master
mgr/dashboard: fix api test issue with pip

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: David Galloway <dgallowa@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: zmc <NOT@FOUND>
2022-03-28 17:29:11 +02:00
Prashant D
1a065043b9 mgr, mon: Keep upto date metadata with mgr for MONs
The mgr updates mon metadata through handle_mon_map which
gets triggered when MONs were removed/added from/to cluster or
the active mgr is restarted or mgr failsover.
We could have handled metadata update through MMgrOpen or
early MMgrReport messages but these are sent before monitor
electin completes and lead monitor updates pending metadata
in monstore. Instead of relying on fetching mon metadata using
'ceph mon metadata <id>' command, explicitly send metadata
update request with mon metadata to mgr.

Fixes: https://tracker.ceph.com/issues/55088

Signed-off-by: Prashant D <pdhange@redhat.com>
2022-03-28 14:28:09 +01:00
Aashish Sharma
9719cc795e mgr/dashboard: Pool overall performance shows multiple entries of same pool in pool overview
This PR intends to fix this issue

Fixes:https://tracker.ceph.com/issues/54513
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
2022-03-28 18:25:25 +05:30
Aashish Sharma
49d6068463
mgr/dashboard: fix promtool test for mtu alert
Fixes: https://tracker.ceph.com/issues/55004
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
2022-03-28 13:39:38 +02:00
Patrick Seidensal
3821548a37
mgr/dashboard: Compare values of MTU alert by device
Fixes: https://tracker.ceph.com/issues/55004

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
2022-03-28 13:38:15 +02:00
Xuehan Xu
34e5ebfca7 crimson/os/seastore: coordinate segment seq of journal and ool segments
the segment seq in ool segments' headers also need to be set to the
current journal segment seq, because we rely on this to judge whether a
delta needs to be replayed

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2022-03-28 17:48:33 +08:00
Tim Serong
19922e1875 ceph.spec.in: Use libthrift-devel on SUSE distros
Fixes: 80e82686eb
Fixes: https://tracker.ceph.com/issues/55087
Signed-off-by: Tim Serong <tserong@suse.com>
2022-03-28 20:46:26 +11:00
Ernesto Puerta
2289ad2bc3
mgr/dashboard: fix api test issue with pip
Fix
```
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
apache-libcloud 3.5.0 requires requests>=2.26.0, but you have requests 2.25.1 which is incompatible.
Successfully installed CherryPy-13.1.0 PyJWT-2.0.1 Routes-2.4.1 bcrypt-3.1.4 ceph-1.0.0 chardet-4.0.0 cheroot-8.6.0 idna-2.10 jaraco.functools-3.5.0 more-itertools-4.1.0 natsort-8.1.0 portend-3.1.0 pyopenssl-22.0.0 pytz-2022.1 repoze.lru-0.7 requests-2.25.1 tempora-5.0.1
```

Fixes: https://tracker.ceph.com/issues/55060
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
2022-03-28 11:28:36 +02:00
Redouane Kachach
b87c966697
mgr/cephadm: check spec host when adding osd
Fixes: https://tracker.ceph.com/issues/47872

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2022-03-28 10:30:27 +02:00
Tim Serong
aa18cb1200 ceph.spec.in: remove build directory at end of %install
By the time we get to the end of the %install section, all the
built binaries have been installed in the build root, so we can
delete the build directory from the source tree.  This frees up
about 17GB of disk space on build hosts, which is helpful in
case other processes later in the RPM build need more disk space.

Fixes: https://tracker.ceph.com/issues/55079
Signed-off-by: Tim Serong <tserong@suse.com>
2022-03-28 19:23:18 +11:00
Kefu Chai
01b57c1f63
Merge pull request #45661 from tchaikov/doc-dpdk
doc/dpdk: reformat and reword

Reviewed-by: Chunsong Feng <fengchunsong@huawei.com>
2022-03-27 09:58:43 +08:00
Kefu Chai
352ab9b5f0 doc/dpdk: reword the root access part
the root access to system is not a must have for running a DPDK
application. so reword the "Configuring OSD DPDKStack" section.

also, manually editing /etc/passwd is not encouraged, so use
"usermod" instead. to add a directory after user's command
interpreter in /etc/passwd does not make sense. see PASSWD(5).
so drop the paragraph on editing /etc/passwd.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-03-27 01:00:21 +08:00
Ronen Friedman
a3bb148507
Merge pull request #45640 from ronen-fr/wip-rf-snaptrim
osd/scrub: restart snap trimming only after scrubbing is done

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2022-03-26 20:00:20 +03:00
Kefu Chai
3d2d6ffabb doc/dpdk: improve the formatting
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-03-27 00:46:17 +08:00
Kefu Chai
20b11d81df
Merge pull request #44292 from fengchunsong/dpdk-doc
doc/dev: add dpdkstack doc

Reviewed-by: Haomai Wang <haomai@xsky.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-03-26 23:48:00 +08:00
Adam King
b6556e5dbd mgr/cephadm: generate one c-v raw prepare cmd per data device in raw mode
Fixes: https://tracker.ceph.com/issues/54522

Signed-off-by: Adam King <adking@redhat.com>
2022-03-25 22:08:02 -04:00
Adam King
bd9eb59657 mgr/cephadm: offline host watcher
To be able to detect if certain offline hosts go
offline quicker. Could be useful for the NFS
HA feature as this requires moving nfs daemons from
offline hosts within 90 seconds.

Signed-off-by: Adam King <adking@redhat.com>
2022-03-25 21:21:59 -04:00
Adam King
56f20feb62
Merge pull request #44343 from adk3798/nfs-offline
mgr/cephadm: Reschedule nfs daemons from offline hosts

Reviewed-by: Michael Fritch <mfritch@suse.com>
2022-03-25 19:45:39 -04:00
David Galloway
dcd4b20462
Merge pull request #45649 from tchaikov/wip-crimson-cleanup
crimson/os: use fmt::format() instead of sstream
2022-03-25 15:07:39 -04:00
David Galloway
01b730d349
Merge pull request #45539 from rhcs-dashboard/css-fix-highlight-search
mgr/dashboard: Remove padding in search highlighted text
2022-03-25 14:44:46 -04:00
Neha Ojha
55f87377e5
Merge pull request #45651 from sseshasa/wip-qa-fix-activate-osd-test
qa/standalone: Fix test_activate_osd() test in ceph-helpers.sh

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
2022-03-25 11:24:52 -07:00
Neha Ojha
88cad13a08
Merge pull request #45553 from wxypro/doc-update
doc/mgr/prometheus.rst: fix spelling error

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2022-03-25 11:06:14 -07:00
Neha Ojha
8d73d8aa1a
Merge pull request #45575 from wxypro/options-fix
common/options: fix typos: smarctl -> smartctl

Reviewed-by: Neha Ojha <nojha@redhat.com>
2022-03-25 11:00:19 -07:00