Brad Hubbard
18107e2b49
common: Restructure cppcheck suppresions
...
Some of the suppressions are currently redundant and some need to be
changed.
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
2017-04-11 12:22:20 +10:00
Brad Hubbard
98283161cc
crypto: Suppress cppcheck error
...
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
2017-04-11 11:59:21 +10:00
Brad Hubbard
36a8a869c6
blkdev: Suppress cppcheck error
...
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
2017-04-11 11:59:21 +10:00
Adam C. Emerson
ef94464f75
librados: Since a pragma push was removed, get rid of that pop
...
Don't you think the plural of pragma should be pragmata?
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2017-04-10 21:57:14 -04:00
Adam C. Emerson
8be4b9712e
cmake: Make -Wno-unknown-pragmas common to all compilers
...
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2017-04-10 21:57:14 -04:00
Adam C. Emerson
e8382a2f60
bluestore: Remove unused expression in statement
...
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2017-04-10 21:57:14 -04:00
Adam C. Emerson
25a681bb1c
filestore: Fix uninitialized return
...
In some error conditions we were returning the value of an
uninitialized variable.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2017-04-10 21:57:14 -04:00
Adam C. Emerson
ba612d97ad
rbd: Remove pessimizing move
...
Do not std::move returned values.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2017-04-10 21:57:14 -04:00
Adam C. Emerson
7f0a5498c6
cls: Fix order of operations of std::string constructor
...
Presumably the intent was to create a string with 128 '1's, rather than
a string with 49 '\200's.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2017-04-10 21:57:14 -04:00
Adam C. Emerson
3c4811fad3
rgw: Remove pessimizing move of return values
...
C++ performs copy elision of return values if:
1. The value is a local declared in the function (i.e. not a
parameter)
2. The type of the value in the return statement is, modulo
const-value qualification, identical to the return type of the
function.
An RValue reference to a type is not identical, modulo const-value
qualification, to the type it is a reference to.
Do not std::move local values in the return statement unless the value
is a parameter or you will make the compiler perform a copy it would
iotherwise avoid.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2017-04-10 21:57:14 -04:00
Adam C. Emerson
5b517ad4cf
rgw: Make AuthResult::get_completer return rvalue reference
...
Since we are explicitly moving the completer out of the AuthResult
and allowing the client to have ownership of it, simply return an
rvalue reference rather than moving into a temporary that is itself
returned.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2017-04-10 21:57:14 -04:00
Adam C. Emerson
568d60631c
msg: Remove pessimizing move
...
Do not std::move the result of a function returning a value.
(Once could reasonably std::move the result of a function returning an
lvalue reference, but *not* that of one returning a value.)
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2017-04-10 21:57:14 -04:00
Adam C. Emerson
7d344d137a
osd: The shard_id_t constructor takes an int8_t
...
So pass it -1 rather than 255 to avoid an implicit conversion warning.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2017-04-10 21:57:14 -04:00
Adam C. Emerson
05fed82cf4
monc: Remove pessimizing move
...
Calling std::move on on a function returning a value can interfere
with RVO. At best it has no effect, but can actively interfere with
Copy/Move Elision and make code less efficient.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2017-04-10 21:57:14 -04:00
Haomai Wang
5da652e1d9
Merge pull request #13940 from Adirl/out
...
msg/async/rdma: Update fix broken compilation
Reviewed-by: Haomai Wang <haomai@xsky.com>
2017-04-11 09:13:03 +08:00
Haomai Wang
1a9ab802e8
Merge pull request #14409 from Adirl/conn_info
...
msg/async/rdma: RDMA-CM, Pass specific ConnMgr info in constructor
Reviewed-by: Haomai Wang <haomai@xsky.com>
2017-04-11 09:11:39 +08:00
Haomai Wang
fd1e65fe21
Merge pull request #14410 from Adirl/get_device
...
msg/async/rdma: RDMA-CM, get_device() by ibv_context
Reviewed-by: Haomai Wang <haomai@xsky.com>
2017-04-11 09:10:26 +08:00
Sage Weil
7e547a10b1
Merge pull request #13073 from chardan/jfw-wip-15475-admin_heap_command
...
osd: add "heap *" admin command
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2017-04-10 16:24:14 -05:00
Sage Weil
a320d62cf6
Merge pull request #14235 from nvedant07/bug_fix_3
...
rados: more info added to pool deletion error
Reviewed-by: Sage Weil <sage@redhat.com>
2017-04-10 16:23:18 -05:00
Sage Weil
95d7a531e2
Merge pull request #14022 from batrick/admin-socket-close-error
...
common: do not print error when asok is closed
Reviewed-by: Sage Weil <sage@redhat.com>
2017-04-10 16:22:59 -05:00
Sage Weil
5adc257715
Merge pull request #14292 from joscollin/wip-radosacl-warning
...
tools: warning, ‘%.16x’ directive output truncated writing 16 bytes into a region of size 9.
Reviewed-by: Kefu Chai <kchai@redhat.com>
2017-04-10 16:22:37 -05:00
Sage Weil
180ff1f47e
Merge pull request #14301 from Andrey1994/master
...
build: Add Virtuozzo Linux support
Reviewed-by: Sage Weil <sage@redhat.com>
2017-04-10 16:22:21 -05:00
Sage Weil
d7e01f6913
Merge pull request #14336 from Adirl/fix_sockaddr
...
src/msg/async: Update fix broken compilation for Posix
Reviewed-by: Haomai Wang <haomai@xsky.com>
2017-04-10 16:22:07 -05:00
Abhishek Lekshmanan
fb9405ea6c
doc: add changelog for v10.2.7
...
Signed-off-by: Abhishek Lekshmanan <alekshmanan@suse.com>
2017-04-10 22:44:12 +02:00
Yuri Weinstein
937adde760
Merge pull request #14039 from dachary/wip-19307-set-deviceclass
...
mon/OSDMonitor: osd crush set-device-class
Reviewed-by: Sage Weil <sage@redhat.com>
2017-04-10 13:30:32 -07:00
Yuri Weinstein
4adfd07910
Merge pull request #14208 from dachary/wip-crush-uniform-weights
...
crush: bucket: crush_add_uniform_bucket_item should check for uniformity
Reviewed-by: Sage Weil <sage@redhat.com>
2017-04-10 13:28:41 -07:00
Yuri Weinstein
8e532b26e6
Merge pull request #14209 from dachary/wip-crush-create-default-tunables
...
crush: builder: creating crush map with optimal configurations
Reviewed-by: Sage Weil <sage@redhat.com>
2017-04-10 13:27:32 -07:00
Mykola Golub
712e7e9677
Merge pull request #14401 from dillaman/wip-rbd-import-fixes
...
rbd: correct issues with image importing
Reviewed-by: Mykola Golub <mgolub@mirantis.com>
2017-04-10 22:23:53 +03:00
Sage Weil
6208821d0f
Merge pull request #14437 from cernceph/dvanders_mgrrotate
...
ceph-mgr: rotate logs on sighup
Reviewed-by: Sage Weil <sage@redhat.com>
2017-04-10 14:20:32 -05:00
Abhishek Lekshmanan
10ff461fc0
script: serve-doc print the port we're serving
...
Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
2017-04-10 19:16:56 +02:00
Abhishek Lekshmanan
a69efc7760
script: build-doc use python2 only for virtualenv
...
This is because the sphinx-ditaa package and ceph's rbd/rgw/rados pybind
require python2
Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
2017-04-10 19:15:25 +02:00
Abhishek Lekshmanan
7984fcc115
doc: release notes for v10.2.7 Jewel
...
Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
2017-04-10 19:09:04 +02:00
Kefu Chai
e8f1f4a6d4
Merge pull request #14413 from hansbogert/patch-3
...
doc: rgw: remove mention of megabytes for quotas
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2017-04-11 00:25:25 +08:00
Dan van der Ster
19f56b4cc0
logrotate.conf: also sighup the ceph-mgr
...
Tell ceph-mgr to reopen its logs postrotate.
Fixes: http://tracker.ceph.com/issues/19568
Signed-off-by: Dan van der Ster <daniel.vanderster@cern.ch>
2017-04-10 17:34:48 +02:00
Danny Al-Gaaf
f47cc2869b
ceph_fuse.cc: fix 64/32bit detection
...
Fix for:
[src/ceph_fuse.cc:111]: (style) Condition 'sizeof(long)==4' is always false
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2017-04-10 23:34:18 +08:00
Danny Al-Gaaf
a5372d5ca6
lua_bufferlist.cc: use static_cast instead of c-style
...
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2017-04-10 23:34:18 +08:00
Danny Al-Gaaf
6212f76bbd
BitAllocator_test.cc: use static_cast instead of c-style
...
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2017-04-10 23:34:18 +08:00
Danny Al-Gaaf
511159a1be
test_librbd.cc: use static_cast instead of c-style
...
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2017-04-10 23:34:18 +08:00
Danny Al-Gaaf
439ae679c2
rgw_rest_s3.cc: use static_cast instead of c-style
...
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2017-04-10 23:34:17 +08:00
Danny Al-Gaaf
1a4720e95a
PrimaryLogPG.cc: use static_cast instead of c-style
...
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2017-04-10 23:34:17 +08:00
Danny Al-Gaaf
e8b31f91bf
osd/PG.cc: use static_cast instead of c-style
...
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2017-04-10 23:34:17 +08:00
Danny Al-Gaaf
e37365385c
BitAllocator.cc: use static_cast instead of c-style
...
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2017-04-10 23:34:16 +08:00
Kefu Chai
bbaac7bfdc
Merge pull request #14430 from jcsp/wip-19566-monassert
...
mon: avoid segfault in wait_auth_rotating
Reviewed-by: Kefu Chai <kchai@redhat.com>
2017-04-10 23:31:06 +08:00
Dan van der Ster
44354e0089
ceph-mgr: reopen logs on SIGHUP
...
Wire up the sighup_handler to reopen logs, like the other daemons.
Fixes: http://tracker.ceph.com/issues/19568
Signed-off-by: Dan van der Ster <daniel.vanderster@cern.ch>
2017-04-10 17:29:05 +02:00
Kefu Chai
e053e18408
Merge pull request #14428 from tchaikov/wip-ceph_objectstore_tool-kill-all
...
tests: ceph_objectstore_tool.py: kill all daemons
Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>
2017-04-10 23:16:09 +08:00
John Spray
d529121b60
Merge pull request #10636 from fullerdj/wip-djf-15069
...
cephfs: Permit recovering metadata into a new RADOS pool
Reviewed-by: John Spray <john.spray@redhat.com>
2017-04-10 13:52:04 +01:00
John Spray
4d41492708
mon: avoid segfault in wait_auth_rotating
...
MonClient users should not be calling into MonClient
after calling shutdown(). However, MonClient should
assert out rather than proceeding to try and
follow a maybe-null pointer.
Related to http://tracker.ceph.com/issues/19566
Signed-off-by: John Spray <john.spray@redhat.com>
2017-04-10 13:02:00 +01:00
Kefu Chai
d3de0036b4
tests: ceph_objectstore_tool.py: kill all daemons
...
init-ceph kills all daemons that can be identified by get_name_list() by
default, so no need to list them explicitly. also, without this change,
mgr is not stopped when the test finishes.
Signed-off-by: Kefu Chai <kchai@redhat.com>
2017-04-10 19:39:26 +08:00
Danny Al-Gaaf
565d2a6303
osd/OSD.cc: use static_cast instead of c-style
...
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2017-04-10 18:16:17 +08:00
Danny Al-Gaaf
78ce269780
rgw_rest_s3.cc: reorder checks in while loop
...
Fix for:
[src/rgw/rgw_rest_s3.cc:1224]: (style) Array index 'chunk_offset'
is used before limits check.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2017-04-10 18:16:17 +08:00