Commit Graph

21 Commits

Author SHA1 Message Date
Sage Weil
59834d60c4 Merge pull request #1410 from ceph/wip-flock
mds: fix owner check of file lock

Reviewed-by: Sage Weil <sage@inktank.com>
2014-03-11 10:00:48 -07:00
Yan, Zheng
d3e3df7ad7 mds: fix owner check of file lock
flock and posix lock do not use process ID as owner identifier.
The process ID of who holds the lock is just for F_GETLK fcntl(2).
For linux kernel, File lock's owner identifier is the file pointer
through which the lock is requested.

The fix is do not take the 'pid_namespace' into consideration when
checking conflict locks. Also rename the 'pid' fields of struct
ceph_mds_request_args and struct ceph_filelock to 'owner', rename
'pid_namespace' fields to 'pid'.

The kclient counterpart of this patch modifies the flock code to
assign the file pointer to the 'owner' field of lock message. It
also set the most significant bit of the 'owner' field. We can use
that bit to distinguish between old and new clients.

Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
2014-03-11 09:45:43 +08:00
Yan, Zheng
617ce6761e mds: introduce LOOKUPNAME MDS request
The new MDS request is used for connecting a given inode to its
parent inode. It allows client to have efficient implementation of
get_rename() NFS export callback.

Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
2014-03-08 07:22:06 +08:00
Josh Durgin
7f1f0b550f librados: remove constant for CMPXATTR_NOP
This constant was just added in the public header to match the
operations in rados.h, and was not included in a stable release yet.
NOP is misleading, since it's actually uninterpreted anywhere, and
using it would always return EIO from the OSD. It's not particularly
useful, so just remove it. Adding a cmpxattr with FAIL_OK is
equivalent.

Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
2014-02-18 12:34:32 -08:00
Kevin Jones
972d22e245 Adding new Wireshark dissector. This is loosely based on the original
dissector, it has been re-worked to bring into line with Wireshark
coding guidelines that aim to ensure portability. It currently only
decodes a handful of messages as test cases, it needs more work to make
it useful. See README.txt for a bit more background.
2013-07-04 17:00:55 +01:00
Danny Al-Gaaf
533fd7a8c8 wireshark/ceph/packet-ceph.c: fix some issues from cppcheck
Fix some smaller performance related issues from cppcheck due to
"Variable '..xy..' is reassigned a value before the old one has been used.

Fix some indention.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-02-14 10:27:40 -08:00
Danny Al-Gaaf
e6591db6dc wireshark: fix some memory leaks
Fix some memory leaks in packet-ceph.c. Error from cppcheck was:

[wireshark/ceph/packet-ceph.c:215]: (error) Memory leak: plop
[wireshark/ceph/packet-ceph.c:237]: (error) Memory leak: plop
[wireshark/ceph/packet-ceph.c:543]: (error) Memory leak: fsid_dec

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-02-10 10:05:06 +01:00
Danny Al-Gaaf
f9f31aae68 wireshark: fix indention
Fix indention.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-01-24 10:35:58 -08:00
Danny Al-Gaaf
3e9cc0d40d wireshark: fix guint64 print format handling
Use G_GUINT64_FORMAT to handle print format of guint64 correctly.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-01-24 10:35:57 -08:00
Yehuda Sadeh
bb6e0d0e58 wireshark: update patch
Update to latest source tree (svn 43768).

Signed-off-by: Yehuda Sadeh <yehuda@inktank.com>
2012-07-31 15:49:25 -07:00
Pierre Rognant
d67ad0db64 Wireshark dissector updated, work with the current development tree of wireshark. The way I patched it is not really clean, but it can be useful if some people quickly need to inspect ceph network flows. 2012-07-24 10:09:27 -07:00
Yehuda Sadeh
52f51a24e2 wireshar/ceph/packet-ceph.c: fix eol
Removing extra char from dos eol format.

Signed-off-by: Yehuda Sadeh <yehuda@inktank.com>
2012-07-24 10:09:27 -07:00
Markus Elfring
f4b9d9d847 Bug #98: Unique names for include guards
A couple of preprocessor symbols for include guards tampered with the reserved namespace.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Sage Weil <sage@newdream.net>
2010-06-17 10:47:37 -07:00
Sage Weil
6de2dde762 ceph: remove leading _ from macro
Reported-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Sage Weil <sage@newdream.net>
2010-06-17 10:36:39 -07:00
Greg Farnum
afdab56a42 msgr: Remove the type CEPH_ENTITY_TYPE_ADMIN.
It *looks* like this won't break EntityName's isAdmin() function as that
depends on a set name, and client.admin will satisfy it. I think.
2010-03-02 10:02:03 -08:00
Yehuda Sadeh
f23530fec1 auth: fix connect response 2009-10-15 16:24:03 -07:00
Yehuda Sadeh
bdc218e352 wireshark: update with latest version, some other fixes 2009-10-15 14:16:27 -07:00
Yehuda Sadeh
df45d256ee wireshark: update patch to latest wireshark svn snapshot 2009-09-03 20:52:07 -07:00
Yehuda Sadeh
cbd2ac570a wireshark: keep plugin code outside of the patch 2009-09-03 17:40:30 -07:00
Ariela
6107617a83 wireshark: update for win32 2008-11-26 17:16:43 -08:00
Yehuda Sadeh
9521a6a93e wireshark: wireshark ceph plugin patch 2008-11-25 10:57:37 -08:00