We are generally careful when bumping the epoch so that we can join
existing rounds. However, if we restart in the middle of an election,
and change versions, we need to be certain that our previous ACK (as
$version - 1) isn't accepted as truth for the restarted daemon (running
$version) keeping the same epoch.
The conservatism with bumping is to avoid spurious election cycles, but
mon restarts are more rare, and we need them here.
Fixes: http://tracker.ceph.com/issues/20949
Signed-off-by: Sage Weil <sage@redhat.com>
Fixes the coverity issues:
** 1398907 Uninitialized scalar field
CID 1398907 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member tag_tid is not initialized in
this constructor nor in any functions that it calls.
** 1398906 Uninitialized scalar field
22. uninit_member: Non-static class member m_r_saved is not initialized in
this constructor nor in any functions that it calls.
CID 1398906 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
24. uninit_member: Non-static class member m_mirror_mode is not initialized
in this constructor nor in any functions that it calls.
** 1399592 Uninitialized scalar field
2. uninit_member: Non-static class member m_order is not initialized in this
constructor nor in any functions that it calls.
4. uninit_member: Non-static class member m_size is not initialized in this
constructor nor in any functions that it calls.
6. uninit_member: Non-static class member m_features is not initialized in
this constructor nor in any functions that it calls.
8. uninit_member: Non-static class member m_incompatible_features is not
initialized in this constructor nor in any functions that it calls.
10. uninit_member: Non-static class member m_flags is not initialized in
this constructor nor in any functions that it calls.
CID 1399592 (#1-2 of 2): Uninitialized scalar field (UNINIT_CTOR)
12. uninit_member: Non-static class member m_exclusive_locked is not initialized
in this constructor nor in any functions that it calls.
Signed-off-by: Amit Kumar amitkuma@redhat.com
rgw: Use namespace for lc_pool and roles_pool
Reviewed-by: Abhishek Lekshmanan <abhishek.lekshmanan@gmail.com>
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
So that we can use the same helper functions to look
up interface names that we use to look up addresses.
Signed-off-by: John Spray <john.spray@redhat.com>
Fixes the coverity issues:
** 1355242 Uninitialized scalar field
2. uninit_member: Non-static class member map_epoch is not initialized
in this constructor nor in any functions that it calls.
4. uninit_member: Non-static class member min_epoch is not initialized
in this constructor nor in any functions that it calls.
CID 1355242 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
6. uninit_member: Non-static class member rep_tid is not initialized
in this constructor nor in any functions that it calls.
** 1355243 Uninitialized scalar field
2. uninit_member: Non-static class member map_epoch is not initialized
in this constructor nor in any functions that it calls.
4. uninit_member: Non-static class member min_epoch is not initialized
in this constructor nor in any functions that it calls.
CID 1355243 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
6. uninit_member: Non-static class member rep_tid is not initialized
in this constructor nor in any functions that it calls.
Signed-off-by: Amit Kumar amitkuma@redhat.com
size_t on a 32-bit architecture is a 32 bit unsigned int which
created ambiguity when casting to bool, uint64_t or std::string
(which are boost::variants for service_daemon::AttributeType).
Align to use of uint64_t to resolve compilation failures in
all 32-bit architectures.
Signed-off-by: James Page <james.page@ubuntu.com>
The previous method to get the watcher admin socket was fragile
and had started to fail after the recent changes to vstart ceph.conf.
Fixes: http://tracker.ceph.com/issues/20954
Signed-off-by: Mykola Golub <mgolub@mirantis.com>
bluestore/NVMeDevice: update NVMeDevice code due to SPDK upgrade
Reviewed-by: Haomai Wang <haomai@xsky.com>
Reviewed-by: Pan Liu <liupan1111@gmail.com>
Destroying a condition variable on which someone is waiting is Undefined
Behavior. it's bad and terrible and awful. On some machines it makes
the destructor just outright hang.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
PerfCountersRef is a unique_ptr using a deleter that unregisters the
managed PerfCounters on deletion.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Kefu Chai just pointed out this exists so I just rolled the in-place variants of the
'ward' function I'd written into it.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
We have a hard 4GB object size limit (although in practice we want
to be *well* below that!).
See http://tracker.ceph.com/issues/20923
Signed-off-by: Sage Weil <sage@redhat.com>
Rearrange logic to make it easier to measure accumulation.
Instrument the boto request/response loop to count bytes in and out.
Accumulate byte counts in usage like structure.
Compare actual usage reported by ceph against local usage measured.
Report and assert if there are any short-comings.
Remove zone placement rule that was newly added at end: tests should be rerunable.
Nit: the logic to wait for "delete_obj" is not quite right.
Fixes: http://tracker.ceph.com/issues/19870
Signed-off-by: Marcus Watts <mwatts@redhat.com>
