Commit Graph

127400 Commits

Author SHA1 Message Date
Sebastian Wagner
a9dd13a0f3
Merge pull request #43668 from rhcs-dashboard/kube-v1_events-update
mgr/k8sevents: pin the kubernetes version to 11.0.0 

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
2021-10-26 16:29:42 +02:00
Nizamudeen A
f54ea99cab mgr/k8sevents: pin the kubernetes version to 11.0.0
Fixes: https://tracker.ceph.com/issues/53044
Signed-off-by: Nizamudeen A <nia@redhat.com>
2021-10-26 18:16:29 +05:30
Ernesto Puerta
8a4649e651
Merge pull request #43640 from rhcs-dashboard/module-status-guard-error-handling
mgr/dashboard: Proper error handling in module status guard

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2021-10-26 10:52:13 +02:00
Ernesto Puerta
5e1297ce3c
Merge pull request #43639 from rhcs-dashboard/angular-11-form-fix
mgr/dashboard: Fix for form inside form closing issue

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2021-10-26 10:51:22 +02:00
Sebastian Wagner
21cfba732b
Merge pull request #43560 from pcuzner/fix-orch-device-zap
mgr/cephadm: improve validation of orch device zap

Reviewed-by: Sage Weil <sage@newdream.net>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
2021-10-26 10:42:05 +02:00
Sebastian Wagner
46afe6b1df
Merge pull request #43499 from jecluis/wip-cephadm-insecure
cephadm: allow pulling from insecure registries

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
2021-10-26 10:27:24 +02:00
Sebastian Wagner
7ac3897c0c
Merge pull request #43502 from adk3798/rm-testing2
mgr/cephadm: remove host addr from agent deps

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
2021-10-26 10:26:44 +02:00
Sebastian Wagner
646173097c
Merge pull request #43579 from sebastian-philipp/cephadm-monitoring-ipv6
mgr/cephadm: Fix IPv6 in monitoring services

Reviewed-by: Adam King <adking@redhat.com>
2021-10-26 10:24:32 +02:00
Samuel Just
925316ab35
Merge pull request #43632 from myoungwon/wip-alloc-free-rbm-paddr
seastore: add alloc/free extent for RBM based on paddr_t

Reviewed-by: Samuel Just <sjust@redhat.com>
2021-10-26 01:12:07 -07:00
Samuel Just
6dd58de82f
Merge pull request #43641 from athanatos/sjust/wip-52805
crimson/os/seastore: fix LBABtree::lower_bound behavior

Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
2021-10-26 00:40:54 -07:00
Samuel Just
83c42539f7
Merge pull request #43651 from rzarzynski/wip-crimson-net-fix-nonceportcheck
crimson/net: don't enforce peer-perceived-myaddr matches myaddr if haven't learned it yet.

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2021-10-25 15:52:19 -07:00
Samuel Just
65e33d1fe5
Merge pull request #43650 from rzarzynski/wip-crimson-improve-dbgs
crimson, monmap: fix / improve miscellaneous debugs

Reviewed-by: Samuel Just <sjust@redhat.com>
2021-10-25 14:18:03 -07:00
Samuel Just
00378ed6f3
Merge pull request #43652 from rzarzynski/wip-crimson-osd-seqmeta
crimson/osd: write object store's meta sequentially.

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2021-10-25 14:17:11 -07:00
Samuel Just
617b87228f crimson/os/seastore/.../lba_btree: fix min_capacity condition
Reducing the size of split_merge_multi has an interesting side effect of
causing removes to happen on some leaf nodes immediately after split.
After split, child nodes would have size 72 or 73.  At size 72, the node
would be at_min_size() and a remove would put it below causing the
at_min_size() condition to fail and hande_merge to misbehave.

Replace at_min_capacity() with below_min_capacity().
below_min_capacity() will not be true for any child of a split, and
asserts that the child is below capacity by no more than 1.

Signed-off-by: Samuel Just <sjust@redhat.com>
2021-10-25 19:59:36 +00:00
Samuel Just
542d237ffe crimson/os/seastore/.../lba_btree: fix lower_bound at_boundary()
Clarify that lookup_depth_range may return an iterator at_boundary() and
audity users.

Fix LBABtree::lookup to correctly handle at_boundary() after the call to
lookup_depth_range.

Fixes: https://tracker.ceph.com/issues/52805
Signed-off-by: Samuel Just <sjust@redhat.com>
2021-10-25 19:59:36 +00:00
Samuel Just
505492844c crimson/os/seastore/lba_manager/lba_btree: factor out iterator::handle_boundary
Factor out helper to adjust iterators at_boundary().

Signed-off-by: Samuel Just <sjust@redhat.com>
2021-10-25 19:59:36 +00:00
Samuel Just
dd2c699892 crimson/os/seastore/lba_manager/lba_btree: add at_boundary helper distinct from is_end
From an external caller, the condition is identical.  However, internally
iterators may be at a leaf boundary without being at end().  For those
checks, use at_boundary() instead.

Signed-off-by: Samuel Just <sjust@redhat.com>
2021-10-25 19:59:36 +00:00
Samuel Just
eb79d8a3bc crimson/test/seastore/test_btree_lba_manager: shorten tests a bit
Signed-off-by: Samuel Just <sjust@redhat.com>
2021-10-25 19:59:36 +00:00
Samuel Just
1c7e53d778 test/crimson/seastore/test_btree_lba_manager: add LBABtree level unit tests
Signed-off-by: Samuel Just <sjust@redhat.com>
2021-10-25 19:59:33 +00:00
Mykola Golub
8c646721c2
Merge pull request #41696 from MrFreezeex/fix-rbd-mirror-remove
rbd-mirror: fix mirror image removal

Reviewed-by: Mykola Golub <mgolub@suse.com>
2021-10-25 18:12:38 +03:00
Yuval Lifshitz
b932c96b20
Merge pull request #43528 from TRYTOBE8TME/wip-rgw-malformed-url-fix
src/rgw: Fix for malformed url
2021-10-25 17:07:14 +03:00
Mykola Golub
03d922ec87
Merge pull request #41657 from sunnyku/wip-rbd-50787
librbd/object_map: rbd diff between two snapshots lists entire image content

Reviewed-by: Mykola Golub <mgolub@suse.com>
2021-10-25 16:19:48 +03:00
Radoslaw Zarzynski
b3b35dba97 crimson/osd: write object store's meta sequentially.
We're violating the contract on `ObjectStore::write_meta()' that
requires the method must be called in one-by-one manner.
For instance, the implementation in `BlueStore` does read-modify-
write without any locking. Having multiple in-flight requests
the same time (can happen b/c of the thread pool in `AlienStore`)
may lead to a corruption like the following one:

```
[2021-10-25 13:38:38,725][ceph_volume.process][INFO  ] Running command: /home/rzarz/dev/ceph1/build/bin/ceph-bluestore-tool show-label --dev /dev/nvme0n1p3
[2021-10-25 13:38:38,737][ceph_volume.process][INFO  ] stdout {
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "/dev/nvme0n1p3": {
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "osd_uuid": "a11030f3-f41f-482c-916c-98476feaf25f",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "size": 1022903713792,
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "btime": "2021-10-25T12:41:11.938439+0200",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "description": "main",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "bfm_blocks": "249732352",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "bfm_blocks_per_key": "128",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "bfm_bytes_per_block": "4096",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "bfm_size": "1022903713792",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "bluefs": "1",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "ceph_fsid": "f884fe47-b307-46f9-b021-320d7c5a427b",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "kv_backend": "rocksdb",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "mkfs_done": "yes"
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout }
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout }
[2021-10-25 13:38:38,738][ceph_volume.devices.raw.list][ERROR ] device /dev/nvme0n1p3 does not have all BlueStore data needed to be a valid OSD: ['{', '    "/dev/nvme0n1p3": {', '        "osd_uuid": "a11030f3-f41f-482c-916c-98476feaf25f",', '        "size": 1022903713792,', '        "btime": "2021-10-25T12:41:11.938439+0200",', '        "description": "main",', '        "bfm_blocks": "249732352",', '        "bfm_blocks_per_key": "128",', '        "bfm_bytes_per_block": "4096",', '        "bfm_size": "1022903713792",', '        "bluefs": "1",', '        "ceph_fsid": "f884fe47-b307-46f9-b021-320d7c5a427b",', '        "kv_backend": "rocksdb",', '        "mkfs_done": "yes"', '    }', '}']
'whoami'
[2021-10-25 13:38:38,738][ceph_volume.devices.raw.list][INFO  ] device /dev/nvme0n1p3 does not have BlueStore information
```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
(cherry picked from commit 92b2fe955f9cafdf6a9c6adb8eadc5f6a9fb9b8b)
2021-10-25 13:18:15 +00:00
Radoslaw Zarzynski
1a41f3c16f crimson/net: don't enforce peer-perceived-myaddr matches myaddr if haven't learned it yet.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-10-25 13:16:06 +00:00
Radoslaw Zarzynski
040fcb9032 crimson/osd: fix broken debug in OSD::_write_superblock().
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
(cherry picked from commit 48d5fc45e3e95485e89419bec716fddfb7029a18)
2021-10-25 13:10:05 +00:00
Radoslaw Zarzynski
3e5b916334 crimson/osd: improve debugs around heatbeat's binding procedure.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-10-25 13:10:04 +00:00
Radoslaw Zarzynski
b6a4579f4a crimson/osd: inform about replacing cluster messenger's unknown addresses.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-10-25 13:09:22 +00:00
Radoslaw Zarzynski
3bed1087b7 crimson, monmap: add more debugs around building initial monmap.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-10-25 13:09:22 +00:00
Nizamudeen A
b4ebca28d8 mgr/dashboard: Fix for form inside form closing issue
After the angular 11 upgrade the form in form behaviour got broken when
one tries to close that "embedded" form. This commit is to fix that
behaviour.

Fixes: https://tracker.ceph.com/issues/53020
Signed-off-by: Nizamudeen A <nia@redhat.com>
2021-10-25 17:03:32 +05:30
Ernesto Puerta
cc5d532c04
Merge pull request #43642 from rhcs-dashboard/pin-version-req-lint
mgr/dashboard: pin a version for autopep8 and pyfakefs

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2021-10-25 13:12:12 +02:00
Nizamudeen A
946dab4f60 mgr/dashboard: pin a version for autopep8 and pyfakefs
Fixes: https://tracker.ceph.com/issues/53024
Signed-off-by: Nizamudeen A <nia@redhat.com>
2021-10-25 14:47:36 +05:30
Samuel Just
c9ae57ca50 crimson/os/seastore/.../lba_btree_node.h: add operator== for lba_map_val_t
Signed-off-by: Samuel Just <sjust@redhat.com>
2021-10-25 01:05:18 -07:00
Samuel Just
b32fbda595 crimson/os/seastore/lba_manager/btree: tolerate op_context_t without pins
Simpler to construct unit tests for the LBABTree itself without pins.

Signed-off-by: Samuel Just <sjust@redhat.com>
2021-10-25 01:05:18 -07:00
Samuel Just
a89353141c test/crimson/seastore/test_btree_lba_manager: factor out btree_test_base
We're going to use this to create tests for LBABtree in isolation.

Signed-off-by: Samuel Just <sjust@redhat.com>
2021-10-25 01:05:18 -07:00
Samuel Just
efcb7a30aa crimson/os/seastore/object_data_handler.cc: misc logging improvements
Signed-off-by: Samuel Just <sjust@redhat.com>
2021-10-25 01:05:18 -07:00
Xuehan Xu
be4c407eff crimson/os/seastore: debug outputs
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2021-10-25 01:05:09 -07:00
Samuel Just
157ad2aab6 crimson/os/seastore/.../lba_btree: fix logging for LBABtree::handle_split
Signed-off-by: Samuel Just <sjust@redhat.com>
2021-10-25 01:05:09 -07:00
Nizamudeen A
dc80f26a50 mgr/dashboard: Proper error handling in module status guard
I've recently introduced a check that verifies if the orch_backend we need for a feature matches the orch_backend of the cluster. But to verify this I need to call configOpt API and some user's don't have the permission to access it. So it'll show this Access Denied page.

Fixes: https://tracker.ceph.com/issues/53021
Signed-off-by: Nizamudeen A <nia@redhat.com>
2021-10-25 12:55:35 +05:30
Mykola Golub
ed9d0b4417
Merge pull request #43633 from ideepika/wip-rbd-full-try-test-fixups
test/librbd: harden RemoveFullTry tests

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Sunny Kumar <sunkumar@redhat.com>
2021-10-24 10:44:00 +03:00
Ilya Dryomov
6278a04ac2 qa/suites/rbd: whitelist POOL_FULL due to quota for test_librbd.sh
RemoveFullTry tests fill up the pool and expect EDQUOT.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2021-10-23 22:04:58 +05:30
Ilya Dryomov
641f782ac7 test/librbd: don't run RemoveFullTry tests with persistent writeback cache
Persistent writeback cache messes with pool quota enforcement on the
OSD side and we don't always break out of the write zeroes loop:

  src/test/librbd/test_librbd.cc:2165: Failure
  Value of: off >= quota && off < size
    Actual: false
  Expected: true

Unfortunately persistent writeback cache doesn't honor FUA [1] so the
workaround for volatile caches from the previous patch doesn't apply.

[1] https://tracker.ceph.com/issues/49715

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2021-10-23 22:04:58 +05:30
Ilya Dryomov
7f5e1ce326 test/librbd: set FUA on writes in remove_full_try()
Work around write-back or write-around cache getting enabled (e.g. if
one runs the tests with rbd_cache_writethrough_until_flush disabled).

Fixes: https://tracker.ceph.com/issues/52883
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2021-10-23 22:04:58 +05:30
myoungwon oh
8865223260 seastore: add device_id_t in RBM
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2021-10-24 00:06:55 +09:00
myoungwon oh
2089a7745e seastore: add rbm alloc infos when alloc_extent() is called
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2021-10-24 00:05:08 +09:00
myoungwon oh
a65c26a5a8 seastore: free allocated extent if extent is retiered
This commit frees allocated extent  when the extent is retired

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2021-10-23 23:33:11 +09:00
myoungwon oh
b950e21573 seastore: make rbm_alloc_delta_t to use pair<paddr_t, size>
This commit makes rbm_alloc_delta_t to use std::pair based on
paddr_t in order that other modules such as cache, which does not
know about RBM, can add free information.

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2021-10-23 23:09:47 +09:00
Samuel Just
e7d152fce8
Merge pull request #43629 from athanatos/sjust/wip-fix-fsdriver
crimson/tools/store_nbd/fs_driver: fix mount and mkfs to handle new mkfs signature

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
2021-10-22 21:42:44 -07:00
Mykola Golub
82c16d39c3
Merge pull request #43573 from idryomov/wip-create-ioctx-preserve-full-try
librbd: preserve CEPH_OSD_FLAG_FULL_TRY in create_ioctx()

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Sunny Kumar <sunkumar@redhat.com>
2021-10-22 09:49:12 +03:00
Mykola Golub
b905c50877
Merge pull request #43568 from idryomov/wip-writesame-fua
librbd: honor FUA op flag for write_same() in write-around cache

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Sunny Kumar <sunkumar@redhat.com>
2021-10-22 09:48:47 +03:00
Samuel Just
2e5aeb8651 crimson/tools/store_nbd/fs_driver: fix mount and mkfs to handle new mkfs signature
Introduced: e5f7ff
Fixes: https://tracker.ceph.com/issues/53012
Signed-off-by: Samuel Just <sjust@redhat.com>
2021-10-21 23:48:38 -07:00