Fixes the coverity issue:
CID 1394846 (#1 of 1): Dereference after null check (FORWARD_NULL)
15. var_deref_model: Passing null pointer pool_name to regex_match,
which dereferences it.
Signed-off-by: Amit Kumar <amitkuma@redhat.com>
ceph-disk now prints "depreacted" warning message when it starts. but
the tests parses its stdout and stderr for a json string. so we need to
silence the warnings for the tests.
Fixes: http://tracker.ceph.com/issues/22154
Signed-off-by: Kefu Chai <kchai@redhat.com>
when bluefs succeed to reserve but failed to alloc in db space,
it will cause a assert, just because of the space fragmentation.
in this situation, it could not use slow device space,
and it would happen in stupid or avl allocator.
Signed-off-by: tangwenjun <tang.wenjun3@zte.com.cn>
Very old, and very new, versions of flake8 treat E722 as an error:
flake8 runtests: commands[0] | flake8 --ignore=H105,H405,E127 ceph_disk tests
ceph_disk/main.py:1575:9: E722 do not use bare except'
ceph_disk/main.py:1582:9: E722 do not use bare except'
ceph_disk/main.py:3252:5: E722 do not use bare except'
ceph_disk/main.py:3288:21: E722 do not use bare except'
ceph_disk/main.py:3296:17: E722 do not use bare except'
ceph_disk/main.py:4358:5: E722 do not use bare except'
tests/test_main.py:26:1: E722 do not use bare except'
ERROR: InvocationError: '/opt/j/ws/mkck/src/ceph-disk/.tox/flake8/bin/flake8 --ignore=H105,H405,E127 ceph_disk tests'
Fixes: http://tracker.ceph.com/issues/22207
References: https://gitlab.com/pycqa/flake8/issues/361
Signed-off-by: Nathan Cutler <ncutler@suse.com>
DPDK requires GNU Make. see
spdk/dpdk/doc/guides/freebsd_gsg/build_dpdk.rst. so, we should use the
configured make program to do the job.
Signed-off-by: Kefu Chai <kchai@redhat.com>
* add a function visit_ops_in_flight() so it accepts a std::function,
which can be applied to all ops in flight. and is used to count
slow ops. the # of slow ops will be sent to mgr.
* add a function with_slow_ops_in_flight(), so we can use it to
implement command like "dump_slow_ops_in_flight". unlike the
existing feature which dumps slow ops to clog periodically, it
will dump the slow ops on demand. and backoff the warning
interval only when the slow ops are dumped.
Signed-off-by: Kefu Chai <kchai@redhat.com>
* pass coremask_arg to the working thread by value.
after 81249ab9d, get_val<>() returns a temporary variables instead of a
reference to the variant held by config. so calling string::c_str(), and
passing the returned `const char*` to a thread is not advisable. instead
we should pass a string by value. since spdk_env_init() will copy the
settings passed in by opt. it's safe even to destruct the coremask_arg
afterward.
* use ffsll() to find the LSB. it's not a bottleneck, but it's easier
and simpler, and probably improves the readability.
* refactor the NVMEManager::try_get() method: to define the variables
when they are used for the first time.
Signed-off-by: Kefu Chai <kchai@redhat.com>
* refs/pull/18274/head:
mds: fold mds_revoke_cap_timeout into mds_session_timeout
client: add new delegation testcases
client: add delegation support for cephfs
common: remove data_dir_option from common_preinit and global_pre_init
Reviewed-by: Gregory Farnum <gfarnum@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
This prevents the Inode from being deleted until after cap trimming is
finished. In particular, this prevents remove_all_caps from being called which
screws up the traversal of caps in trim_caps.
Fixes: http://tracker.ceph.com/issues/22157
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
rgw: fix a bug in rgw cache in delete_system_obj and get_system_obj.
Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
Reviewed-by: Orit Wasserman <owasserm@redhat.com>
Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
Reviewed-by: Amit Kumar <amitkuma@redhat.com>
Improve the error message for 'ceph fs authorize' where the
given entity exists but has different auth caps.
Fixes: http://tracker.ceph.com/issues/21765
Signed-off-by: Douglas Fuller <dfuller@redhat.com>
Revert CEPH_FEATURE_MSG_AUTH-related hunks of commit 7ba4d5324e
("msg/simple/Pipe: remove legacy feature case handle"), which
removed code that handled !CEPH_FEATURE_MSG_AUTH footers. It's needed
for kernels prior to 3.19, where cephx signatures aren't supported.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Revert CEPH_FEATURE_MSG_AUTH-related hunks of commit 83f7e392a1
("msg/async/AsyncConnection: remove legacy feature case handle"), which
removed code that handled !CEPH_FEATURE_MSG_AUTH footers. It's needed
for kernels prior to 3.19, where cephx signatures aren't supported.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
rgw: radosgw-admin zonegroup get and zone get return defaults when there is no realm
Reviewed-by: Orit Wasserman <owasserm@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Fixes the coverity issue:
CID 1405270 (#1 of 1): Division or modulo by zero (DIVIDE_BY_ZERO)
2. divide_by_zero: In function call ll_get_stripe_osd,
division by expression l.stripe_count which may be zero has
undefined behavior.
Signed-off-by: Amit Kumar <amitkuma@redhat.com>
rgw: keystone: bump up logging when error is received
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
