If you add, say, a field "auid" to the struct and it's being
piece-wise initialized then you need to change every copy to include it.
Or you assume it's just copied wholesale and then spend many hours trying
to find where it isn't. Like in this one.
of AuthTicket, et al. Let's do it that way.
Revert "authtool: give generated key specific uid if one is provided on the cli."
This reverts commit 3a080fa109.
Revert "cephx: Add auth_uid (if present) to Info for all service types"
This reverts commit 1cb95b4194.
Revert "osd: mon: caps store auth_uid as an int for fast checking"
This reverts commit 08e21ca094.
Hmm. Ultimately this is the direction we want to go, so that,
for example, a client that is forcefully disconnected can at
least attempt a reconnect (even if all its caps go ESTALE).
There are undoubtably some issues that need to be dealt with to
keep the mds from choking on weird client data, but those things
need to be fixed regardless.
The latest spirit breaks parsing. It seems to choke on
whitespace (e.g., fail to parse if there is any trailing
whitespace). I couldn't find any obvious problems with how
spirit is beign used, so work around it by stripping out any
extra whitespace from the input. Bleh!
Attempting to add an auth_uid to all the relevant structs has gotten too messy;
it *will* get messed up at some point in the future. So we're moving it into
the string map caps, and the machines can store it in their local structs
however they like.
Note to self: In future, do not attempt to extend mirrored structs without
great cause. Or else commit to making them properly-encapsulated objects.
Revert "auth: Add an auth_uid to AuthTicket. Still to do: copy it around"
This reverts commit 62c8ceba87.
Revert "auth: misc printing and initialization fixes"
This reverts commit ae8ed243df.
Revert "authtool: set generated key to specific uid if one is given"
This reverts commit 2ab6e75c9b.
Revert "auth: constant for unknown/unsecured user"
This reverts commit ea01f18305.
Revert "auth: auth_uid needs to be in AuthCapsInfo as well."
This reverts commit d499cf5c05.
Revert "auth: Add a uid field to EntityAuth; make it a required feature"
This reverts commit 14052d4b12.
Conflicts:
src/include/ceph_fs.h
Snapid should always be non-zero; assert as much.
This fixes bug where valid was set to false when stating dir
inodes on non-auth mds's, which in turn returned no caps to
clients and, in the case of cfuse, caused a crash.
We need to set committing_seq when we first block access to the
fs in commit_start(), NOT in commit_started(), as by that time
we may have queued all sorts of additional entries for the
journal. The committing_seq is all about syncing up with the
live fs (via op_apply_start), not what's queued for the journal.
