Commit Graph

103413 Commits

Author SHA1 Message Date
Venky Shankar
a7994a0fdd Revert "qa/suites/rados/mgr/tasks/module_selftest: whitelist mgr client getting backlisted"
This reverts commit 0060f1c5b8.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
2019-10-24 03:34:44 -04:00
Kefu Chai
097de62bf9
Merge pull request #31069 from tchaikov/wip/crimson/replace-ceph-with-crimson
crimson: s/ceph/crimson/ in namespace names

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2019-10-24 13:57:11 +08:00
Kefu Chai
bd023211d9 test/crimson: silence deprecated warnings
* do not discard returned future<>
* do not use variadic future<>

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-10-24 12:37:30 +08:00
Kefu Chai
4589fff6bf crimson: s/ceph/crimson/ in namespace names
to help differentiate the symbols shared by classic and crimson osd,
after this change, all crimson code will live in "crimson::" namespaces.
and in a follow-up change, all classic code used by crimson will live in
"ceph::" namespaces.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-10-24 12:37:30 +08:00
Kefu Chai
acff723c32 crimson/osd/osd_operation.h: s/ceph_assert/assert/
so we don't need to include `include/ceph_assert.h` for it. and
presumably, `ceph_assert()` is for fail the application early when it is
not able to recover from a failure, while `assert()` is for debugging.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-10-24 12:23:17 +08:00
Neha Ojha
d79325b07f
Merge pull request #31066 from ideepika/wip-doc-adds-cmake-options
doc: Adds cmake build options for optionally skipping few components

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-10-24 09:29:36 +05:30
Sage Weil
29c97547a9 Merge PR #30859 into master
* refs/pull/30859/head:
	auth: EACCES, not EPERM
	mon: shunt old tell commands from cli interface to asok
	mon: allow mgr to tell mon.foo smart
	mon: include quorum features in quorum_status
	qa/workunits/mon/caps.sh: fix test
	ceph_test_rados_api_cmd: fix MonDescribe test
	Merge branch 'vstart-fs-auth' of git://github.com/batrick/ceph into wip-cleanup-mon-asok
	test/pybind/test_ceph_argparse: fix tests
	vstart: add volume client keys to keyring
	vstart: use fs authorize to create master client key
	vstart: redirect some output to stderr
	vstart: output command strings to stderr
	qa/workunits/cephtool/test.sh: fix 'quorum enter' caller
	qa: change mon_status calls to quorum_status or tell commands
	mon: fix 'heap ...' command
	mon: consolidate 'sync force' commands
	mon: allow asok commands to return an error code
	mon: move 'quorum enter|exit' and 'mon_status' to asok
	mon: fix 'smart' asok command
	mon: remove old 'config set' and 'injectargs'

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2019-10-23 21:05:42 -05:00
Sage Weil
bf09a04d22 Merge PR #31094 into master
* refs/pull/31094/head:
	ceph-daemon: remove redundant --privileged
	test_ceph_daemon: test unit, enter, shell
	ceph-daemon: drop exec
	ceph-daemon: fix exit code for run, shell, enter, exec
	ceph-daemon: allow optional command for 'enter'
	ceph-daemon: fix LANG for 'enter' command
	ceph-daemon: allow shell to take optional command
	qa/suites/rados/singleton-nomsgr/ceph-daemon: run test_ceph_daemon.sh
	qa/standalone/test_ceph_daemon.sh: add new functional tests
	test_ceph_daemon.sh: use newer image
	ceph-daemon: unconditionally enable and start crash unit
	ceph-daemon: fix crash unit cleanup
	ceph-daemon: include 'crash' unit/item in 'ls' output
	ceph-daemon: fix 'ls'
	mgr/orchestrator: s/sdd/ssd/
	mgr/ssh: remove stdout/stderr kludges
	ceph-daemon: fix ceph-volume command to write stdout to stdout

Reviewed-by: Sebastian Wagner <swagner@suse.com>
2019-10-23 19:46:06 -05:00
Gregory Farnum
e190825f26
Merge pull request #30650 from athanatos/sjust/wip-dmclock-server-only
dmclock server side refactor

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
2019-10-23 13:35:13 -07:00
Samuel Just
6eaf324083 PendingReleaseNotes: note mClockScheduler config changes
Signed-off-by: Samuel Just <sjust@redhat.com>
2019-10-23 13:33:59 -07:00
Samuel Just
2157ac7d14 osd/: remove legacy schedulers
The consensus seems to be that PrioritizedQueue is strictly worse than
WeightedPriorityQueue.

mClockClientQueue and mClockClassQueue are superceded by
mClockScheduler.

Signed-off-by: Samuel Just <sjust@redhat.com>
2019-10-23 13:33:59 -07:00
Samuel Just
9ec24d3bfe osd/scheduler: introduce mClockScheduler
mClockScheduler schedules items based on op_scheduler_class
with configured mclock parameters.  Items which should be
scheduled immediately (op_scheduler_class::immediate) are placed
into a single queue as it's not clear that there's a reason to
differentiate among them.

A subsequent patch will add support for client provided mclock
params and dmclock request state.

Signed-off-by: Samuel Just <sjust@redhat.com>
2019-10-23 13:33:55 -07:00
Sage Weil
c6773f4c4c Merge PR #31057 into master
* refs/pull/31057/head:
	common/thread: Fix race condition in make_named_thread

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
2019-10-23 15:20:56 -05:00
Sage Weil
adf22b9e59 Merge PR #31054 into master
* refs/pull/31054/head:
	qa/suites/upgrade/*-x-singleton: suppress TOO_FEW_PGS warning

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2019-10-23 15:20:43 -05:00
Sage Weil
62452dc191 Merge PR #30882 into master
* refs/pull/30882/head:
	ceph-daemon: deploy a logrotate.d config file for each cluster

Reviewed-by: Sebastian Wagner <swagner@suse.com>
2019-10-23 15:18:26 -05:00
Sage Weil
7d2bd68461 ceph-daemon: remove redundant --privileged
The only caller, command_shell, passes this.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-23 15:08:55 -05:00
Sage Weil
d7bd029b51 test_ceph_daemon: test unit, enter, shell
Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-23 15:08:55 -05:00
Sage Weil
86b2c8dd60 ceph-daemon: drop exec
It's not identical to enter.  enter seems more intuitive to me, but that
may be because I'm not a longtime docker user.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-23 15:08:55 -05:00
Sage Weil
9c3e270eec ceph-daemon: fix exit code for run, shell, enter, exec
Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-23 15:08:55 -05:00
Sage Weil
c475186856 ceph-daemon: allow optional command for 'enter'
Default to interactive shell; otherwise run a specific command, just like
the 'shell' command.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-23 15:08:55 -05:00
Sage Weil
e427e72d2d ceph-daemon: fix LANG for 'enter' command
We did the same thing for 'shell' in 02d4f8c097

Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-23 15:08:55 -05:00
Sage Weil
75c1ebe606 ceph-daemon: allow shell to take optional command
This is different from 'exec' in that it creates a new container instead
of entering an existing one.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-23 15:08:55 -05:00
Sage Weil
47777b9c0d qa/suites/rados/singleton-nomsgr/ceph-daemon: run test_ceph_daemon.sh
Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-23 15:08:55 -05:00
Sage Weil
202d615d38 qa/standalone/test_ceph_daemon.sh: add new functional tests
- sudo as needed
- clean up afterward

There is still a bit of missing coverage, but this captures most of it.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-23 15:08:55 -05:00
Sage Weil
a779cb8fd0 test_ceph_daemon.sh: use newer image
Not sure what the difference between latest-master and latest-master-devel
is, but the -devel image is way out of date.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-23 14:45:34 -05:00
Sage Weil
31c974e5de ceph-daemon: unconditionally enable and start crash unit
Even if it exists, (re)try to enable and start it.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-23 14:45:34 -05:00
Sage Weil
8a19fbfbde ceph-daemon: fix crash unit cleanup
Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-23 14:45:34 -05:00
Sage Weil
ebf1a7b19f ceph-daemon: include 'crash' unit/item in 'ls' output
Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-23 14:45:34 -05:00
Sage Weil
0c318ed2b2 ceph-daemon: fix 'ls'
This broke when we added the crash service.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-23 14:45:34 -05:00
Sage Weil
22d83b0b0d mgr/orchestrator: s/sdd/ssd/
Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-23 14:45:34 -05:00
Sage Weil
a4b7201d6e mgr/ssh: remove stdout/stderr kludges
ceph-daemon is now well-behaved with respect to stdout vs stderr.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-23 14:45:34 -05:00
Sage Weil
fb0899b8dc ceph-daemon: fix ceph-volume command to write stdout to stdout
Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-23 14:45:34 -05:00
Sage Weil
ef3c42cd64 auth: EACCES, not EPERM
EPERM means an operation requires superuser; EACCES more generally means
permission denied.  We use EACCES elsewhere for ceph auth denials; use it
here too for consistency.  This fixes qa/workunits/mon/caps.sh.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-23 13:39:46 -05:00
Casey Bodley
250a65e045
Merge pull request #30997 from cbodley/wip-qa-rgw-objectstores
qa/rgw: drop some objectstore types

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
2019-10-23 11:37:32 -04:00
Casey Bodley
604db96bbb
Merge pull request #28421 from pritha-srivastava/wip-rgw-omap-offload
rgw: add cls_queue and cls_rgw_gc for omap offload

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2019-10-23 09:59:28 -04:00
Sebastian Wagner
39039d6424
Merge pull request #31068 from bk201/wip-lint-python-common
python-common: enable lint in tox tests

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-10-23 14:39:20 +02:00
Lenz Grimmer
a479811c51
mgr/dashboard: Extend documentation about differences between… (#30963)
mgr/dashboard: Extend documentation about differences between E2E and Unit Tests

Reviewed-by: Patrick Seidensal <pnawracay@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2019-10-23 11:13:23 +00:00
Laura Paduano
8242dd56cb mgr/dashboard: Document valid frontend tests
This documentation is supposed to help clarify
when and where different type of tests should
be used by explaining the types and what
they are designed for.

Fixes: https://tracker.ceph.com/issues/42253

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
Signed-off-by: Laura Paduano <lpaduano@suse.com>
2019-10-23 10:04:32 +02:00
Kiefer Chang
189a096b67
python-common: fix lint errors
Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
2019-10-23 15:51:17 +08:00
Kiefer Chang
db24e71f0a
python-common: enable lint in tox tests
* Change tox env py35 and py36 to just py3.
* Use flake8 to lint code.
* Use rstcheck to lint rst files.

Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
2019-10-23 15:43:43 +08:00
Kefu Chai
b5800329d0
Merge pull request #30974 from tchaikov/wip/do_cmake/enable-amqp
do_cmake.sh: enable amqp and rdma for EL8

Reviewed-by: Yuval Lifshitz <yuvalif@yahoo.com>
2019-10-23 14:46:12 +08:00
Deepika Upadhyay
fc822b2330 doc: Adds cmake build options for optionally skipping few components
Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
2019-10-23 11:57:12 +05:30
Kefu Chai
95c266cc6d
Merge pull request #31044 from tchaikov/wip/pybind/rados-py3
pybind/rados: do not slice zip()

Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-10-23 14:08:58 +08:00
Patrick Donnelly
f9d5c6de86
Merge PR #30710 into master
* refs/pull/30710/head:
	mds: add configurable snapshot limit

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-10-22 20:55:19 -07:00
Kefu Chai
b216e4a3ad
Merge pull request #31065 from changchengx/mon_doc
doc: fix typo to auto scale pg number

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-10-23 11:34:20 +08:00
Patrick Donnelly
b630ee66a3
Merge PR #30887 into master
* refs/pull/30887/head:
	mgr/volumes: refactor dir handle cleanup

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-10-22 20:30:27 -07:00
Changcheng Liu
909f87a862 doc: fix typo to auto scale pg number
Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>
2019-10-23 10:53:14 +08:00
Adam C. Emerson
2bd106ec0d common/thread: Fix race condition in make_named_thread
The thread may well no longer exist by the time we try to set the
name, so have the thread set its own name first thing.

Thanks to Ilya Dryomov <idryomov@gmail.com> for pointing it out.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2019-10-22 20:50:56 -04:00
Sage Weil
0b6194a375 mon: shunt old tell commands from cli interface to asok
Pre-octopus clients will send tell commands as CLI commands.  Explicitly
identify those and send them to the asok infrastructure.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-22 19:46:14 -05:00
Samuel Just
17a05cb15b src/osd: replace OpQueue abstraction in osd with Scheduler
OpQueue is overkill for mclock based schedulers.  The interface doesn't
need to externalize the _strict modifiers, the scheduler can figure that
out from the item itself.  Introduce simpler Scheduler interface and add
an adapter for the existing OpQueue based implementations.

Signed-off-by: Samuel Just <sjust@redhat.com>
2019-10-22 15:11:51 -07:00