Commit Graph

92716 Commits

Author SHA1 Message Date
Mykola Golub
5561ffc864 mgr/osd_perf_query: example how limit can be used
Signed-off-by: Mykola Golub <mgolub@suse.com>
2018-12-04 17:36:14 +02:00
Mykola Golub
0d0919fe06 osd: make use of osd perf query's limit param
Signed-off-by: Mykola Golub <mgolub@suse.com>
2018-12-04 17:36:14 +02:00
Mykola Golub
b1f1267118 mgr: add limit param to osd perf query
Signed-off-by: Mykola Golub <mgolub@suse.com>
2018-12-04 17:36:14 +02:00
Jason Dillaman
c80882919c
Merge pull request #25192 from ProgVal/doc-rbd-features
rbd: Document new RBD feature flags and version support

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2018-12-04 09:47:15 -05:00
Tatjana Dehler
f71e4f15e5 mgr/dashboard: add config option bulk_set
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
2018-12-04 15:15:19 +01:00
Lenz Grimmer
cce8d7672f
Merge pull request #25359 from zmc/wip-dashboard-fix-teuth-runner
mgr/dashboard: Fix PYTHONPATH for test runner

Reviewed-by: Tatjana Dehler <tdehler@suse.com>
2018-12-04 15:06:48 +01:00
Lenz Grimmer
8d7112b603
Merge pull request #25231 from rhcs-dashboard/37371-logs-links-permissions
mgr/dashboard: 'Logs' links permission in Landing Page

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2018-12-04 15:01:54 +01:00
Lenz Grimmer
3fa3060253
Merge pull request #25322 from Devp00l/wip-issue-37468
mgr/dashboard: Document custom RESTController endpoints

Reviewed-by: Tatjana Dehler <tdehler@suse.com>
2018-12-04 15:00:23 +01:00
Jianpeng Ma
87cfbcac13 msg/async/rdma: Delete duplicate header file
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
2018-12-04 20:31:07 +08:00
Mykola Golub
ac5af020e7 rbd: bench snapshot if it was specified
Signed-off-by: Mykola Golub <mgolub@suse.com>
2018-12-04 11:20:04 +00:00
Mykola Golub
99d22c5dfd mgr/osd_perf_query: add query to test all supported subkeys
Signed-off-by: Mykola Golub <mgolub@suse.com>
2018-12-04 11:20:04 +00:00
Mykola Golub
7f6738c41e osd: support more dynamic perf query subkey types
Signed-off-by: Mykola Golub <mgolub@suse.com>
2018-12-04 11:20:04 +00:00
Radoslaw Zarzynski
403eef8699 common: drop the doubly-linked-list compatibility of bl::buffers_t.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2018-12-04 10:34:10 +01:00
Radoslaw Zarzynski
a533f0d3c8 common: switch bl::buffers_t to a singly-linked list. Drop bi::list.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2018-12-04 10:34:09 +01:00
Adam Kupczyk
b2a8751bf3 bluestore/tools: Add option 'dump' to ceph-kvstore-tool to print both key and values.
Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
2018-12-04 09:19:26 +01:00
Kefu Chai
ab29f3d301
Merge pull request #25335 from ifed01/wip-ifed-fix-enospc
os/bluestore: fix and unify log output on allocation failure

Reviewed-by: Kefu Chai <kchai@redhat.com>
2018-12-04 14:51:31 +08:00
Kefu Chai
827d36a66e
Merge pull request #25343 from liewegas/wip-36612
msg/async: do not trigger RESETSESSION from connect fault during connection phase

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Reviewed-by: Haomai Wang <haomai@xsky.com>
2018-12-04 14:50:03 +08:00
xie xingguo
f043dcc6d8 osd/OSDMap: fix upmap mis-killing for erasure-coded PGs
The up-set of erasure-coded PGs may include CRUSH_ITEM_NONE,
which as a result causes mis-killing of valid upmap items.

Fixes: https://tracker.ceph.com/issues/37493
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: ningtao <ningtao@sangfor.com.cn>
2018-12-04 14:31:50 +08:00
Kefu Chai
940b4abb6b
Merge pull request #25336 from dragonylffly/wip-silence-warning
crush/CrushWrapper: silence compiler warning

Reviewed-by: Kefu Chai <kchai@redhat.com>
2018-12-04 14:31:49 +08:00
Sage Weil
62d1382599 Merge PR #25373 into master
* refs/pull/25373/head:
	ceph_argparse: fix CephBool to CephChoices conversion

Reviewed-by: Sage Weil <sage@redhat.com>
2018-12-03 22:10:43 -06:00
Sage Weil
fe90c61031 mon/OSDMonitor: do not no_reply on ready_to_merge message
The C_ReplyMap will reply to this op.  Do not no_reply, or else an
ill-timed mon election will mean we do nothing for this request.

Fixes: http://tracker.ceph.com/issues/37512
Signed-off-by: Sage Weil <sage@redhat.com>
2018-12-03 22:09:47 -06:00
oliveiradan
67784065ce auth: Kerberos authentication
Signed-off-by: Daniel Oliveira <doliveira@suse.com> (github: oliveiradan)
2018-12-03 18:55:46 -07:00
Brad Hubbard
84f25f598d
Merge pull request #25361 from badone/wip-add-luminous-12.2.9-and-10
doc/releases: Add luminous releases 12.2.9 and 10

Reviewed-by: Noah Watkins <noahwatkins@gmail.com>
2018-12-04 09:16:52 +10:00
Sage Weil
a7c3290b65 mon/OSDMonitor: include host, container info for 'osd find' command
Signed-off-by: Sage Weil <sage@redhat.com>
2018-12-03 16:34:34 -06:00
Dan Mick
f2d6b03583 common/util.cc: add CONTAINER_NAME processing for metadata
Kubernetes clusters use POD_NAME; simple containers should be
distinguishable and don't have 'pods'.

Signed-off-by: Dan Mick <dan.mick@redhat.com>
2018-12-03 14:34:34 -08:00
Valentin Lorentz
cffa33b80a doc/rbd: Document new RBD feature flags and librbd/krbd version support
Sources:

layering:

* f87c441f68
* krbd: 770eba6e29

striping:

* 2e403ef2c9
* krbd: 770eba6e29

exclusive-lock:

* fa96bb4db4
* krbd: ed95b21a4b

object-map:

* 7e751ce912

fast-diff:

* 16ad44cebc

deep-flatten:

* b556d3173a

journaling:

* 750771c6ff
* not a default: https://github.com/ceph/ceph/blob/1a14963/src/test/cli/rbd/help.t#L229

data-pool:

* c5f2290047
* description: https://tracker.ceph.com/issues/17409
* krbd: 7e97332ea9

operations:

* 209f6fc5a4
* description: e573427a44
* krbd: e573427a44

migrating:

* 2f7c4ae3fc

Signed-off-by: Valentin Lorentz <progval+git@progval.net>
2018-12-03 22:33:40 +01:00
Kefu Chai
5431fba5c5 librbd: reset snaps in rbd_snap_list()
in SnapIterator in rbd.pyx, rbd_snap_list_end() is called by
SnapIterator.__dealloc__(). and rbd_snap_list_end() frees
snaps->name if it is not nullptr.  but there is chance that
snaps->name is never initialized after snaps is allocated by
SnapIterator.__init__, in that case, we will free() a wild pointer.

Fixes: http://tracker.ceph.com/issues/37508
Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-12-04 00:32:11 +08:00
Mykola Golub
f5b727e595 mgr: add "total" perf counter types
Signed-off-by: Mykola Golub <mgolub@suse.com>
2018-12-03 18:12:12 +02:00
Sage Weil
25da7d9cd4 mgr/hello: add serve() method
Signed-off-by: Sage Weil <sage@redhat.com>
2018-12-03 09:23:00 -06:00
Stephan Müller
b324aaaa48 mgr/dashboard: Fix 'resource' typo
Signed-off-by: Stephan Müller <smueller@suse.com>
2018-12-03 15:20:03 +01:00
Stephan Müller
1146a01504 mgr/dashboard: Document custom RESTController endpoints
Extended HACKING.rst by the fact how to extend a RESTController with
a custom endpoint which has all permissions preserved.

Fixes: https://tracker.ceph.com/issues/37468
Signed-off-by: Stephan Müller <smueller@suse.com>
2018-12-03 15:19:24 +01:00
Casey Bodley
70242bf7b5
Merge pull request #25305 from cbodley/wip-37440
qa/rgw: fix invalid syntax error in radosgw_admin_rest.py

Reviewed-by: Volker Theile <vtheile@suse.com>
2018-12-03 09:00:39 -05:00
Igor Fedotov
1562956f5a os/bluestore: fix and unify log output on allocation failure
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
2018-12-03 16:41:47 +03:00
alfonsomthd
11ca48830e mgr/dashboard: 'Logs' links permission in Landing Page
- 'Logs' links in Landing Page cards' popovers
for cards 'Cluster Status' (when not in HEALTH_OK) and
'PG Status' appear only when the user has
the appropriate permissions.
- Some refactor.
- Added test: ensure that clickable text (popover) is shown
when there are health checks' messages.

Fixes: https://tracker.ceph.com/issues/37371

Signed-off-by: Alfonso Martínez <almartin@redhat.com>
2018-12-03 13:54:05 +01:00
jtlayton
47fae14caa
Merge pull request #25366 from jtlayton/wip-orchestrator
orchestrator: add the ability to remove services
2018-12-03 07:08:05 -05:00
Ricardo Dias
f7fb760e4d
Merge pull request #25344 from sebastian-philipp/volumes-py3
mgr/volumes: Fix Python 3 import error

Reviewed-by: Ricardo Dias <rdias@suse.com>
2018-12-03 10:05:51 +00:00
Ricardo Dias
1a1691d20c
ceph_argparse: fix CephBool to CephChoices conversion
Commit 525623b has introduced a regression that makes Ceph clients of
versions prior to Nautilus to receive invalid unicode characters in the
commands list JSON sent by the monitors.

The unicode characters are caused by memory corruption in a dangling
pointer stored by a std::string_view. The dangling pointer belonged to
an std::string object that was already destructed when the
std::string_view is used.
The fix in this PR makes the std::string object to live enough time for
the std::string_view to be used safely.

Signed-off-by: Ricardo Dias <rdias@suse.com>
2018-12-03 09:54:23 +00:00
Sebastian Wagner
ce28976055
Merge pull request #24445 from jmolmo/wip_ansible_orchestrator
mgr/ansible: Ansible orchestrator module

Reviewed-by: John Spray <john.spray@redhat.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: Sébastien Han <seb@redhat.com>
2018-12-03 10:38:53 +01:00
Radoslaw Zarzynski
dbede2ffc6 common: bufferlist::buffers_t wraps bi::list now.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2018-12-03 00:49:34 +01:00
Radoslaw Zarzynski
ef036c441d include: buffer_raw.h uses C++11-compatible std::aligned_storage.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2018-12-03 00:49:34 +01:00
Radoslaw Zarzynski
cfc73f0f72 common: factories of buffer::ptr_node produce std::unique_ptr now.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2018-12-03 00:49:34 +01:00
Radoslaw Zarzynski
763fec4930 client: create buffer::ptr_node directly.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2018-12-03 00:49:33 +01:00
Radoslaw Zarzynski
420c49e17e os/bluestore: KernelDevice creates buffer::ptr_node directly.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2018-12-03 00:49:33 +01:00
Radoslaw Zarzynski
54a5358e67 tests: bench_bufferlist_alloc() gives a try to node_ptr.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2018-12-03 00:49:33 +01:00
Radoslaw Zarzynski
9a41b7b865 common: hypercombined bufferlist.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2018-12-03 00:49:33 +01:00
Radoslaw Zarzynski
43863e88b4 common: proliferate ptr_node in the bufferlist implementation.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2018-12-03 00:49:33 +01:00
Radoslaw Zarzynski
7cf03ab153 common: switch bufferlist to use boost::intrusive for _buffers.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2018-12-03 00:49:33 +01:00
jtlayton
b021f2cad5
Merge pull request #25339 from jtlayton/wip-volumes
mgr/volumes: fix orchestrator remove operation
2018-12-02 11:40:10 -05:00
Radoslaw Zarzynski
e107fff1b0 common: drop ::length() from other implementations of the OpQueue.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2018-12-02 14:59:18 +01:00
Radoslaw Zarzynski
65f25b7f13 common, osd: kill OpQueue::length() to minimize inter-core traffic.
Before
------
```
-    1,50%     1,34%  msgr-worker-0  ceph-osd  [.] WeightedPriorityQueue<OpQueueItem, unsigned long>::Queue::insert
```

Where self if 1.34%
```
       │       mov    %r12d,0x2c(%r14)
       │               }
       │               ++size;
 17,33 │1ba:   addl   $0x1,0x2ec48(%r14)
       │             }
```

After
-----
```
-    1,05%     0,93%  msgr-worker-0  ceph-osd  [.] WeightedPriorityQueue<OpQueueItem, unsigned long>::Queue::insert
```

Let's annotate hottest place (self is 0,93%):
```
       │           //Find the upper bound, cache the previous value and if we should
       │           //store it in the left or right node
       │           bool left_child = true;
       │           while(x){
       │ a0:   mov    %rax,%rbx
       │              ++depth;
       │              y = x;
       │              x = (left_child = comp(key, x)) ?
  8,86 │ a3:   cmp    0x20(%rbx),%r15
       │     _ZN5boost9intrusive31default_rbtree_node_traits_implIPvE9get_rightERKPNS0_11r
```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2018-12-02 09:45:07 +01:00