Commit Graph

49212 Commits

Author SHA1 Message Date
Danny Al-Gaaf
a55f8c2186 librbd/operation/RebuildObjectMapRequest.cc: init m_snap_list_ret in ctor
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2016-02-19 12:51:11 +01:00
Danny Al-Gaaf
c645bd9c09 librbd/DiffIterate.cc: reduce scope of variable
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2016-02-19 12:51:11 +01:00
Danny Al-Gaaf
1f0c1b1a7e librbd/ImageCtx.cc: reduce scope of variable
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2016-02-19 12:51:11 +01:00
Danny Al-Gaaf
e6d3a0f9b4 msg/async/EventKqueue.cc: reduce scope of variable
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2016-02-19 12:51:11 +01:00
Danny Al-Gaaf
e5c9694aa5 msg/async/Event.cc: reduce scope of variable
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2016-02-19 12:51:11 +01:00
Danny Al-Gaaf
a37ae6a3e3 log/Graylog.h: make ctor explicit
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2016-02-19 12:51:11 +01:00
Danny Al-Gaaf
60b61b450a librbd/AioImageRequest.cc: reduce scope of var
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2016-02-19 12:51:11 +01:00
Danny Al-Gaaf
c51ada3b38 ErasureCodeJerasure.h: init packetsize member var in ctor
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2016-02-19 12:51:11 +01:00
Danny Al-Gaaf
00af2a2783 compressor/zlib/CompressionPluginZlib.cc: use explicit for ctor
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2016-02-19 12:51:11 +01:00
Danny Al-Gaaf
6169854519 compressor/zlib/CompressionZlib.cc: reduce scope of variable
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2016-02-19 12:51:11 +01:00
Danny Al-Gaaf
91a8b1b2b1 journal/JournalMetadata.cc: compare size of lhs instead of rhs to rhs
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2016-02-19 12:51:11 +01:00
Danny Al-Gaaf
d71df26198 test_Replay.cc: prefer ++operator for non-primitive iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2016-02-19 12:51:11 +01:00
Danny Al-Gaaf
11bfc6dfc5 common/PluginRegistry.h: init Plugin::library in ctor
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2016-02-19 12:50:35 +01:00
Danny Al-Gaaf
b906041aff common/Graylog.h: make constructor explicit
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2016-02-19 12:50:35 +01:00
Danny Al-Gaaf
44e028f9d5 HTMLFormatter: reuse m_header_done from parent class
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2016-02-19 12:50:35 +01:00
Danny Al-Gaaf
fc44347428 cls/rbd/cls_rbd.cc: reuse existing variable with same name
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2016-02-19 12:50:35 +01:00
Danny Al-Gaaf
8793921ce2 mds/Server.cc: replace inefficient string::find() w/ compare()
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2016-02-19 12:50:35 +01:00
Danny Al-Gaaf
729117f90e client/SyntheticClient.cc: reduce scope of some variables
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2016-02-19 12:50:35 +01:00
Danny Al-Gaaf
cfd076537a client/SyntheticClient.cc: remove unused code
Removed since 2007 unused code and fixed indentation.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2016-02-19 12:50:35 +01:00
Danny Al-Gaaf
2b60306467 client/Client.cc: init owner_uid and owner_gid vars in ctor
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2016-02-19 12:50:35 +01:00
Danny Al-Gaaf
d407faa274 rgw/rgw_rados.cc: remove unused variable locator
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2016-02-19 12:50:35 +01:00
Danny Al-Gaaf
822eecf8d3 rgw/rgw_op.cc: remove unused variables
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2016-02-19 12:50:35 +01:00
Danny Al-Gaaf
a5d78c22fb rgw/rgw_admin.cc: remove unused variables
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2016-02-19 12:50:35 +01:00
Danny Al-Gaaf
aef72abe7f mds/mdstypes.h: init fnode_t::damage_flags in ctor
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2016-02-19 12:50:35 +01:00
Danny Al-Gaaf
c08435cfe5 client/Client.cc: reduce scope of some variables
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2016-02-19 12:50:35 +01:00
Kefu Chai
f6692a42df Merge pull request #7371 from theanalyst/mon/quota-msg-cleanup
mon: cleanup set-quota error msg

Reviewed-by: Kefu Chai <kchai@redhat.com>
2016-02-19 17:56:20 +08:00
Josh Durgin
49a7ef5001 Merge pull request #7708 from jdurgin/wip-cython-cleanup
pybind: replace __del__ with __dealloc__ for rbd

Reviewed-by: Hector Martin <marcan@marcan.st>
Reviewed-by: Mehdi Abaakouk <sileht@sileht.net>
2016-02-19 00:34:50 -08:00
Abhishek Lekshmanan
a917ccfce5 mon: cleanup set-quota error msg
When we send in an unrecognized field for set-quota, specify that the
options should be `max_bytes` or `max_objects`. This doesn't affect the
ceph-cli as the choices are caught at an earlier stage, however the
error message is seen while reaching the cluster via rados api for eg.

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
2016-02-19 09:29:04 +01:00
Josh Durgin
b556b24a31 Merge pull request #7668 from dillaman/wip-librbd-replay-locks
librbd: use async librados notifications

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2016-02-19 00:15:36 -08:00
Josh Durgin
3d391546f5 .gitignore: include recently added rgw programs
Signed-off-by: Josh Durgin <jdurgin@redhat.com>
2016-02-18 23:49:09 -08:00
Josh Durgin
0a988f95bc pybind: replace __del__ with __dealloc__ for rbd
Cython extension types like these don't call __del__, but use
__dealloc__ instead:

http://docs.cython.org/src/userguide/special_methods.html#finalization-method-dealloc

Signed-off-by: Josh Durgin <jdurgin@redhat.com>
2016-02-18 23:47:24 -08:00
Josh Durgin
5489ad3a21 Merge pull request #7706 from sileht/sileht/rados-cython
pybind: remove next() on iterators

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2016-02-18 23:46:21 -08:00
Mehdi Abaakouk
f98b4855e4 pybind: remove next() on iterator
Cython recommends to implement only __next__() methods.

http://docs.cython.org/src/userguide/special_methods.html#the-next-method

Signed-off-by: Mehdi Abaakouk <sileht@redhat.com>
2016-02-19 07:59:08 +01:00
Loic Dachary
78b3c40cbc Merge pull request #7641 from batrick/vstart-usage
Clarify usage on starting single osd/mds/mon.

Reviewed-by: Loic Dachary <ldachary@redhat.com>
2016-02-19 13:25:46 +07:00
Josh Durgin
398c493fa9 Merge pull request #7692 from sileht/sileht/rados-cython
pybind/rados: use __dealloc__ since __del__ is ignored by cython

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2016-02-18 17:42:26 -08:00
Jason Dillaman
4f15332db3 librbd: don't hold owner lock while refreshing image synchronously
The write lock will be taken when the new state is applied.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2016-02-18 17:58:28 -05:00
Jason Dillaman
4ecdf066fd librbd: need owner write lock when disabling exclusive lock
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2016-02-18 17:56:20 -05:00
Jason Dillaman
922072aeb5 librbd: correct memory leaks discovered via valgrind
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2016-02-18 17:46:35 -05:00
Jason Dillaman
7e09cb132b librbd: notifications should be flushed between exclusive lock states
Avoid leaving in-flight notification messages when transitioning lock
states.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2016-02-18 17:46:34 -05:00
Jason Dillaman
3d8d9da348 librbd: update image name upon rename operations
Previously the image could not have been renamed twice without
re-opening the image.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2016-02-18 15:45:51 -05:00
Jason Dillaman
ad78558a66 librbd: missing owner lock on snap rollback cache invalidation
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2016-02-18 15:45:51 -05:00
Jason Dillaman
e01b406762 librbd: journal replay should execute ops in clean context
lockdep will complain about loop cycles that won't cause an
issue in reality as replay and record are two different
journal states.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2016-02-18 15:45:51 -05:00
Jason Dillaman
bc2ae0ef56 librbd: use AIO notifications to prevent blocking ops
If two or more images share the same CephContext, notifications
from one image can block the work queue which will potentially
block acknowledging the notification until after it times out.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2016-02-18 15:45:51 -05:00
Jason Dillaman
9d0b5b9e5e librbd: cleanup header update notifications
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2016-02-18 15:45:51 -05:00
Jason Dillaman
2c656171e4 Revert "librbd: lock notifications should be executed outside librados thread"
This reverts commit d898995b0e.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2016-02-18 15:45:50 -05:00
Jason Dillaman
dd5c9e5503 librbd: support for AIO notifications
The header update and lock notifications might be invoked
from the librados AIO thread.  Update the close state
machine to flush any potential AIO notifications.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2016-02-18 15:45:50 -05:00
Greg Farnum
12a55d6b1a rstats: enable by default on client; move test workunit to its own dir
Signed-off-by: Greg Farnum <gfarnum@redhat.com>
2016-02-18 12:44:22 -08:00
Gregory Farnum
957c77d570 Merge pull request #7323 from ukernel/wip-client-dirsize
client: add option to control how directory size is calculated

This lets you disable rstats if your workload is unhappy about directories
changing size (eg, tar of recently-moved/created/untarred files).

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2016-02-18 12:47:05 -08:00
Yehuda Sadeh
3687a0d9fd Merge pull request #7457 from weiqiaomiao/w1
Rgw: check the return value when call fe->run()

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
2016-02-18 08:16:23 -08:00
Yehuda Sadeh
210b075d02 Merge pull request #7666 from rzarzynski/wip-rgw-sysreq-over-swift
rgw: add support for system requests over Swift API

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
2016-02-18 08:08:13 -08:00