Commit Graph

95658 Commits

Author SHA1 Message Date
Mykola Golub
a277b5c1fe
Merge pull request #26683 from dillaman/wip-38500
librbd: race condition possible when validating RBD pool

Reviewed-by: Mykola Golub <mgolub@suse.com>
2019-03-04 10:43:35 +02:00
Sage Weil
533a9b6a07 Merge PR #26698 into master
* refs/pull/26698/head:
	common/str_map: better trim() impl using boost
	common/str_map: fix trim() on empty string

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-03-03 11:39:52 -06:00
J. Eric Ivancich
15c91a6eea
Merge pull request #25538 from mkogan1/wip-rgw-reshard-status
rgw: change the "rgw admin status" 'num_shards' output to signed int

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
2019-03-03 08:58:20 -05:00
Xie Xingguo
d793c3e67b
Merge pull request #26668 from xiexingguo/wip-38493
msg/async/Protocol*: send keep alive if existing wins

Reviewed-by: Sage Weil <sage@redhat.com>
2019-03-03 14:43:15 +08:00
Kefu Chai
b2da6c4e23
Merge pull request #26723 from liewegas/wip-38537
mgr/BaseMgrModule: drop GIL for ceph_send_command

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-03-03 10:09:14 +08:00
Patrick Donnelly
e117299ab1
Merge PR #26726 into master
* refs/pull/26726/head:
	mds: Fix use of auto prototype, it is a non std extension

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-03-02 11:24:22 -08:00
Sage Weil
5de132944a Merge PR #26720 into master
* refs/pull/26720/head:
	ceph-osd: infer objectstore type of 'type' file is missing

Reviewed-by: Alfredo Deza <adeza@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-03-02 08:31:54 -06:00
Xie Xingguo
46189eaa64
Merge pull request #26705 from dzafman/wip-23999
Improve docs osd_recovery_priority, osd_recovery_op_priority and related

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
2019-03-02 09:43:33 +08:00
Brad Hubbard
c5036f912a
Merge pull request #26666 from badone/wip-kvstore_tool-ice
tools/ceph_kvstore_tool: Move summary output to print_summary

Reviewed-by: Dan Mick <dmick@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
2019-03-02 09:13:58 +10:00
David Zafman
f7bec341da common, doc: Improve docs osd_recovery_priority, osd_recovery_op_priority and related
Add option desciptions for osd_recovery_priority and osd_recovery_op_priority

Fixes: https://tracker.ceph.com/issues/23999

Signed-off-by: David Zafman <dzafman@redhat.com>
2019-03-01 13:55:35 -08:00
Sage Weil
9c09ff2d0c ceph-osd: infer objectstore type of 'type' file is missing
The current value of osd_objectstore should have no bearing--we should
rely on the state in front of us.

- If there is a directory called current/, assume filestore.
- If there is a symlink called block, assume bluestore.
- If we see none of those, fail.

Fixes: http://tracker.ceph.com/issues/38517
Signed-off-by: Sage Weil <sage@redhat.com>
2019-03-01 15:51:38 -06:00
Sage Weil
b3eb525471 Merge PR #26692 into master
* refs/pull/26692/head:
	test/test_ipaddr: added test for pick_address when ipv4 and ipv6 are enabled
	common/pick_address: improves log message when no IP is found
	pick_address: error out in dual stack mode if both addr types cannot be provided

Reviewed-by: Sage Weil <sage@redhat.com>
2019-03-01 14:36:35 -06:00
Willem Jan Withagen
f94d5af52c mds: Fix use of auto prototype, it is a non std extension
Clang complains:
In file included from /home/jenkins/workspace/ceph-master/src/msg/Message.cc:128:
In file included from /home/jenkins/workspace/ceph-master/src/messages/MFSMap.h:20:
/home/jenkins/workspace/ceph-master/src/mds/FSMap.h:330:49: error: 'auto' not allowed in function prototype
  void modify_filesystem(fs_cluster_id_t fscid, auto&& fn)
                                                ^~~~
/home/jenkins/workspace/ceph-master/src/mds/FSMap.h:341:37: error: 'auto' not allowed in function prototype
  void modify_daemon(mds_gid_t who, auto&& fn)
                                    ^~~~

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
2019-03-01 21:36:26 +01:00
Sage Weil
94486a9fb6 mgr/BaseMgrModule: drop GIL for ceph_send_command
Otherwise, we can easily deadlock, since other bits of the code hold the
objecter lock and then take the GIL.

Fixes: http://tracker.ceph.com/issues/38537
Signed-off-by: Sage Weil <sage@redhat.com>
2019-03-01 11:00:55 -06:00
Jason Dillaman
4ab84327d9
Merge pull request #26688 from yangdongsheng/librbd_fix_all_throttled
librbd: fix were_all_throttled() to avoid incorrect ret-value

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2019-03-01 10:43:36 -05:00
Patrick Donnelly
eac565f7b0
Merge PR #26659 into master
* refs/pull/26659/head:
	qa: remove libcephfs-java tests

Reviewed-by: Nathan Cutler <ncutler@suse.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2019-03-01 06:53:20 -08:00
Nathan Cutler
94656d99e9
Merge pull request #26695 from smithfarm/wip-make-check-amqp-endpoint
do_cmake.sh: SUSE builds need WITH_RADOSGW_AMQP_ENDPOINT=OFF

Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Kyr Shatskyy <kyrylo.shatskyy@suse.de>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
2019-03-01 15:49:41 +01:00
Patrick Donnelly
06e7b12d24
Merge PR #26699 into master
* refs/pull/26699/head:
	qa: unmount clients before deleting fs

Reviewed-by: Zheng Yan <zyan@redhat.com>
2019-03-01 06:46:46 -08:00
Patrick Donnelly
a2dac30db5
Merge PR #26700 into master
* refs/pull/26700/head:
	qa: bump fsstress timeout to 6h

Reviewed-by: Zheng Yan <zyan@redhat.com>
2019-03-01 06:44:36 -08:00
Dongsheng Yang
e803b0b666 librbd: fix were_all_throttled() to avoid incorrect ret-value
Fixes: http://tracker.ceph.com/issues/38504

Signed-off-by: Dongsheng Yang <dongsheng.yang@easystack.cn>
2019-03-01 09:33:48 -05:00
Jason Dillaman
819290e5cf librbd: pool_init API now validates the pool
This offloads the validation process from the image creation
state machine under normal conditions.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-03-01 08:27:27 -05:00
Jason Dillaman
6a84ca3f24 librbd: create state machine uses new validate pool state machine
Fixes: http://tracker.ceph.com/issues/38500
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-03-01 08:27:27 -05:00
Jason Dillaman
b3ee83b9ce librbd: separate pool validation into a standalone state machine
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-03-01 08:27:26 -05:00
Lenz Grimmer
34f04be35b
Merge pull request #26482 from votdev/show_success_notification_rgw
mgr/dashboard: Show success notification in RGW forms

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2019-03-01 12:02:15 +01:00
Lenz Grimmer
86edaa3d91
Merge pull request #26507 from votdev/yesno_pipe
mgr/dashboard: Introduce pipe to convert bool to text

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
2019-03-01 11:46:33 +01:00
Volker Theile
346cfa3969 mgr/dashboard: Introduce pipe to convert bool to text
Convert boolean values to 'Yes' or 'No' or any other value.

Signed-off-by: Volker Theile <vtheile@suse.com>
2019-03-01 10:27:13 +01:00
Ricardo Dias
b975a35eeb
Merge pull request #26714 from cyx1231st/wip-async-bannercheck
msg/async: fix banner_v1 check in ProtocolV2

Reviewed-by: Ricardo Dias <rdias@suse.com>
2019-03-01 09:24:48 +00:00
Lenz Grimmer
305095ed7a
Merge pull request #26626 from LenzGr/master-documentation
doc: Updated Ceph Dashboard documentation

Reviewed-by: Tatjana Dehler <tdehler@suse.com>
2019-03-01 10:00:01 +01:00
Ricardo Dias
4c5c303cc4
Merge pull request #26711 from cyx1231st/wip-async-frame-header
msg/async: fix include in frames_v2.h

Reviewed-by: Ricardo Dias <rdias@suse.com>
2019-03-01 08:03:16 +00:00
Yingxin Cheng
e17ec6437d msg/async: fix banner_v1 check in ProtocolV2
Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>
2019-03-01 15:46:36 +08:00
Sage Weil
6154874aa9 common/str_map: better trim() impl using boost
Thanks Kefu!

Signed-off-by: Sage Weil <sage@redhat.com>
2019-02-28 23:41:59 -06:00
Sage Weil
16ffca6f0a common/str_map: fix trim() on empty string
If was pass an empty string (e.g., with something like
get_str_map("M= T= P=")) we end up with a (size_t)-1 for end.

Fixes: http://tracker.ceph.com/issues/38329
Signed-off-by: Sage Weil <sage@redhat.com>
2019-02-28 23:39:44 -06:00
Yingxin Cheng
939b381b93 msg/async: fix include in frames_v2.h
`ceph_clock_now()` needs to include common/Clock.h.

Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>
2019-03-01 12:39:43 +08:00
Patrick Donnelly
1f5892f820
Merge PR #26638 into master
* refs/pull/26638/head:
	doc: update documentation for standby-replay
	qa: update discontinous map test to use mds freezing
	mon: add freeze MDS command
	qa: update testing for standby-replay
	mon: add setting for fs to enable standby-replay
	ceph-mds: obsolete hot-standby option
	fs: obsolete standby_for config options
	messages/MMDSBeacon: use inline init
	mds: avoid unnecessary copy of entity_addrvec_t
	mds: use inline init for mds_info_t
	mds: use rank from MDSMap always
	mds: remove obsolete comment
	qa: use SIGTERM when stopping vstart service

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Zheng Yan <zyan@redhat.com>
2019-02-28 20:37:13 -08:00
Xie Xingguo
4102b62c12
Merge pull request #26605 from xiexingguo/wip-misc-cleanups
osd/OSDMap: drop local pool filter in calc_pg_upmaps

Reviewed-by: Sage Weil <sage@redhat.com>
2019-03-01 11:23:16 +08:00
xie xingguo
dee0e1ed67 msg/async/ProtocolV2: send_keepalive under the scope of lock
Dropping lock is dangerous and could be race-prone.
Any time the lock is dropped we need to reverify the connection state.

send_keepalive under the scope of lock should be just fine since
it does not introduce any extra lock dependencies.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
2019-03-01 09:38:27 +08:00
xie xingguo
61b9432ef9 msg/async/Protocol*: send keep alive if existing wins
This is a follow-up fix of https://github.com/ceph/ceph/pull/25754.

It turns out the existing connection would win the connection race
and then be stuck in the __replacing__ stage forever without being
aware of that the underlying Pipe is actually broken.

Fix by forcing existing sending keepalive periodically __too__.

Fixes: http://tracker.ceph.com/issues/38493
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
2019-03-01 09:31:35 +08:00
Sage Weil
5eb77a2b73 Merge PR #26614 into master
* refs/pull/26614/head:
	osd: Implement lazy omap usage statistics

Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-02-28 18:08:29 -06:00
Sage Weil
649ea55d8a Merge PR #26453 into master
* refs/pull/26453/head:
	rpm: build with lttng on ppc64le (SUSE)
	rpm: no lttng build on openSUSE s390x

Reviewed-by: Tim Serong <tserong@suse.com>
2019-02-28 18:07:59 -06:00
Sage Weil
cac4335ff3 Merge PR #26667 into master
* refs/pull/26667/head:
	cmake: link rgw tests with ${rgw_libs}
	cmake: link ${rgw_libs} not rgw_a and rabbitmq
	cmake: move rgw tests targets down to end

Reviewed-by: Tim Serong <tserong@suse.com>
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
Reviewed-by: Nathan Cutler <ncutler@suse.com>
2019-02-28 18:07:26 -06:00
Sage Weil
fa690ea9c6 Merge PR #26681 into master
* refs/pull/26681/head:
	mon/ConfigMonitor: add 'config ls'

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: João Eduardo Luís <joao@suse.de>
2019-02-28 18:05:28 -06:00
Jason Dillaman
499bef6591
Merge pull request #26693 from trociny/wip-rbd-bench-interrupt
rbd: close image when bench is interrupted

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2019-02-28 17:31:45 -05:00
Matt Benjamin
23efa7dbee
Merge pull request #26639 from cbodley/wip-38479
rgw: data sync drains lease stack on lease failure
2019-02-28 16:58:34 -05:00
Patrick Donnelly
df62f2d91d
qa: remove libcephfs-java tests
These have bit-rotted and no longer work. No cycles from interested parties
available to fix.

Fixes: https://tracker.ceph.com/issues/38487
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2019-02-28 13:32:15 -08:00
David Zafman
b1efd43096 doc: Update some of the priority item descriptions
Signed-off-by: David Zafman <dzafman@redhat.com>
2019-02-28 12:34:53 -08:00
David Zafman
992c690772 doc: Minor fixes to monitoring-osd-pg.rst
Signed-off-by: David Zafman <dzafman@redhat.com>
2019-02-28 12:34:53 -08:00
David Zafman
dee162039c doc: Remove osd disk thread items that no longer exist
Caused by: 35a4b5072f

Signed-off-by: David Zafman <dzafman@redhat.com>
2019-02-28 12:34:53 -08:00
David Zafman
4a6d44d459 common: Fix typo in description
Signed-off-by: David Zafman <dzafman@redhat.com>
2019-02-28 12:34:53 -08:00
Alfredo Deza
9106ede784
Merge pull request #26685 from ceph/wip-testinfra-ceph-volume
ceph-volume: use our own testinfra suite for functional testing

Reviewed-by: Alfredo Deza <adeza@redhat.com>
2019-02-28 13:01:22 -05:00
Lenz Grimmer
a0ce357c87
Merge pull request #26650 from LenzGr/typo-fix
mgr/dashboard: Fixed typos in environment.build.js

Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2019-02-28 18:42:10 +01:00