Commit Graph

76550 Commits

Author SHA1 Message Date
Sage Weil
0afffa5c58 Merge pull request #16611 from liewegas/wip-doc-health
doc/rados/operations/health-checks: osd section

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: John Spray <john.spray@redhat.com>
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
2017-08-01 08:26:24 -05:00
Sage Weil
dbb1dd33e6 doc/rados/operations/health-checks: add PG health check commentary
Include a link to pg-repair.rst, although there is no
content there yet.

Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-01 09:25:42 -04:00
Sage Weil
cb34a63b32 mon/PGMap: include which pgs have unfound objects in detail
Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-01 09:25:42 -04:00
Sage Weil
6a4b83d646 mon/PGMap: put the _toofull states under DEGRADED_FULL
I think this was an oversight?

Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-01 09:25:42 -04:00
Sage Weil
3789f46ead mon/PGMap: 'incomplete' means data is unavailable
Well, data is certainly unavailable, and may also be
degraded in the sense that we can't peer.  I think
unavailable is the more severe of the two, though, so
let's put it there!

Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-01 09:25:42 -04:00
Sage Weil
6bac77e960 doc/rados/operations/health-checks: osd section
First paragraph: explain what the error means.

Second or later paragraph: describe steps to fix or mitigate.

Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-01 09:25:41 -04:00
John Spray
0b80927661 mds: fix health checks for multiple filesystems
Signed-off-by: John Spray <john.spray@redhat.com>
2017-08-01 09:02:07 -04:00
Zhu Shangzhong
c91bb519e8 doc: change the default filesystem/pool names
- s/cephfs_data/cephfs_data_a
- s/cephfs_metadata/cephfs_metadata_a
- s#./rados df#bin/rados df
- update the 'bin/rados df' output
- remove the rbd pool, it isn't created by default anymore.

Signed-off-by: Zhu Shangzhong <zhu.shangzhong@zte.com.cn>
2017-08-01 20:40:58 +08:00
John Spray
ac2b9d63ca qa: include config help in admin socket test
Signed-off-by: John Spray <john.spray@redhat.com>
2017-08-01 13:38:40 +01:00
John Spray
fbf08b6868 doc: document config help command
Signed-off-by: John Spray <john.spray@redhat.com>
2017-08-01 13:38:27 +01:00
Jos Collin
beab3c5ef4 Merge pull request #16721 from joscollin/wip-config-rst-typo
doc: fix typo in config.rst

Reviewed-by: Xie Xingguo <xie.xingguo@zte.com.cn>
2017-08-01 11:21:59 +00:00
John Spray
4f2172cae1 Merge pull request #16723 from tchaikov/wip-doc-kill-warnings
doc: various fixes
2017-08-01 12:06:36 +01:00
John Spray
1469cac02b mon: fix log message on mds rank stop
Signed-off-by: John Spray <john.spray@redhat.com>
2017-08-01 06:57:50 -04:00
John Spray
a5ed38f3fa mon: uniform way of referring to MDS daemons
... in cluster log messages.  Replaces the mixture
of "mds.foo", "mds daemon 'foo'", etc, with a standard
"daemon mds.foo".

Signed-off-by: John Spray <john.spray@redhat.com>
2017-08-01 06:57:49 -04:00
John Spray
d0192e5962 mds: revise health checks for _FAILED/_DEGRADED
No longer output MDS_* versions as well as FS_* versions,
because it was noisy and the important message is about
the availability (or not) of the filesystem.

Revise the _FAILED check to only raise the message if
there are not suitable replacements available for failed
ranks.  This avoids a spurious health check failure when
a rank has been failed (e.g. by the admin) but it will
be replaced at the next tick().

After this change, doing a "ceph mds fail" when a standby
is available just gives you a single FS_DEGRADED health
check from the point of the "fail" to when the replacement
is active.

Signed-off-by: John Spray <john.spray@redhat.com>
2017-08-01 06:57:49 -04:00
John Spray
beb4c38ae7 mon/MDSMonitor: log messages on MDS rank changes
Add explicit messages, and demote the addr+state prints
to DEBUG level.  At INFO level we now see
just  a message when we decide to assign a rank, and
a message when the daemon is active, rather than messages
for each state the daemon progresses through.

Signed-off-by: John Spray <john.spray@redhat.com>
2017-08-01 06:57:49 -04:00
Kefu Chai
5c374e7382 Merge pull request #16471 from jan--f/janf-mds-deactivate-doc
doc: reword mds deactivate docs; add optional fs_name argument

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2017-08-01 18:52:59 +08:00
Kefu Chai
a8c2b10439 Merge pull request #16620 from cfanz/master
common: use std::move() for better performance

Reviewed-by: Jos Collin <jcollin@redhat.com>
2017-08-01 17:45:06 +08:00
Kefu Chai
69607f8092 Merge pull request #16526 from TsaiJin/wip-fix-msg-typo
msg/async: fix the bug of inaccurate calculation of l_msgr_send_bytes

Reviewed-by: Pan Liu <wanjun.lp@alibaba-inc.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Haomai Wang <haomai@xsky.com>
2017-08-01 17:40:27 +08:00
Kefu Chai
24742cf3ef Merge pull request #16666 from scienceluo/wip-luo-auth-branch
auth: Remove unused function in AuthSessionHandler

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2017-08-01 17:38:08 +08:00
Kefu Chai
2670d244fd doc: various fixes
- radosgw/s3/bucketops.rst: fix Malformed table.
- operations/health-checks.rst: Title underline too short
- rbd/rados-rbd-cmds.rst: Title underline too short
- rados/operations/index.rst: include health-checks in toc

Signed-off-by: Kefu Chai <kchai@redhat.com>
2017-08-01 17:31:36 +08:00
Jos Collin
eb1f53782a doc: fix typo in config.rst
Fixed the typo introduced by PR#16681

Signed-off-by: Jos Collin <jcollin@redhat.com>
2017-08-01 14:16:14 +05:30
Josh Durgin
61908ac890 Merge pull request #16622 from dillaman/wip-cmpext-dne
osd: cmpext operator should ignore -ENOENT on read

Reviewed-by: David Zafman <dzafman@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2017-07-31 23:52:43 -07:00
Greg Farnum
f19a3d96a3 osd: pg: be more careful with locking around forced pg recovery
This does several little things that add up to big concurrency and safety
improvements:
* Switch to passing around PGRefs instead of raw pointers, which is
  generally a good idea
* drop the pg_map_lock once we're done looking up the PGRefs, since
  we don't need it and holding the PG pointer alive was the only previous
  thing that might have made it necessary
* don't hold the recovery_lock since we don't need any OSD-level
  synchronization
* make sure the PG is not being deleted before we do a force-change of its
  state

Fixes: http://tracker.ceph.com/issues/20808

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
2017-07-31 23:41:08 -07:00
Kefu Chai
c4b25b114d Merge pull request #16677 from tchaikov/wip-20785
osd: do not send pg_created unless luminous

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2017-08-01 13:12:53 +08:00
Yanhu Cao
ce7fed2926 ceph-osd: fix auto detect which objectstore is currently running
Fixes: http://tracker.ceph.com/issues/20865

Signed-off-by: Yanhu Cao <gmayyyha@gmail.com>
2017-08-01 10:44:57 +08:00
Josh Durgin
886971b58b mon/OSDMonitor: make setting require-osd-release idempotent
Signed-off-by: Josh Durgin <jdurgin@redhat.com>
2017-07-31 21:51:47 -04:00
Josh Durgin
966513908c osd: do not try to set device class before luminous
This avoids crashing when older monitors do not support it.

Fixes: http://tracker.ceph.com/issues/20850
Signed-off-by: Josh Durgin <jdurgin@redhat.com>
2017-07-31 21:50:48 -04:00
David Zafman
901f14aa7c Merge pull request #16663 from dzafman/wip-ec-enoent
osd: EC read handling: don't grab an objectstore error to use as the read error

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2017-07-31 18:19:02 -07:00
Jos Collin
7e9d87fa2e Merge pull request #16681 from shun-s/wip-doc-config
doc: fix typos in config.rst

Reviewed-by: Jos Collin <jcollin@redhat.com>
2017-08-01 00:59:06 +00:00
Patrick Donnelly
8db2c43e79
qa: test export_pin is correct in dumped subtree
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2017-07-31 15:33:49 -07:00
Gregory Farnum
b16b973e39 Merge pull request #16695 from tchaikov/wip-cmake-disable-vta
cmake: disable -fvar-tracking-assignments for config.cc

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2017-07-31 15:05:23 -07:00
Patrick Donnelly
e52fdc0c4f
mds: print export_pin for dumped subtree
Fixes: http://tracker.ceph.com/issues/20595

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2017-07-31 15:00:18 -07:00
Gregory Farnum
861225339d Merge pull request #16697 from wjwithagen/wip-wjw-ENODATA-HashIndex.cc
HashIndex.cc: add compat.h for ENODATA

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2017-07-31 14:59:43 -07:00
Patrick Donnelly
5e5ff5c086
qa: ignore failed MDS message during upgrade
The cluster is expected to become degraded during reboot.

Fixes: http://tracker.ceph.com/issues/20731
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2017-07-31 14:45:07 -07:00
Adam C. Emerson
d02db19cf8 Merge pull request #16689 from pritha-srivastava:wip-rgw-policy-parse-error
rgw: Fix for Policy Parse exception in case of multiple statements.

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2017-07-31 14:43:58 -04:00
Adam C. Emerson
bf223bab68 Merge pull request #16661 from adamemerson/wip-throttle-minimal
throttle: Minimal destructor fix for Luminous

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2017-07-31 14:08:20 -04:00
J. Eric Ivancich
81d3def3c2 doc: Describe mClock's use within Ceph in great detail.
It seems many are initially unclear as to how the current
implementations of mclock op queues work, so we need to document it to
avoid confusion.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
2017-07-31 13:20:31 -04:00
Adam C. Emerson
0f52f486ef throttle: Minimal destructor fix for Luminous
Get rid of the undefined behavior of destroying condition variables
while they're being waited on.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2017-07-31 13:17:46 -04:00
Douglas Fuller
58073cfcd1 cephfs: Resend discover when joining from starting state
From: Zheng Yan <zyan@redhat.com>

Kick discover messages when transitioning from STATE_STARTING
to STATE_ACTIVE.

Fixes: http://tracker.ceph.com/issues/20799
Signed-off-by: Douglas Fuller <dfuller@redhat.com>
2017-07-31 10:51:38 -04:00
Douglas Fuller
bffa375975 cephfs: Wait for MDCache to be ready before starting log segment
These can race as the MDS starts.

Fixes: http://tracker.ceph.com/issues/20799
Signed-off-by: Douglas Fuller <dfuller@redhat.com>
2017-07-31 10:51:24 -04:00
Jason Dillaman
05b182c1c2 Merge pull request #16547 from dillaman/wip-dashboard-iscsi
mgr/dashboard: RBD iSCSI daemon status page

Reviewed-by: John Spray <john.spray@redhat.com>
2017-07-31 10:22:21 -04:00
Song Shun
2556605b79 doc: fix sevral typos
fix sevral typos

Signed-off-by: Song Shun <song.shun3@zte.com.cn>
2017-07-31 22:10:51 +08:00
Jason Dillaman
41c251c243 Merge pull request #16670 from Yan-waller/wip-walle-0729rbdcompile
cls/rbd: silence warning from -Wunused-variable

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2017-07-31 10:07:45 -04:00
Jason Dillaman
9b3fe6f03b Merge pull request #16583 from lxbsz/ws_macro
librbd: add LIBRBD_SUPPORTS_WRITESAME support

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2017-07-31 09:49:13 -04:00
John Spray
f8068cd438 mon: extensible output format for health checks
The summary field can be extended with the fields
used to construct the message (e.g. including
the down osd count in the message about osds
being down).

The detail entries, similarly, can be extended
with machine-readable fields like the PG ID
for a damaged PG.

For the moment all the internal stuff is just
strings still, but we change the output format
so that we don't break it later when we
add things.

Signed-off-by: John Spray <john.spray@redhat.com>
2017-07-31 09:33:12 -04:00
John Spray
ac01dff6a9 osd/mon/mds: fix config set tell command
This was working for setting values, but failing to call
the config observers, so some values didn't take effect.

Fixes: http://tracker.ceph.com/issues/20803
Signed-off-by: John Spray <john.spray@redhat.com>
2017-07-31 09:28:21 -04:00
Yan Jun
b3b1f2cfb2 cls/rbd: silence warning from -Wunused-variable
Signed-off-by: Yan Jun <yan.jun8@zte.com.cn>
2017-07-31 21:26:13 +08:00
Jason Dillaman
51c7cec7bb Merge pull request #16694 from Songweibin/wip-doc-rbd
rbd: modified some commands' description into imperative sentence

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2017-07-31 09:12:27 -04:00
Willem Jan Withagen
9667222d98 HashIndex.cc: add compat.h for ENODATA
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
2017-07-31 15:02:53 +02:00