Commit Graph

99901 Commits

Author SHA1 Message Date
Igor Fedotov
a1246da570 os/bluestore: cleanup around allocator calls
Both stupid and bitmap allocator returs -ENOSPC if they're
unable to allocate any space. Existing callers aren't always
respect this - hence doing some cleanup.

Signed-off-by: Igor Fedotov <ifedotov@suse.com>
2019-07-16 17:16:16 +03:00
Jason Dillaman
353ceeb698
Merge pull request #28820 from trociny/wip-journal-fetch-corrupt-end
journal: return error after first corruption detected

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2019-07-16 10:10:29 -04:00
Patrick Donnelly
b049eb9bbc
client: do not return EEXIST for mkdirs
Behavior should be similar to `mkdir -p`.

Introduced-by: 26905ca827
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2019-07-16 06:52:23 -07:00
Ricardo Marques
498eec659f
Merge pull request #28633 from p-na/wip-pna-refactor-unit-tests
mgr/dashboard: Reduce code duplication through TableActionComponent UnitTests

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2019-07-16 14:13:28 +01:00
Ricardo Marques
9804db3e83
Merge pull request #28999 from rafaelquint/bucketstest3
mgr/dashboard: RGW bucket E2E Tests

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Patrick Nawracay <pnawracay@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2019-07-16 14:07:28 +01:00
Tiago Melo
2da5430614 mgr/dashboard: Reduce code duplication through TableActionComponent Unit Tests
Fixes: http://tracker.ceph.com/issues/40399

Signed-off-by: Patrick Nawracay <pnawracay@suse.com>
2019-07-16 13:52:02 +02:00
Yingxin Cheng
3408db07f3 crimson/net: printable accept address
entity_addr_t::TYPE_NONE is not printable, change to TYPE_ANY.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2019-07-16 19:39:53 +08:00
Yingxin Cheng
24f01201dc crimson/net: unify loggings for message exchange
* remove duplicated information in message logs,
  because connection prefix already contains information about:
  "[my_name(my_logic_name) my_addr >> peer_name peer_addr]"
* unify message logs for both v1 and v2;
* continue to use familiar identifiers to highlight message logs:
  - received messages identified by "<== #seq === msg (type)";
  - sent messages identified by "--> #seq === msg (type)";

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2019-07-16 19:39:53 +08:00
Yingxin Cheng
b86632ed1e crimson/net: clean up loggings in v2 protocol
Defind log levels in V2 Protocol:
* error level, something error that cause connection to terminate:
  - fatal errors;
  - bugs;
* warn level: something unusual that identifies connection fault or replacement:
  - unstable network;
  - incompatible peer;
  - auth failure;
  - connection race;
  - connection reset;
* info level, something very important to show connection lifecycle,
  which doesn't happen very frequently;
* debug level, important logs for debugging, including:
  - all the messages sent/received (-->/<==);
  - all the frames exchanged (WRITE/GOT);
  - important fields updated (UPDATE);
  - connection state transitions (TRIGGER);
* trace level, trivial logs showing:
  - the exact bytes being sent/received (SEND/RECV(bytes));
  - detailed information of sub-frames;
  - integrity checks;
  - etc.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2019-07-16 19:39:53 +08:00
Yingxin Cheng
b5f74c5e3f crimson/net: cleanup, rename _peer_addr to _my_addr_from_peer
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2019-07-16 19:39:30 +08:00
Yingxin Cheng
917d70cf3c crimson/net: abort with unhandled exceptions from dispatcher
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2019-07-16 19:38:51 +08:00
Yingxin Cheng
da3d729051 crimson/net: cleanup, fix spelling error
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2019-07-16 19:36:54 +08:00
Yingxin Cheng
b59fddda3b crimson/net: cleanup, return void from unexpected_tag()
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2019-07-16 19:34:32 +08:00
Rafael Quintero
fb025001bd mgr/dashboard: E2E Tests for Create, Edit, Delete, and Invalid Input on RGW Buckets
Fixes: https://tracker.ceph.com/issues/40372
Fixes: https://tracker.ceph.com/issues/40484
Fixes: https://tracker.ceph.com/issues/40259

Signed-off-by: Adam King <adking@redhat.com>
Signed-off-by: Rafael Quintero <rquinter@redhat.com>
2019-07-16 07:11:22 -04:00
Ricardo Dias
d4049a5ad6
Merge pull request #28879 from Devp00l/wip-40580
mgr/dashboard: Fix the table mouseenter event handling test

Reviewed-by: Patrick Nawracay <pnawracay@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2019-07-16 11:48:39 +01:00
Ricardo Marques
78e580bc7c
Merge pull request #28916 from p-na/wip-pna-fix-tag
mgr/dashboard: Add linter for unclosed HTML tags

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2019-07-16 11:16:33 +01:00
Yingxin Cheng
cfc0e32e39 crimson/net: unify the usage of entity_type_t and entity_name_t
* use standard entity_type_t(uint8_t) in favor of peer_type_t(int);
* use standard ceph_entity_type_name() to print where possible;
* use peer_name to encapsulate peer_type and peer_id in Connection.h;
* clean related interfaces in Messenger and Connection;
* print peer_name in Connection logging prefix;

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2019-07-16 17:06:38 +08:00
Patrick Nawracay
07a97a7dee mgr/dashboard: Add missing closing tag for container
Signed-off-by: Patrick Nawracay <pnawracay@suse.com>
2019-07-16 10:51:07 +02:00
Ricardo Marques
ec02aa9541
Merge pull request #27463 from rjfd/wip-dashboard-ssl-cert
mgr/dashboard: commands to set SSL certificate and key

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2019-07-16 09:25:38 +01:00
Sebastian Wagner
9c4795dab2
Merge pull request #28213 from sebastian-philipp/orchestrator_cache
mgr/orchestrator: Add cache for Inventory and Services

Reviewed-by: Tim Serong <tserong@suse.com>
2019-07-16 10:17:45 +02:00
Patrick Donnelly
ecf8502395
pybind/mgr/volumes: print exceptions in purge thread
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2019-07-15 21:42:17 -07:00
Patrick Donnelly
e71e9187ec
pybind/mgr/volumes: refactor trash readdir
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2019-07-15 21:42:17 -07:00
Patrick Donnelly
e9c314abd0
pybind/mgr/volumes: use existing client provided recursive mkdir
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2019-07-15 21:42:17 -07:00
Patrick Donnelly
7cc4b72305
pybind/mgr/volumes: cleanup fs removal
In Nautilus, the simplest sequence is:

    fs fail name
    fs rm name --yes-i-really-mean-it

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2019-07-15 21:42:17 -07:00
Patrick Donnelly
3d63cd947f
pybind/mgr/subvolumes: use bytes for paths
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2019-07-15 21:42:13 -07:00
Jos Collin
35657ce8e7
Merge pull request #28700 from batrick/i39620
doc/cephfs: improve add/remove MDS section

Reviewed-by: Jos Collin <jcollin@redhat.com>
2019-07-16 09:36:11 +05:30
Neha Ojha
f537db9583
Merge pull request #29033 from neha-ojha/wip-add-yt
doc/dev/developer_guide/index.rst: add youtube references

Reviewed-by: Noah Watkins <nwatkins@redhat.com>
2019-07-15 11:31:45 -07:00
Ricardo Marques
1f2430a547
Merge pull request #28649 from votdev/issue_40427
mgr/dashboard: Pool form uses different loading spinner

Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2019-07-15 18:51:16 +01:00
Sage Weil
1624883890 mon/OSDMonitor: tolerate duplicate MRemoveSnaps messages
Fixes: http://tracker.ceph.com/issues/40774
Signed-off-by: Sage Weil <sage@redhat.com>
2019-07-15 12:48:40 -05:00
Ricardo Dias
69895dd516
doc/mgr/dashboard: update SSL configuration instructions
Signed-off-by: Ricardo Dias <rdias@suse.com>
2019-07-15 15:56:14 +01:00
Ricardo Dias
7648d294bf
mgr/dashboard: added CLI commands to set SSL certificate and key
Fixes: https://tracker.ceph.com/issues/39123

Signed-off-by: Ricardo Dias <rdias@suse.com>
2019-07-15 15:56:14 +01:00
Radoslaw Zarzynski
8ba6775350 Revert "mgr/dashboard: Add nolockdep option to e2e-script"
This reverts commit d92117d8ea7018c533cc422e31c09d7e45a0793a
at the rason for it has been fixed.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2019-07-15 10:53:47 -04:00
Radoslaw Zarzynski
0844a209aa common: refactor handling of lockdep's group name in debug locks.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2019-07-15 10:53:45 -04:00
Radoslaw Zarzynski
2118ca4bd5 common: shared_mutex_debug doesn't use empty group name for lockdep.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2019-07-15 10:53:45 -04:00
Radoslaw Zarzynski
c466a625f7 common, crypto: give names to OpenSSL's mutexes.
Fixes: http://tracker.ceph.com/issues/40698
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2019-07-15 10:53:45 -04:00
Radoslaw Zarzynski
82e7b78269 common: tiny_vector – CPU-friendly container for mutexes & co.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2019-07-15 10:53:45 -04:00
Volker Theile
3606ea21be mgr/dashboard: Pool form uses different loading spinner
Use the 'cd-loading-panel' element to display the loading progress.

Fixes: https://tracker.ceph.com/issues/40427

Signed-off-by: Volker Theile <vtheile@suse.com>
2019-07-15 16:45:46 +02:00
Ricardo Marques
87f5023ecb
Merge pull request #29043 from votdev/issue_40778
mgr/dashboard: Form fields do not show error messages/hints.

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2019-07-15 15:30:01 +01:00
Patrick Donnelly
c44674b393
Merge PR #28951 into master
* refs/pull/28951/head:
	mds: apply configuration changes through MDSRank
	common/TrackedOp: make settings atomic

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-07-15 07:00:46 -07:00
Kefu Chai
23604b3f7e crimson/osd/heartbeat: use v2 address also
as we support v2 protocol, so no need to pick v1 address.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-07-15 21:21:47 +08:00
Kefu Chai
ef0b9b95fe messages/MOSDRepOpReply: include necessary header
for accessing the member variables of `MOSDRepOp`, we should include its
header file for its definition.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-07-15 21:21:47 +08:00
Casey Bodley
35cb8dcee7
Merge pull request #28964 from cbodley/wip-qa-workunit-s3tests
qa/rgw: update run-s3tests.sh

Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>
2019-07-15 09:14:41 -04:00
Patrick Nawracay
4f1bffb57d mgr/dashboard: Add linter for unclosed HTML tags
Fixes: http://tracker.ceph.com/issues/40686

Signed-off-by: Patrick Nawracay <pnawracay@suse.com>
2019-07-15 14:31:16 +02:00
Volker Theile
48a66cb5b1 mgr/dashboard: Form fields do not show error messages/hints.
Fixes: https://tracker.ceph.com/issues/40778
Signed-off-by: Volker Theile <vtheile@suse.com>
2019-07-15 12:09:57 +02:00
Kefu Chai
e877af04b9
Merge pull request #28682 from cyx1231st/wip-seastar-msgr-socket2
crimson/net: implement preemptive shutdown/close

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-07-15 15:46:13 +08:00
Kefu Chai
a373238878 crimson/osd: an MOSDOp should be waiting for min_epoch
for MOSDOp, get_min_epoch() is an alias of get_map_epoch(), but
get_min_epoch() is symantically more correct.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-07-13 21:46:05 +08:00
Kefu Chai
0df8e57b16 crimson/osd: add a dedicate code path for WRITE
differentiate WRITE from WRITEALL.
and handles differnt cases of `os.oi.truncate_seq` caused by
`write_trunc` and/or `trunc` ops.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-07-13 21:46:05 +08:00
Rishabh Dave
9aa9ff01fd test_volume_client: add positive test for ceph_volume_client method
ceph_volume_client.py's put_object_versioned() has only one test. Since
this only test is a negative test it may fail to assure that
put_object_versioned() works as expected with positive inputs even when
it completes successfully. Therefore, write a positive test for better
coverage.

Also, make sure the new test is both python 2 and python3 compatible.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2019-07-13 11:43:03 +05:30
Rishabh Dave
7980e1fb7c test_volume_client: rename test_put_object_versioned()
test_put_object_versioned() is too generic for a negative test that
specifically tests if the version is verified before writing.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2019-07-13 11:43:03 +05:30
Rishabh Dave
37744ecc2b test_volume_client: rewrite test_put_object_versioned
The test's success depends on whether CommandFailedError exception is
raised. This manner of testing is unreliable since there's no way to
check if the exception was raised by the statement (in the embedded
Python program) the test expects to.

This implies that this test's failure may go undetected. This is primary
reason why bugs like tracker #38946 occured despite of having a test.

Fixes: http://tracker.ceph.com/issues/39510
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2019-07-13 11:43:03 +05:30