Commit Graph

79439 Commits

Author SHA1 Message Date
Casey Bodley
160240e0c1 qa/rgw: ignore errors from 'pool application enable'
Fixes: http://tracker.ceph.com/issues/21715

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2017-10-09 10:25:26 -04:00
Kefu Chai
385786b362 kv: unify {create_and_,}open() methods
this silences the warning of "-Woverloaded-virtual" where create() and
create_and_open() from KeyValueDB are hidden from the ones defined in
derived classes.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2017-10-09 21:50:26 +08:00
Haomai Wang
765259a082 Merge pull request #18190 from JustL/master
msg/async/rdma: unnecessary reinitiliazation of an iterator

Reviewed-by: Haomai Wang <haomai@xsky.com>
2017-10-09 08:48:19 -05:00
Sage Weil
0260bc5b7a Merge pull request #18058 from Yan-waller/wip-walle-0927pgstatexpandstate
osd/PG:  extend pg state bits to fix pg ls commands error

Reviewed-by: Sage Weil <sage@redhat.com>
2017-10-09 08:22:42 -05:00
JustL
fa13eaf8da msg/async/rdma: unnecessary reinitiliazation of an iterator
current_buffer iterator does not need to be reinitalized as no changes
occur between the initialization and iteration steps.

Signed-off-by: Justinas Lingys jlingys@connect.ust.hk
2017-10-09 20:37:43 +08:00
Orit Wasserman
db0602e963 Merge pull request #18178 from joscollin/wip-radosgw-admin-reshard-fix
rgw: update usage() with status
Reviewed-by: Orit Wasserman <owasserm@redhat.com>
2017-10-09 15:19:05 +03:00
Jos Collin
30a97e8c72 Merge pull request #18180 from oritwas/wip-rgw-21617
rgw: add reshard commands

Reviewed-by: Jos Collin <jcollin@redhat.com>
2017-10-09 12:03:57 +00:00
Jos Collin
b0cea4d943 rgw: Fixed typos and status in help.t
Fixed typos and status in help.t

Signed-off-by: Jos Collin <jcollin@redhat.com>
2017-10-09 16:58:51 +05:30
Orit Wasserman
8ea13174f7 rgw: add reshard commands to the man pages
Fixes: http://tracker.ceph.com/issues/21617
Signed-off-by: Orit Wasserman <owasserm@redhat.com>
2017-10-09 14:16:55 +03:00
Yan, Zheng
27db025599 osdc/ObjectCacher: limit memory usage of BufferHead
when doing small size random writes, size of data structures that used
for tracking dirty data can be larger than the dirty data size.

Fixes: http://tracker.ceph.com/issues/21726
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
2017-10-09 18:28:20 +08:00
Kefu Chai
d8227f43fd Merge pull request #18162 from tchaikov/wip-ceph-disk-retry-on-dev-not-ready
ceph-disk: retry on OSError

Reviewed-by: Loic Dachary <ldachary@redhat.com>
2017-10-09 18:25:45 +08:00
Jos Collin
2d3a91c493 rgw: update usage() with status
Fixed the missing 'status' in usage().

Signed-off-by: Jos Collin <jcollin@redhat.com>
2017-10-09 15:54:34 +05:30
Yao Zongyou
bba3a89591 rgw: fix command argument error for radosgw-admin.
Fixes: http://tracker.ceph.com/issues/21723
Signed-off-by: Yao Zongyou <yaozongyou@vip.qq.com>
2017-10-09 17:19:45 +08:00
xie xingguo
b650e91519 osd/PG: avoid updating missing_loc_sources multiple times
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
2017-10-09 15:53:53 +08:00
xie xingguo
d9b9b075ff osd/PG: MissingLoc - reduce some overhead on operating unfound (objects)
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
2017-10-09 15:26:32 +08:00
lu.shasha
4a759c9aaa rgw:lc: using midnight time to check obj expiration
Amazon S3 calculates the expiration time by adding the number of days specified in the rule to the object creation time and rounding the resulting time to the next day midnight.
So rgw should using the rounding down midnight time to compare with the object creation time to check obj expiration.

Fixes: http://tracker.ceph.com/issues/21533

Signed-off-by: Shasha Lu <lu.shasha@eisoo.com>
2017-10-09 14:31:15 +08:00
Yan Jun
a25221e551 osd/PG: extend pg state to 64 bits
Signed-off-by: Yan Jun <yan.jun8@zte.com.cn>
2017-10-09 12:45:16 +08:00
Yan Jun
f953770c88 os/bluestore: drop unused class FreelistManager
Signed-off-by: Yan Jun <yan.jun8@zte.com.cn>
2017-10-09 12:45:10 +08:00
Jos Collin
2953986b52 Merge pull request #18157 from batrick/ptl-tool-branch-checkout
ptl-tool: checkout branch after creation

Reviewed-by: Jos Collin <jcollin@redhat.com>
2017-10-09 03:27:27 +00:00
Sage Weil
96ddf5c3a0 Merge pull request #17708 from liewegas/wip-pg
osd: initial minimal efforts to clean up PG interface
2017-10-08 21:47:49 -05:00
Sage Weil
95fb8fbad7 Merge pull request #18125 from cernceph/dvanders_conf
mon: mark mon_allow_pool_delete as observed

Reviewed-by: Sage Weil <sage@redhat.com>
2017-10-08 21:47:26 -05:00
Sage Weil
6f72b404f4 Merge pull request #18144 from hjwsm1989/wip-21425-part2
qa/suites/rest/basic/tasks/rest_test: whiltelist OSD_DOWN

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
2017-10-08 21:47:02 -05:00
Sage Weil
2dbbb351e2 Merge pull request #18159 from liewegas/wip-21712-b
os: fix 0-length zero semantics, add tests

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2017-10-08 21:46:27 -05:00
Sage Weil
b588eaf2b0 os/bluestore: 0-length zero should not change object size
Fixes: http://tracker.ceph.com/issues/21712
Signed-off-by: Sage Weil <sage@redhat.com>
2017-10-08 21:46:03 -05:00
Sage Weil
979b7c9cd2 os/filestore: make 0-length zero avoid touching object length
Fixes: http://tracker.ceph.com/issues/21712
Signed-off-by: Sage Weil <sage@redhat.com>
2017-10-08 21:46:03 -05:00
Sage Weil
9ad1f4f10f os/ObjectStore: 0-length zero does not change length of object
Signed-off-by: Sage Weil <sage@redhat.com>
2017-10-08 21:46:03 -05:00
Kefu Chai
93452dbadc mon/OSDMonitor: s/g_ceph_context/cct/
use this->cct if possible, yet another step to remove the dependency on
global `g_ceph_context`.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2017-10-09 10:42:53 +08:00
Kefu Chai
b248f8903b common/config: return const reference instead of a copy
avoid creating temporary Option::value_t instances if possible

Signed-off-by: Kefu Chai <kchai@redhat.com>
2017-10-09 10:42:53 +08:00
Kefu Chai
c7a530fd24 common/config: use boost::get<> instead of visitor
simpler this way with caveat of less developer friendly assertion
failure.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2017-10-09 10:38:08 +08:00
Kefu Chai
aa3ea0b244 osd,common: avoid casting useless casts
no need to cast a variable of type `Foo` to `Foo`, for example, 2.000 is
of type `double`, so (double)2.000 does not make sense.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2017-10-09 10:38:08 +08:00
Kefu Chai
69f48f4663 include/types.h: silence "-Wdouble-promotion" warnings
avoid implicit promotion from float to double.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2017-10-09 10:38:08 +08:00
Kefu Chai
28b653616e common/config: s/_get_val/_get_val_generic/
avoid distinguish two methods with their return types and non-templated
versus templated. also, this follows the convention of md_config_t.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2017-10-09 10:38:08 +08:00
Kefu Chai
3b9564f667 Merge pull request #18141 from adamemerson/wip-log-time
log: Use the coarse real time clock in log timestamps

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2017-10-09 09:35:46 +08:00
Kefu Chai
987809c2aa Merge pull request #17976 from adamemerson/wip-warning-sign
mgr,osd,kv: Fix various warnings for Clang and GCC7

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2017-10-09 09:34:50 +08:00
Kefu Chai
4f82dfb9e7 ceph-disk: retry on OSError
we are likely to
1) create partition, for instance, sdc1
2) partprobe sdc
3) udevadm settle
4) check the device by its path: /dev/sdc1

but there is chance that the uevent sent from kernel fails to reach udev
before we call "udevadm", hence "/dev/sdc1" does not exist even after
"udevadm settle" returns. so we retry in case of OSError here.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2017-10-07 23:33:14 +08:00
Kefu Chai
02a8620de7 ceph-disk: factor out the retry logic into a decorator
Signed-off-by: Kefu Chai <kchai@redhat.com>
2017-10-07 23:33:14 +08:00
Chang Liu
c3fa3252c1 os/bluestore: do not core dump when we try to open kvstore twice
Signed-off-by: Chang Liu <liuchang0812@gmail.com>
2017-10-07 16:46:46 +08:00
Li Wang
2a8e8c56b4 test/rbd_mirror/test_mock_ImageSync: fix uninitialized member
Silence coverity 1418957

Signed-off-by: Li Wang <laurence.liwang@gmail.com>
2017-10-07 03:51:47 +00:00
Li Wang
27643fb849 librbd/operation/SnapshotUnprotectRequest: fix uninitialized member
Silence coverity 1413793

Signed-off-by: Li Wang <laurence.liwang@gmail.com>
2017-10-07 03:44:22 +00:00
Li Wang
2888328b4b librbd/operation/SnapshotRenameRequest: fix uninitialized member
Silence coverity 1396229

Signed-off-by: Li Wang <laurence.liwang@gmail.com>
2017-10-07 03:44:10 +00:00
Li Wang
4ea9ac9462 librbd/operation/SnapshotRemoveRequest: fix uninitialized member
Silence coverity 1413790

Signed-off-by: Li Wang <laurence.liwang@gmail.com>
2017-10-07 03:36:07 +00:00
Li Wang
4cd9bb2b05 librbd/operation/SnapshotProtectRequest: fix uninitialized member
Silence Coverity 1413777

Signed-off-by: Li Wang <laurence.liwang@gmail.com>
2017-10-07 03:34:23 +00:00
Adam C. Emerson
afaf48a263 log: Mark timestamps for coarseness and print appropriately
Have each timestamp know whether it's coarse or fine. Print six figures
for fine stamps and three for coarse.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2017-10-06 20:49:53 -04:00
Adam C. Emerson
0f8606b4e0 log: Add log_coarse_timestamps option
And set up an observer in CephContext to coarsen/refine time stamps as
requested.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2017-10-06 20:49:53 -04:00
Adam C. Emerson
a0a4c483bc config: Add templated _get_val for use in observers
When notified by a config observer, the config lock is already held,
create a _get_val template to manipulate newstyle options when
notified.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2017-10-06 20:49:53 -04:00
Adam C. Emerson
31de198955 log: Use log_clock, defaulting to coarse time
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2017-10-06 17:29:06 -04:00
Adam C. Emerson
f00547bb7d log: Add optional msg parameter to create_entry and test with it
The tests should, really, get their time from the same source as the
log, and also probably use the same interface to creating entries that
other people do. So add an optional message argument and have the
tests use that rather than using the new operator directly.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2017-10-06 17:29:06 -04:00
Adam C. Emerson
7b0168c5dd log: Create log_clock to replace use of utime_t
We create a new time type to support using coarse timestamps (for
performance) by default while still allowing the user to switch to
fine timestamps.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2017-10-06 17:29:06 -04:00
Sage Weil
582ee8d4b7 osd/PGLog: drop old compat coll/oid args to read_log_and_missing
The oldest version we care about is 10, and these were for <8.

Signed-off-by: Sage Weil <sage@redhat.com>
2017-10-06 15:37:51 -05:00
Sage Weil
b4e4ad3b85 Merge pull request #18122 from liewegas/wip-monthrash-peering
qa/suites/rados/monthrash: tolerate PG_AVAILABILITY during mon thrashing
2017-10-06 15:32:45 -05:00