Before the commit the `crimson::mon:Connection::reply`
was commented as being specific to the ProtocolV1.
However, the code suggests this member participates also
in V2-related paths like `Connection::renew_tickets()`
where `do_auth()` is called from. `do_auth()` generates
`MAuth` which causes a monitor to send `MAuthReply`.
The `Connection::reply` synchronizes sending the auth
request with response handling.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
At the moment crimson offers only a partial and buggy
support for ProtocolV1. When it enters the production,
V1 will be long obsolete, so spending time on improving
it doesn't seem to be a sound investment while offering
half-baked feature can be worse that lacking it entirely.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
and fallback to ms_type if ms_public_type is not configured
otherwise rdma support breaks with ms_public_type set to async+rdma explicitly
and left ms_type & ms_cluster_type to their defaults.
Signed-off-by: luo.runbing <luo.runbing@zte.com.cn>
* refs/pull/39631/head:
osd/OSDMap: don't warn on NEW osd ids
mon/OSDMonitor: behave if inc map sets weight on not-yet-existing OSD
mon/OSDMonitor: do not mark newly created OSDs OUT
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
before this change, `this` is wrapped by a smart pointer which is
in turn captured by multiple continuations. the continuation with the
longest life cycle is the one passed to `seastar::repeat()`. where
the underlying `repeater` captures the continuation as its member variable.
and `repeater` is not destroyed before `seastar::repeat()` returns.
so, we only need to capture `opref` in the continuation passed to
`seastar::repeat()`.
Signed-off-by: Kefu Chai <kchai@redhat.com>
* no need to capture this, it is already enclosed by `ref`
* use finally for capturing `ref`, and for printing out the "complete"
logging message. we could use a different branch for printing out
the failure message if any.
Signed-off-by: Kefu Chai <kchai@redhat.com>
ext4/002 exercises obsolete EXT4_EOFBLOCKS_FL feature that was removed
in kernel 5.7 and therefore always fails.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
dioread_nolock was made default in kernel 5.6, changing the expected
output of ext4/001: for dioread_nolock we want 001.out.nozero instead
of 001.out.default. Add dioread_nolock to EXT_MOUNT_OPTIONS so that
_link_out_file() selects 001.out.nozero.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
- don't mention xfstests_branch together with xfstests_url as
xfstests_branch gets superseded by xfstests_url
- make xfstests_url example more clear
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Currently in the case where the mon returns a command error code, we print
the error stream and Error ... message but not the command output. Usually
there isn't any, so we haven't noticed until now, but there is not reason
why shouldn't return both an error code and some output.
Restructure the code so that the error message goes *after* the JSON output,
where it will be a bit more obvious to the user (if the stdout scrolled
the terminal, for instance). (This is not a change in behavior since
previously we weren't seeing the stdout at all.)
Signed-off-by: Sage Weil <sage@newdream.net>
