Jeff Layton
5579035cfd
client: type safety cleanup for _read and _write codepaths
...
In the read codepath, bl->length() returns an unsigned value, and that
could end up looking negative when cast to int. On the write side,
totalwritten is a uint64_t, which could look negative when cast to int.
Have the underlying layers pass back an int64_t and convert them to
int at a higher level. This prepares the underlying infrastructure for
ceph_ll_readv and ceph_ll_writev support.
Tracker: http://tracker.ceph.com/issues/22948
Signed-off-by: Jeff Layton <jlayton@redhat.com>
2018-02-12 07:17:51 -05:00
lvshuhua
1bf0696f7d
tools/rados: make rados get/put/append command help txt clearer
...
Fixes: http://tracker.ceph.com/issues/22958
Signed-off-by: lvshuhua <lvshuhua@cmss.chinamobile.com>
2018-02-12 15:30:15 +08:00
Kefu Chai
87e3aa6427
Merge pull request #20392 from adamemerson/wip-clangtastic-voyage
...
cmake, test/fs, client: fix build with clang
Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2018-02-12 11:19:39 +08:00
Kefu Chai
4021d2b679
Merge pull request #20379 from tchaikov/wip-test-fix-freebsd
...
test/librados: s/invoke_result_t/result_of_t/
Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>
2018-02-12 11:17:22 +08:00
Kefu Chai
ce5226a8e2
Merge pull request #20360 from ifed01/wip-ifed-extents-cleanup
...
os/bluestore: cleanup around ExtentList, AllocExtent and bluestore_extent_t classes
Reviewed-by: Sage Weil <sage@redhat.com>
2018-02-12 11:16:44 +08:00
Kefu Chai
cc2fa37380
Merge pull request #20320 from rzarzynski/wip-common-md_config_cacher_t
...
common: introduce md_config_cacher_t
Reviewed-by: Sage Weil <sage@redhat.com>
2018-02-12 11:15:37 +08:00
Kefu Chai
d73b7f2c2a
Merge pull request #20198 from wido/zabbix-health-checks
...
mgr/zabbix: Implement health checks
Reviewed-by: John Spray <john.spray@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2018-02-12 11:14:41 +08:00
Kefu Chai
ba82060def
qa/tasks/mgr: correct the log message
...
Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-02-11 14:25:37 +08:00
Kefu Chai
6396cb5b36
pybind/mgr/dashboard: various py3 fixes
...
Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-02-11 14:25:37 +08:00
Kefu Chai
936e720c01
vstart.sh: add comma in DASH_URLS and RESTFUL_URLS
...
Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-02-11 14:25:37 +08:00
Kefu Chai
5e34b7480c
mgr: import absolute_import to enforce absolute_import
...
to make sure new "import" statements in future in these files do not
assume relative import.
Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-02-11 14:12:16 +08:00
Kefu Chai
92af0732ea
pybind/mgr/restful: move global variable into context.py
...
otherwise we need to tackle with the circular import. it's not fatal, if
we can "import foo" in py2 and "from . import foo" in py3, respectively.
but we cannot unify them using "from . import foo", because the circular
reference issue. and conditionalize the import statement is ugly. so, i
think we'd better break the loop. so i am moving the "instance" variable
into its own file.
Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-02-11 14:12:16 +08:00
Kefu Chai
5f89243046
restful: various py3 fixes
...
Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-02-11 14:12:16 +08:00
Kefu Chai
c8baadf3c0
cmake: depend on the right version of python bindings
...
Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-02-11 14:12:16 +08:00
Kefu Chai
477595de48
vstart.sh: set PYTHONPATH correctly
...
it varies depending on the major version of the python we are using.
Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-02-11 14:12:16 +08:00
Kefu Chai
3b58a1c18c
vstart.sh: introduce get_cmake_variable()
...
Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-02-11 14:12:16 +08:00
Kefu Chai
8039c46d49
init-ceph: s/lib.2/lib.$MGR_PYTHON_VERSION_MAJOR/
...
we should not hardwire cython_modules's path to lib.2, it should be
cython_modules/lib.3 if ceph-mgr requires python3.
Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-02-11 14:12:15 +08:00
Kefu Chai
410ce76f62
mgr: load ceph_{logger,module} globally
...
no need to add them for each sub-interpreter. extensions are shared
among them.
Fixes: http://tracker.ceph.com/issues/22880
Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-02-11 14:12:15 +08:00
Kefu Chai
b09f754ecb
pybind/mgr: use relative import
...
* in python3, we cannot assume default relative import. instead, we should
be explicit. also, only import the `Module` and `StandbyModule` classes
from plugins, as they are what we are interested.
* and import urllib.parse in python3.
Fixes: http://tracker.ceph.com/issues/22880
Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-02-11 14:11:38 +08:00
Kefu Chai
91f83cc0a5
pybind/mgr: fix the TabError error
...
018-02-08 18:50:10.790 7fcfbb679700 -1 mgr[py] Module not found:
'dashboard'
2018-02-08 18:50:10.790 7fcfbb679700 -1 mgr[py] Traceback (most recent
call last):
File "/var/ceph/ceph/src/pybind/mgr/dashboard/__init__.py", line 2, in
<module>
from . module import Module # NOQA
File "/var/ceph/ceph/src/pybind/mgr/dashboard/module.py", line 1189
template = env.get_template("rgw_detail.html")
^
TabError: inconsistent use of tabs and spaces in indentation
Fixes: http://tracker.ceph.com/issues/22880
Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-02-11 14:10:00 +08:00
Kefu Chai
511fc9c4b2
Merge pull request #20378 from tchaikov/wip-os-perf-stat-in-ns
...
osd: check feature bits when encoding objectstore_perf_stat_t
Reviewed-by: John Spray <john.spray@redhat.com>
2018-02-11 09:53:40 +08:00
Kefu Chai
7bb4761d52
Merge pull request #20275 from badone/wip-osdmonitor-unused-function
...
mon/OSDMonitor: Comment out unused function
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Joao Eduardo Luis <joao@suse.de>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2018-02-11 09:52:10 +08:00
Kefu Chai
4c43c67d6d
Merge pull request #20371 from tchaikov/wip-admin_socket_output
...
test/admin_socket_output: add --vstart=path/to/asok option
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
2018-02-11 09:51:04 +08:00
Kefu Chai
7e36b630a0
Merge pull request #20227 from rzarzynski/wip-bs-final-aiocontexts
...
os/bluestore: mark derivatives of AioContext as final.
Reviewed-by: Sage Weil <sage@redhat.com>
2018-02-11 01:24:31 +08:00
Mykola Golub
7a2b56c28a
Merge pull request #20376 from dillaman/wip-22873
...
librbd: auto-remove trash snapshots when image is deleted
Reviewed-by: Mykola Golub <mgolub@suse.com>
2018-02-10 08:53:35 +02:00
Adam C. Emerson
ba5ce157bd
build: Use the right experimental library
...
Test whether we're building with libstdc++ or libc++.
Use stdc++filesystem if the former and c++experimental if the later.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2018-02-09 19:54:02 -05:00
Adam C. Emerson
b27e40d254
{client,test}: Explicitly initialize empty inode_t
...
Using an explicit {} initializer. This unbreaks Clang.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2018-02-09 15:59:46 -05:00
Jason Dillaman
82ef376e80
librbd: auto-remove trash snapshots when image is deleted
...
Fixes: http://tracker.ceph.com/issues/22873
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2018-02-09 13:34:55 -05:00
Kefu Chai
df8b1c2bc8
test/librados: s/invoke_result_t/result_of_t/
...
to workaround buggy libc++ implementation. see
https://cplusplus.github.io/LWG/issue2807 . we should switch to
invoke_result_t once issue2807 is fixed in the latest release of
libc++.
Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-02-10 00:06:24 +08:00
Igor Fedotov
2d78999451
os/bluestore: cleanup around ExtentList class.
...
Also move it out of bluestore_types.h.
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
2018-02-09 18:46:21 +03:00
Igor Fedotov
e0cd948298
os/bluestore: kill AllocExtent[Vector] to simplify code a bit
...
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
2018-02-09 18:46:21 +03:00
Igor Fedotov
774773e3ae
Merge pull request #20387 from ifed01/wip-ifed-fio-build-fix
...
test/fio: fix build failure caused by sequencer replacement.
2018-02-09 18:35:25 +03:00
John Spray
4e2748d3a4
Merge pull request #20043 from Rubab-Syed/configuration_setting_browser
...
mgr/dashboard: add configuration setting browser
Reviewed-by: John Spray <john.spray@redhat.com>
2018-02-09 15:22:51 +00:00
Jason Dillaman
30aed9f9de
Merge pull request #20389 from trociny/wip-cli_generic
...
qa/workunits/rbd: fix cli_generic test_purge for rbd default format 1
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2018-02-09 09:21:57 -05:00
Mykola Golub
57baca0166
qa/workunits/rbd/cli_generic: fix test_purge for rbd default format 1
...
Signed-off-by: Mykola Golub <mgolub@suse.com>
2018-02-09 16:04:43 +02:00
Mykola Golub
8079d23897
Merge pull request #20364 from Songweibin/wip-fix-test-rbd
...
test/rbd: cli_generic fails if v1 image format or deep-flatten disabled
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
2018-02-09 14:42:27 +02:00
Igor Fedotov
935a1bdb34
tools/ceph-objectstore-tool: do not fail on lack of OI_ATTR for an
...
object.
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
2018-02-09 15:00:07 +03:00
Igor Fedotov
7f768dbf62
test/fio: create superblock on mkfs to provide proper tools functioning
...
E.g. ceph-objectstore-tool requires that
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
2018-02-09 14:58:15 +03:00
Igor Fedotov
9f8ae668c1
test/fio: fix build failure caused by sequencer replacement.
...
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
2018-02-09 14:06:15 +03:00
Yan, Zheng
c822b3e257
mds: optimize getattr file size
...
Fixes: http://tracker.ceph.com/issues/22925
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
2018-02-09 18:46:05 +08:00
John Spray
e654f2832a
Merge pull request #20372 from tchaikov/wip-mgr-doc
...
doc/mgr: remove non user-facing code from doc
Reviewed-by: John Spray <john.spray@redhat.com>
2018-02-09 10:51:09 +01:00
Wido den Hollander
b7d0cab99e
mgr/zabbix: Implement health checks in Zabbix module
...
Should make it easier for users to see why the module is failing.
Signed-off-by: Wido den Hollander <wido@42on.com>
2018-02-09 09:57:41 +01:00
songweibin
21c3bc3e69
test/rbd: cli_generic fails if v1 image format or deep-flatten disabled
...
Fixes: http://tracker.ceph.com/issues/22950
Signed-off-by: songweibin <song.weibin@zte.com.cn>
2018-02-09 16:17:27 +08:00
Piotr Dałek
989abb0b4c
common/ConfUtils: check key before actually normalizing
...
Key normalization involves some copying and strlens, and these are
expensive.
Check if key contain whitespaces, normalize it only when it does.
Signed-off-by: Piotr Dałek <piotr.dalek@corp.ovh.com>
2018-02-09 08:57:19 +01:00
Kefu Chai
01d350f388
Merge pull request #20382 from tchaikov/wip-fix-ftbfs-store-test
...
test/store_test: fix FTBFS as Sequencer is removed
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
2018-02-09 14:39:49 +08:00
Kefu Chai
6e90be1ac9
check feature bits when encoding objectstore_perf_stat_t
...
OS_PERF_STAT_NS feature bit is added. it's sharing the same bit with
QOS_DMC.
Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-02-09 14:31:48 +08:00
huanwen ren
b1248273d6
client: fixup parallel calls to ceph_ll_lookup_inode() in NFS FASL
...
fixup parallel calls to ceph_ll_lookup_inode() in NFS FASL,
Because the original fuction does not have a global Lock to
ensure the atomicity of the lookup inode process,It eventually
caused an exception when the NFS-Ganesha FSAL module called
this interface in parallel,see the Bug report.
Fixes: http://tracker.ceph.com/issues/22683
Signed-off-by: huanwen ren <ren.huanwen@zte.com.cn>
2018-02-09 13:34:56 +08:00
Kefu Chai
3a7cac0684
test/store_test: fix FTBFS as Sequencer is removed
...
Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-02-09 13:05:25 +08:00
Kefu Chai
5757d6f118
Merge pull request #20294 from rzarzynski/wip-bs-drop-std_function
...
os/bluestore: avoid overhead of std::function in blob_t.
Reviewed-by: Kefu Chai <kchai@redhat.com>
2018-02-09 10:45:24 +08:00
Kefu Chai
24d1b2edb4
Merge pull request #19232 from socketpair/precision
...
mgr: increase time resolution of Commit/Apply OSD latencies.
Reviewed-by: Kefu Chai <kchai@redhat.com>
2018-02-09 10:44:27 +08:00