Commit Graph

114459 Commits

Author SHA1 Message Date
Michael Fritch
ed0074da2c
mgr/cephadm: use raw string during re.search
cephadmservice.py:348: DeprecationWarning: invalid escape sequence \:
    port = re.search('\:\d+\/', end_point)

Signed-off-by: Michael Fritch <mfritch@suse.com>
2020-08-21 10:03:05 -06:00
Alfonso Martínez
28ecbbde65 mgr/dashboard: fix API tests: Invalid URL: None/api/auth
Fixes: https://tracker.ceph.com/issues/47052
Signed-off-by: Alfonso Martínez <almartin@redhat.com>
2020-08-21 17:22:21 +02:00
Jason Dillaman
4e1633edfc librbd: flush requests could race past initiation of write ops
Now that IO is being processed by multiple threads, it's possible
that a write operation that was issued prior to a flush would not
have been started prior to the processing of the flush.

Fixes: https://tracker.ceph.com/issues/47050
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2020-08-21 10:37:41 -04:00
Jason Dillaman
1f28e5ffed librbd: reset collection state after move operation
A technical requirement of move operations requires that the collection
be reset to a known state before being used again.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2020-08-21 10:36:55 -04:00
Igor Fedotov
41823db09c os/bluestore: enable more flexible bluefs space management by default.
It turned out that we did't enable it when introduced this feature in
https://github.com/ceph/ceph/pull/29687.

Fixes: https://tracker.ceph.com/issues/47053

Signed-off-by: Igor Fedotov <ifedotov@suse.com>
2020-08-21 14:51:00 +03:00
Kefu Chai
c8bfc66f2d
Merge pull request #35789 from Reperator/fix-ceph-objectstore-tool-docs
doc/man/8/ceph-objectstore-tool.rst: remove duplicate lines

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-08-21 18:31:20 +08:00
Kefu Chai
344d964b94
Merge pull request #36742 from hulksmaaash/patch-2
doc/rados: remove statement that ISA plugin only works on Intel chips

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-08-21 18:26:46 +08:00
Sebastian Wagner
cb529acaf4
Merge pull request #36496 from Daniel-Pivonka/cephadm-44926
mgr/cephadm: rgw update period after realm, zone creation

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2020-08-21 11:40:17 +02:00
Sebastian Wagner
95042ecce8
Merge pull request #36716 from jmolmo/dashboard_ports_2
cephadm: Allow users to use a custom dashboard ssl port

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2020-08-21 11:39:52 +02:00
Lenz Grimmer
5b8d52e9d7
Merge pull request #36721 from ceph/47036-sass-colors-typescript
mgr/dashboard: use SASS colors in TypeScript

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Sebastian Krah <skrah@suse.com>
2020-08-21 11:12:33 +02:00
Lenz Grimmer
218d2df473
Merge pull request #36735 from rhcs-dashboard/fix-this-week-endpoint
mgr/dashboard: remove "This week/month/year" and "Today" time stamps of Grafana in dashboard

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2020-08-21 11:10:18 +02:00
Kefu Chai
d8bc9c7b09 test/pybind: remove object for testing after done with it
* add vertical spacing for better readability
* remove object for testing after done with it

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-08-21 16:41:31 +08:00
Kefu Chai
90dbe6b3ba test/pybind: label test_rados tests with attributes
so we can pick the tests selectively. currently, some features are not
supported by crimson. but we will cover more and more of them. so
attaching different labels to tests cases helps us to run these tests
selectively.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-08-21 16:41:31 +08:00
Kefu Chai
6ad87dbbdc qa/workunits/rados: pass options down to test_rados.py
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-08-21 16:41:31 +08:00
Sebastian Wagner
fc9da48226
Merge pull request #36740 from varshar16/wip-fix-nfs-bug-47009
qa/tasks/nfs: Change the mds name and delete created nfs clusters

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.
2020-08-21 09:58:12 +02:00
Kefu Chai
2e029fa331
Merge pull request #36694 from shun-s/fix-linger-op-stray
osdc: fix lingerOp stray

Reviewed-By: Josh Durgin <jdurgin@redhat.com>
2020-08-21 15:33:14 +08:00
Avan Thakkar
f76d56c45f mgr/dashboard: remove "This week/month/year" and "Today" time stamps of Grafana in dashboard
Fixes: https://tracker.ceph.com/issues/47049

Signed-off-by: Avan Thakkar <athakkar@redhat.com>
2020-08-21 12:37:35 +05:30
Kefu Chai
e2031418d4
Merge pull request #36465 from majianpeng/bluefs-avoid-flush-much-data
os/bluestore/BlueRocksEnv: Avoid flushing too much data at once.

Reviewed-by: Mark Nelson <mnelson@redhat.com>
Reviewed-by: Adam Kupczyk <akucpzyk@redhat.com>
2020-08-21 09:57:27 +08:00
Kefu Chai
268cbe5bb7
Merge pull request #36593 from gregsfortytwo/wip-46914
mon: mark pgtemp messages as no_reply more consistenly in preprocess_…

Reviewed-by: Neha Ojha <nojha@redhat.com>
2020-08-21 09:53:25 +08:00
Kefu Chai
03891c82c2
Merge pull request #36675 from tchaikov/wip-fix-option-typo
common/options: fix a typo in option description

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-By: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2020-08-21 09:52:40 +08:00
Kefu Chai
565f6ed3f1
Merge pull request #35613 from changchengx/str_list
use for_each_substr to avoid redundant operation by calling get_str_set

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-08-21 09:51:28 +08:00
Kefu Chai
f2b13ff87c
Merge pull request #36573 from changchengx/osdmonitor
mon: use string_veiw to glimpse string and remove unused variable

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-08-21 09:50:11 +08:00
Kefu Chai
ec73fea99e
Merge pull request #36680 from tchaikov/wip-mgr-disk-predict
pybind/mgr/diskprediction_cloud: remove mgr-diskprediction-cloud

Reviewed-By: Josh Durgin <jdurgin@redhat.com>
Reviewed-By: Zac Dover <zac.dover@gmail.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
2020-08-21 09:46:54 +08:00
Kefu Chai
e9e4af403c
Merge pull request #36534 from changchengx/formatter
common/Formatter: don't construct string if string_view work

Reviewed-By: Kefu Chai <kchai@redhat.com>
2020-08-21 09:45:03 +08:00
Kefu Chai
afaf5913ac
Merge pull request #36420 from qwren/qat-compressor
compressor: fix compile error for QAT

Reviewed-By: Kefu Chai <kchai@redhat.com>
2020-08-21 09:42:18 +08:00
Robbie Williamson
ccee814ffc doc/rados: remove statement that ISA plugin only works on Intel chips
ISA-L supports aarch64 (Arm), not just Intel processors, as does Ceph (see #32171).

Signed-off-by: Robbie Williamson <robbie.williamson@arm.com>
2020-08-21 08:32:53 +08:00
Michael Fritch
87ccbad671
mgr/cephadm: use supplied CephadmDaemonSpec
69ed3d9cff refactored `_create_daemon()` which obsoleted any need to
search for the NFSServiceSpec in the SpecStore

Signed-off-by: Michael Fritch <mfritch@suse.com>
2020-08-20 14:14:21 -06:00
Michael Fritch
170220875d
mgr/cephadm: move NFS config/create func
preserve func order seen in the impl. for the other services

Signed-off-by: Michael Fritch <mfritch@suse.com>
2020-08-20 14:06:15 -06:00
Greg Farnum
73a014fc2c mon: mark pgtemp messages as no_reply more consistently in preprocess_pgtemp
If a message is forwarded, it's conceivable the leader's and peon's evaluation
will disagree about whether the message is useful or not, which could result
in the leader ignoring it and the peon having a dangling forwarded message.
Fix this by marking the op as no_reply whenever ignoring it.

Fixes:  https://tracker.ceph.com/issues/46914

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
2020-08-20 19:31:52 +00:00
Varsha Rao
5c4e659067 qa/tasks/nfs: Instead of 'orch ls' use 'orch ps'
Signed-off-by: Varsha Rao <varao@redhat.com>
2020-08-20 15:18:31 +00:00
Jason Dillaman
34f539d8af rbd: delay parsing of default kernel map options
It now connects to the cluster to retrieve any global config
overrides before processing the default map options.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2020-08-20 10:40:38 -04:00
Jason Dillaman
1527dcfa6d rbd: 'list' action should connect to cluster before querying config
This will allow global config overrides for the max concurrent ops to
be applied prior to listing the images.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2020-08-20 10:40:38 -04:00
Jason Dillaman
596d892e60 rbd: drop querying of RBD default features
These will be computed internally by librbd using any potential
global configuration overrides.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2020-08-20 10:40:38 -04:00
Jason Dillaman
96f05a7956 rbd: delay determination of default pool name
Wait until after the CLI has connected to the cluster and therefore
has received all global configuration overrides.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2020-08-20 10:40:37 -04:00
Jason Dillaman
f6c6887fe7 rbd: let librados finish initializing the global context
librados will retrieve a bootstrap config update from the MONs
after connecting and then finish initializing the context. In
general, non-primitive config options cannot be updated after
initialization is complete. This prevents the rbd CLI from
supporting non-primitive config overrides from the MON.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2020-08-20 10:35:30 -04:00
Jason Dillaman
313aeaa55d mon/MonClient: apply MON config before finishing bootstrap
In general, non-primitive config options cannot be updated after
the service threads have been marked as running. In librados, this
happens after the MonClient bootstrap process. However, the configs
received from the MON were applied in a separate thread which can
race with librados marking the service threads as running.

Now the received MON configs will be applied within the context of
the bootstrap function call instead of deferring to a separate
thread.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2020-08-20 10:35:29 -04:00
Varsha Rao
572f0aeceb qa/suites/rados/test_orch_cli: Change mds name
As MDS name should not start with numeric digit.

Signed-off-by: Varsha Rao <varao@redhat.com>
2020-08-20 14:28:57 +00:00
Varsha Rao
049afe5a7e qa/tasks/nfs: Delete nfs cluster after exports are created
Fixes: https://tracker.ceph.com/issues/47009
Signed-off-by: Varsha Rao <varao@redhat.com>
2020-08-20 14:27:25 +00:00
Sebastian Wagner
281dce82c0
Merge pull request #36477 from p-se/fix-downstream-alertmanager
cephadm: Support custom alertmanager container


Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2020-08-20 14:24:43 +02:00
Patrick Seidensal
658230048b cephadm: deploying of monitoring images partially broken
Deployment of monitoring images has been broken in the context of
ceph-salt. Due to the removal of the registries in
/etc/containers/registries.conf, all images need to be provided
qualified.

Fixes: https://tracker.ceph.com/issues/46726

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
2020-08-20 14:21:40 +02:00
Juan Miguel Olmo Martínez
08c4a53e79
cephadm: Allow users to use a custom dashboard ssl port
This modification allows the user to create a new bootstrap cluster using a predefined SSl port for the dashboard.
If firewall is enabled, any new manager daemon deployed in new hosts will take care of open the required ports for all the services enabled in the manager.

Two new parameters for cephadm tool (aka binary or standalone):
Command bootstrap:
--ssl-dashboard-port SSL_DASHBOARD_PORT
                      Port number used to connect with dashboard using SSL
Command deploy:
--tcp-ports TCP_PORTS
                      List of tcp ports to open in the host firewall

Signed-off-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
2020-08-20 13:56:59 +02:00
Ramana Raja
f84d22832a
Merge pull request #35756 from ShyamsundarR/tr-46163
mgr/volumes: Use snapshot root directory attrs when creating clone root

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
2020-08-20 16:53:11 +05:30
Rishabh Dave
4022e2ba7d cephfs: allow only "good" characters
Allow only [A-Za-z0-9-_.] characters for FS, volume, subvolume and
subvolume group names and add test for the same.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2020-08-20 15:34:02 +05:30
Sebastian Wagner
35b0261818
Merge pull request #36485 from adk3798/cephadm-44252
mgr/cephadm: mgr or mds scale-down should prefer non-active daemons

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2020-08-20 11:18:26 +02:00
Yan, Zheng
df7e9aa42b qa/workunits/fs: add test for subvolume
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
2020-08-20 11:10:19 +08:00
Yan, Zheng
63da28d6a8 mds: don't move inode with nlink > 1 to global snaprealm if it's in subvolume
Fixes: https://tracker.ceph.com/issues/46074
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
2020-08-20 11:10:19 +08:00
Yan, Zheng
55cc3f7d7d mds: disallow hardlink across subvolume
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
2020-08-20 11:10:18 +08:00
Yan, Zheng
53348ab67f mds: disallow across subvolume rename
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
2020-08-20 11:10:18 +08:00
Yan, Zheng
34c6b4437a mds: disallow creating snapshot on descendent directory of subvolume
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
2020-08-20 11:10:18 +08:00
Yan, Zheng
8d531680cd mds: add vxattr that marks/clears subvolume flag
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
2020-08-20 11:10:08 +08:00