Commit Graph

24967 Commits

Author SHA1 Message Date
Samuel Just
505bebbb3c OSD: check for is_stopping after locking osd_lock or heartbeat_lock
Signed-off-by: Samuel Just <sam.just@inktank.com>
2013-03-21 18:37:34 -07:00
Samuel Just
9d076a0edb OSD: lookup_lock_raw_pg is dead
Signed-off-by: Samuel Just <sam.just@inktank.com>
2013-03-21 18:37:34 -07:00
Samuel Just
e41554da14 OSD: rename timer to tick_timer
Only used for scheduling ticks - we should keep it
that way.

Signed-off-by: Samuel Just <sam.just@inktank.com>
2013-03-21 18:37:34 -07:00
Samuel Just
30b7a151f3 OSD: move backfill_request_timer cleanup to OSDService::shutdown
Signed-off-by: Samuel Just <sam.just@inktank.com>
2013-03-21 18:37:34 -07:00
Samuel Just
264cd3efca ReplicatedPG,OSD: move dequeueing into on_shutdown
Signed-off-by: Samuel Just <sam.just@inktank.com>
2013-03-21 18:37:34 -07:00
Samuel Just
eb8dd0d404 PG: clarify PG::deleting comment
Signed-off-by: Samuel Just <sam.just@inktank.com>
2013-03-21 18:37:34 -07:00
Sage Weil
7118df89cd Merge pull request #135 from ceph/wip-4519
mon: AuthMonitor: delete auth_handler while increasing max_global_id

Reviewed-by: Sage Weil <sage@inktank.com>
2013-03-21 18:25:01 -07:00
Joao Eduardo Luis
71ec9c6bd5 mon: AuthMonitor: delete auth_handler while increasing max_global_id
By not deleting and setting NULL the session's auth_handler, we could
hit a scenario in which we'd end up dispatching a previously-wait-listed
auth message and we wouldn't start its auth session.

This only happened when increasing max_global_id via Paxos (in which case
we would wait-list the message) and would only be noticeable when running
with cephx disabled.

Fixes: #4519

Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
2013-03-22 01:21:00 +00:00
Samuel Just
42a71c1dd8 FileJournal: quieter debugging on journal scanning
Signed-off-by: Samuel Just <sam.just@inktank.com>
Reviewed-by: David Zafman <david.zafman@inktank.com>
(cherry picked from commit 6740d512ac)
2013-03-21 18:09:58 -07:00
Samuel Just
6740d512ac FileJournal: quieter debugging on journal scanning
Signed-off-by: Samuel Just <sam.just@inktank.com>
Reviewed-by: David Zafman <david.zafman@inktank.com>
2013-03-21 18:03:14 -07:00
John Wilkins
7e8cc57dee doc: Fixed some typos.
Signed-off-by: John Wilkins <john.wilkins@inktank.com>
2013-03-21 17:04:54 -07:00
Josh Durgin
56183ebc86 Merge pull request #128 from dalgaaf/wip-da-pylint
Fix some python issues

Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
2013-03-21 16:41:34 -07:00
Sage Weil
7a4b880f5d Merge pull request #132 from ceph/wip-libcephfs-fix
libcephfs: fix ceph_get_osd_crush_location

Reviewed-by: Sage Weil <sage@inktank.com>
2013-03-21 16:16:31 -07:00
Noah Watkins
76985007fd libcephfs: fix ceph_get_osd_crush_location
(a) Allow NULL buffer when length is zero to get the target buffer
length. (b) fix edge case where buffer length is the exact size
required.

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
2013-03-21 15:32:39 -07:00
Noah Watkins
a72aaff66c test: add ceph_rename test
Triggers bug in ticket #4517

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
2013-03-21 12:54:17 -07:00
John Wilkins
4939301706 Merge pull request #127 from alram/master
[doc] undisplayed notes, tips, and important sections

Reviewed-by: John Wilkins <john.wilkins@inktank.com>
2013-03-21 11:21:05 -07:00
Sage Weil
ebfb81a3a3 Merge pull request #120 from ceph/wip-msgr-acks
msg/Pipe: fix seq handshake on reconnect

Reviewed-by: Greg Farnum <greg@inktank.com>
2013-03-21 11:14:29 -07:00
Danny Al-Gaaf
7ed0be1971 rados.py: remove unnecessary semicolon
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-21 18:47:46 +01:00
Danny Al-Gaaf
cffc2d508b rados.py: fix bad indention
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-21 18:46:16 +01:00
Danny Al-Gaaf
9496622255 rados.py: remove lenght modifier 'l' on format string
Remove length modifier 'l' since it's ignored for python.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-21 18:43:48 +01:00
Danny Al-Gaaf
d81d2c02d9 rados.py: fix 'Rados' has no member 'name'
Lets store rados_id from __init__ and use this instead of 'name'.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-21 18:23:25 +01:00
Danny Al-Gaaf
eed8d532c6 rados.py: add missing space after ','
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-21 17:14:02 +01:00
Danny Al-Gaaf
e2df59e245 ceph-create-keys: rename log to LOG since it's a constants
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-21 17:13:26 +01:00
Gary Lowell
d67eee1d11 Merge branch 'next' 2013-03-21 00:40:16 -07:00
Sage Weil
17d4a7c457 doc/release-notes: v0.59
Signed-off-by: Sage Weil <sage@inktank.com>
2013-03-20 22:11:15 -07:00
Sage Weil
541cd3c64b msg/Pipe: fix seq handshake on reconnect
We go to the trouble to exchange our seq numbers during the handshake, but
the bit that then avoids resending old messages was broken because we
already requeue_sent() before we get to this point.  Fix it by discarding
queued items (in the high prio slot) that we don't need to resend, and
adjust out_seq as needed.

Drop the optional arg to requeue_sent() now that it is unused.

Signed-off-by: Sage Weil <sage@inktank.com>
2013-03-20 21:52:21 -07:00
Alexandre Marangone
ac9fa4336e Fix tips in documentation
Use of .. tip: instead of .. tip:: resulting in content not
being displayed.

Signed-off-by: Alexandre Marangone <alexandre.marangone@inktank.com>
2013-03-20 21:17:53 -07:00
Alexandre Marangone
cd96dbe25b Fix important in documentation
Use of .. important: instead of .. important:: resulting in content
not being displayed.

Signed-off-by: Alexandre Marangone <alexandre.marangone@inktank.com>
2013-03-20 21:15:08 -07:00
Alexandre Marangone
330515780e Fix notes in documentation
Use of .. note: instead of .. note:: resulting in content not
being displayed

Signed-off-by: Alexandre Marangone <alexandre.marangone@inktank.com>
2013-03-20 21:10:55 -07:00
Sage Weil
f21411423b Merge pull request #126 from alram/master
Update Chef deployment documentation

Reviewed-by: Sage Weil <sage@inktank.com>
2013-03-20 17:07:11 -07:00
Alexandre Marangone
e485471765 Update Chef deployment documentation
Signed-off-by: Alexandre Marangone <alexandre.marangone@inktank.com>
2013-03-20 16:49:49 -07:00
Sage Weil
131dce6e8e Merge pull request #124 from ceph/wip-4509
mon: DataHealthService: shutdown mon if failed to obtain disk stats

Reviewed-by: Sage Weil <sage@inktank.com>
2013-03-20 16:17:51 -07:00
Joao Eduardo Luis
97fd7b610d mon: DataHealthService: log to derr instead if we're about to shutdown
Otherwise the message would -- or could -- be lost.

Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
2013-03-20 20:51:06 +00:00
Joao Eduardo Luis
51d62d325c mon: DataHealthService: shutdown mon if failed to obtain disk stats
Being unable to run a ::statfs() may be a symptom of something bigger.

We want to cleanly shutdown the monitor ASAP if such thing happens.

Fixes: #4509

Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
2013-03-20 20:49:20 +00:00
Sage Weil
06ae519672 Merge pull request #123 from dalgaaf/wip-da-sca-misc-1
Some smaller misc fixes

Reviewed-by: Sage Weil <sage@inktank.com>
2013-03-20 10:12:06 -07:00
Danny Al-Gaaf
5bf0331a97 client/Client.cc: handle error if _lookup() fails
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-20 17:08:42 +01:00
Danny Al-Gaaf
fc41684e99 qa/workunits/direct_io/test_sync_io.c: add proper error handling
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-20 16:56:03 +01:00
Danny Al-Gaaf
a8a5683e6d test_short_dio_read.c: add proper error handling
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-20 16:37:37 +01:00
Danny Al-Gaaf
f9c108c798 mds/Locker.cc: prefer prefix ++operator for iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-20 16:15:06 +01:00
Danny Al-Gaaf
4151630c58 mount/mount.ceph.c: remove unused variable
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-20 16:15:00 +01:00
Sage Weil
9f37b49c5c Merge pull request #122 from dalgaaf/wip-da-ceph-disk-1
More fixes for ceph-disk

Reviewed-by: Sage Weil <sage@inktank.com>
2013-03-20 06:48:36 -07:00
Danny Al-Gaaf
87691dc46e ceph-disk: cast output of subprocess.Popen() to str()
Cast output of subprocess.Popen() to str() to be able to use
str.split() and str.splitlines() without warnings from pylint.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-20 14:36:58 +01:00
Sage Weil
45d5544c3f Merge pull request #121 from ceph/wip-4448
mon: Monitor: clearer output on error during attempt to convert store

Reviewed-by: Sage Weil <sage@inktank.com>
2013-03-20 06:33:18 -07:00
Joao Eduardo Luis
c29812cdaf mon: Monitor: clearer output on error during attempt to convert store
Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
2013-03-20 13:31:14 +00:00
Danny Al-Gaaf
3575feb7d2 ceph-disk: fix adjust_symlink() replace 'journal' with 'target'
Replace 'journal' variable with 'target' since journal doesn't
exist in this function.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-20 14:02:28 +01:00
Danny Al-Gaaf
a27cb85b21 ceph-disk: fix adjust_symlink() replace 'canonical' with 'path'
Replace 'canonical' variable with 'path' since canonical doesn't
exist in this function.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-20 14:01:02 +01:00
Danny Al-Gaaf
6d3247b5c0 ceph-disk: there is no os.path.lstat use os.lstat
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-20 13:56:23 +01:00
Danny Al-Gaaf
97b4f8d66b ceph-disk: remove unused variable key from prepare_journal_dev()
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-20 13:30:21 +01:00
Danny Al-Gaaf
9daf6cfce2 ceph-disk: fix except to catch OSError
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-20 13:27:27 +01:00
Danny Al-Gaaf
0ada43f79d ceph-disk: add missing space after >> operator
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-20 13:15:36 +01:00