Ceph Dashboard replaces the original checkbox with a fancy replacement
using the pseudo selector "::before" inside the <label> tag. When the
fancy replacement checkbox is clicked, it actually triggers a click on
the label of the checkbox. `clickCheckbox` does the same.
Removed `moveClick` as it was used to perform an action that the user
would not be able to perform, namely clicking on the checkbox instead of
the checkboxes' label. It was also used for cases where it was not
necessary to be used for, hence the replacement `clickCheckbox` has been
introduced. It checks if the argument passed to it is of type `checkbox`
or `label`. If it is of type `label`, the label will be clicked. If it
is of type `checkbox`, the corresponding `label` is determined and
clicked. This replaces the old implementation with a solution that has
an easy to understand purpose. It also prevents every false application.
This method is designed to be used on all checkboxes of Ceph Dashboard.
Fixes: https://tracker.ceph.com/issues/40693
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
and migrate `protractor.conf.js` to use async/await.
Fixes: https://tracker.ceph.com/issues/40693
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
Avoid creating of list of LVs in different methods of the same module
and resue them.
Fixes: https://tracker.ceph.com/issues/37490
Signed-off-by: Rishabh Dave <ridave@redhat.com>
* check libfmt version instead of the exisistence of chrono.h, as
libfmt merged fmt/time.h into fmt/chrono.h since v 6.0, while in
libfmt v5.3, fmt/chrono.h did not provide all the necessary bits
for fmt::to_format(..., const tm&). see also
a939c75956
and https://github.com/fmtlib/fmt/blob/master/ChangeLog.rst
* use fmt API instead of libc API for getting `localtime()`, it's
more C++ friendly than plain `localtime_r()`
Signed-off-by: Kefu Chai <kchai@redhat.com>
test/librbd: set nbd timeout due to newer kernels defaulting it on
Reviewed-by: Mike Christie <mchristi@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
* v2 api: remove variadic futures. let's be in sync with upstream.
* warn if the returned future is ignored. this helps us to catch
bugs and to improve the readability of the code -- we need to
explicitly ignore a future if we want to. and ideally, we should
document the reason why a future is ignored.
Signed-off-by: Kefu Chai <kchai@redhat.com>
When handshake failed before client receive server_cookie, don't renew
client_cookie, or the session will be reset and pending messages will be
lost.
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Tests need to introspect whether the connection is closed correctly.
For normal users, ms_handle_reset() will notify them when a connection is
closed by messenger.
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
There's no need to return a futurized bool from is_connected() if we are
holding ConnectionRef from the same core. Also add the missing const
qualifier.
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
we will need to talk to BlueStore, and currently `ceph::os::Collection`
only works with `CyanStore`, so a wrapper around `ceph::os::Collection`
is added. we can subclass it to adapt to CyanStore and to BlueStore.
the underlying concrete `FuturizedStore` classes are responsible to
cast `FuturizedCollection` to their own `Collection` type if they
want to access the interface not exposed by `FuturizedCollection`.
Signed-off-by: chunmei Liu <chunmei.liu@intel.com>
prepare for the futurized Collection, which will be an abstract
interface allowing us to talk to BlueStore with one of its concrete
subclass.
Signed-off-by: Kefu Chai <kchai@redhat.com>
allowing to open the image and do some maintenance operations,
and returning -ENODEV for ops that require data pool.
Fixes: https://tracker.ceph.com/issues/41206
Signed-off-by: Mykola Golub <mgolub@suse.com>
after making `open_collection()` return a future, we don't need to chain
the body of `PGMeta::load()` after `omap_get_values()`. instead we can
lift it.
Signed-off-by: Kefu Chai <kchai@redhat.com>
This script processes GitHub backport PRs, checking for proper cross-linking
with a Redmine Backport tracker issue and, if a PR is merged and properly
cross-linked, it can optionally resolve the tracker issue and correctly
populate the "Target version" field.
The script takes a single positional argument, which is optional. If the
argument is an integer, it is assumed to be a GitHub backport PR ID (e.g. "28549").
In this mode ("single PR mode") the script processes a single GitHub backport
PR and terminates.
If the argument is not an integer, or is missing, it is assumed to be a
commit (SHA1 or tag) to start from. If no positional argument is given, it
defaults to the tag "BRI", which might have been added by the last run of the
script. This mode is called "scan merge commits mode".
In both modes, the script scans a local git repo, which is assumed to be
in the current working directory. In single PR mode, the script will work
only if the PR's merge commit is present in the current branch of the local
git repo. In scan merge commits mode, the script starts from the given SHA1
or tag, taking each merge commit in turn and attempting to obtain the GitHub
PR number for each.
For each GitHub PR, the script interactively displays all relevant information
(NOTE: this includes displaying the GitHub PR and Redmine backport issue in
web browser tabs!) and prompts the user for her preferred disposition.
Signed-off-by: Nathan Cutler <ncutler@suse.com>
