Kefu Chai
c54bcf660f
crimson/net: move implementation of dtor into .cc file
...
ceph_assert() is expanded into 5 lines of code. it'd help to speed up
the compiling a little bit.
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-22 13:07:48 +08:00
Kefu Chai
9a248da3fe
crimson/mon: add mon::Client::wait_for_config()
...
just for waiting for monmap and config from mon. crimson-osd needs this
for populating settings related to booting and transport layer before it
starts.
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-22 13:07:48 +08:00
Kefu Chai
264e710a37
crimson/mon: fallback to msgr v2 for unbound msgr
...
so, for instance, if we want to connect to monitor without bind to any
address, we can try to use the v2 addresses advertised in monmap or
local settings, instead of being unable to connect to mon because we are
using an `entity_addr_t::TYPE_NONE` address which is returned by
`entity_addrvec_t::front()` if the addrvec is empty.
see also AsyncMessenger::should_use_msgr2().
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-22 13:07:48 +08:00
Kefu Chai
51c8ffff6d
crimson/mon: print out entity addr type when non peer address matches
...
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-22 13:07:48 +08:00
Casey Bodley
3cdd3d18a1
Merge pull request #39010 from mdw-at-linuxbox/wip-master-barbicany2021
...
qa/tasks/barbican.py: fix year2021 problem
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2021-01-21 17:42:38 -05:00
Casey Bodley
e36b72f4f0
Merge pull request #39008 from mdw-at-linuxbox/wip-master-vaultunzip
...
qa/tasks/vault.py: unzip: try harder to find a working unzip.
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2021-01-21 17:42:09 -05:00
Adam C. Emerson
78ece45796
rgw: Since we aren't using these anyway
...
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2021-01-21 17:17:39 -05:00
Jason Dillaman
8d86249a8e
Merge pull request #38988 from orozery/librbd-crypto-empty-copyup
...
librbd: don't restart empty copyups in crypto layer
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2021-01-21 15:07:01 -05:00
Jason Dillaman
21bc198918
Merge pull request #38985 from orozery/rbd-nbd-luks2-blksize
...
tools/rbd-nbd: change block size to 4K for LUKS2 images
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2021-01-21 15:06:20 -05:00
Jason Dillaman
410c40ee53
Merge pull request #38983 from orozery/qa-qemu-rbd-encryption
...
qa/tasks/rbd: increase image size of encrypted disks
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2021-01-21 15:05:30 -05:00
Nizamudeen A
3c2e8e4f9a
mgr/dashboard: Fix for incorrect validation in rgw user form
...
The rgw users create form doesnt validate the username correctly if the username is a tenated one. For eg. Consider there is a user called tenate$sample. Now I am trying to create another user and I entered tenate$sample as username. But it doesn't async validate the username as existing. Instead it just shows the green tick and once the submit button is clicked it'll show the user as existing.
Fixes: https://tracker.ceph.com/issues/48907
Signed-off-by: Nizamudeen A <nia@redhat.com>
2021-01-22 00:38:41 +05:30
Marcus Watts
b1fac2224b
qa/tasks/barbican.py: fix year2021 problem
...
The expiration timestamp was hard-coded as
2020-12-31T19:14:44.180394
which is now in the past. Instead, use a timestamp
90 minutes in the future.
Fixes: https://tracker.ceph.com/issues/48919
Signed-off-by: Marcus Watts <mwatts@redhat.com>
2021-01-21 13:31:27 -05:00
Marcus Watts
ed664a4d0b
qa/tasks/vault.py: unzip: try harder to find a working unzip.
...
The existing logic uses "python -m zipfile" to unzip files.
This will (most likely) fail on CentOS 8-Stream , where python
defaults to 'unset' (see man unversioned-python).
So: try harder: try unzip, python3, and python in that order,
to find something that can unzip files.
Fixes: https://tracker.ceph.com/issues/48921
Signed-off-by: Marcus Watts <mwatts@redhat.com>
2021-01-21 12:35:01 -05:00
Harish Munjulur
b32153a4ed
Merge pull request #38691 from soumyakoduri/lc_fixes
...
rgw/lc: Fix use-after-free in RGWLC::process
2021-01-21 09:25:06 -08:00
Harish Munjulur
dee214ea11
Merge pull request #38465 from IlsooByun/fix_lc_infinite_loop
...
rgw: lc: fix infinite loop in bucket_lc_prepare
2021-01-21 09:24:51 -08:00
Venky Shankar
beb00bd2a8
Merge pull request #36698 from vshankar/wip-cephfs-mirror-tests
...
cephfs-mirror: teuthology task and tests
2021-01-21 09:46:51 +05:30
Venky Shankar
a7d1fd6ae8
Merge pull request #35993 from vshankar/wip-fs-mirror-interface
...
pybind/mgr/mirroring: directory snapshot mirror support
2021-01-21 09:45:41 +05:30
Brad Hubbard
4f07cffb8b
osd/OSDMap: An empty bucket or OSD is not an error
...
Fixes: https://tracker.ceph.com/issues/48884
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
2021-01-21 13:15:23 +10:00
Brad Hubbard
3dc72a0be0
test/osd: Verify print_osd_utilization output
...
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
2021-01-21 13:15:20 +10:00
Sage Weil
9eef1bcced
qa/suites/rados/cephadm/upgrade: avoid allow_ptrace with old cephadm
...
Older cephadm is not smart enough to not combine --cap-add=SYS_PTRACE
and --privileged, which some version of podman cannot handle.
For upgrades, leave off the allow_ptrace behavior since we may be starting
on one of those old versions.
See also https://tracker.ceph.com/issues/46429
Fixes: https://tracker.ceph.com/issues/48142
Signed-off-by: Sage Weil <sage@newdream.net>
2021-01-20 16:40:17 -06:00
Casey Bodley
d42db5f434
Merge pull request #38991 from cbodley/wip-rgw-perm-state-valgrind
...
rgw: fix reference to temporary in perm_state ctor
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2021-01-20 17:05:30 -05:00
Sage Weil
59576d17f7
Merge pull request #38817 from ideepika/fix-interactive-error
...
qa/tasks/ceph: do not update info.yaml if ctx.archive is not set
2021-01-20 15:21:15 -06:00
Neha Ojha
173ba0a239
Merge pull request #38941 from sseshasa/wip-48906-async-rec-min-cost-fix
...
osd: Remove override for osd_async_recovery_min_cost for mclock profiles
Reviewed-by: Sunny Kumar <sunkumar@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-01-20 12:37:44 -08:00
Igor Fedotov
6159a692d9
os/bluestore: be more protective in _deferred_queue
...
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
2021-01-20 22:57:15 +03:00
Matt Benjamin
9773f0a538
rgw: avoid (rgw_file) illegal access to stack memory
...
Fixes: https://tracker.ceph.com/issues/48941
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2021-01-20 13:46:58 -05:00
Sage Weil
0ee2b2b807
mgr/devicehealth: fix 'device monitoring on|off' return value
...
Signed-off-by: Sage Weil <sage@newdream.net>
2021-01-20 12:35:23 -06:00
Casey Bodley
b421128951
Merge pull request #38987 from cbodley/wip-qa-rgw-valgrind-supp-tls
...
valgrind: update suppression for _dl_allocate_tls
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-01-20 13:22:56 -05:00
Or Ozeri
cd6f3ccd33
librbd: don't restart empty copyups in crypto layer
...
This commit fixes a bug where an empty parent copyup is restarted indefinitely.
Signed-off-by: Or Ozeri <oro@il.ibm.com>
2021-01-20 18:43:47 +02:00
Casey Bodley
ae8db357f7
Merge pull request #38966 from rzarzynski/wip-qa-rgw-no-valgrind-early-exit
...
qa/task/rgw: instruct Valgrind to don't exit on first error.
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2021-01-20 11:08:38 -05:00
Casey Bodley
db17daf3b0
valgrind: update suppression for _dl_allocate_tls
...
in the rgw suite, there's an extra allocate_dtv() call in this stack.
add a ... to match it
<stack>
<frame>
<ip>0x4C3321A</ip>
<obj>/usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so</obj>
<fn>calloc</fn>
<dir>/builddir/build/BUILD/valgrind-3.16.0/coregrind/m_replacemalloc</dir>
<file>vg_replace_malloc.c</file>
<line>760</line>
</frame>
<frame>
<ip>0x4012341</ip>
<obj>/usr/lib64/ld-2.28.so</obj>
<fn>allocate_dtv</fn>
</frame>
<frame>
<ip>0x4012CD1</ip>
<obj>/usr/lib64/ld-2.28.so</obj>
<fn>_dl_allocate_tls</fn>
</frame>
<frame>
<ip>0x101C7F32</ip>
<obj>/usr/lib64/libpthread-2.28.so</obj>
<fn>pthread_create@@GLIBC_2.2.5</fn>
</frame>
<frame>
<ip>0x6F14E64</ip>
<obj>/usr/lib64/ceph/libceph-common.so.2</obj>
<fn>Thread::try_create(unsigned long)</fn>
</frame>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2021-01-20 11:03:21 -05:00
Joao Eduardo Luis
9e81a5dfc5
cephadm: fix stuff
...
Signed-off-by: Joao Eduardo Luis <joao@suse.com>
2021-01-20 13:20:47 -01:00
Joao Eduardo Luis
4fa175e967
cephadm: annotate variable type for mypy
...
mypy was complaining about the type of the variable being None, later on
on assignment with an int.
Signed-off-by: Joao Eduardo Luis <joao@suse.com>
2021-01-20 13:20:47 -01:00
Joao Eduardo Luis
5178403833
cephadm/test: support context class
...
Signed-off-by: Joao Eduardo Luis <joao@suse.com>
2021-01-20 13:20:47 -01:00
Joao Eduardo Luis
c785dc5679
cephadm: have context handle config options
...
Signed-off-by: Joao Eduardo Luis <joao@suse.com>
2021-01-20 13:20:46 -01:00
Joao Eduardo Luis
b56eb958df
cephadm: drop ctx class from where we don't need it
...
Signed-off-by: Joao Eduardo Luis <joao@suse.com>
2021-01-20 13:20:46 -01:00
Joao Eduardo Luis
bc256983c1
cephadm/bootstrap: move mon net discovery to function
...
Signed-off-by: Joao Eduardo Luis <joao@suse.com>
2021-01-20 13:20:46 -01:00
Joao Eduardo Luis
13addf6f54
cephadm: don't forget ipv6 behind
...
Fixes a bug introduced earlier in the patchset. It's just too hard to go
back and fix it up with the right commit.
Signed-off-by: Joao Eduardo Luis <joao@suse.com>
2021-01-20 13:20:46 -01:00
Joao Eduardo Luis
b5e9c81321
cephadm: split-off config work on bootstrap
...
Signed-off-by: Joao Eduardo Luis <joao@suse.com>
2021-01-20 13:20:46 -01:00
Joao Eduardo Luis
4d30ee7e5d
cephadm: split-off dashboard setup on bootstrap
...
Signed-off-by: Joao Eduardo Luis <joao@suse.com>
2021-01-20 13:20:46 -01:00
Joao Eduardo Luis
9ef0a67926
cephadm: split-off ssh preparations on bootstrap
...
Signed-off-by: Joao Eduardo Luis <joao@suse.com>
2021-01-20 13:20:45 -01:00
Joao Eduardo Luis
60329c6be3
cephadm: split-off mgr creation
...
Signed-off-by: Joao Eduardo Luis <joao@suse.com>
2021-01-20 13:20:45 -01:00
Joao Eduardo Luis
1dd2dcc8ed
cephadm: split mon prepare and create
...
Signed-off-by: Joao Eduardo Luis <joao@suse.com>
2021-01-20 13:20:45 -01:00
Joao Eduardo Luis
adc58849fe
cephadm: move configuration out of the way
...
Signed-off-by: Joao Eduardo Luis <joao@suse.com>
2021-01-20 13:20:45 -01:00
Joao Eduardo Luis
6cab3f02aa
cephadm/bootstrap: spin-off waiting for mon
...
Signed-off-by: Joao Eduardo Luis <joao@suse.com>
2021-01-20 13:20:45 -01:00
Joao Eduardo Luis
6dec4d5008
cephadm: split some of bootstrap to other functions
...
Signed-off-by: Joao Eduardo Luis <joao@suse.com>
2021-01-20 13:20:45 -01:00
Joao Eduardo Luis
b3b6639b7f
cephadm: fix linting/types issues
...
Signed-off-by: Joao Eduardo Luis <joao@suse.com>
2021-01-20 13:20:45 -01:00
Joao Eduardo Luis
3afec2ab30
cephadm: split main into an init function
...
Signed-off-by: Joao Eduardo Luis <joao@suse.com>
2021-01-20 13:20:44 -01:00
Joao Eduardo Luis
da309f21da
cephadm: introduce context, drop global variables
...
Signed-off-by: Joao Eduardo Luis <joao@suse.com>
2021-01-20 13:20:38 -01:00
Or Ozeri
114a7cfb2e
qa/tasks/rbd: increase image size of encrypted disks
...
This commit increases the rbd image sizes in used by qemu to support the storage requirements of the luks encryption header.
Signed-off-by: Or Ozeri <oro@il.ibm.com>
2021-01-20 16:08:17 +02:00
Or Ozeri
988039f6ec
tools/rbd-nbd: change block size to 4K for LUKS2 images
...
This commit sets the NBD device block size to 4K for images encrypted using LUKS2 (whose sector size is by default 4K(.
Signed-off-by: Or Ozeri <oro@il.ibm.com>
2021-01-20 15:37:16 +02:00