Commit Graph

91911 Commits

Author SHA1 Message Date
Kefu Chai
f6cc40a5d2
Merge pull request #24920 from wjwithagen/wjw-fix-build-symbolic
cmake: do not pass -B{symbolic,symbolic-functions} to linker on FreeBSD

Reviewed-by: Kefu Chai <kchai@redhat.com>
2018-11-05 17:15:48 -08:00
Sage Weil
01d31d471d Merge PR #24814 into master
* refs/pull/24814/head:
	Merge PR #24804 into nautilus
	include/types: fixed compile warning for signed/unsigned comparison
	osd/PrimaryLogPG: uncommitted dup ops should respond with logged return code
	osd/PrimaryLogPG: propagate error return codes on object copy_get ops
	osd/PGLog: optionally record error return codes for extra_reqids
	osd/osd_types: include PG log return codes in object copy data

Reviewed-by: Neha Ojha <nojha@redhat.com>
2018-11-05 15:51:14 -06:00
Matt Benjamin
e636a56c50 rgw: move keystone secrets from ceph.conf to files
Permits setting restrictive permissions on these secrets.

Fixes: http://tracker.ceph.com/issues/36621

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2018-11-05 16:49:06 -05:00
Alfredo Deza
52ddb69813 ceph-volume tests install ceph-ansible's requirements.txt dependencies
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2018-11-05 16:25:20 -05:00
Mykola Golub
7d2ffd981b rbd: show info about mirror instance in image mirror status output
It is particularly useful when running multiple rbd-mirror instances
in Active-Passive or Active-Active mode.

Signed-off-by: Mykola Golub <mgolub@suse.com>
2018-11-05 22:34:39 +02:00
Jason Dillaman
b3fc22ebe3
Merge pull request #24891 from iridescent-rsy/fix-return-value
rbd: make sure the return-value 'r' will be returned

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2018-11-05 12:17:06 -05:00
Jason Dillaman
e450360f08
Merge pull request #24893 from iridescent-rsy/need-to-return
rbd: return error code when the source and distination namespace are different

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2018-11-05 12:16:07 -05:00
Lenz Grimmer
a4bc8872ee
Merge pull request #24823 from Devp00l/wip-issue-36615
[RFC] mgr/dashboard: Cleanup of OSD list methods

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Patrick Nawracay <pnawracay@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2018-11-05 17:12:54 +01:00
Stephan Müller
4971b2d5ff mgr/dashboard: Simplify OSD disabled action test
Fixes: https://tracker.ceph.com/issues/36616
Signed-off-by: Stephan Müller <smueller@suse.com>
2018-11-05 14:36:49 +01:00
Lenz Grimmer
de159f6d53
Merge pull request #24475 from votdev/feature_36193
mgr/dashboard: Audit REST API calls

Reviewed-by: Patrick Nawracay <pnawracay@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
2018-11-05 13:52:09 +01:00
Tiago Melo
d6b057bdcd mgr/dashboard: Fix duplicate tasks
In certain situations a new task is already in the current summary before we
manually push it to the running task list.
Since we were not checking that, at the end of the operation we would have 2
entries for the same task and that would be displayed in the UI.

Signed-off-by: Tiago Melo <tmelo@suse.com>
2018-11-05 12:31:34 +00:00
Jason Dillaman
bbb0fc0f17
Merge pull request #24856 from leseb/spec-rbd-mirror
spec: add missing rbd mirror bootstrap directory

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2018-11-05 07:23:42 -05:00
Lenz Grimmer
7095dae0e3
Merge pull request #24892 from p-na/pna-cleanup-pool-form-simpl
mgr/dashboard: Simplification of PoolForm method

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2018-11-05 13:11:38 +01:00
Willem Jan Withagen
60c6e70cc8 cmake: do not pass -B{symbolic,symbolic-functions} to linker on FreeBSD
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
2018-11-05 11:27:16 +01:00
Sébastien Han
8c8d60d3c7 spec: add missing rbd mirror bootstrap directory
Currently /var/lib/ceph/bootstrap-rbd-mirror is absent, which means we
need to create it manually in order to pool the
client.bootstrap-rbd-mirror key.

Signed-off-by: Sébastien Han <seb@redhat.com>
2018-11-05 11:06:07 +01:00
Volker Theile
22e07ff1a4 mgr/dashboard: Audit REST API calls
Fixes: https://tracker.ceph.com/issues/36193

Enable API auditing with 'ceph dashboard set-audit-api-enabled true' (default is false). If you do not want to log the request payload, then disable it via 'set-audit-api-log-payload false' (default is true).

Example output:
2018-10-08 10:25:21.850994 mgr.x [INF] [DASHBOARD] from='https://[::1]:44410' path='/api/auth' method='POST' user='None' params='{"username": "admin", "password": "***", "stay_signed_in": false}'

Signed-off-by: Volker Theile <vtheile@suse.com>
2018-11-05 10:56:28 +01:00
Mykola Golub
472abc2ed9 test/librbd: migration supporting namespace tests
Signed-off-by: Mykola Golub <mgolub@suse.com>
2018-11-03 19:36:44 +02:00
Jason Dillaman
8931f8cd14
Merge pull request #23190 from maxcuttins/master
doc: rewrote the iscsi-target-cli installation

Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2018-11-03 08:48:30 -04:00
Mykola Golub
96c9e8bfde rbd-mirror: provide instance_id for ceph service status
Signed-off-by: Mykola Golub <mgolub@suse.com>
2018-11-03 10:20:42 +02:00
Mykola Golub
e337963534 librbd: API to get info which rbd-mirror daemon is mirroring image
Signed-off-by: Mykola Golub <mgolub@suse.com>
2018-11-03 10:20:42 +02:00
Mykola Golub
31453519ee cls/rbd: new methods to get image mirror instance info
Signed-off-by: Mykola Golub <mgolub@suse.com>
2018-11-03 10:20:42 +02:00
Patrick Donnelly
a71a984a39
Merge PR #24870 into master
* refs/pull/24870/head:
	client: request next osdmap for blacklisted client

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2018-11-02 16:59:13 -07:00
Massimiliano Cuttini
6df20fafa8 doc: rewrote the iscsi-target-cli installation
Rewrote the documentation in a step-by-step style, reformatted using RST's
titles instead of bolds, added installation of GIT if needed, added
installation of compilers needed for tcmu-runner

Signed-off-by: Massimiliano Cuttini <massimiliano.cuttini@phoenixweb.it>
2018-11-02 17:52:01 -04:00
Casey Bodley
cf9a0a28ea
Merge pull request #24895 from votdev/feature_36681
rgw: Return tenant field in bucket_stats function

Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2018-11-02 16:28:26 -04:00
Mykola Golub
a1d8e1263a
Merge pull request #24864 from dillaman/wip-36659
rbd-mirror: update mirror status when stopping

Reviewed-by: Mykola Golub <mgolub@suse.com>
2018-11-02 22:10:01 +02:00
Mykola Golub
f59ec53a81
Merge pull request #24836 from dillaman/wip-26951
rbd: support namespaces for image migration

Reviewed-by: Mykola Golub <mgolub@suse.com>
2018-11-02 22:06:53 +02:00
Gregory Farnum
f081b10060
Merge pull request #24812 from gregsfortytwo/wip-readable-fails-on-empty
test: make readable.sh fail if it doesn't run anything

Reviewed-by:  Sage Weil <sage@redhat.com>
2018-11-02 13:02:17 -07:00
Yuri Weinstein
a24793ed6c
Merge pull request #22923 from ceph/wip-fix-latest-distro
qa/tests: update links for centos latest to point to 7.5

Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
2018-11-02 12:30:41 -07:00
Jason Dillaman
c9a44e8359
Merge pull request #24897 from trociny/wip-36683
test/rbd_mirror: race in TestMockImageMap.AddInstancePingPongImageTest

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2018-11-02 14:34:53 -04:00
Mykola Golub
c796aecc2e test/rbd_mirror: race in TestMockImageMap.AddInstancePingPongImageTest
Remove a context from peer_ack_ctxs before completing to avoid a race
with a listener inserting a new one.

Fixes: http://tracker.ceph.com/issues/36683
Signed-off-by: Mykola Golub <mgolub@suse.com>
2018-11-02 19:47:55 +02:00
Volker Theile
9440776f06 rgw: Return tenant field in bucket_stats function
Fixes: https://tracker.ceph.com/issues/36681

Signed-off-by: Volker Theile <vtheile@suse.com>
2018-11-02 13:26:10 +01:00
John Spray
a3e1a3e048 pybind: update python callers of force flags
Signed-off-by: John Spray <john.spray@redhat.com>
2018-11-02 06:57:43 -04:00
John Spray
98c2511334 mon: convert remaining confirmation flags to CephBool
Signed-off-by: John Spray <john.spray@redhat.com>
2018-11-02 06:57:43 -04:00
John Spray
525623b6cd ceph_argparse: introduce CephBool arguments
This replaces use of CephChoices for cases like
--yes-i-really-really-mean-it.

It's a relatively invasive change, because both
client and server need to handle backward compatibility:
 - Clients are easy, they just cope with the server's
   use of CephChoices/CephString with a few special case
   strings to recognise --yes-i-really-mean-it and similar
 - Servers are harder, they have to convert CephBool arguments
   into a similar CephChoices argument that older clients will
   understand.  This involves propagating feature flags into
   some code paths that couldn't see them before.

Signed-off-by: John Spray <john.spray@redhat.com>
2018-11-02 06:57:42 -04:00
John Spray
6c1e4b825c test: remove quirky argparse case
This relied on a behaviour where positional
arguments could be omitted if the subsequent
argument was of a different type.

This was pretty weird, and in any case the reweight-by-utilization
command is likely to go away soon.

Signed-off-by: John Spray <john.spray@redhat.com>
2018-11-02 06:57:42 -04:00
John Spray
0da65ed851 mgr,mon: use CephChoices for confirmation flags
...so that arg parsing can rely on strings satisfying
a "doesn't start with --" convention.

Signed-off-by: John Spray <john.spray@redhat.com>
2018-11-02 06:57:41 -04:00
John Spray
61d2ad0c38 test: add cases for CLI's --key=val style
Signed-off-by: John Spray <john.spray@redhat.com>
2018-11-02 06:57:41 -04:00
John Spray
cc7a12f78c mon: remove dead "cluster_snap" command
This had existed in a disabled state (by having an empty
string for the cli/rest field in the command definition)
for a long time.  Now that that field is gone, we don't
have a concept of "disabled" commands any more, so
let's just clean up this loose end.

Signed-off-by: John Spray <john.spray@redhat.com>
2018-11-02 06:57:41 -04:00
John Spray
e8775e8f30 pybind: enable --keyword=arguments in ceph_argparse
This is a simple implementation that treats anything
that matches the "--X=Y" pattern as separate from
positional arguments.

This works well for optional arguments.  Mandatory
arguments still need to be specified positionally,
or the parsing code will think the command's
argument description has not been satisfied.

Signed-off-by: John Spray <john.spray@redhat.com>
2018-11-02 06:57:41 -04:00
John Spray
bd548c0e61 ceph.in: some cleanups
Add some docstrings to functions, remove some
dead code and places where e.g. dicts were used
unncessary.

Signed-off-by: John Spray <john.spray@redhat.com>
2018-11-02 06:57:40 -04:00
John Spray
917fc3d085 ceph.in: misc cleanups
Get this pyflakes-clean ahead of making
changes for keyword arguments.

Signed-off-by: John Spray <john.spray@redhat.com>
2018-11-02 06:57:40 -04:00
John Spray
7734e9fa88 common: remove unused 'avail' field from commands
This was introduced for the now-removed ceph-rest-api
gateway.  It enabled limiting certain commands
to be CLI-only or rest-only, but in practice almost
everything just said "cli,rest" here.

Now that ceph-rest-api is gone, let's remove this
field.

The CLI client code already tolerated the absence
of this field, so older CLI clients will not mind.

Signed-off-by: John Spray <john.spray@redhat.com>
2018-11-02 06:57:40 -04:00
John Spray
f82372fe2e mon: fix help string for osd crush rule create-replicated
Signed-off-by: John Spray <john.spray@redhat.com>
2018-11-02 06:57:40 -04:00
Shiyang Ruan
e2d50a774b rbd: return error code when the source and distination namespace are different.
Signed-off-by: Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>
2018-11-02 17:51:41 +08:00
Patrick Nawracay
27ee675d3c mgr/dashboard: Simplification of PoolForm method
Signed-off-by: Patrick Nawracay <pnawracay@suse.com>
2018-11-02 08:57:37 +01:00
Shiyang Ruan
5af59e2444 rbd: make sure the return-value 'r' will be returned.
Signed-off-by: Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>
2018-11-02 13:44:57 +08:00
Kefu Chai
a7bb772e11
Merge pull request #24616 from tchaikov/wip-wip-librados-3
librados: split C++ and C APIs into different source files

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Nathan Cutler <ncutler@suse.com>
2018-11-02 10:44:04 +08:00
Patrick Donnelly
f981e10c5f
Merge PR #24555 into master
* refs/pull/24555/head:
	doc: document optional timeout argument for `cache drop`
	mds: make timeout parameter optional for "cache drop"

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2018-11-01 14:58:23 -07:00
Patrick Donnelly
e9fbb47150
Merge PR #24747 into master
* refs/pull/24747/head:
	client: add new routine to get fscid from a ceph_mount

Reviewed-by: John Spray <john.spray@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2018-11-01 14:53:25 -07:00
Josh Durgin
1d832401f4
Merge pull request #24868 from liewegas/wip-doc-fix
doc/rados/operations/crush-map-edits: fix 'take' syntax

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2018-11-01 14:52:24 -07:00