avoid starting identifiers with two underscores, these names are
reserved for C/C++ compiler and standard library.
Signed-off-by: Kefu Chai <kchai@redhat.com>
The Windows build is hitting linking errors after
bumping the Boost version to 1.75. The issue is that Boost
is now setting the zlib dependecy using INTERFACE_LINK_LIBRARIES,
which means that it's no longer located using the standard
"find_package" mechanism.
In order for the linker to locate zlib, we'll add it to the
linker search path.
[1] https://github.com/boostorg/boost_install/issues/47
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
Gives SeaStore ownership over SegmentManager and rearranges mkfs/mount.
Replaces mkfs_config_t/mount_config_t with config params.
Signed-off-by: Samuel Just <sjust@redhat.com>
Otherwise, initing those values needs to be done after the SegmentManager
instance is mounted. This is simpler for now.
Signed-off-by: Samuel Just <sjust@redhat.com>
FuturizedStore::create_new_collection isn't supposed to actually
create the collection. See OSD::mkfs for a usage example.
Signed-off-by: Samuel Just <sjust@redhat.com>
There's really no reason to cache the decoded representation here since
the meta keys are only accessed during startup, mkfs. This approach is
much simpler.
Signed-off-by: Samuel Just <sjust@redhat.com>
The Windows build scripts try to use the build dir before
actually creating it.
We'll have to move up the "mkdir" command a few lines.
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
otherwise we have to put something like
local_conf().template get_val<T>(name)
which is not quite convenient or readable.
Signed-off-by: Kefu Chai <kchai@redhat.com>
we should not redefine a default argument of a method of templated class.
this change also address following error from clang:
../src/crimson/os/seastore/onode_manager/staged-fltree/node.cc:621:30: error: template parameter redefines default argument
template <bool FORCE_MERGE = false>
^
../src/crimson/os/seastore/onode_manager/staged-fltree/node.h:438:32: note: previous default template argument defined here
template <bool FORCE_MERGE = false>
^
Signed-off-by: Kefu Chai <kchai@redhat.com>
merge_stage and merge_size are structured bindings, they are not
variables. so cannot be captured without defining variables in
capture list.
Signed-off-by: Kefu Chai <kchai@redhat.com>
The standalone tests need parameters to be passed as ceph_args to
override defaults.
This was just doubling the number of standalone tests being run in each rados
run with no effect!
Signed-off-by: Neha Ojha <nojha@redhat.com>
mclock_scheduler is now the default and some of these tests need to be modified
to run well with it. Continue using wpq until
https://tracker.ceph.com/issues/50574 is addressed.
Signed-off-by: Neha Ojha <nojha@redhat.com>
