Commit Graph

100249 Commits

Author SHA1 Message Date
Ricardo Marques
02bc599f3f
Merge pull request #29192 from ceph/dependabot/npm_and_yarn/src/pybind/mgr/dashboard/frontend/lodash-4.17.13
build(deps): bump lodash from 4.17.11 to 4.17.13 in /src/pybind/mgr/dashboard/frontend

Reviewed-by: Tiago Melo <tmelo@suse.com>
2019-07-26 12:41:33 +01:00
Jason Dillaman
7ccf0b3229 pybind/mgr: don't log exception when cannot find RBD task by id
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-07-26 07:01:59 -04:00
myoungwon oh
5badc4bd47 osd: fix wrong arguments when dropping refcount
Signed-off-by: Myoungwon Oh <omwmw@sk.com>
2019-07-26 19:40:31 +09:00
Ricardo Marques
1043154123
Merge pull request #29198 from rhcs-dashboard/e2e-ci
mgr/dashboard: run e2e tests against prod build (jenkins job)

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2019-07-26 11:22:00 +01:00
Ricardo Marques
0bcbcb9d01
Merge pull request #29280 from rhcs-dashboard/bucket-tests
mgr/dashboard: RGW bucket creation when no placement target received

Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
2019-07-26 10:39:14 +01:00
Volker Theile
2c95333903 mgr/dashboard: Various UI issues related to CephFS
* Check if data is accessible, otherwise set grafanaId to undefined.
* Catch errors in 'Clients' tab and stop loading spinner. Display ViewCacheStatus Exception.
* Render the 'Enabled' column using the checkIcon cell template as other lists do.

Fixes: https://tracker.ceph.com/issues/40925

Signed-off-by: Volker Theile <vtheile@suse.com>
2019-07-26 11:29:41 +02:00
Jianpeng Ma
44dbc2eec5 os/bluestore: avoid unnecessary notify.
Add parameter count waiting list for Onode::flush to avoid unnecessary
notify.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
2019-07-26 15:46:29 +08:00
songweibin
5e8c412e63 common,tools: make sure the destination buffer can handle the size of the string
fix klocwork issues:
Width is not specified for 's' conversion specifier.
This can result in an overflow of the buffer
provided in argument 3 of a call to 'sscanf'

Signed-off-by: songweibin <song.weibin@zte.com.cn>
2019-07-26 14:27:02 +08:00
songweibin
1428c6e447 src/tools: initialize variables before the goto statement
CID 172143 (#15 of 15): Branch past initialization (PW.BRANCH_PAST_INITIALIZATION)
1. branch_past_initialization:
2. name_at_decl_position: variable "oid" (declared at line 220)
3. name_at_decl_position: variable "exkeys" (declared at line 241)
4. name_at_decl_position: variable "exvals" (declared at line 242)
5. name_at_decl_position: variable "safe" (declared at line 278)

Signed-off-by: songweibin <song.weibin@zte.com.cn>
2019-07-26 14:27:02 +08:00
songweibin
b737cc4248 src/mount: check before dereference buf
CID 180671 (#1 of 1): Dereference null return value (NULL_RETURNS)

Signed-off-by: songweibin <song.weibin@zte.com.cn>
2019-07-26 14:27:02 +08:00
songweibin
e027012117 src/crush: check before dereference out2
CID 174874 (#2 of 2): Dereference after null check (FORWARD_NULL)
30. var_deref_op: Dereference null pointer out2.

Signed-off-by: songweibin <song.weibin@zte.com.cn>
2019-07-26 14:27:02 +08:00
Kefu Chai
d5ed1eaa1b
Merge pull request #29264 from rjfd/wip-dashboard-fix-qa-rbd
mgr/dashboard: qa: fix RBD test when matching error strings

Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-07-26 14:25:35 +08:00
Xiaoxi CHEN
c9ff6ab4eb Client: unlink dentry for inode with llref=0
when client get notification from MDS that a file has been deleted(via
getting CEPH_CAP_LINK_SHARED cap for inode with nlink = 0), if the client
hasnt touch the inode in the past, the ll_ref will be zero.

In previous code, we only call Client::unlink when ll_ref > 0, which is wrong
and will leave the dn in cache, keeping the caps and resulting the inode stays
in stray till the dn cache is dropped by kernel.

Under certain workload(write intensive and rotate intensive), this issue can cause
stray stacking to 100k+ and causeing huge space "leaking".

Fixes: http://tracker.ceph.com/issues/40960

Signed-off-by: Xiaoxi CHEN <xiaoxchen@ebay.com>
2019-07-25 19:32:53 -07:00
Mark Nelson
f7376c0754
Merge pull request #28597 from markhpc/wip-bs-ind-cache
os/bluestore: Refactor Bluestore Caches
2019-07-25 20:48:19 -05:00
Yan, Zheng
6e9e3757be mds: execute PurgeQueue on_error handler in finisher
Fix: https://tracker.ceph.com/issues/40695
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
2019-07-26 09:36:53 +08:00
Sage Weil
9ecfc55ead Merge PR #28847 into master
* refs/pull/28847/head:
	doc/mgr/telemetry: update
	mgr/telemetry: move contact info to an 'ident' channel
	mgr/telemetry: accept channel list to 'telemetry show'
	mgr/telemetry: always generate new report for 'telemetry show'
	mgr/telemetry: add 'device' channel and call out to devicehealth module
	mgr/telemetry: add telemetry channel 'device'
	mgr/telemetry: add separate channels

Reviewed-by: Dan Mick <dmick@redhat.com>
2019-07-25 20:15:17 -05:00
Sage Weil
34c741efbf Merge PR #29130 into master
* refs/pull/29130/head:
	os/bluestore: Reduce unnecessary wakeups.
	os/bluestore: Reduce unnecessary wakeups.

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Igor Fedotov <ifedotov@suse.com>
2019-07-25 20:14:59 -05:00
Sage Weil
d87d271d41 Merge PR #29221 into master
* refs/pull/29221/head:
	mon/OSDMonitor: do not clobber pending xinfo during boot
	osd/OSDMap: add is_dead() helper
	mon/OSDMonitor: 'osd down ... --definitely-dead'
	osd: send MOSDMarkMeDead when we are marked down
	mon/OSDMonitor: implement MOSDMarkMeDead handling
	mon/OSDMonitor: set dead_epoch for immediate failure (ECONNREFUSED)
	osd/OSDMap: add dead_epoch to xinfo

Reviewed-by: Samuel Just <sjust@redhat.com>
2019-07-25 20:14:46 -05:00
Sage Weil
b41dea60a3 Merge PR #29323 into master
* refs/pull/29323/head:
	rocksdb: enable rocksdb_rmrange=true by default

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2019-07-25 20:14:01 -05:00
Patrick Donnelly
67f81c7214
Merge PR #29300 into master
* refs/pull/29300/head:
	doc: fix youtube channel url
	doc: fix urls in posix.rst

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-07-25 16:19:24 -07:00
Patrick Donnelly
09b905a450
Merge PR #28874 into master
* refs/pull/28874/head:
	ceph-mds: dump all info of ceph_file_layout, InodeStoreBase, frag_info_t, inode_t

Reviewed-by: Zheng Yan <zyan@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-07-25 16:13:57 -07:00
Patrick Donnelly
2adf929f80
Merge PR #29103 into master
* refs/pull/29103/head:
	mgr/volumes: add `ceph fs subvolumegroup getpath` command

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-07-25 16:12:31 -07:00
Patrick Donnelly
aba6e6d76e
Merge PR #29166 into master
* refs/pull/29166/head:
	mds: Reorganize class members in Capability header

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
2019-07-25 16:10:51 -07:00
Patrick Donnelly
7d32369cab
Merge PR #29149 into master
* refs/pull/29149/head:
	cephfs-shell: Fix flake8 E302 blank line error
	cephfs-shell: Fix flake8 indentation error

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-07-25 16:07:48 -07:00
Patrick Donnelly
fe1abce20b
Merge PR #28860 into master
* refs/pull/28860/head:
	mds: Move scalar type initializations of CDir data members to its header
	mds: Reorganize class members in CDir header

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
2019-07-25 16:05:19 -07:00
Patrick Donnelly
19c724c1d6
qa: wait for MDS to come back after removing it
Fixes: http://tracker.ceph.com/issues/40967
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2019-07-25 14:42:34 -07:00
Sage Weil
7f89617b64 mon/OSDMonitor: do not clobber pending xinfo during boot
If we have a pending xinfo change and also process a boot message, we
should not throw out the pending xinfo change.

This triggers when you mark an osd down and it sends both a MOSDMarkMeDead
and a new MOSDBoot message in quick succession: the first message sets
dead_epoch but the boot message processing clobbers it.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-07-25 15:55:35 -05:00
Sage Weil
b75e17159b osd/OSDMap: add is_dead() helper
Signed-off-by: Sage Weil <sage@redhat.com>
2019-07-25 15:55:35 -05:00
Sage Weil
095ddc3ede mon/OSDMonitor: 'osd down ... --definitely-dead'
Like 'osd down', but we also set dead_epoch.  Should only be used if we
know the process/host is already completely dead and unresponsive.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-07-25 15:55:35 -05:00
Jason Dillaman
ea0a9adc88
Merge pull request #29036 from mikechristie/rbd-nbd-add-nl-resize
rbd-nbd: add nl resize

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
2019-07-25 16:06:47 -04:00
Patrick Donnelly
2d47f3ebf8
Merge PR #28955 into master
* refs/pull/28955/head:
	doc: Update mount CephFS index

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-07-25 11:01:27 -07:00
Sage Weil
3968d564c5 Merge PR #29111 into master
* refs/pull/29111/head:
	qa/mgr/progress: Update the test suite for progress module

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-07-25 12:44:24 -05:00
Sage Weil
091ef61ff8 osd: send MOSDMarkMeDead when we are marked down
Signed-off-by: Sage Weil <sage@redhat.com>
2019-07-25 12:24:25 -05:00
Sage Weil
82bd0ba939 mon/OSDMonitor: implement MOSDMarkMeDead handling
Allow updates to the dead_epoch in osd_xinfo, so that the OSD can inform
us that they know they are down (as of a particular epoch).

Signed-off-by: Sage Weil <sage@redhat.com>
2019-07-25 12:24:25 -05:00
Sage Weil
e82bd5136a mgr/telemetry: obscure entity_name with a salt
Signed-off-by: Sage Weil <sage@redhat.com>
2019-07-25 12:20:52 -05:00
Jason Dillaman
9bdc376c55 pybind/mgr: handle duplicate rbd task commands
The 'ceph' CLI will duplicate commands within teuthology to test
the MONs idempotency. This shouldn't be required for the MGR module,
but we can keep a fixed set of completed tests to handle this
possible command replay.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-07-25 12:58:55 -04:00
Varsha Rao
4c0b2ac887 mds: Move inline functions with loops or switch statements to CInode.cc
Signed-off-by: Varsha Rao <varao@redhat.com>
2019-07-25 12:08:22 -04:00
Varsha Rao
2ef2bf6e82 mds: Reorganize class members in CInode header
Fixes: https://tracker.ceph.com/issues/40787
Signed-off-by: Varsha Rao <varao@redhat.com>
2019-07-25 12:07:49 -04:00
Sage Weil
9fd65934de doc/mgr/telemetry: update
Signed-off-by: Sage Weil <sage@redhat.com>
2019-07-25 10:47:07 -05:00
Sage Weil
35c273c9c3 mgr/telemetry: move contact info to an 'ident' channel
Signed-off-by: Sage Weil <sage@redhat.com>
2019-07-25 10:46:55 -05:00
Sage Weil
07cc88431a rocksdb: enable rocksdb_rmrange=true by default
Signed-off-by: Sage Weil <sage@redhat.com>
2019-07-25 10:10:02 -05:00
Kefu Chai
b3abfe4812
Merge pull request #29117 from tchaikov/wip-mgr-set_health_checks-unicode
mgr: check for unicode passed to "set_health_checks()"

Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-07-25 23:03:00 +08:00
Sage Weil
ed1f8b98d3 Merge PR #29320 into master
* refs/pull/29320/head:
	os/bluestore: remove unused arg to _get_deferred_op()

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
2019-07-25 09:52:33 -05:00
Yuri Weinstein
633a3fa8ae
Merge pull request #29282 from yuriw/wip-yuriw-upgrade-rwg-splits-master
qa/tests: added rgw into upgrade sequence to improve coverage - splits
2019-07-25 07:16:24 -07:00
Sage Weil
58d02762ad os/bluestore: remove unused arg to _get_deferred_op()
Fixes: http://tracker.ceph.com/issues/40918
Signed-off-by: Sage Weil <sage@redhat.com>
2019-07-25 09:13:25 -05:00
Jason Dillaman
63a8f6c2c3 qa: test case for new rbd background tasks
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-07-25 08:58:37 -04:00
Jason Dillaman
e87aff5a90 pybind/mgr: rbd tasks now provide a dict to the progress events
This dict will include an origin key fixed to 'rbd_support' as well
as pool and image references.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-07-25 08:58:37 -04:00
Jason Dillaman
b99ae27d49 pybind/mgr: mark progress events as failed if an error occurs
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-07-25 08:58:37 -04:00
Jason Dillaman
d78ddaabdf pybind/mgr: support marking progress events as failed
The failed events can also include a failure message to indicate
the reason for the failure.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-07-25 08:58:37 -04:00
Jason Dillaman
b7a826df9f pybind/mgr: new 'rbd task' background task management
Fixes: http://tracker.ceph.com/issues/40621
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-07-25 08:58:37 -04:00