Commit Graph

101267 Commits

Author SHA1 Message Date
Neha Ojha
f93b48a786 doc/dev/developer_guide/index.rst: add youtube ref for Getting Started
Signed-off-by: Neha Ojha <nojha@redhat.com>
2019-08-16 12:52:12 -07:00
Casey Bodley
a282cfaafa
Merge pull request #29448 from cbodley/wip-41045
rgw: datalog/mdlog trim commands loop until done

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
2019-08-16 15:52:11 -04:00
Ernesto Puerta
1e07237d92
mgr/dashboard: clean-up tox and unit tests
Refactor CMake add_tox_test to automatically add py27 and/or py3 to
provided toxenvs.

Refactor tox.ini:
- Remove requirements-{py27,py3}.txt, as python release dependant
packages can be handled with PEP 508 syntax.
- Remove develepment dependencies from requirements.
- Move pycodestyle settings to separate section.
- Add flake8 check and other checkers (rst, naming, etc). Some of them
are commented out for future clean-ups (Ceph trackers have been opened)
- Pycodestyle removed, as flake8 is a wrapper for pycodestyle.
- Add instafail plugin to report failures immediately
- Add timeout plugin to limit max run time (sometimes test_tasks hangs)
- Remove unused dependencies (lru_cache, pluggy)

Test and code linting fixes:
- Unused imports
- Fixes to HACKING.rst

Doc:
- Update HACKING.rst

Add conftest.py to mock imported modules (rados, rbd, cephfs), and mock
also rados Error and OSError Exceptions.

Fixes: https://tracker.ceph.com/issues/40487
Fixes: https://tracker.ceph.com/issues/41152
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
2019-08-16 19:17:27 +02:00
Sage Weil
3d295cb407 Merge PR #29548 into master
* refs/pull/29548/head:
	osd: add device_id to list_devices to help get smart info easily

Reviewed-by: Sage Weil <sage@redhat.com>
2019-08-16 11:39:13 -05:00
Kefu Chai
b4989dc434
Merge pull request #29709 from rzarzynski/wip-osd-no-mds-pglsparent
osd: remove orphan include after PGLSParentFilter.

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-08-16 23:29:07 +08:00
Casey Bodley
91eef6712a radosgw-admin: 'mdlog trim' loops until done
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2019-08-16 11:28:22 -04:00
Casey Bodley
b9af497b2a radosgw-admin: 'datalog trim' takes shard-id and loops until done
Fixes: https://tracker.ceph.com/issues/41045

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2019-08-16 11:28:22 -04:00
Casey Bodley
fd618763c5
Merge pull request #29695 from cbodley/wip-41300
rgw: RGWSI_User_Module filters '.buckets' objects out of user listing

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
2019-08-16 11:21:12 -04:00
Radoslaw Zarzynski
2228b7f12b objclass, osd: improve const-correctness of PGLSFilter.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2019-08-16 10:58:55 -04:00
Radoslaw Zarzynski
9c1bb6a055 common: add bl::contents_equal() override for void* + size_t.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2019-08-16 10:58:55 -04:00
Radoslaw Zarzynski
6c581965e8 osd: refactor manufacturing of PGLSFilter.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2019-08-16 10:58:53 -04:00
Radoslaw Zarzynski
295ce538ea osd: don't carry PGLSFilter between multiple ops in MOSDOp.
Currently result of executing multiple PG listing operations
in single MOSDOp – if PGLSFilter is being used – depends on
the order in the sequence. To exemplify:

  [ CEPH_OSD_OP_PGNLS, CEPH_OSD_OP_PGNLS_FILTER ]

may bring different result for CEPH_OSD_OP_PGNLS than

  [ CEPH_OSD_OP_PGNLS_FILTER, CEPH_OSD_OP_PGNLS ].

This happens because ..._PGNLS_FILTER sets up PGLSFilter which
is used also by plain ..._PGNLS.

The commit changes that. After the filter is set-up separately
for each interested operation in MOSDOp.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2019-08-16 10:58:23 -04:00
Casey Bodley
f0575a7144
Merge pull request #26787 from soumyakoduri/bucket_name_validation
[rgw]:Validate bucket names as per revised s3 spec

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2019-08-16 10:53:54 -04:00
Casey Bodley
4b0eec368c
Merge pull request #29515 from ivancich/wip-clean-up-reset-stats
rgw: housekeeping of reset stats operation in radosgw-admin and cls back-end

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>
2019-08-16 10:21:02 -04:00
Casey Bodley
fa38718e6f
Merge pull request #28904 from ZVampirEM77/wip-s3website-fix
rgw: fix the bug of rgw not doing necessary checking to website configuration

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2019-08-16 10:20:24 -04:00
Casey Bodley
5b0ef90265
Merge pull request #29215 from tianshan/fix_list_with_delimiter
rgw: fix list bucket with delimiter wrongly skip some special keys

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
2019-08-16 10:19:50 -04:00
Casey Bodley
cb725cb679
Merge pull request #29369 from tianshan/fix_realm_watch
rgw: fix potential realm watch lost

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2019-08-16 10:18:27 -04:00
Casey Bodley
44a6203f99
Merge pull request #29380 from theanalyst/rgw-dns-name-fixes
rgw: make dns hostnames matching case insensitive

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2019-08-16 10:18:08 -04:00
Casey Bodley
44ce9e5d7f
Merge pull request #28558 from cbodley/wip-rgw-bucket-max-aio
[RFC] rgw: raise default rgw_bucket_index_max_aio to 128

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
2019-08-16 10:17:33 -04:00
Radoslaw Zarzynski
96502dfc00 osd: remove orphan include after PGLSParentFilter.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2019-08-16 16:15:34 +02:00
Casey Bodley
38be6f81c6
Merge pull request #28824 from dang/zipper
rgw: Project Zipper part 1

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2019-08-16 09:49:28 -04:00
Ernesto Puerta
f4cbe8965f
mgr/dashboard: clean-up python unit tests
Fix pylint issues.

Refactor JwtManager check to avoid code duplication (found by pylint
when --jobs=1).

Fix issue with DashboardException.code property, using abs() on
potentially None attribute.

Disables Doctests in services/rbd.py that are actually integration tests
(they check the value of rbd.RBD_FEATURES_NAME_MAPPING). Ideally, these
kind of tests should be explicitly executed in an integration testing
stage, rather that unit-testing. Disabled tests have been prepended with
@DISABLEDOCTEST token.

Fixes: https://tracker.ceph.com/issues/40487
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
2019-08-16 15:24:31 +02:00
Kefu Chai
3bdf181ffe
Merge pull request #29621 from xiexingguo/wip-build-push-segv
osd/ReplicatedBackend: check against empty data_included before enabling crc

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2019-08-16 20:25:55 +08:00
Kefu Chai
fc55a51a87
Merge pull request #29579 from liewegas/wip-big-vs-bluestore
osd: scrub error on big objects; make bluestore refuse to start on big objects

Reviewed-by: David Zafman <dzafman@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-08-16 20:24:43 +08:00
Kefu Chai
7be0708b5c
Merge pull request #29663 from cxytt/bugfix
osd/PrimaryLogPG: Avoid accessing destroyed references in finish_degr…

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-08-16 20:22:32 +08:00
Kefu Chai
a041cffd6c
Merge pull request #29646 from zy751713126/get_pool_name_and_id
pybind/rados: add Ioctx.get_pool_id() and Ioctx.get_pool_name()

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-08-16 20:21:34 +08:00
Kefu Chai
2b4b397539
Merge pull request #29675 from tchaikov/wip-remove-parent-pgls-filter
osd/PrimaryLogPG: remove unused "parent" pgls-filter

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-08-16 20:05:00 +08:00
Radoslaw Zarzynski
e92fd433b8 denc: don't overestimate STL container's size by sizeof(uint32_t).
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2019-08-16 07:56:13 -04:00
Kefu Chai
7aae20cdf2 denc: add fallback for the O(n) legacy of std::list::size().
Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-08-16 07:56:13 -04:00
Radoslaw Zarzynski
f1b61c548b denc: slightly optimize container_base::bound_encode.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2019-08-16 07:56:12 -04:00
Mykola Golub
0866a2456b qa/workunits/rbd: stress test rbd mirror pool status --verbose
Fixes: https://tracker.ceph.com/issues/40923
Signed-off-by: Mykola Golub <mgolub@suse.com>
2019-08-16 12:50:42 +01:00
Kefu Chai
ebdf419c63
Merge pull request #29597 from tchaikov/wip-qa/tasks/cbt
qa/tasks/cbt.py: use "git --depth 1 for" faster clone

Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-08-16 19:17:58 +08:00
Kefu Chai
d03f397544 ceph-objectstore-tool: return 0 if incmap is sane
this change addresses the regression introduced by 2e2414b3

Fixes: https://tracker.ceph.com/issues/41177
Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-08-16 19:11:10 +08:00
Alfredo Deza
3add40c4ee
Merge pull request #29683 from jan--f/c-v-keep-device-list-as-lists
ceph-volume: don't keep device lists as sets

Reviewed-by: Alfredo Deza <adeza@redhat.com>
2019-08-16 07:00:50 -04:00
Sage Weil
8958df969e Merge PR #29676 into master
* refs/pull/29676/head:
	test/unittest_bluefs: always remove temp bdev file

Reviewed-by: Sage Weil <sage@redhat.com>
2019-08-15 14:03:37 -05:00
Sage Weil
81f5b3788d Merge PR #29581 into master
* refs/pull/29581/head:
	os/bluestore: do not set osd_memory_target default from cgroup limit

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Mark Nelson <mnelson@redhat.com>
2019-08-15 14:02:34 -05:00
Sage Weil
83a59884e1 Merge PR #29577 into master
* refs/pull/29577/head:
	os/bluestore/KernelDevice: fix RW_IO_MAX constant
	os/bluestore/KernelDevice: print aio error extent in hex

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-08-15 14:02:00 -05:00
Casey Bodley
c35f9d6ecd
Merge pull request #29578 from theanalyst/rgw-user-policy-urlencode
rgw: url decode PutUserPolicy params

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Pritha Srivastava <prsrivas@redhat.com>
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
2019-08-15 14:02:03 -04:00
Matt Benjamin
306bc84af1
Merge pull request #29670 from linuxbox2/wip-rgwfile-marker
rgw_file: readdir: do not construct markers w/leading '/'
2019-08-15 13:33:27 -04:00
Sage Weil
09beeb0e03 Merge PR #29422 into master
* refs/pull/29422/head:
	qa/tasks/mgr/dashboard/test_health: update schema
	doc/rados/operations/monitoring: document muting health alerts
	qa/standalone/mon/health-mutes: add tests
	doc/rados/operations/health-checks: document MON_DISK_{LOW,CRIT,BIG}
	doc/rados/operations/health-checks: document OSD_NO_DOWN_OUT_INTERVAL
	doc/rados/operations/health-checks: document AUTH_BAD_CAPS
	doc/reados/operations/health-checks: document PG_SLOW_SNAP_TRIMMING
	doc/rados/operations/health-checks: document MGR_DOWN
	mon/HealthCheck: check mutes based on count, not parsing the summary string
	mon/health_checks: associate a count with health_alert_t
	mon/HealthMonitor: simplify health alert dump
	mon/PGMap: use nice timespan for PG stuck warnings
	mon/HealthMonitor: allow muted alert counts to decrease but not increase
	mon/PGMap: fix summary form for bluestore health alerts
	doc/rados/operations/health-alerts: document BLUESTORE_NO_COMPRESSION
	mon/PGMap: fix summary form for POOL_APP_NOT_ENABLED
	mon/HealthMonitor: persist summary for non-sticky mutes
	mon/HealthMonitor: move get_health_status()
	mon/HealthMonitor: automatically clear non-sticky mutes when alert clears
	mon/HealthMonitor: add gather_all_health_checks helper
	mon/HealthMonitor: add sticky flag to mutes
	mon/HealthMonitor: expire mutes based on ttl
	mon: apply mutes to health [detail]
	mon/HealthMonitor: implement mute and unmount commands
	mon/HealthMonitor: maintain list of mutes
	mon: refactor/simplify health [detail]
	mon/health_checks: format 'health summary' with a colon
	mon/health_checks: drop dump_summary_compat

Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-08-15 12:28:26 -05:00
Sage Weil
2ac53bb645 Merge PR #29537 into master
* refs/pull/29537/head:
	os/bluestore/BlueFS: fix device_migrate_to_* to handle varying alloc sizes
	os/bluestore/BlueFS: apply shared_alloc_size to shared device
	os/bluestore: whitespace
	os/bluestore/BlueFS: add bluefs_shared_alloc_size
	os/bluestore/BlueStore.cc: start should be >= _get_ondisk_reserved()

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-08-15 12:26:29 -05:00
Casey Bodley
2af27be08e rgw: RGWSI_User_Module filters '.buckets' objects out of user listing
Fixes: https://tracker.ceph.com/issues/41300

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2019-08-15 13:13:43 -04:00
Kefu Chai
441ed26c9b
Merge pull request #29686 from tchaikov/wip-osdc-wait-for-osdmap
osdc: should release the rwlock before waiting

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-08-16 00:10:25 +08:00
Lenz Grimmer
97928fb323
Merge pull request #26953 from Exotelis/ceph-dashboard-i18ntool
mgr/dashboard: ceph dashboard i18ntool

Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2019-08-15 14:45:51 +00:00
Kefu Chai
8432b6a9c1
Merge pull request #29568 from votdev/ignore_dirs
.gitignore: add more stuff

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-08-15 22:39:05 +08:00
Jan Fajerski
52fdbe4cb8 ceph-volume: don't try to test lvm zap on simple tests
Fixes: https://tracker.ceph.com/issues/41245

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
2019-08-15 15:33:26 +02:00
Jan Fajerski
0534cf188a ceph-volume: don't keep device lists as sets
This was introduced by #27754. The explicit device lists were cast to
sets but other parts of the code where not updated accordingly. To avoid
touching all code places, only cast to sets for disjoint test and keep
lists otherwise.

Fixes: https://tracker.ceph.com/issues/41292

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
2019-08-15 15:31:03 +02:00
Jan Fajerski
362bfac4dc
Merge pull request #29684 from jan--f/c-v-batch-functional-check-stderr
ceph-volume: fix batch functional tests, idempotent test must check s…
2019-08-15 15:19:23 +02:00
Lenz Grimmer
9294989bc2
mgr/dashboard: Daemons Page Tables Test (#29469)
mgr/dashboard: Daemons Page Tables Test

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2019-08-15 13:18:33 +00:00
Lenz Grimmer
e64198315c
mgr/dashboard: Logs Page E2E Tests (#29434)
mgr/dashboard: Logs Page E2E Tests

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2019-08-15 13:17:53 +00:00