Commit Graph

137542 Commits

Author SHA1 Message Date
zdover23
71b5f94bdb
Merge pull request #51062 from zdover23/wip-doc-2023-04-13-glossary-hybrid-storage
doc/glossary: add "Hybrid Storage"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-04-16 08:58:41 +02:00
Zac Dover
dc8148d072 doc/glossary: add "Hybrid Storage"
Add "Hybrid Storage" to the glossary.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-04-16 08:42:04 +02:00
Anthony D'Atri
61aadc5ade
Merge pull request #51091 from cityofships/fix_confval
doc/mgr/prometheus: fix confval reference
2023-04-16 00:03:37 +02:00
Piotr Parczewski
b9b75dafe2
doc/mgr/prometheus: fix confval reference
Signed-off-by: Piotr Parczewski <piotr@stackhpc.com>
2023-04-15 23:16:35 +02:00
Anthony D'Atri
0119ae9df9
Merge pull request #51086 from zdover23/wip-doc-2023-04-15-rados-ops-ceph-medic-removal
doc/rados/ops: remove ceph-medic from monitoring
2023-04-15 05:01:02 -04:00
Zac Dover
42cd28a2a6 doc/rados/ops: remove ceph-medic from monitoring
Remove mention of ceph-medic from doc/rados/operations/monitoring.rst,
because it is no longer supported.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-04-15 09:42:31 +02:00
Nizamudeen A
6987191377 mgr/dashboard: expose more grafana configs in service form
Show the grafana_port and initial_admin_password in the form but disable
the password field in the edit option

Fixes: https://tracker.ceph.com/issues/58016
Signed-off-by: Nizamudeen A <nia@redhat.com>
2023-04-15 00:29:02 +05:30
Nizamudeen A
4157c215ec
Merge pull request #51074 from rhcs-dashboard/expression-changed-e2e
mgr/dashboard: fix cephadm e2e expression changed error

Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2023-04-14 23:57:11 +05:30
Yuri Weinstein
29228ecd14
Merge pull request #51055 from ceph/wip-yuriw-release-16.2.12-main
doc: 16.2.12 Release Notes

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>
Reviewed-by: Adam King adking@redhat.com
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-04-14 09:23:26 -07:00
Venky Shankar
6684f3e55e Merge PR #50909 into main
* refs/pull/50909/head:
	qa/workunit: print the detail commands excuted in the scripts

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
2023-04-14 15:59:12 +05:30
Pedro Gonzalez Gomez
6b5a00fb8e mgr/dashboard: delete-ceph-authx
Fixes: https://tracker.ceph.com/issues/59365
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
2023-04-14 09:31:04 +02:00
Nizamudeen A
abff7f0bb7
Merge pull request #49531 from rhcs-dashboard/fix-rbd-snapshot-creation
mgr/dashboard: Fix rbd snapshot creation

Reviewed-by: VasishtaShastry <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: sunilangadi2 <NOT@FOUND>
2023-04-14 12:06:05 +05:30
Nizamudeen A
f7e29e5ab8 mgr/dashboard: fix cephadm e2e expression changed error
tried to fix this issue from the daemon component sometime ago several
times but it didn't work. So force ignoring the error

Fixes: https://tracker.ceph.com/issues/59444
Signed-off-by: Nizamudeen A <nia@redhat.com>
2023-04-14 11:35:28 +05:30
Yingxin Cheng
ebda490073 crimson/osd: specialize messages to use the external connection
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-04-14 13:46:35 +08:00
Yingxin Cheng
b54153ecad crimson/net: change ConnectionRef to be a local_shared_foreign_ptr
Make it possible for connections and messages to be dispatched in
arbitrary core without asynchronous foreign copy.

The local_shared_foreign_ptr conn cannot be moved to another core
implicitly, maintain it outside Message independently.

Do asynchronous foreign copy to the new ConnectionRef only in
with_remote_shard_state_and_op().

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-04-14 13:46:35 +08:00
Yingxin Cheng
1f419b779e crimson/osd: drop unused methods in ClientRequest
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-04-14 13:46:35 +08:00
Yingxin Cheng
3fde061a49 test/crimson/test_messenger_thrash: free msgr after its connections
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-04-14 13:46:35 +08:00
Yingxin Cheng
f96ae0b367 crimson/common: improve local_shared_foreign_ptr
Make ptr nullable and add necessary operators.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-04-14 13:44:51 +08:00
Ilya Dryomov
ebc99c9821
Merge pull request #50939 from pkalever/logging_improve
librbd: on notify_quiesce() show attempts in a better format

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: N Balachandran <nibalach@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2023-04-13 20:21:27 +02:00
Casey Bodley
d5f97e6543 cmake/rgw: librgw tests depend on ALLOC_LIBS
somehow this stops tcmalloc from crashing on ubuntu 20.04

Fixes: https://tracker.ceph.com/issues/59269

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2023-04-13 09:28:44 -07:00
Prasanna Kumar Kalever
7156addcdc librbd: on notify_quiesce() show attempts in a better format
notify_quiesce() currently shows number of attempts in descending order,
this might be bit confusing to read.

Example: on the very first attempt,
2023-04-04T19:45:56.096+0530 7ff8ba7fc640 10 librbd::ImageWatcher:
  0x7ff898008b30 notify_quiesce: async_request_id=[4151,140705343226832,23] attempts=10

I initially misread the above means 10 attempts where done.

This commit tries to pick the format that is used by
ImageWatcher<I>::handle_payload() and ImageWatcher<I>::notify_async_progress()

Fixes: https://tracker.ceph.com/issues/59379
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
2023-04-13 18:22:34 +05:30
Lucian Petrut
3701ffa673 common/tracer: fix decoding when jaeger tracing is disabled
We aren't currently using jaeger tracing on Windows. The issue is
that Windows hosts (or any other host that doesn't use jaeger)
are experiencing message decoding failures after a recent change [1].

This change updates the tracer encoding so that messages from
non-jaeger hosts may be decoded by services that use jaeger.

[1] https://github.com/ceph/ceph/pull/47457

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
2023-04-13 10:59:14 +00:00
Ilya Dryomov
3b936801fd
Merge pull request #51051 from idryomov/wip-59431
qa/suites/rbd: install qemu-utils in addition to qemu-block-extra on Ubuntu

Reviewed-by: Ramana Raja <rraja@redhat.com>
2023-04-13 11:54:57 +02:00
Igor Fedotov
3db83ad62f
Merge pull request #43546 from ifed01/wip-ifed-snapdiff3-good
cephfs: implement snapdiff

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-04-13 12:26:58 +03:00
Yuri Weinstein
ff7791f67f doc: 16.2.12 Release Notes
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
2023-04-12 12:38:48 -07:00
Nizamudeen A
34fc77ad58
Merge pull request #50877 from rhcs-dashboard/add-rbd-mirror-force-promote
mgr/dashboard: rbd-mirror force promotion

Reviewed-by: Nizamudeen A <nia@redhat.com>
2023-04-12 20:40:40 +05:30
Ronen Friedman
9bea055157
Merge pull request #50666 from athanatos/sjust/wip-scrub-interval-pr-49959-2
osd/scrubber: simplify scrub resource handling and interval changes
2023-04-12 17:37:31 +03:00
Guillaume Abrioux
6de9bcdae2
Merge pull request #51008 from guits/cv-tests-fix-rpm-issue-main
ceph-volume/tests: fix an issue with rpm
2023-04-12 16:23:31 +02:00
Ilya Dryomov
c529fdd63a qa/suites/rbd: install qemu-utils in addition to qemu-block-extra on Ubuntu
qemu-utils is usually pre-installed but, due to what appears to be
a Ubuntu packaging bug, it's not upgraded when qemu-block-extra is
installed:

  The following NEW packages will be installed:
    qemu-block-extra
  The following packages will be upgraded:
    qemu-system-common qemu-system-data qemu-system-gui qemu-system-x86

However, the version of the block driver must match exactly the version
of the qemu-img tool, so the above leads to:

  $ qemu-img convert -f qcow2 -O raw /home/ubuntu/cephtest/qemu/base.client.0.0.qcow2 rbd:rbd/client.0.0
  Failed to initialize module: /usr/lib/x86_64-linux-gnu/qemu/block-rbd.so
  Note: only modules from the same build can be loaded.
  qemu: module block-block-rbd not found, do you want to install qemu-block-extra package?
  qemu-img: Unknown protocol 'rbd'

Fixes: https://tracker.ceph.com/issues/59431
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2023-04-12 15:37:44 +02:00
Yingxin
094206c554
Merge pull request #50840 from zhscn/segment-nonce-collision
crimson/os/seatore: avoid segment nonce collision

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-04-12 14:22:56 +08:00
Aashish Sharma
5ea4171ae3 mgr/dashboard: fix rbd mirror snapshot creation
There are two types of snapshots that can be created on a snapshot based mirroring image - Normal Snapshot(same as journal based snapshot) and Nirror Image Snapshot. Till now Dashboard allowed only Mirror image snapshot, this PR intends to enable both the types

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
2023-04-12 11:50:40 +05:30
Samuel Just
6a56d85f19 qa/standalone/scrub/osd-scrub-dump.sh: drop unnecessary primary lookup
1e44d86b2 swapped this to a pg tell command which doesn't actually
need the primary specified.  Drop the now unnecessary lookup.

Signed-off-by: Samuel Just <sjust@redhat.com>
2023-04-11 20:39:19 -07:00
Samuel Just
3698f7638b osd/: remove PL::reschedule_scrub, notify scrubber on config/pool change directly
As with on_info_history_change(), we don't need to deal with scrub
scheduling during peering. Once we've gone active, the scrubber itself
would be the origin of any stat changes that could affect scrub
scheduling.  The other possible change vectors would be OSD config
changes or pool config changes.

PG::reschedule_scrub becomes PG::on_scrub_schedule_input_change.  Should
be called in all cases where an input to scrub scheduling changes.

OSD::resched_all_scrubs() calls PG::on_scrub_schedule_input_change
unconditionally
now to deal with changes to osd_scrub_(min|max)_interval.

PG::set_last_[deep_]scrub_stamp now invoke
PG::on_scrub_schedule_input_change directly.

PG::handle_activate_map() now calls PG::on_scrub_schedule_input_change
directly to deal with changes to scrub related pool options.

Signed-off-by: Samuel Just <sjust@redhat.com>
2023-04-11 20:39:19 -07:00
Samuel Just
948e8ee394 osd/: remove PeeringListener::on_info_history_change()
The only usage of this method was to notify scrub that the pg history
has been updated during split or peering.  That shouldn't be necessary.
Scrub does not schedule itself prior to activation, and we necessarily
must have an authoritative history by that point.

Signed-off-by: Samuel Just <sjust@redhat.com>
2023-04-11 20:39:19 -07:00
Samuel Just
31af98f52d osd/scrubber: associate replica state with state machine states
Moves responsibility for owning and resetting replica state to state
machine events.

Signed-off-by: Samuel Just <sjust@redhat.com>
2023-04-11 20:39:19 -07:00
Ronen Friedman
754157c428 osd/scrub: split on_pg_activate from on_new_interval
Separate and clarify handling of interval termination, pg activation,
and configuration change.

A primary PG now registers with its OSD for scrubbing only on
activation: on_pg_activate() called from PG::on_activate().

When the interval ends, the scrubber is notified via on_interval_change,
which is responsible for cleaning up any active or replica state
associated with scrub.

Configuration changes are still handled by update_scrub_job().

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Signed-off-by: Samuel Just <sjust@redhat.com>
2023-04-11 20:39:19 -07:00
Samuel Just
2176dfe32c osd/scrubber/scrub_machine*: s/ActiveReplica/ReplicaBuildingMap/g
Signed-off-by: Samuel Just <sjust@redhat.com>
2023-04-11 20:39:19 -07:00
Samuel Just
eb3d0eb26c scrubber/pg_scrubber: regularize message interval checks
OpRequestRef::sent_epoch can be used to uniformly check incoming
messages against the current interval.  Every caller should do it first
thing before any other processing.

Signed-off-by: Samuel Just <sjust@redhat.com>
2023-04-11 20:39:19 -07:00
Samuel Just
b883af38a3 osd/scrubber: make PgScrubber::check_interval const
Signed-off-by: Samuel Just <sjust@redhat.com>
2023-04-11 20:39:19 -07:00
Samuel Just
285901a700 osd/scrubber: rename advance_token to reset_replica_state
Also removes misleading comment -- because primaries may
freely reset scrub, there may well be valid scrub state.

Signed-off-by: Samuel Just <sjust@redhat.com>
2023-04-11 20:39:19 -07:00
Samuel Just
97e4891fa1 osd/scrubber: move m_remote_osd_resource.reset() into advance_token()
Signed-off-by: Samuel Just <sjust@redhat.com>
2023-04-11 20:39:19 -07:00
Samuel Just
e29dd06df9 osd/scrubber: simplify existing reservation case in handle_scrub_reserve_request
First, the is_stale() case should be impossible.  This patch leaves an
error message rather than an assert.

Second, this patch removes the special handling for receiving a reservation
when m_remote_osd_resource is already populated.  The next patch will exploit
the fact that all calls to m_remote_osd_resource.reset() and advance_token()
occur together.

Signed-off-by: Samuel Just <sjust@redhat.com>
2023-04-11 20:39:19 -07:00
Samuel Just
10e9b56e0e osd/scrubber: remove unused PgScrubber::send_full_reset
Signed-off-by: Samuel Just <sjust@redhat.com>
2023-04-11 20:39:19 -07:00
Ronen Friedman
c37d45f434 osd/scrub: remove PgScrubber::unregister_from_osd()
and inline its functionality into its sole caller
(PgScrubber::rm_from_osd_scrubbing())

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2023-04-11 20:39:19 -07:00
Ronen Friedman
ef41362612 osd/: misc scrub related formatting fixes -- no functional changes
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2023-04-11 20:39:19 -07:00
zdover23
811e9d76eb
Merge pull request #50993 from zdover23/wip-doc-2023-04-11-rados-operations-monitoring-3-of-3
doc/rados/operations: edit monitoring.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-04-12 10:04:47 +10:00
Yuri Weinstein
bf6db9f2c0
Merge pull request #50245 from baergj/bluefs-perf-stats-write-count
os/bluestore: Add bluefs write op count metrics.

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
2023-04-11 09:09:51 -07:00
Zac Dover
b9ccad8060 doc/rados/operations: edit monitoring.rst
Line-edit the final third of doc/rados/operations/monitoring.rst.

Follows https://github.com/ceph/ceph/pull/50834.

https://tracker.ceph.com/issues/58485

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-04-12 02:04:50 +10:00
Casey Bodley
9f160e4f1a rgw/aio: fix recursion from tracing changes
Fixes: https://tracker.ceph.com/issues/59423

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2023-04-11 10:49:11 -04:00
Pedro Gonzalez Gomez
9696b6a048 mgr/dashboard: rbd-mirror force promotion
resolves: https://tracker.ceph.com/issues/59327
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
2023-04-11 13:53:23 +02:00