Commit Graph

132287 Commits

Author SHA1 Message Date
chunmei-liu
7110e0e9fa crimson/test: add more list_objects test in test_seastore
Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
Signed-off-by: Samuel Just <sjust@redhat.com>
2022-07-22 16:12:35 -07:00
chunmei-liu
4010c4f24d crimson/seastore: fix test_seastore
collection default has pool(0), and NO_SHARD,
so the ghobject_t should have the same setting.
and ghobject_t default hash not within 1<<(32-4),
so set collection bits to be 0.

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
2022-07-22 16:12:23 -07:00
chunmei-liu
16becf3157 crimson/seastore: fix list_onodes bug
Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
2022-07-22 16:12:23 -07:00
chunmei-liu
96c6f67a9c crimson/seastore: calculate list_objects ranges by coll_range_(temp)_start/end
Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
Signed-off-by: Samuel Just <sjust@redhat.com>
2022-07-22 16:11:54 -07:00
Samuel Just
f13b6b0f16
Merge pull request #46979 from rzarzynski/wip-crison-fix-connpriv-life-time
crimson/osd: fix life-time management of OSDConnectionPriv

Reviewed-by: Samuel Just <sjust@redhat.com>
2022-07-05 16:29:24 -07:00
Samuel Just
163ae57e34
Merge pull request #46965 from rzarzynski/wip-crimson-fix-no-mon-config-argv
crimson/osd: fix ignoring --no-mon-config

Reviewed-by: Samuel Just <sjust@redhat.com>
2022-07-05 13:50:58 -07:00
Radoslaw Zarzynski
295108881f crimson/osd: fix life-time management of OSDConnectionPriv
Before the patch there was a possibility that `OSDConnectionPriv`
gets destructed before a `PipelineHandle` instance that was using
it. The reason is our remote-handling operations store `conn` directly
while `handle` is defined in a parent class. Due to the language rules
the former gets deinitialized earlier.

```
==756032==ERROR: AddressSanitizer: heap-use-after-free on address 0x615000039684 at pc 0x0000020bdfa2 bp 0x7ffd3abfa370 sp 0x7ffd3abfa360
READ of size 1 at 0x615000039684 thread T0
Reactor stalled for 261 ms on shard 0. Backtrace: 0x45d9d 0xe90f6d1 0xe6b8a1d 0xe6d1205 0xe6d16a8 0xe6d1938 0xe6d1c03 0x12cdf 0xccebf 0x7f6447161b1e 0x7f644714aee8 0x7f644714eed6 0x7f644714fb36 0x7f64471420b5 0x
7f6447143f3a 0xd61d0 0x32412 0xbd8a7 0xbd134 0xbdc1a 0x20bdfa1 0x20c184e 0x352eb7f 0x352fa28 0x20b04a5 0x1be30e5 0xe694bc4 0xe6ebb8a 0xe843a11 0xe845a22 0xe29f497 0xe2a3ccd 0x1ab1841 0x3aca2 0x175698d
    #0 0x20bdfa1 in seastar::shared_mutex::unlock() ../src/seastar/include/seastar/core/shared_mutex.hh:122
    #1 0x20c184e in crimson::OrderedExclusivePhaseT<crimson::osd::ConnectionPipeline::GetPG>::exit() ../src/crimson/common/operation.h:548
    #2 0x20c184e in crimson::OrderedExclusivePhaseT<crimson::osd::ConnectionPipeline::GetPG>::ExitBarrier::exit() ../src/crimson/common/operation.h:533
    #3 0x20c184e in crimson::OrderedExclusivePhaseT<crimson::osd::ConnectionPipeline::GetPG>::ExitBarrier::cancel() ../src/crimson/common/operation.h:539
    #4 0x20c184e in crimson::OrderedExclusivePhaseT<crimson::osd::ConnectionPipeline::GetPG>::ExitBarrier::~ExitBarrier() ../src/crimson/common/operation.h:543
    #5 0x20c184e in crimson::OrderedExclusivePhaseT<crimson::osd::ConnectionPipeline::GetPG>::ExitBarrier::~ExitBarrier() ../src/crimson/common/operation.h:544
    #6 0x352eb7f in std::default_delete<crimson::PipelineExitBarrierI>::operator()(crimson::PipelineExitBarrierI*) const /opt/rh/gcc-toolset-11/root/usr/include/c++/11/bits/unique_ptr.h:85
    #7 0x352eb7f in std::unique_ptr<crimson::PipelineExitBarrierI, std::default_delete<crimson::PipelineExitBarrierI> >::~unique_ptr() /opt/rh/gcc-toolset-11/root/usr/include/c++/11/bits/unique_ptr.h:361
    #8 0x352eb7f in crimson::PipelineHandle::~PipelineHandle() ../src/crimson/common/operation.h:457
    #9 0x352eb7f in crimson::osd::PhasedOperationT<crimson::osd::ClientRequest>::~PhasedOperationT() ../src/crimson/osd/osd_operation.h:152
    #10 0x352eb7f in crimson::osd::ClientRequest::~ClientRequest() ../src/crimson/osd/osd_operations/client_request.cc:64
    #11 ...
```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2022-07-05 18:49:20 +00:00
Radoslaw Zarzynski
de70e12c9f crimson/osd: avoid unnecessary counter management in ClientRequest's ctor
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2022-07-05 18:49:20 +00:00
Radoslaw Zarzynski
0200e22cc2 crimson/osd: improve assertions around Connection::user_private
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2022-07-05 18:49:20 +00:00
Adam King
edeca5a157
Merge pull request #46735 from guits/guits-better-msg-rm-osd
cephadm: improve message when removing osd

Reviewed-by: Adam King <adking@redhat.com>
2022-07-05 14:45:34 -04:00
Adam King
8c4b3ea4e3
Merge pull request #46676 from dparmar18/fix_56024
pybind/mgr/cephadm/serve: don't remove ceph.conf which leads to qa failure

Reviewed-by: Adam King <adking@redhat.com>
2022-07-05 10:39:50 -04:00
Adam King
b349762a9d
Merge pull request #46926 from rkachach/fix_issue_53997
doc/cephadm/services: the config section of service specs

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
2022-07-05 09:50:32 -04:00
Guillaume Abrioux
854b62e2a9 cephadm: improve message when removing osd
make it clearer that not passing --zap will leave VG/LV, therefore all
LVM metadata associated with the osd being removed from the Ceph cluster.

Fixes: https://tracker.ceph.com/issues/56092

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2022-07-05 15:29:22 +02:00
Guillaume Abrioux
a2a3897217
Merge pull request #46766 from guits/util-device-refactor
ceph-volume: avoid unnecessary subprocess calls
2022-07-05 15:11:54 +02:00
Guillaume Abrioux
a540765d76
Merge pull request #46753 from guits/improve-lvm-list
ceph-volume: decrease number of `pvs` calls in `lvm list`
2022-07-05 14:56:00 +02:00
Radoslaw Zarzynski
38cb07c756 crimson/osd: fix ignoring --no-mon-config
Before we were treating the `--no-mon-config` as one of the
`seastar_n_early_args`. However, this was wrong as it truly
belongs to `config_proxy_args` as:

```cpp
int md_config_t::parse_argv(ConfigValues& values,
                            const ConfigTracker& tracker,
                            std::vector<const char*>& args, int level)
{
    // ...
    else if (ceph_argparse_flag(args, i, "--no-mon-config", (char*)NULL)) {
      values.no_mon_config = true;
    }
    // ...
}
```

The net result of this ignoring `--no-mon-config` which was
the reason behind many dead jobs at Sepia.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2022-07-05 12:46:16 +00:00
Radoslaw Zarzynski
1b2f250ed9 crimson/osd: log about respecting --no-mon-config
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2022-07-05 12:46:16 +00:00
Daniel Gryniewicz
67364c45d0
Merge pull request #46879 from dang/wip-dang-zipper-virtual
RGW Zipper pure virtual base class

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Soumya Koduri <skoduri@redhat.com>
2022-07-05 08:01:59 -04:00
Venky Shankar
05976ab9fb
Merge pull request #46157 from nmshelke/fix-55041
mgr/volumes: display in-progress clones for a snapshot

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
2022-07-05 14:39:57 +05:30
Anthony D'Atri
1481446a9e
Merge pull request #46957 from hookak/cephadm-doc
doc/cephadm/services: update docs for overriding loki, promtail configuration file
2022-07-04 22:23:55 -07:00
jinhong.kim
6081729267
doc/cephadm/services: overriding loki, promtail conf file
Signed-off-by: jinhong.kim <jinhong.kim0@navercorp.com>
2022-07-05 12:30:31 +09:00
Venky Shankar
d54685879d
Merge pull request #46641 from lxbsz/wip-56010
mds: switch to use projected inode instead

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by:  Luis Henriques <lhenriques@suse.de>
2022-07-05 08:19:32 +05:30
Venky Shankar
01e0a9a7e2
Merge pull request #46746 from vshankar/wip-fs-snaps-timeout
qa: increase fs/snaps workunit timeout to 6h

Reviewed-by: Xiubo Li <xiubli@redhat.com>
2022-07-04 20:41:51 +05:30
Venky Shankar
c88e7ee9e4
Merge pull request #45143 from lxbsz/wip-54384
mds: skip fetching the dirfrags if not a directory 

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
2022-07-04 20:40:24 +05:30
Ilya Dryomov
ad70b9ef2a
Merge pull request #46839 from maydaycc/wip-56387
rbd-fuse: librados will filter out -r option from command-line

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2022-07-04 11:50:33 +02:00
Redouane Kachach
b67bd50a3b
doc/cephadm/services: the config section of service specs
Fixes: https://tracker.ceph.com/issues/53997

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2022-07-04 11:29:58 +02:00
Nikhilkumar Shelke
f4c6bdb3c6 qa: display in-progress clones for a snapshot
If any clone is in pending or in-progress state then
show these clones in 'fs subvolume snapshot info'
command output.

Fixes: https://tracker.ceph.com/issues/55041
Signed-off-by: Nikhilkumar Shelke <nshelke@redhat.com>
2022-07-04 13:31:40 +05:30
Nikhilkumar Shelke
a8b819da71 docs: display in-progress clones for a snapshot
If any clone is in pending or in-progress state then
show these clones in 'fs subvolume snapshot info'
command output. This field only exists if clones are
in pending or in progress state.

Fixes: https://tracker.ceph.com/issues/55041
Signed-off-by: Nikhilkumar Shelke <nshelke@redhat.com>
2022-07-04 13:31:40 +05:30
Nikhilkumar Shelke
099efb4249 mgr/volumes: display in-progress clones for a snapshot
If any clone is in pending or in-progress state then
show these clones in 'fs subvolume snapshot info'
command output.

Fixes: https://tracker.ceph.com/issues/55041
Signed-off-by: Nikhilkumar Shelke <nshelke@redhat.com>
2022-07-04 13:31:40 +05:30
Venky Shankar
988b17c73f
Merge pull request #46472 from lxbsz/wip-55331
mds: notify the xattr_version to replica MDSes

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2022-07-04 08:27:54 +05:30
Venky Shankar
c37bd10303
Merge pull request #46575 from batrick/i51332
qa: exercise metadata replication in workloads

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2022-07-04 08:25:15 +05:30
Anthony D'Atri
cf1415a2b2
Merge pull request #46919 from jsoref/spelling-docs
doc: Fix many spelling errors
2022-07-03 19:54:55 -07:00
Venky Shankar
3dbf673084
Merge pull request #46602 from batrick/i55980
mds,qa: some balancer debug messages (<=5) not printed when debug_mds is >=5

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
2022-07-04 08:22:50 +05:30
Yingxin
5699a031b1
Merge pull request #46770 from rzarzynski/wip-crimson-setallochint
crimson: bring alloc hints to OpsExecuter, ignore them in SeaStore

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
2022-07-04 09:24:15 +08:00
Yingxin
ad577a7755
Merge pull request #46929 from rzarzynski/wip-crimson-ftbfs-segment_cleaner
crimson/tools: fix FTBFS due to seastore/segment_cleaner.h

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-07-04 09:15:00 +08:00
Anthony D'Atri
fe2200527e
Merge pull request #46087 from rhcs-dashboard/update-centralized-logging-docs
doc: update docs for centralized logging
2022-07-03 16:32:59 -07:00
Anthony D'Atri
693e0d49e6
Merge pull request #46942 from Schweinepriester/patch-1
README.md: HTTP => HTTPS
2022-07-03 16:19:11 -07:00
Kai
8f50c67eae
README.md: HTTP => HTTPS
Switching the link http://ceph.com/ from HTTP to HTTPS, so https://ceph.com/, to skip the redirect when opening it.
(http://ceph.com/ is being redirected to https://ceph.com/)

Signed-off-by: Kai Hollberg <kai.hollberg@googlemail.com>
2022-07-03 21:36:27 +02:00
Josh Soref
8abce157f1 doc: Fix many spelling errors
* administrators
* allocated
* allowed
* approximate
* authenticate
* availability
* average
* behavior
* binaries
* bootstrap
* bootstrapping
* capacity
* cephadm
* clients
* combining
* command
* committed
* comparison
* compiled
* consequences
* continues
* convenience
* cookie
* crypto
* dashboard
* deduplication
* defaults
* delivered
* deployment
* describe
* directory
* documentation
* dynamic
* elimination
* entries
* expectancy
* explicit
* explicitly
* exporter
* github
* hard
* healthcheck
* heartbeat
* heavily
* http
* indices
* infrastructure
* inherit
* layout
* lexically
* likelihood
* logarithmic
* manually
* metadata
* minimization
* minimize
* object
* of
* operation
* opportunities
* overwrite
* prioritized
* recipe
* records
* requirements
* restructured
* running
* scalability
* second
* select
* significant
* specify
* subscription
* supported
* synonym
* throttle
* unpinning
* upgraded
* value
* version
* which
* with

Plus some line wrapping and additional edits...

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
2022-07-02 23:38:18 -04:00
Anthony D'Atri
f6af9a616b
Merge pull request #42095 from thotz/rgwvaultdocupdate
doc/radosgw/vault: update the vault documentation
2022-07-02 20:04:12 -07:00
zdover23
0939f19934
Merge pull request #46938 from zdover23/wip-doc-2022-07-03-dev-guide-irc-registration-instructions-2
doc/dev: add IRC registration instructions

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2022-07-03 03:40:08 +10:00
Zac Dover
893e68a8f5 doc/dev: add IRC registration instructions
This PR adds to the Developer Guide a link to the OFTC's IRC nick
registration instructions.
2022-07-03 01:50:44 +10:00
zdover23
963888a9bf
Merge pull request #46906 from zdover23/wip-doc-2022-06-30-devguide-basic-workflow-the-the-fix
doc/dev: s/the the/the/ in basic-workflow.rst
2022-07-03 01:19:45 +10:00
Anthony D'Atri
03162009e8
Merge pull request #43085 from thotz/updategocephadminops
doc/radosgw/adminops: add latest go ceph library to adminops doc
2022-07-02 00:52:19 -07:00
Anthony D'Atri
15ec9da7d8 doc/radosgw: Resolving conflicts with #43128
Signed-off-by: Anthony D'Atri <anthony,.datri@gmail.com>
2022-07-01 23:01:20 -07:00
Anthony D'Atri
a04f271f12
Merge branch 'main' into updategocephadminops 2022-07-01 13:26:08 -07:00
Anthony D'Atri
8e499ab2f9
Merge pull request #43128 from lbausch/adminops_php_binding_libraries
doc/radosgw/adminops: add PHP binding libraries
2022-07-01 13:24:24 -07:00
Adam King
11a3668db2
Merge pull request #46784 from adk3798/backport-cephadm-label
script/ceph-backport.sh: add label entries for cephadm

Reviewed-by: Neha Ojha <nojha@redhat.com>
2022-07-01 16:05:49 -04:00
Adam King
a3e268fde6
Merge pull request #46892 from rkachach/fix_issue_56415
mgr/cephadm: fixing scheduler consistent hashing

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2022-07-01 16:02:48 -04:00
Adam King
1c0813b90e
Merge pull request #44493 from zenomri/wip-omri-cephadm-jaeger
mgr/cephadm: Add jaeger-tracing services support

Reviewed-by: Adam King <adking@redhat.com>
2022-07-01 16:00:50 -04:00