Commit Graph

136614 Commits

Author SHA1 Message Date
zdover23
c0df8ce5bf
Merge pull request #50213 from pponnuvel/osd_backfill_doc
doc/rados: update OSD_BACKFILLFULL description

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-02-23 15:16:33 +10:00
Xuehan Xu
7d60549032 crimson/os/seastore/async_cleaner: make backref retrieval trans non-weak
backref retrieval transactions may conflict with others on RootBlock

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2023-02-23 02:03:06 +00:00
Xuehan Xu
7ad7b31fef crimson/os/seastore/cache: return the RootBlock it's waiting on in
`Cache::get_root()`

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2023-02-23 01:30:59 +00:00
Laura Flores
96b45cb61a
Merge pull request #50215 from ljflores/wip-temporarily-disable-cronjobs 2023-02-22 19:29:20 -06:00
Laura Flores
39df3b8827 qa/crontab: temporarily disable teuthology cronjobs
Temporarily disable teuthology cron jobs before
the Reef dev freeze. This commit is intended to
lessen the load on the teuthology queue as we
test final patches for Reef, but should be reverted
after the dev freeze.

Signed-off-by: Laura Flores <lflores@redhat.com>
2023-02-22 23:17:19 +00:00
Nizamudeen A
f3bc98d335
Merge pull request #50201 from ceph/fix-github_action-main
.github/workflows: update failing action

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: rkachach <NOT@FOUND>
2023-02-22 22:49:44 +05:30
Ilya Dryomov
c192eee0d8
Merge pull request #48127 from petrutlucian94/cephfs_tests
Windows tests follow-up (librados_asio error category, disable some tests)

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-02-22 17:43:17 +01:00
Laura Flores
c61fe847c6 test/osd: add read balancer unit tests
This commit adds unit test coverage to the read balancing
feature, including small vs. large osdmap scenarios,
random osdmap scenarios, and scenarios that involve
tweaking primary affinity on an OSD.

Signed-off-by: Laura Flores <lflores@redhat.com>
2023-02-22 16:29:38 +00:00
Laura Flores
10b89f96d9 tools, test/cli: add read balancer to osdmaptool
This commit adds the capability to balance reads on a
given osdmap with the osdmaptool. The user has the option
of performing a "dry run" of read balancing OR taking it a
step further and applying the results to a live cluster.

Performing a "dry run" would involve simply running an
osdmaptool command and inspecting the results.

The template for the command is:
`osdmaptool <osd map file> --read <file for command output> --read-pool <pool name>`

An example command a user might run is:
`osdmaptool om --read out.txt --read-pool default.rgw.control`

This commit also adds a `--vstart` flag that allows a user to print ceph
commands in the outfile formatted for a vstart cluster. An example command
a user might run is:
`./bin/osdmaptool om --vstart --read out.txt --read-pool default.rgw.control`
The out.txt file would contain ceph commands prefixed with `./bin/`.
The `--vstart` flag may also be applied to an `--upmap` osdmaptool command.

If the user wants to apply read balancing results from their dry run to a
live cluster, they may either manually apply the ceph commands from the out
file, or run `source <outfile>`.

Signed-off-by: Laura Flores <lflores@redhat.com>
2023-02-22 16:29:38 +00:00
Laura Flores
8daff1cb38 osd: implement read balancer
This commit implements two functions:

1. calc_desired_primary_distribution
   Based on the number of pgs in a pool and the pool's
   replica count, we calculate the ideal number of primary
   pgs that should be assigned to each OSD on that pool in
   order for reads to be balanced.

2. balance_primaries
   This is the overall algorithm used to balance reads (primary
   pgs) in a pool. Based on the first function, we re-distribute
   primaries on the OSDs in a pool so each OSD has the ideal
   number of primaries. This is done without data movement.

Signed-off-by: Laura Flores <lflores@redhat.com>
2023-02-22 16:29:38 +00:00
Ponnuvel Palaniyappan
198a9e02cb doc/rados: update OSD_BACKFILLFULL description
Document that this warning can happen even when the OSDs' limits
haven't hit the backfill_full_ratio.

Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
2023-02-22 16:22:24 +00:00
Rishabh Dave
cd3f9575af doc/cephfs: describe conf opt "client quota df" in quota doc
The ceph config file option (from the client section) "client quota df"
is mentioned in "CephFS Client Capabilities" document but not in the
"CephFS Quota" document. Adding information about this option to this
document too would make it easier for CephFS users to discover,
understand and use this option.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-02-22 21:17:36 +05:30
Rishabh Dave
57335e8a4f doc/cephfs: rearrange CephFS Quota document
CephFS users, especially new users, would find it easier to discover,
understand and use CephFS Quota when basic information (like setting,
viewing and removing CephFS quota from a CephFS directory) is mentioned
in the documentation before advanced information (like limitations &
implementation details of CephFS Quota).

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-02-22 21:17:36 +05:30
Rishabh Dave
92aaaf7b57 qa/cephfs: save results dir from xfstests-dev repo
The "results" directory in xfstests-dev repo contains logs that are
created by it during execution of its tests. Copying this directory to
Ceph log directory saves it from being erased during tear down conducted
by teuthology test runner. These logs allow deeper inspection in to the
cause of failure of tests.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-02-22 20:44:29 +05:30
Rishabh Dave
053a1fb851 qa/cephfs: don't create symlinks for xfstests-dev
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-02-22 20:29:02 +05:30
Rishabh Dave
18465b8f56 qa/cephfs: modify user creation code for xfstests-dev
Create user "fsgqa2" and, since xfstests-dev's README uses option "-m"
while creating user "fsgqa", do the same in our codebase.

Creating user "fsgqa2" is optional along with other users according to
xfstests-dev's README. Create all these users is a preventive step since
tests needing user/users maybe skipped during execution.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-02-22 20:29:02 +05:30
Rishabh Dave
392e278749 qa/cephfs: log xfstests-dev local.config
Log contents of xfstests-dev repo config file "local.config" to make
debugging easier.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-02-22 20:29:02 +05:30
Rishabh Dave
4d75730200 qa/cephfs: minor changes in xfstests_dev.py
In xfstests-dev repo, local.config options "SCRATCH_DEV" and
"SCRATCH_MNT" were enabled in commit
2ba6b87105 but TODO comment for the
wasn't deleted. Let's delete that and use format string instead of
format function on regular string.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-02-22 20:29:02 +05:30
Ernesto Puerta
a29a620b87
Merge pull request #50207 from rhcs-dashboard/fix-58827-main
mgr/dashboard: fix constraints.txt

Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2023-02-22 15:57:38 +01:00
Rishabh Dave
49c7a79f8a qa/cephfs: make it easier to use xfstests-dev using vstart_runner
The intention of this re-arrangement is to make it easier for developers
to use an already cloned and built xfstests-dev repo  with
vstart_runner.py.

The re-arrangements are -

* move tearDown() closer to setUp() (so that devs can
  enable/disable parts of them easily),

* carve out separate methods (so that these codeblocks can be disabled
  in a single go) for -
  ** deleting groups and users,
  ** deleting xfstests-dev and xfsprogs-dev repo and
  ** building xfstests-dev repo

* carve out method for deleting xfstests-dev and xfsprogs-dev repos

* add self.xfstests_repo_path comment (for devs to set path to
  xfstests-dev repo), and,

* add a note showing how to use already cloned and built xfstests-dev
  repo

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-02-22 20:07:48 +05:30
Rishabh Dave
4a00b2bbb1 qa/cephfs: use standard name for logging variable
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-02-22 20:03:05 +05:30
Venky Shankar
ae6f1b18be Merge PR #50175 into main
* refs/pull/50175/head:
	cephfs: upgrade cephfs-shell's path wherever necessary

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
2023-02-22 19:47:43 +05:30
Ernesto Puerta
bdd81e62b2
Merge pull request #49979 from ceph/dependabot-npm_and_yarn-src-pybind-mgr-dashboard-frontend-http-cache-semantics-4.1.1
mgr/dashboard: bump http-cache-semantics from 4.1.0 to 4.1.1 in /src/pybind/mgr/dashboard/frontend

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2023-02-22 14:56:05 +01:00
Ernesto Puerta
773b11ec2d
Merge pull request #49192 from ceph/dependabot-npm_and_yarn-src-pybind-mgr-dashboard-frontend-decode-uri-component-0.2.2
mgr/dashboard: bump decode-uri-component from 0.2.0 to 0.2.2 in /src/pybind/mgr/dashboard/frontend

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2023-02-22 12:09:25 +01:00
Ernesto Puerta
d5f8927a5c
mgr/dashboard: fix constraints.txt
Replaces strict version matching with compatible version syntax.

Reference: https://peps.python.org/pep-0440/#version-specifiers

Fixes: https://tracker.ceph.com/issues/58827

Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
2023-02-22 11:31:47 +01:00
Venky Shankar
8ce318517d Merge PR #45669 into main
* refs/pull/45669/head:
	client: switch to use 32 bits ext_num_fwd
	client: switch to use 32 bits ext_num_retry
	ceph_fs.h: add 32 bits extended num_retry and num_fwd support
	ceph_fs.h: switch to use its own encode/decode helpers

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-02-22 14:41:09 +05:30
Xiubo Li
0f9d3f2d3d qa: export DIFF_LENGTH env parameter to print the full git diff
From the xfstests-dev's README doc set DIFF_LENGTH to 0 will print
the full diff instead of the default 10.

This will be very helpful to debug the test failures, or we will
lose many valuable debug infomation.

Signed-off-by: Xiubo Li <xiubli@redhat.com>
2023-02-22 14:15:14 +08:00
Venky Shankar
86b90286cd Merge PR #49934 into main
* refs/pull/49934/head:
	qa: add test_fscrypt_dummy_encryption test case support
	qa: add 'options' parameter support for write_local_config
	qa: add ceph.exclude file to exclude individual tests
	qa: add require_kernel_mount helper support
	qa: rename test_fscrypt to test_fscrypt_encrypt

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-02-22 11:41:44 +05:30
zdover23
8a7bfa1068
Merge pull request #50203 from zdover23/wip-doc-2023-02-22-radosgw-multisite-refine-top-matter
doc/rgw: clarify multisite.rst top matter

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-02-22 14:23:01 +10:00
Zac Dover
bbc229340f doc/rgw: clarify multisite.rst top matter
Improve the pragmatics of the top matter of multisite.rst. Organize the
text into sections, where doing so makes the nature of multi-site
configurations clearer.

Co-authored-by: Cole Mitchell <cole.mitchell@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-02-22 13:59:12 +10:00
Yingxin
9f24ec0f01
Merge pull request #49605 from myoungwon/wip-rbm-integration-step2
crimson/os/seastore: enable metadata (*_INTERNAL and *_LEAF ) allocation using OOL path

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-22 09:37:07 +08:00
Ernesto Puerta
fea1ada449
Merge pull request #49722 from ceph/dependabot-npm_and_yarn-src-pybind-mgr-dashboard-frontend-loader-utils-1.4.2
mgr/dashboard: bump loader-utils from 1.4.0 to 1.4.2 in /src/pybind/mgr/dashboard/frontend

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2023-02-22 01:48:01 +01:00
Ernesto Puerta
4855c768be
Merge pull request #50042 from ceph/dependabot-npm_and_yarn-src-pybind-mgr-dashboard-frontend-sideway-formula-3.0.1
mgr/dashboard: bump @sideway/formula from 3.0.0 to 3.0.1 in /src/pybind/mgr/dashboard/frontend

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2023-02-22 00:26:23 +01:00
Radoslaw Zarzynski
e9495737f9 examples/librbd: drop -std=c++11 from CXXFLAGS
In terms of `CXXFLAGS` this commit does for `examples/librbd`
exactly what be838652fa already
did to `examples/librados`. Together they cover the purpose
of the long-waiting PR #44738.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2023-02-21 20:43:18 +00:00
Ernesto Puerta
2d11e4770a
.github/workflows: update failing action
[Example](https://github.com/ceph/ceph/actions/runs/4222995073/jobs/7360873373) of failing run.

Signed-off-by: Ernesto Puerta <37327689+epuertat@users.noreply.github.com>
2023-02-21 20:47:31 +01:00
Rishabh Dave
48ef044477 cephfs: upgrade cephfs-shell's path wherever necessary
Commit dc69033763 moves cephfs-shell from
"<CEPH-REPO-ROOT>/src/tools/cephfs/" to
"<CEPH-REPO-ROOT>/src/tools/cephfs/shell" but cephfs-shell's location in
src/vstart.sh and qa/tasks/cephfs/test_cephfs_shell.py is left
un-updated. This produces a broken vstart_environment.sh and broken
export command in test_cephfs_shell.py.

Introduced-by: dc69033763
Fixes: https://tracker.ceph.com/issues/58795
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-02-21 19:16:27 +05:30
Neeraj Pratap Singh
db48c819bb cephfs-top: navigate to home screen while selecting sort field, if no filesystems.
Fixes: https://tracker.ceph.com/issues/58813
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
2023-02-21 18:26:37 +05:30
Neeraj Pratap Singh
8a13592b16 cephfs-top: display_menu() isn't triggered when all fs' are removed
Fixes: https://tracker.ceph.com/issues/58813
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
2023-02-21 18:21:55 +05:30
Xiubo Li
b420db8dba qa: add test_fscrypt_dummy_encryption test case support
This will test around 130 test cases with the test_dummy_encryption
option enabled.

Signed-off-by: Xiubo Li <xiubli@redhat.com>
2023-02-21 16:15:12 +08:00
zdover23
01ad87ef30
Merge pull request #50165 from zdover23/wip-doc-2023-02-19-radosgw-multisite-multisite-top-matter-cleanup
doc/rgw: multisite ref. top matter cleanup

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-02-21 14:52:21 +10:00
Xiubo Li
306b8bea4a qa: add 'options' parameter support for write_local_config
This will allow the fscrypt test case to add dedicated options.

Signed-off-by: Xiubo Li <xiubli@redhat.com>
2023-02-21 12:41:33 +08:00
Xiubo Li
002d45b589 qa: add ceph.exclude file to exclude individual tests
Skip some tests, which will take to much time or will fail, for now.

Signed-off-by: Xiubo Li <xiubli@redhat.com>
2023-02-21 12:41:30 +08:00
zdover23
56b5dca495
Merge pull request #50186 from zdover23/wip-doc-2023-02-21-radosgw-session-tags-render-fix
doc/rgw: session-tags.rst - fix link to keycloak

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2023-02-21 14:09:30 +10:00
Venky Shankar
347acdf738 Merge PR #49154 into main
* refs/pull/49154/head:
	qa: add tests for cephfs-top
	doc: updates --dump and --dumpfs
	cephfs-top: dump values to stdout

Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>
2023-02-21 09:33:18 +05:30
Zac Dover
76eae93ab8 doc/rgw: session-tags.rst - fix link to keycloak
Fix a link in the doc/radosgw/session-tags.rst file that was intended to
link to the doc/radosgw/keycloak.rst file.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-02-21 13:55:03 +10:00
zdover23
3aae102209
Merge pull request #43145 from pritha-srivastava/wip-rgw-sts-doc-fixes
rgw/sts: correcting documentation errors.

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-02-21 13:48:28 +10:00
Yuri Weinstein
a9e42474b6
Merge pull request #49843 from shreyanshjain7174/compression_58410
rados: Set snappy as default value in ms_osd_compression_algorithm

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2023-02-20 14:29:38 -08:00
Yuri Weinstein
f69b76e042
Merge pull request #49487 from trociny/wip-58269
mgr: don't dump global config holding gil

Reviewed-by: Tim Serong <tserong@suse.com>
2023-02-20 14:28:49 -08:00
Yuri Weinstein
7d2620739a
Merge pull request #49379 from zhsgao/osd_deep_scrub_stride
osd/scrub: add a variable to store osd_deep_scrub_stride

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
2023-02-20 14:27:31 -08:00
Yuri Weinstein
7e1ade5578
Merge pull request #49199 from ifed01/wip-ifed-fix-require-osd-release
mon: avoid exception when setting require-osd-release more than 2

Reviewed-by: Neha Ojha <nojha@redhat.com>
2023-02-20 14:26:39 -08:00