mon: add warn info for osds were removed from osdmap but still kept in crushmap
Reviewed-by: Piotr Dałek <piotr.dalek@ts.fujitsu.com>
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Sage Weil <sage@redhat.com>
It should live in teuthology, not in Ceph. And it is currently broken:
there is no need to keep it around.
Fixes: http://tracker.ceph.com/issues/18846
Signed-off-by: Loic Dachary <loic@dachary.org>
Previously this was indirect..
monmap requirements -> compatset -> quorum requirements
However, how that we are consistently using the monmap features, we no
longer need to use the compatset features when the monmap already
communicates the same thing. Rename the helper to reflect that
quorum requirements come from both the compatset and the monmap.
Signed-off-by: Sage Weil <sage@redhat.com>
Require that mons are upgraded to luminous first. This will ensure that
the last_force_op_resend flag is set for pre-luminous clients so that
luminous OSDs can safely discard them. (This will come in a future patch.)
Signed-off-by: Sage Weil <sage@redhat.com>
fix coverity cid 1395314: it's invalid to pass a negative value to close function, and we have closed socket in net.connect/nonblock_connect in error cases indeed
Signed-off-by: liuchang0812 <liuchang0812@gmail.com>
- It currently only supports running with filestore
- Testing is executed while running on a ZFS partition
- All disktypes and naming is different on FreeBSD
- Partitioning and tools are not workable on FreeBSD
- add diagnostic timeout
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
if fails and object already exists then retry. This improves first obj
write performance on the expense of overwrites.
Fixes: http://tracker.ceph.com/issues/18622
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
Way back in 9ea02b8410 we defined the
SNAPMAPPER feature such that it set bits 32-63 by sign-extending a negative
int32_t to int64_t. In 4255b5c2fb it was
fixed. This affected v0.58-657-g9ea02b8 to v0.65-263-g4255b5c.
The workaround santized features whenever the top bit 63 was set to be the
intended set of features (bits 0-32). Only buggy peers in that range
ever set bit 63.
Since these versions are truly ancient (pre-dumpling) and no clients
should be that old, we are dropping the workaround. Note that the Linux
kernel client never had this bug: 2b3e0c905af43cfe402a2ef3f800be5dc1684005
went from 30 bits used to 38 bits defiend with the workaround in place.
We deprecate the bit now (i.e., stop paying attention to this bit). After
another extended period of time we'll eventually be able to retire
and reuse it.
Signed-off-by: Sage Weil <sage@redhat.com>
The mon we are talking to may be an old ceph-mon with the prior meanging of
the SERVER_KRAKEN bit; use the mask to disambiguate instead of testing for
two featurse explicitly.
Signed-off-by: Sage Weil <sage@redhat.com>
Test for multiple features all being set together. Note that this can be
used with the CEPH_FEATUREMASK_ defines to safely test for reused feature
bits.
Signed-off-by: Sage Weil <sage@redhat.com>
This lets you test a feature succintly by name, *AND* makes use of the
FEATUREMASK so that it can be used on bitmasks that may come from old
versions with prior usages of the bit. This makes it usable for data
type encoding or with client-provided bits.
Signed-off-by: Sage Weil <sage@redhat.com>