crimson/os: do not let omap_get_values() return input_output_error
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
BlueStore only returns 0 or -ENOENT. so no need to handle the cases
where the return value is neither of them.
but Seastore might return EIO, so keep the interface unchanged.
Signed-off-by: Kefu Chai <kchai@redhat.com>
pass string_view as the section_name when reading options from a
ConfFile. as there is no need to create a temporary string object
if the section name is a `const char*` literal.
also, update the caller site in `common/config.cc` accordingly as a
cleanup. as it's not necessary to pass a `const char*` for the section
name even without this change.
Signed-off-by: Kefu Chai <kchai@redhat.com>
if nasm is able to emit AVX512 instructions, we can assume that it's
able to generate AVX2 instructions as well. so no need to print "Found
nasm" multiple times.
and by chaining mutual exclusive branches with "elseif", we can have
better readability.
Signed-off-by: Kefu Chai <kchai@redhat.com>
not_arch_x32 replicates ${_support_x64}. and a variable starts with
"not" is just difficult to parse. so drop it.
Signed-off-by: Kefu Chai <kchai@redhat.com>
instead of passing an intrusive_ptr<> to it, pass an instance of event
to post_event(). for couple reasons:
* post_event() is able to create an intrusive_ptr<> from the event
passed to it using event.intrusive_from_this() which creates a clone
of the original event. but since the overhead of creating scrub events
is relative low. and presumably, it is not the bottleneck of the
overall performance of Ceph, so it should be fine.
* simpler this way. so we don't need to repeat
`boost::intrusive_ptr<EventName>(new EventName{})`
* more consistent this way. we use the same variant of `post_event()`
elsewhere.
* for silencing the warning from GCC-11, like:
../src/osd/scrub_machine.cc:323:64: note: returned from ‘static void* boost::statechart::event<MostDerived, Allocator>::operator new(std::size_t) [with MostDerived = Scrub::GotReplicas; Allocator =
std::allocator<boost::statechart::none>]’
../src/osd/scrub_machine.cc: In constructor ‘Scrub::WaitReplicas::WaitReplicas(boost::statechart::state<Scrub::WaitReplicas, Scrub::ActiveScrubbing>::my_context)’:
../src/osd/scrub_machine.cc:346:64: warning: ‘static void boost::statechart::event<MostDerived, Allocator>::operator delete(void*) [with MostDerived = Scrub::GotReplicas; Allocator =
std::allocator<boost::statechart::none>]’ called on pointer returned from a mismatched allocation function [-Wmismatched-new-delete]
346 | post_event(boost::intrusive_ptr<GotReplicas>(new GotReplicas{}));
|
this warning is a false alarm. but it is distracting.
Signed-off-by: Kefu Chai <kchai@redhat.com>
This allows the S3 keys to be better protected since the MON can
be configured to restrict access to keys by user and the results
can be encrypted in transit.
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
A special "config://" URI prefix can be used to denote configuration
settings that should be (securely) pulled from the MON config store.
This will be first used in a follow-up commit to support storing
the S3 access and secret keys in the MON config store.
This "config://" syntax is already in-use by RGW and ceph-iscsi for
pulling secrets when deployed via cephadm.
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Since we cannot mark the source image read-only when running in import-only
migration mode, we should require the user to provide a snapshot to ensure
that data cannot change while the migration is running.
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
no need to put `if True`. it was used when removing unused variables.
but it'd be better to have less indent for better readability.
Signed-off-by: Kefu Chai <kchai@redhat.com>
mgr/dashboard:minimize console log traces of Ceph backend API test
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
- Rewrote a sentence about forking.
- s/exactly how to proceed/how to proceed/
- Changed titles to present participles
- Rewrote "Fixing the Bug Locally" to improve its elegance.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
As each osd_op's indata holds only its own data, there's no need to drop their it.
On the other hand, indata is still needed when osd_op needs to be redone in case of
acting set change.
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
mgr/dashboard: Fix for copy2Clipboard failing to copy on the first time
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Fixes: https://tracker.ceph.com/issues/48601
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
Fix for the copy2Clipboard button to work on the first click itself.
acting = where clients requests are processed
up = where pgs were planned to be by crush+upmap
Fixes: https://tracker.ceph.com/issues/48718
Signed-off-by: Jonas Jelten <jj@sft.lol>
