Commit Graph

119688 Commits

Author SHA1 Message Date
Kefu Chai
eadc2bce48 crimson/os: mark unused variable [[maybe_unused]]
to silence warning like

key_layout.h:516:10: warning: unused variable 'nspace_masked'
[-Wunused-variable]
    auto nspace_masked = string_view_masked_t::decode(nspace, delta);
         ^

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-02-08 22:09:46 +08:00
Kefu Chai
876737f92e crimson/os: do not define assignment operator for Value
we cannot assign a reference.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-02-08 22:09:46 +08:00
Kefu Chai
0d7242917b crimson/os: do not capture unused variable
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-02-08 22:09:46 +08:00
Kefu Chai
244a7db3c3 crimson/common: mark ExitBarrier final
to silence warnings like:

crimson/common/operation.h:394:20: warning: class with destructor marked
'final' cannot be inherited from [-Wfinal-dtor-non-final-class]
    ~ExitBarrier() final {
                   ^

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-02-08 22:09:46 +08:00
Xiubo Li
1100403ce6 client: use scoped_lock instead of unique_lock
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2021-02-08 19:02:17 +08:00
Sebastian Wagner
8df1956d16
Merge pull request #39350 from tchaikov/wip-cephadm-unicode
cephadm: do not cast subnet to unicode

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-02-08 11:47:11 +01:00
Sebastian Wagner
44b912b626
Merge pull request #39266 from sebastian-philipp/cephadm-rm-keyring-on-failed-deploy
mgr/cephadm: cleanup daemon keyring on failed daemon deploy

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
2021-02-08 11:46:35 +01:00
Sebastian Wagner
4db6aebee0
Merge pull request #38695 from pcuzner/orch-status-changes
mgr/orchestrator: minor improvements to orch status

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-02-08 11:15:19 +01:00
Kefu Chai
318ddc521c
Merge pull request #39347 from xxhdx1985126/wip-crimson-pg-bug-fix
crimson/osd: make sure ox be removed after all continuations are finished in PG::do_osd_ops

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-02-08 18:08:57 +08:00
Kefu Chai
5ca820fb9e Revert "msg,mon,common: log when DispatchQueue throttle limit is reached"
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-02-08 18:03:14 +08:00
Kefu Chai
b585164877 cephadm: do not cast subnet to unicode
this change addresses a regression introduced by
fe4f4402fb, which was tested before
abd9287db0 got merged. and the former was
merged after abd9287db0. hence the
regression.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-02-08 16:29:55 +08:00
Xuehan Xu
005534856a crimson/osd: make sure ox be removed after all continuations are finished in PG::do_osd_ops
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2021-02-08 15:01:59 +08:00
Kefu Chai
b64e2479b0
Merge pull request #39193 from tchaikov/wip-cephadm-py3
cephadm: drop support to python<3.3

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-02-08 12:20:03 +08:00
Kefu Chai
3d012222fa
Merge pull request #38897 from Daniel-Pivonka/mgroktostop
mgr/cephadm: ok-to-stop for mgr

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-02-08 11:57:21 +08:00
Kefu Chai
b0eb012256
Merge pull request #39082 from ifed01/wip-ifed-meta-in-objectstore-tool
tools/ceph-objectstore-tool: allow object operations on meta pgid

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-02-08 11:55:17 +08:00
Kefu Chai
708de33295
Merge pull request #39273 from tchaikov/wip-timer-mono
common/Timer: use mono_clock for clock_t

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-02-08 11:54:03 +08:00
Kefu Chai
385db1c5a2
Merge pull request #39295 from tchaikov/wip-mgr-balancer-ann
pybind/mgr/balancer: add type annotations

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
2021-02-08 11:52:21 +08:00
Kefu Chai
c7aa97628e
Merge pull request #39164 from tchaikov/wip-crimson-push-mov
crimson/osd: consume the push payload

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
2021-02-08 09:39:35 +08:00
Ali Maredia
88cc6f2231
Merge pull request #39204 from TRYTOBE8TME/wip-rgw-create-bucket-dpp
src/rgw: Dpp addition to create bucket log
2021-02-07 12:07:14 -05:00
root
a53c206f63 rgw: Dpp addition to create bucket log
This commit adds dpp to the create bucket log.

Signed-off-by: Kalpesh Pandya <kapandya@redhat.com>
2021-02-07 20:46:49 +05:30
Kefu Chai
6448226ccc pybind/mgr/balancer: flake8 cleanups
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-02-07 20:18:42 +08:00
Kefu Chai
0d48b03db2 pybind/mgr/balancer: define Plan.{dump,show}()
as they are called by the commands

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-02-07 20:18:42 +08:00
Kefu Chai
51ee3926d7 pybind/mgr/alerts: flake8 cleanups
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-02-07 20:18:42 +08:00
Kefu Chai
af3f49d981 pybind/mgr/balancer: define options using Option
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-02-07 20:18:42 +08:00
Kefu Chai
376939d8d8 pybind/mgr/balancer: add type annotations
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-02-07 20:18:41 +08:00
Kefu Chai
46f00b3da2 pybind/mgr/balancer: define commands using CLICommand
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-02-07 20:17:58 +08:00
Kefu Chai
e06bf9157e
Merge pull request #39336 from AlexWangD/patch-4
doc: fix the spelling mistake of “Topicd”

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-02-07 20:07:01 +08:00
Alex Wang
357e1b2c84
doc: fix the spelling mistake of “Topicd”
“Topicd” is a spelling mistake of "Topics".
2021-02-07 15:26:04 +08:00
Kefu Chai
b3e1a0c122
Merge pull request #37566 from AmnonHanuhov/wip-ObjectStore_EIO_Handling
crimson/osd: Recover missing object on read error

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-02-07 12:18:01 +08:00
Yingxin Cheng
4f556014b0 crimson/onode-staged-tree: cleanup -- switch to get_*_slot() interfaces
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-02-07 10:19:41 +08:00
Mykola Golub
7bafcfbb01
Merge pull request #39303 from dillaman/wip-49173
librbd/io: conditionally disable move optimization

Reviewed-by: Mykola Golub <mgolub@suse.com>
2021-02-06 11:23:45 +02:00
chunmei-liu
ca3ac9830e crimson/seastore: fix omap manager DENC issue
Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
2021-02-05 18:11:28 -08:00
J. Eric Ivancich
36a208f287
Merge pull request #39312 from ivancich/wip-orphan-list-binary-data
rgw: allow rgw-orphan-list to handle intermediate files w/ binary data

Reviewed-by: Michael Kidd <linuxkidd@gmail.com>
2021-02-05 14:46:56 -05:00
Michael Fritch
80990f5bdc
mgr/cephadm: Redefinition of unused name from line n (F811)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:58 -07:00
Michael Fritch
2e2b419daf
mgr/cephadm: Module imported but unused (F401)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:58 -07:00
Michael Fritch
6658c53d6f
mgr/cephadm: Local variable name is assigned to but never used (F841)
add error handling when `CompletedProcess` fails during rgw relam,
zongroup create et al.

Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:57 -07:00
Michael Fritch
97c6a8564e
mgr/cephadm: Local variable name is assigned to but never used (F841)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:57 -07:00
Michael Fritch
4e4d4c5e4b
mgr/cephadm: Line break occurred after a binary operator (W504)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:57 -07:00
Michael Fritch
8e093a5993
mgr/cephadm: Trailing whitespace (W291)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:57 -07:00
Michael Fritch
867c7423e5
mgr/cephadm: undefined name 'channel' (F821)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:56 -07:00
Michael Fritch
b40d28ce90
mgr/cephadm: use ==/!= to compare constant literals (F632)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:56 -07:00
Michael Fritch
22d6a1b7d8
mgr/cephadm: f-string is missing placeholders (F541)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:56 -07:00
Michael Fritch
fb73d8e5c2
mgr/cephadm: Do not use variables named 'I', 'O', or 'l' (E741)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:55 -07:00
Michael Fritch
e26db8c210
mgr/cephadm: Do not assign a lambda expression, use a def (E731)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:55 -07:00
Michael Fritch
9b0a3e6239
mgr/cephadm: Do not use bare except, specify exception instead (E722)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:55 -07:00
Michael Fritch
5136f4b1d0
mgr/cephadm: Comparison to true should be 'if cond is true:' or 'if cond:' (E712)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:54 -07:00
Michael Fritch
1738e22ec0
mgr/cephadm: Multiple statements on one line (def) (E704)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:54 -07:00
Michael Fritch
bed9be73ee
mgr/cephadm: statement ends with a semicolon (E703)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:32 -07:00
Michael Fritch
d76324ea38
mgr/cephadm: Expected 1 blank line before a nested definition (E306)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:02 -07:00
Michael Fritch
7e73af4b98
mgr/cephadm: Expected 2 blank lines, found 0 (E302)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:01 -07:00