Commit Graph

105121 Commits

Author SHA1 Message Date
Patrick Donnelly
b45c08b997
pybind/mgr/volumes: print errors in cleanup timer
The squelched error prevented us from knowing connection cleanup doesn't
work on py3.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2019-12-04 07:01:41 -08:00
Patrick Donnelly
4e16633856
qa: improve variable name
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2019-12-04 07:01:34 -08:00
Sage Weil
0de99152cc mon: fix mon_sync_max_payload_size type
Signed-off-by: Sage Weil <sage@redhat.com>
2019-12-04 08:52:28 -06:00
Sage Weil
4d6c7e349b mon: cap keys in mon_sync messages
The previous cap was set at 1 MB.  However, a user was experiencing mon
timeouts while syncing the purged_snap_epoch * keys, which are ~20 bytes
each.  Reducing the max payload to 64K resolved the problem, which maps
to (very!) roughly 1500 keys per message.  Set our limit a bit higher than
that since we just made this quite a bit more efficient.  Most of the time
the keys are larger than 20 bytes and we wouldn't hit the key limit, but
having one ensures that we won't burn too much CPU in one go when we do
have lots of these little keys.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-12-04 08:52:15 -06:00
Sage Weil
b7f9f3651f doc/install/containers: note vX.Y.Z[-YYYYMMDD] tags
Signed-off-by: Sage Weil <sage@redhat.com>
2019-12-04 08:22:52 -06:00
Zac Dover
c0e09de50b doc: add "chrony" to preflight checklist for Ubuntu 18.04
This commit updates the "Install NTP" section of the preflight
checklist, instructing readers who are using Ubuntu 18.04 to
use the package name "chrony" where elsewhere the package name
"ntp" would be used. "chrony" has replaced "ntp" in Ubnutu 18.04.

This commit fixes Bug number 8 in the list here:
https://pad.ceph.com/p/Report_Documentation_Bugs

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2019-12-05 00:07:24 +10:00
Casey Bodley
18555ad75a
Merge pull request #31972 from clwluvw/patch-1
doc: rgw: Fixed bug on wrong name for user_id for OPA

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2019-12-04 08:32:00 -05:00
Laura Paduano
c0a409944a
Merge pull request #31906 from s0nea/wip-dashboard-fix-pg-num-warning
mgr/dashboard: fix tests in order to match pg num conventions

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
2019-12-04 14:20:39 +01:00
Jason Dillaman
b27820cc73 rbd: incorporate rbd-mirror daemon status in mirror pool status
This will ensure that the Ceph dashbord's block mirroring page and
the CLI's 'mirror pool status' have matching health indications.

Fixes: https://tracker.ceph.com/issues/42748
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-12-04 08:14:06 -05:00
Sage Weil
361b1906e9 mgr/restful: allow shutdown before we've fully started up
Sometimes we get shutdown() before self.server has been assigned.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-12-04 07:13:44 -06:00
Sage Weil
77068f2e47 Merge PR #31797 into master
* refs/pull/31797/head:
	qa: test mgr cephfs mount blacklist
	mgr: forward RADOS client instances for potential blacklist
	mon/MgrMonitor: blacklist previous instance
	mon: set RUNTIME flag on mon_mds_blacklist_interval
	mgr: use more efficient data structure

Reviewed-by: Sage Weil <sage@redhat.com>
2019-12-04 07:10:49 -06:00
Mykola Golub
20c721f3f5
Merge pull request #31950 from dillaman/wip-mirror-peer-fsid
rbd-mirror: peer_ping should send the local fsid to the remote

Reviewed-by: Mykola Golub <mgolub@suse.com>
2019-12-04 15:08:23 +02:00
Sage Weil
e24f597630 Merge PR #31908 into master
* refs/pull/31908/head:
	ceph-daemon: use uid/gid 0 when creating tempfiles
	ceph-daemon: drop unneeded `mode` during tmpfile create
	ceph-daemon: consolidate NamedTemporaryFile logic
	ceph-daemon: chown uid/gid `ceph-volume` tmpfiles

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
2019-12-04 07:06:34 -06:00
Sage Weil
c26c1efdd8 Merge PR #31940 into master
* refs/pull/31940/head:
	mgr/ssh: Port raising exceptions from completion handlers to Py2

Reviewed-by: Joshua Schmid <jschmid@suse.de>
2019-12-04 07:06:13 -06:00
Patrick Seidensal
36421284c3 mgr/dashboard: extend dashboard documentation
by adding the previously added monitoring related features as well as
the newest feature addition. Extends the documentation where necessary
to describe the Prometheus' alert configuration.

Fixes: https://tracker.ceph.com/issues/42877

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
2019-12-04 12:27:37 +01:00
Jianpeng Ma
296364df73 msg/async: No need lock for func _filter_addrs
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
2019-12-04 13:17:24 +08:00
Kefu Chai
aaba179533
Merge pull request #31990 from dzafman/wip-43084
tools/osdmaptool.cc: do not use deprecated std::random_shuffle()

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>
2019-12-04 12:30:11 +08:00
Patrick Donnelly
98e3b7efe8
qa: test mgr cephfs mount blacklist
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2019-12-03 17:53:14 -08:00
Patrick Donnelly
df507cde8d
mgr: forward RADOS client instances for potential blacklist
The mgr creates a per-module RADOS client connection for modules which
interact with RADOS (e.g. the volumes module). These clients should also
be blacklisted when the active mgr is failed; we don't want the former
active mgr to continue interacting with RADOS when the new one takes
over. This is particularly impactful for avoiding extraneous
"unresponsive client" warnings from the MDS when the mgr switches
(especially in testing). The MDS will pickup the new OSD blacklists
which include's the old mgr's libcephfs instance and blacklist/evict
that session quietly.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2019-12-03 17:53:14 -08:00
Patrick Donnelly
f2986a4400
mon/MgrMonitor: blacklist previous instance
This wasn't realized as necessary early on in the ceph-mgr development
because the mgr didn't interact with RADOS. However, now it is becoming
common for plugins to store data there. It's important that the previous
instance can no longer interact with RADOS while the new mgr takes over.

In particular, this means that the mgr's client sessions with the MDS
are automatically evicted once the MDS receives the new OSDMap. This
avoids a pesky "unresponsive client" warning in the cluster logs.

Fixes: https://tracker.ceph.com/issues/42939
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2019-12-03 17:53:13 -08:00
Patrick Donnelly
cc6422af85
mon: set RUNTIME flag on mon_mds_blacklist_interval
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2019-12-03 17:53:13 -08:00
Patrick Donnelly
78576c9eec
mgr: use more efficient data structure
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2019-12-03 17:53:13 -08:00
Kefu Chai
30dfef208d tools/osdmaptool.cc: do not use deprecated std::random_shuffle()
the use of `std::random_shuffle()` was introduced by
b946308 .

in this change, it is replaced using `std::shuffle()`.

Fixes: https://tracker.ceph.com/issues/43084

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-12-03 16:06:40 -08:00
Sage Weil
dd23fb4be3 mgr/MgrClient: fix 'tell mgr.x ...'
If we start the command before we get the mgrmap at the client, we
will send MCommand via a different code path; make sure it behaves
correctly too.

Missed this in 6f35d28352

Signed-off-by: Sage Weil <sage@redhat.com>
2019-12-03 17:56:46 -06:00
Sage Weil
c7e3dd0af4 common/config: less noise about configs from mon we can't apply
It is normal to set things in teh mon config database that can't be absorbed
by clients/daemons at runtime.  Things like ms_type can/should be set there
(so that they, for instance, help produce the 'config minimal-conf') but
we don't need daemons to spit out error messages every time they get a config
update.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-12-03 17:54:44 -06:00
Sage Weil
0e0c32ce21 Merge PR #31891 into master
* refs/pull/31891/head:
	qa/suites/rados/ssh: only install ceph-daemon for packaged mode
	tasks/ceph2: add support for packaged ceph-daemon
	qa/tasks/ceph2: make image cluster-private
	qa/tasks/ceph2: add 'shell' command

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2019-12-03 16:49:28 -06:00
Sage Weil
e58515227a Merge PR #31984 into master
* refs/pull/31984/head:
	mgr/telemetry: fix log typo

Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-12-03 16:11:21 -06:00
Sage Weil
1770270af6 Merge PR #31869 into master
* refs/pull/31869/head:
	ceph-daemon: bootstrap: deploy initial mon via deploy_daemon()
	qa/standalone/test_ceph_daemon.sh: more $SUDO
	ceph-daemon: configure firewalld for new daemon deploys
	ceph-daemon: name mgr the same way mgr/ssh does

Reviewed-by: Michael Fritch <mfritch@suse.com>
2019-12-03 16:00:14 -06:00
Sage Weil
e3bc13de3a Merge PR #31930 into master
* refs/pull/31930/head:
	mgr/orchestrator: add optional "format" param for "orchestrator host ls"

Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Sage Weil <sage@redhat.com>
2019-12-03 15:59:16 -06:00
Ilya Dryomov
0632872e07
Merge pull request #31968 from idryomov/wip-krbd-python3
qa: update krbd tests for python3

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2019-12-03 21:54:41 +01:00
Sage Weil
462aa8ff95 mgr/telemetry: fix log typo
Signed-off-by: Sage Weil <sage@redhat.com>
2019-12-03 13:38:50 -06:00
Sage Weil
5d8ca08924 Merge PR #31983 into master
* refs/pull/31983/head:
	mgr/ssh/tests: fix RGWSpec test

Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-12-03 13:20:16 -06:00
Yuval Lifshitz
19832a0dae rgw/pubsub: support eventId in push mode
Signed-off-by: Yuval Lifshitz <yuvalif@yahoo.com>
2019-12-03 20:42:20 +02:00
Yuval Lifshitz
9cce2381cb rgw/pubsub: prevent kafka thread from spinning when there are no
messages

Signed-off-by: Yuval Lifshitz <yuvalif@yahoo.com>
2019-12-03 20:16:25 +02:00
Sage Weil
5f649cff42 mgr/ssh/tests: fix RGWSpec test
Signed-off-by: Sage Weil <sage@redhat.com>
2019-12-03 12:14:47 -06:00
Sage Weil
d5f1730025 Merge PR #31973 into master
* refs/pull/31973/head:
	mgr/crash: fix 'crash ls[-new]' sorting

Reviewed-by: Sebastian Wagner <swagner@suse.com>
2019-12-03 11:32:55 -06:00
Lenz Grimmer
11a1708e19
mgr/dashboard: grafana charts match time picker selection. (#31964)
mgr/dashboard: grafana charts match time picker selection.

Reviewed-by: Jan Fajerski <jfajerski@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Patrick Seidensal <pnawracay@suse.com>
2019-12-03 17:09:00 +00:00
Sage Weil
8b20bb016d doc/foundation: add ceph foundation info here
Signed-off-by: Sage Weil <sage@redhat.com>
2019-12-03 10:45:45 -06:00
Sage Weil
4f29870543 Merge PR #31890 into master
* refs/pull/31890/head:
	mgr/orchestrator: name rgw by client.rgw.$realm.$zone[.$id]

Reviewed-by: Ali Maredia <amaredia@redhat.com>
2019-12-03 10:38:28 -06:00
Sage Weil
729007ba66 Merge PR #31952 into master
* refs/pull/31952/head:
	mgr/ssh: fix remove_osds
	mgr/ssh: fix service_action

Reviewed-by: Sebastian Wagner <swagner@suse.com>
2019-12-03 10:33:44 -06:00
Sage Weil
db736e082f ceph-daemon: bootstrap: deploy initial mon via deploy_daemon()
Signed-off-by: Sage Weil <sage@redhat.com>
2019-12-03 10:13:38 -06:00
Sage Weil
8aadba15bf qa/standalone/test_ceph_daemon.sh: more $SUDO
Signed-off-by: Sage Weil <sage@redhat.com>
2019-12-03 10:13:37 -06:00
Sage Weil
7630ac6ae9 ceph-daemon: configure firewalld for new daemon deploys
Note that we only open firewalld ports; we never close them.

We could conceivably do that from rm-cluster, but that might also interfere
with something else on the host...

Signed-off-by: Sage Weil <sage@redhat.com>
2019-12-03 10:13:37 -06:00
Seena Fallah
c13cdfd57d Fixed bug on wrong name for user_id
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
2019-12-03 19:37:04 +03:30
Kefu Chai
3719fceb99
Merge pull request #31202 from athanatos/sjust/wip-crimson-obc
crimson, common: Add ephemeral ObjectContext state to crimson

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-12-04 00:04:20 +08:00
Patrick Seidensal
855f214b29 mgr/dashboard: move monitoring tabs to a single page
with a tab for 'active alerts', 'all alerts' and 'silences'. Due to
ambiguity with existing names, `AlertListComponent` has been renamed to
`ActiveAlertListComponent`. Introduces `MonitoringListComponent` as
first page for monitoring concerns, using path `/monitoring`.

Keeps the activated tab open, independent of the way that's used to go
back to the previous page, be it the cancel button or submit button or
the link on the breadcrumb. Also keeps the active tab open even when the
page is reloaded.

Fixes: https://tracker.ceph.com/issues/42877

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
2019-12-03 16:54:24 +01:00
Patrick Seidensal
b85b24b2d0 mgr/dashboard: refactor test of Prometheus alert service
Mocking the test the way it was removed the asynchronous nature of the
test. By using an Observable the test can stay asynchronous and be
tested as well.

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
2019-12-03 16:54:24 +01:00
Patrick Seidensal
2a50e277d4 mgr/dashboard: list configured Prometheus alerts
Fixes: https://tracker.ceph.com/issues/42877

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
2019-12-03 16:54:24 +01:00
Patrick Seidensal
4917279f9f mgr/dashboard: return Prometheus alert groups, too
Fixes: https://tracker.ceph.com/issues/42877

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
2019-12-03 16:54:24 +01:00
Sebastian Wagner
c162b8345e mgr/ssh: HACKING.rst: Add Understanding AsyncCompletion
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-12-03 16:27:06 +01:00