* refs/pull/28692/head:
test_volume_client: add positive test for ceph_volume_client method
test_volume_client: rename test_put_object_versioned()
test_volume_client: rewrite test_put_object_versioned
test_volume_client: use sudo_write_file() form teuthology
test_volume_client: make test_object_versioned py3 compatible
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
ceph_volume_client.py's put_object_versioned() has only one test. Since
this only test is a negative test it may fail to assure that
put_object_versioned() works as expected with positive inputs even when
it completes successfully. Therefore, write a positive test for better
coverage.
Also, make sure the new test is both python 2 and python3 compatible.
Signed-off-by: Rishabh Dave <ridave@redhat.com>
test_put_object_versioned() is too generic for a negative test that
specifically tests if the version is verified before writing.
Signed-off-by: Rishabh Dave <ridave@redhat.com>
The test's success depends on whether CommandFailedError exception is
raised. This manner of testing is unreliable since there's no way to
check if the exception was raised by the statement (in the embedded
Python program) the test expects to.
This implies that this test's failure may go undetected. This is primary
reason why bugs like tracker #38946 occured despite of having a test.
Fixes: http://tracker.ceph.com/issues/39510
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Instead of defining another method to write a file as root user in
test_volume_client.py, use the method from teuthology/misc.py.
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Convert strings to bytes in the Python program embedded inside this
test. Also, in the process don't lose Python 2 compatibility.
Fixes: http://tracker.ceph.com/issues/39405
Signed-off-by: Rishabh Dave <ridave@redhat.com>
.. and since we have async subvolume deletes now, check
trash directory for emptiness in other tests.
Fixes: http://tracker.ceph.com/issues/40036
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Test `test_subvolume_create_with_desired_mode_in_group()` creates three
subvolume in a subvolume group. During cleanup, it only removed two of
the three subvolumes. This causes failure when removing the subvolume
group since it's not empty.
Signed-off-by: Venky Shankar <vshankar@redhat.com>
* refs/pull/27073/head:
qa/tasks: Check MDS failover during mon_thrash
qa/tasks: Compare two FSStatuses
qa/suites/fs: renamed default.yaml to mds.yaml
qa/suites/fs: mon_thrash test for fs
qa/tasks: Fix typo in the comment
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
* refs/pull/28642/head:
mds: check last laggy before marking unresponsive client stale
mds: remove the code that skip evicting the only client
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
... of fs subvolumes and subvolume groups during their creation.
Fixes: https://tracker.ceph.com/issues/40299
Signed-off-by: Ramana Raja <rraja@redhat.com>
... of fs subvolumes and subvolume groups during their creation.
Fixes: https://tracker.ceph.com/issues/40431
Signed-off-by: Ramana Raja <rraja@redhat.com>
* refs/pull/28194/head:
test_volume_client: declare only one default for python version
test_volume_client: don't shadow class variable
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
There is already logic that defer marking unresponsive client stale.
No reason to defer evicting the only stale client.
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
* refs/pull/27856/head:
test: remove fs/test-volume.sh workunit
test: port fs/volume related tests to python
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
* refs/pull/28221/head:
qa/tasks/cephfs/test_volume_client: print py2 or py3 which the test case runs
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
* refs/pull/28293/head:
mds: avoid passing null to SessionmMap::hit_session()
qa/cephfs: add test for blacklisted client eviction
mds: fix 'is session in blacklist' check in Server::apply_blacklist()
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
sudo cannot be omitted from the given command's arguments, when running
passwd, chown and, specially, when sudo is used for running the given
command as different user.
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Instead of looking at the number of threads (used by the simple messenger) to
judge the coming and going of connections, use the (async) messenger perf
counters.
Plus some other minor improvements.
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Client unmount during test cleanup will hang if the file system was deleted.
Fixes: http://tracker.ceph.com/issues/38518
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
If we use the defaults, the MDS/client will recall/release everything quickly.
We want it to take time to see things like the timeout get hit.
Fixes: http://tracker.ceph.com/issues/38348
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
