Replaces Directive-Based copy2ClipboardButton with a Component-based version.
Further replaces all instances of Directive use with Component version.
Similar toastr logic used.
Fixes: https://tracker.ceph.com/issues/44960
Signed-off-by: Courtney Caldwell <ccaldwel@redhat.com>
This acts like a big hammer to avoid adding sensitive information, like passwords
into mon/mgr/cluster logs when using "config set" and "config-key set" to set keys
whose values should be secure.
Fixes: https://tracker.ceph.com/issues/37503
Signed-off-by: Neha Ojha <nojha@redhat.com>
first can be deduced by variable already captured, so store it as a
local variable. it's less expensive than storing it as a captured
variable.
Signed-off-by: Kefu Chai <kchai@redhat.com>
in this change, a seastar::do_with() is removed, as the captured
variables are passed to submit_push_data() by value. so no need to keep
them alive after the call.
Signed-off-by: Kefu Chai <kchai@redhat.com>
trim_pushed_data() is responsible for building up the extents to be used
for pushing. so let it return the extents.
Signed-off-by: Kefu Chai <kchai@redhat.com>
also add comment explaining
ReplicatedRecoveryBackend::trim_pushed_data()
and move the definition of local variable closer to where it is used.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Added a generic Error component for HTTP Errors such as 404,403,501
Fixes:https://tracker.ceph.com/issues/39128
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
Perform a basic sanity check to verify that the remote start snapshot
still exists. This was previosly being deleted as part of the unlink
process due to a race condition between the remote side completing
a sync between snapshots 1 and 2 and snapshot 2 being unlinked due
to reaching max snapshots.
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
cmake: add alien::cflags and move SubProcess.cc into crimson-alien-common
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
This is a follow-up to the c2dc437f78cd8be393c4d2eb8d79ce9c351ec4de
which removes unused OBC mebers after the with_lock() transition.
I'm not sure there is a reason to keep the `Blocker` bits as all
`ObjectContext::dump_detail()` does is just dumping `object_state_t`
while entering the OBC stage is already denoted by `PGPipeline::get_obc`.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
which exposes the definitions needed for building alienized bluestore
and the shared facilities compiled with -DWITH_ALIEN and -DWITH_SEASTAR
Signed-off-by: Kefu Chai <kchai@redhat.com>
ReplicatedRecoveryBackend::prep_push() is responsible for building
PushOps, so it's more natural to let it return a map of PushOp.
Signed-off-by: Kefu Chai <kchai@redhat.com>
if the variables held by do_with() is not used by the continuation, and
the continuation does not depend on the other continuations called in
the do_with(), let's move it out for smaller lexical scope. and hence
better readability.
Signed-off-by: Kefu Chai <kchai@redhat.com>
