Commit Graph

68515 Commits

Author SHA1 Message Date
Josh Durgin
f75e5c99b1 osd: clarify REQUIRE_LUMINOUS error message
This should be visible at the default log level, so users have some
hope of figuring out the problem.

Signed-off-by: Josh Durgin <jdurgin@redhat.com>
2017-02-10 14:27:18 -08:00
John Spray
0eb0abae63 doc: ref cephfs docs from os-recommendations
...instead of having potentially conflicting kernel
version information.

Signed-off-by: John Spray <john.spray@redhat.com>
2017-02-10 21:24:08 +01:00
Ilya Dryomov
09ce8867e8 doc: update krbd kernel recommendations
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2017-02-10 21:24:08 +01:00
Kefu Chai
87bdeb23aa Merge pull request #13249 from liewegas/wip-mon-smooth
mon: smooth io/recovery stats over longer period

Reviewed-by: Kefu Chai <kchai@redhat.com>
2017-02-11 04:02:48 +08:00
Kefu Chai
108f2e20a8 Merge pull request #13264 from tchaikov/wip-print-failed-test-name
qa/workunits/rados/test.sh: print test name when it fails

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2017-02-11 03:57:45 +08:00
Kefu Chai
d52918779a Merge pull request #13362 from adamemerson/wip-oh-yeah
test: Fix mismatched sign comparison in histogram test

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2017-02-11 03:56:31 +08:00
Samuel Just
6da3f9a5d2 Merge pull request #13344 from gregsfortytwo/wip-osd-discussion-docs
Wip osd discussion docs

Reviewed-by: Samuel Just <sjust@redhat.com>
2017-02-10 11:20:02 -08:00
Samuel Just
534ae8fe04 Merge pull request #13342 from athanatos/wip-17831-18583-18809
osd/: don't leak context for Blessed*Context or RecoveryQueueAsync

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2017-02-10 11:18:02 -08:00
Adam C. Emerson
ae43b774a4 test: Fix mismatched sign comparison in histogram test
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2017-02-10 13:50:58 -05:00
Ken Dreyer
0be7a9ae4e doc: improve firewalld instructions
firewalld in RHEL 7.3 contains service definitions for ceph's ports, so
we can simply use "--add-service=ceph-mon" or "--add-service=ceph"
rather than having to remember specific port numbers.

Break out two examples for both MONs and OSDs/MDSs.

Add the "firewall-cmd --reload" step to ensure the --permanent configs
take effect immediately.

Signed-off-by: Ken Dreyer <kdreyer@redhat.com>
2017-02-10 11:08:28 -07:00
John Spray
880cbf09aa Merge pull request #13137 from jcsp/wip-18661
qa: fix race in Mount.open_background

Reviewed-by: Yan, Zheng <zyan@redhat.com>
2017-02-10 17:48:05 +00:00
John Spray
a3fd3f225c Merge pull request #13099 from jcsp/wip-18663
qa/tasks: force umount during kclient teardown
2017-02-10 17:42:37 +00:00
Sage Weil
6470a90034 Merge pull request #13281 from theanalyst/release/v12.0.0
doc: v12.0.0 release notes

Reviewed-by: Sage Weil <sage@redhat.com>
2017-02-10 10:57:27 -06:00
Sage Weil
411d488823 Merge pull request #13302 from YankunLi/lyk_clean_code
rgw: clean redundant code

Reviewed-by: Sage Weil <sage@redhat.com>
2017-02-10 10:53:14 -06:00
Sage Weil
edebfed48e Merge pull request #13304 from majianpeng/async-tracing
msg/async: cleanup code.

Reviewed-by: Haomai Wang <haomai@xsky.com>
2017-02-10 10:52:45 -06:00
Sage Weil
e9b3f16ade Merge pull request #13329 from Adirl/fix_febe
msg: Fix calls to Messenger::create with new parameter

Reviewed-by: Haomai Wang <haomai@xsky.com>
2017-02-10 10:48:58 -06:00
Sage Weil
602278dc25 Merge pull request #13351 from tchaikov/wip-init-ceph-newline
init-ceph: print trailing n in "status" output

Reviewed-by: Nathan Cutler <nculter@suse.com>
Reviewed-by: Sage Weil <sage@redhat.com>
2017-02-10 10:40:36 -06:00
Sage Weil
7c43f5e7e2 Merge pull request #13356 from rubenk/rgw-docs-fix-typo
doc: Fix typo and grammar in RGW config reference

Reviewed-by: Sage Weil <sage@redhat.com>
2017-02-10 10:38:09 -06:00
Kefu Chai
787f6ac699 qa/workunits/rados/test.sh: print test name when it fails
we have

2017-02-04T16:15:46.090 INFO:tasks.workunit.client.0.mira032.stdout:error in 22088
2017-02-04T16:15:46.092 INFO:tasks.workunit.client.0.mira032.stderr:bash: line 1: 22092 Alarm clock             ceph_test_rados_api_aio 2>&1
2017-02-04T16:15:46.096 INFO:tasks.workunit.client.0.mira032.stderr:     22093 Done                    | tee ceph_test_rados_api_aio.log
2017-02-04T16:15:46.099 INFO:tasks.workunit.client.0.mira032.stderr:     22094 Done                    | sed "s/^/                  api_aio: /"
2017-02-04T16:15:46.102 INFO:tasks.workunit.client.0.mira032.stderr:+

if a unittest in rados/test.sh fails in teuthology.log, but it would
be desirable to have the failed test name in the line of "error in
22088".

Signed-off-by: Kefu Chai <kchai@redhat.com>
2017-02-10 23:54:29 +08:00
Jason Dillaman
697416b286 Merge pull request #13258 from trociny/wip-18819
common: possible lockdep false alarm for ThreadPool lock

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2017-02-10 10:17:23 -05:00
Jason Dillaman
26672a3497 Merge pull request #13287 from guihecheng/rbd-fix
librbd: fix segfault on EOPNOTSUPP returned while fetching snapshot timestamp

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2017-02-10 09:21:47 -05:00
Ruben Kerkhof
3a1c7b19df doc: Fix typo and grammar in RGW config reference
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2017-02-10 15:07:38 +01:00
Jason Dillaman
9a3c4d0511 Merge pull request #13322 from ceph/wip-include-workqueue
librbd: Include WorkQueue.h since we use it

Reviewed-by: Mykola Golub <mgolub@mirantis.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2017-02-10 08:58:38 -05:00
Zhiqiang Wang
1842a910cc osd: fix the setting of soid in sub_op_push
In the case of recovery pull using sub op, and if the prep push on
remote peers fail for some reasons, recovery_info.soid is not set
in prep_push_op_blank. Use it on the primary would lead to an
assertion failure.

Signed-off-by: Zhiqiang Wang <zhiqiang@xsky.com>
2017-02-10 17:52:44 +08:00
Kefu Chai
68ab318944 init-ceph: print trailing n in "status" output
the version command is handled by HelpHook, which does not print newline
at the end of the returned JSON. so the output of "status" subcommand
looks like:

=== osd.1 ===
osd.1: running {"version":"Development"}=== osd.2 ===
osd.2: not running.

with this change, a newline is added to the end of version.

also use the "daemon" subcommand to talk to the asok, let the "ceph" cli
to figure out the asok path.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2017-02-10 17:42:55 +08:00
Nathan Cutler
9bd91dc5d9 Merge pull request #13338 from kshtsk/add-bc-to-deps
ceph.spec.in, debian/control: Add bc to build dependencies

Reviewed-by: Dan Mick <dan.mick@redhat.com>
Reviewed-by: Nathan Cutler <ncutler@suse.com>
2017-02-10 10:28:10 +01:00
Kefu Chai
7caa2d7bc3 Merge pull request #13334 from tchaikov/wip-osd-scrub-repair-more-patient
tests: osd-scrub-repair.sh disable scrub backoff in test

Reviewed-by: David Zafman <dzafman@redhat.com>
Reviewed-by: Loic Dachary <ldachary@redhat.com>
2017-02-10 10:36:10 +08:00
xie xingguo
db107cc7f1 crush: do is_out test only if we do not collide
The is_out() test could requires additional hash, so we shall
skip it whenever it is possible.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
2017-02-10 09:38:09 +08:00
Kyr Shatskyy
3ff4be6d68 ceph.spec.in, debian/control: Add bc to build dependencies
The bc is missing for ceph-helpers.sh

Fixes: http://tracker.ceph.com/issues/18876
Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@gmail.com>
2017-02-10 00:43:53 +01:00
Greg Farnum
db5ed8ed4a OSD: update OSD backfill discussion comments
Signed-off-by: Greg Farnum <gfarnum@redhat.com>
2017-02-09 15:28:11 -08:00
Loic Dachary
29e18707d4 Merge pull request #13309 from dachary/wip-mailmap
mailmap updates

Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>
2017-02-10 00:13:26 +01:00
Kefu Chai
6016dd9acb tests: osd-scrub-repair.sh disable scrub backoff in test
there is good chance that the newly scheduled scrub fail to pass the
flip-coin check: the probability of scheduling a new scrub 1/3 every
time we flip the coin. so, instead hardwiring the probability to 1/3,
a new option named "osd_scrub_backoff_ratio" is introduced. so we can
override it when performing test.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2017-02-10 03:25:12 +08:00
Sage Weil
2ed28407e7 Merge pull request #13325 from liewegas/wip-fsck
ceph_test_objectstore: tolerate fsck EOPNOTSUPP too

Reviewed-by: Kefu Chai <kchai@redhat.com>
2017-02-09 08:39:03 -06:00
Sage Weil
3af6e992c9 Merge pull request #13208 from ceph/wip-dalgaaf-sca-20170131
misc: SCA and Coverity Fixes

Reviewed-by: Sage Weil <sage@redhat.com>
2017-02-09 08:30:44 -06:00
Sarit Zubakov
206942737a msg: Fix calls to Messenger::create with new parameter
Update all calls to Messenger::create()
take 'ms_public_type' or 'ms_cluster_type' instead of 'ms_type'

issue: 971661

Change-Id: Ib234daf393d1838ef596dde35a6d83c1aeecaf10
Signed-off-by: Sarit Zubakov <saritz@mellanox.com>
2017-02-09 11:54:46 +00:00
Kefu Chai
f95627f220 Merge pull request #13306 from tchaikov/wip-18464
rocksdb: sync with upstream

Reviewed-by: Nathan Cutler <ncutler@suse.com>
2017-02-09 17:31:05 +08:00
Nathan Cutler
a605089522 Merge pull request #13313 from smithfarm/wip-18856
tests: update SUSE yaml facets in qa/distros/all

Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>
2017-02-09 10:14:20 +01:00
Boris Ranto
480f82847a librbd: Include WorkQueue.h since we use it
We use m_work_queue of type ContextWQ in handle_update function but we
do not include common/WorkQueue.h that defines ContextWQ. This results
in dereference of an incomplete type and causes build error in latest
Fedora rawhide (future 26).

Fixes: http://tracker.ceph.com/issues/18862

Signed-off-by: Boris Ranto <branto@redhat.com>
2017-02-09 09:44:29 +01:00
Kefu Chai
f630600666 script/sepia_bt.sh: support xenial
* support xenial
* support "rados" cli debugging
* do not include the ending "'" in the prog name sending to gdb

Signed-off-by: Kefu Chai <kchai@redhat.com>
2017-02-09 14:35:04 +08:00
songbaisen
0b4e2c626c osd: add is_split check before _start_split
Signed-off-by:song baisen <song.baisen@zte.com.cn>
2017-02-09 11:05:42 +08:00
Zhiqiang Wang
2e80950521 osd: fix stat sum update of recovery pushing
Use the stat field of PushInfo to do the stat update, which is
more accurate, especially in the case of sparse file. Also,
remove the stat sum update in on_peer_recover, which is done in
on_global_recover.

Signed-off-by: Zhiqiang Wang <zhiqiang@xsky.com>
2017-02-09 10:58:26 +08:00
Danny Al-Gaaf
ce5493cab0 RadosStriperImpl.cc: fix double free
Some variables have been already free'd by calling
release(), no need to call delete() again on them.

CID 1396200 (#1 of 1): Double free (USE_AFTER_FREE)
 double_free: Calling operator delete frees pointer
 getxattr_completion which has already been freed.
CID 1396206 (#1 of 1): Double free (USE_AFTER_FREE)
 double_free: Calling operator delete frees pointer
 getxattr_completion which has already been freed.
CID 1396214 (#1 of 1): Double free (USE_AFTER_FREE)
 double_free: Calling operator delete frees pointer
 stat_completion which has already been freed.
CID 1396218 (#1 of 1): Double free (USE_AFTER_FREE)
 double_free: Calling operator delete frees pointer
 stat_completion which has already been freed.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2017-02-08 21:54:25 -05:00
Danny Al-Gaaf
ea34ee50c9 osdc/ObjectCacher.cc: fix wrong self assignment
Fix for:

CID 1395468 (#1 of 1): Self assignment (NO_EFFECT)
self_assign: Assigning bh->last_write to itself has no effect.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2017-02-08 21:54:25 -05:00
Danny Al-Gaaf
79dbe984c9 common/Checksummer.h: close resource leak
CID 1395784 (#2-1 of 2): Resource leak (RESOURCE_LEAK)
 leaked_storage: Variable state going out of scope
 leaks the storage it points to.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2017-02-08 21:54:25 -05:00
Danny Al-Gaaf
9365b8d7d0 rgw/rgw_main.cc: close leak in error case
ID 1398895 (#1 of 1): Resource leak (RESOURCE_LEAK)
 leaked_storage: Variable config going out of scope leaks
 the storage it points to.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2017-02-08 21:54:25 -05:00
Danny Al-Gaaf
7086cf9a73 rgw/rgw_rados.cc: prefer ++operator for non-primitive iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2017-02-08 21:54:25 -05:00
Danny Al-Gaaf
cc63f928d6 rgw/rgw_main.cc: reorder framework detection
Fix for:

CID 1398896: Resource leak (RESOURCE_LEAK)
 overwrite_var: Overwriting fe in fe = new
 RGWLoadGenFrontend(env, config) leaks the storage that fe
 points to.

Do not check again and again for framework if there is
already a match, make use of if/else. This should also
fix the RESOURCE_LEAK warning.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2017-02-08 21:54:25 -05:00
Danny Al-Gaaf
33de6f7014 rgw/rgw_compression.cc: prefer ++operator for non-primitive iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2017-02-08 21:54:25 -05:00
Danny Al-Gaaf
ecf83f9eef rgw/rgw_common.cc: prefer ++operator for non-primitive iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2017-02-08 21:54:25 -05:00
Danny Al-Gaaf
a8f4d635b4 rgw/rgw_torrent.cc: prefer ++operator for non-primitive iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2017-02-08 21:54:25 -05:00