flake8 3.1.1 surfaces the following issues:
ceph_disk/main.py:173:1: E305 expected 2 blank lines after class or
function definition, found 1
ceph_disk/main.py:5011:1: E305 expected 2 blank lines after class or
function definition, found 1
Fixes: http://tracker.ceph.com/issues/17898
Signed-off-by: Ken Dreyer <kdreyer@redhat.com>
If the osd actually restarts, there is no guarrantee that the epoch will
advance past up_from. If the inst is different, it can't really be a
dup. At worst, it might be a queued MOSDBoot from a previous inst, but
in that case, the real inst would see itself marked up, and then back
down causing it to try booting again.
Fixes: http://tracker.ceph.com/issues/17899
Signed-off-by: Samuel Just <sjust@redhat.com>
The C test checks the functionality of the new IoCtxImpl::aio_exec
override that accepts a char* buffer. The C++ test does the same action,
but internally uses the other override that accepts a bufferlist*.
Signed-off-by: Iain Buclaw <iain.buclaw@sociomantic.com>
rocksdb references some jemalloc specific symbols (malloc_stats_print()
for example), if jemalloc is enabled. this fails the build. so we need
to link against ${ALLOC_LIBS} when appropriate.
Signed-off-by: Kefu Chai <kchai@redhat.com>
so the linked libraries are able to find the symbols in libcommon.
and do not `list(APPEND librbd ...)` anymore, which is wrong and not
necessary. librbd does not depends on krbd.
Signed-off-by: Kefu Chai <kchai@redhat.com>
- ContextCompletion.cc is used by TrimRequest.cc which is included by
rbd_internal, it's more natural to put ContextCompletion.cc into
rbd_internal also. as rbd_internal is the only consumer of this
translation unit.
- librbd/internal.cc is not referencing any symbols from util.cc, so
remove this include. and also, do not add
$<TARGET_OBJECTS:common_util_obj> to librbd.
Signed-off-by: Kefu Chai <kchai@redhat.com>
- escape the "$" in "$osd", so it won't be expanded by local shell
- fix the permission bits of /var/lib/ceph/mon/mon.0/store.db
- add the doc to explain the step to prepare the keyring
Signed-off-by: Kefu Chai <kchai@redhat.com>
ceph-detect-init/ceph_detect_init/freebsd/__init__.py
New file
ceph_detect_init/__init__.py: Only test FreeBSD after it is not Linux
If we do it the other way around it will not work during testing on FreeBSD
because it will always have platform.system() == FreeBSD
So first test for Linux, and only then check to see if it is FreeBSD.
ceph-detect-init/tests/test_all.py: add tests for FreeBSD
ceph-detect-init/run-tox.sh: ReEnable to run test for FreeBSD
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
Signed-off-by: Kefu Chai <kchai@redhat.com>
switching the callback order in bluestore.
In Bluestore ack callback and commit callback are queued one by one in
the function "BlueStore;:_txc_finish_kv". Therefore, just only one callback
is needed to call, in order to improve performance. We do this by switching
the callback order in bluestore, and the callback work can be done in
sub_op_modify_commit and doesn't need to do it again in sub_op_modify_applied.
Signed-off-by: Pan Liu <pan.liu@istuary.com>
