Commit Graph

133705 Commits

Author SHA1 Message Date
Xuehan Xu
d050a85ab4 crimson/common: parallel_for_each shouldn't accept rvalue reference of containers
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2022-08-24 10:26:25 +08:00
Xuehan Xu
e82f6714e8 crimson/os/seastore/cache: skip invalid inline extents when completing commits
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2022-08-24 10:26:23 +08:00
Yingxin Cheng
d41297a95c crimson/os/seastore: move journal_type_t to seastore_types.h with shorter names
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-08-24 09:54:57 +08:00
Yingxin
03e45eb506
Merge pull request #47646 from cyx1231st/wip-seastore-move-cleaner-to-epm
crimson/os/seastore: move AsyncCleaner to EPM

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
Reviewed-by: Zhang Song <zhangsong325@gmail.com>
2022-08-24 07:54:15 +08:00
chunmei-liu
eedc47329c crimson/seastore: fix omap empty delta buffer
when rm_key get end iterator, don't do muatate
otherwise delta buffer will be empty and cause assert(delta.bl.lenght())

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
2022-08-23 15:23:06 -07:00
Daniel Gryniewicz
f47cf05c85
Merge pull request #47561 from dang/wip-dang-zipper-cast
RGW - Zipper - Remove a bunch of casts

Reviewed-by: Soumya Koduri <skoduri@redhat.com>
2022-08-23 13:51:06 -04:00
John Mulligan
2a2d044247 doc/mgr: add a tutorial-esque section on object_format python module
It doesn't cover everything but should get most use cases started.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2022-08-23 13:01:45 -04:00
John Mulligan
30d3e5bab5 doc/mgr: fix quoting error in python example
Found by vim syntax highlighting. Thanks vim!

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2022-08-23 13:01:45 -04:00
John Mulligan
481776becf doc/mgr: use subsections for two approaches to exposing commands
This makes the content for each approach clearer and prepares
for a future sub-section.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2022-08-23 13:01:45 -04:00
John Mulligan
61f00ddcb0 pybind/mgr: improve behavior of ErrorResponse.wrap method
The wrap classmethod is intended to turn any exception into something
that can produce a manager response. All exceptions inheriting from
ErrorResponseBase can do that, so instead of losing all that state,
have wrap return those exceptions inheriting from ErrorResponseBase
as-is.

Additionally, only change the sign of errno values that aren't already
negative.

Adds tests for these cases.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2022-08-23 13:01:45 -04:00
John Mulligan
370901a4e6 pybind/mgr: extend return types valid for Responder wrapped functions
One wonders why this wasn't found by the test code, but oh well.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2022-08-23 13:01:45 -04:00
John Mulligan
d4aa1754f8 pybind/mgr: fix incorrect construction of mgr CLI arguments
Instead of adding the extra_args correctly the code was "adding" the
"--format" option with the wrong name - using whatever the last argument
name in the actual arguments of the decorated function.

Updated tests to verify that the format option is added to the "ceph
args" string properly.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2022-08-23 13:01:45 -04:00
John Mulligan
7ef55fef71 pybind/mgr: add test cases for EmptyResponder decorator
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2022-08-23 13:01:45 -04:00
John Mulligan
dfd2213660 pybind/mgr: add test cases for ErrorResponseHandler decorator
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2022-08-23 13:01:45 -04:00
John Mulligan
a41678a4c7 pybind/mgr: add additional decorators for mgr response handling
Add a ErrorResponseHandler decorator for catching and automatically
handling ErrorResponseBase exceptions like Responder does but it *only*
handles exceptions. Normal return value tuples are passed on to the mgr.

Add a EmptyResponder decorator that catches errors but returns "empty"
strings as a response to the mgr. This matches a number of preexisting
functions that don't return json or any other value on success.

Both these decorators are added in order to match behaviors of Responder
decorator without opting into auto formatted responses wholesale. They
are intended to be used when converting older apis to use object_format
module.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2022-08-23 13:01:45 -04:00
Venky Shankar
d1ca282f60
Merge pull request #45949 from neesingh-rh/feature-51434
mgr/volumes: Add volume info command

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Nikhilkumar Shelke <nshelke@redhat.com>
2022-08-23 21:33:09 +05:30
Venky Shankar
b3b6a829e5
Merge pull request #44501 from SMIL-Infra/fix-mds-evicted
mon/MDSMonitor: fix standby-replay mds being removed from MDSMap unexpectedly

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2022-08-23 21:30:18 +05:30
Daniel Gryniewicz
39fae6bdd2
Merge pull request #47678 from dang/wip-dang-admin-user
RGW - Admin - Pass user to created bucket

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-08-23 11:40:50 -04:00
Laura Flores
4cf097d7e0
Merge pull request #47642 from ljflores/wip-librados-fix
qa/workunits/rados: pull librados files from "main" instead of "master"
2022-08-23 10:32:31 -05:00
Kefu Chai
9734b7f32b
Merge pull request #47624 from Mer1997/wip-57138
mgr/snap-schedule: use the right way to check the result returned by…

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-08-23 23:29:06 +08:00
Kefu Chai
7f47ade98a
Merge pull request #47301 from rzarzynski/wip-bug-55851
msg: reset ProtocolV2's frame assembler in appropriate thread

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2022-08-23 23:27:54 +08:00
Kefu Chai
ccff328190
Merge pull request #46943 from kalaspuffar/python39
mgr/diskprediction_local: Support Python 3.9 for disk prediction module.

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-08-23 23:26:07 +08:00
Kefu Chai
a1d8b793e1
Merge pull request #47672 from Matan-B/wip-matanb-buffer-next
include/buffer: clear_and_dispose() fix implicitly-declared operator= usage

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-08-23 23:24:15 +08:00
Kefu Chai
a9ac5438a7
Merge pull request #47710 from tchaikov/denc-concept
include/denc: define is_const_iterator as a concept

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-08-23 23:21:35 +08:00
Kefu Chai
9dda4b4188
Merge pull request #47718 from tchaikov/wip-no-isp2
*: replace functions in intarith.h with the ones provided by standard library

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2022-08-23 23:19:41 +08:00
Matan
2f23b96182
Merge pull request #46419 from Matan-B/wip-matanb-c-snaps
crimson/osd: Snaps IO path

Reviewed-by: Samuel Just <sjust@redhat.com>
2022-08-23 17:45:18 +03:00
Yingxin Cheng
b62f2057fd test/crimson/seastore: fix teardown with cleanups
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-08-23 22:25:01 +08:00
Yingxin Cheng
5131fcdd68 crimson/os/seastore: move AsyncCleaner to EPM
There are two purposes related to generic device tiering:

* Make AsyncCleaner (need to introduce a generic interface class later)
  to hide differences between segment-based tier and RB-based tier
  cleaner implementations.
* Make EPM to coordinate cleaning transactions across tiers with general
  AsyncCleaners.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-08-23 22:22:18 +08:00
Yingxin Cheng
915cfef7e1 test/crimson/seastore: drop unnecessary run_until_halt()
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-08-23 22:10:26 +08:00
Venky Shankar
5ef57ea4a0
Merge pull request #47182 from lxbsz/wip-56638
libcephfs: define AT_NO_ATTR_SYNC back for backward compatibility

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Nikhilkumar Shelke <nshelke@redhat.com>
2022-08-23 19:39:40 +05:30
Yingxin Cheng
e56b2759b4 crimson/os/seastore/async_cleaner: cleanup and sort interfaces
To prepare for a general interface class for device tiering.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-08-23 22:05:25 +08:00
Yingxin Cheng
541a5f11e6 crimson/os/seastore/async_cleaner: cleanup, replace init_complete by explicit states
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-08-23 22:05:19 +08:00
Aswin Toni
351e1ac639 ceph-mixin: fix CephNodeNetworkPacket alerts
Signed-off-by: Aswin Toni <aswin.toni@cern.ch>
2022-08-23 15:26:52 +02:00
Ilya Dryomov
3eda6f9682
Merge pull request #47737 from ceph/release-docs2
admin: Fix check if PR or release branch docs build

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2022-08-23 14:24:36 +02:00
Venky Shankar
a9a7d50d20
Merge pull request #47542 from batrick/i56140
tools/cephfs: add basic detection/cleanup tool for dentry first damage

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2022-08-23 16:22:29 +05:30
Nizamudeen A
0e0e5803a4
Merge pull request #43771 from rhcs-dashboard/wip-52701-master
mgr/dashboard: add backend-driven UI tables

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: sherrif10 <NOT@FOUND>
Reviewed-by: Zac Dover <zac.dover@gmail.com>
2022-08-23 15:33:30 +05:30
Pere Diaz Bou
a80c058ad2 mgr/dashboard: ensure limit 0 returns 0 images
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
2022-08-23 10:36:43 +02:00
Venky Shankar
78871e59c0
Merge pull request #46599 from kotreshhr/rename_config_on_flush
mgr/volumes: Better handle config file on osd full scenario

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
2022-08-23 13:25:02 +05:30
Venky Shankar
5e1625fa7c
Merge pull request #47063 from lxbsz/wip-56529
mds/client: fail the request if the peer MDS doesn't support getvxattr op

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
2022-08-23 13:22:09 +05:30
Venky Shankar
528670c86c
Merge pull request #47132 from lxbsz/_rmsnap_finish_clean
mds: remove useless code in _rmsnap_finish()

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
2022-08-23 12:49:57 +05:30
Venky Shankar
e496f48cb0
Merge pull request #47384 from lxbsz/wip-56633
mds: add more debug logs before crashing the MDS

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Nikhilkumar Shelke <nshelke@redhat.com>
2022-08-23 12:43:36 +05:30
Xuehan Xu
f5b5c3a990 crimson/os/seastore/cache: set extent's state to INVALID when invalidating it
Previously, when invalidating a non-conflict extent, I forgot to set its state

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2022-08-23 10:23:07 +08:00
lu.shasha
04282ae3c1 rgw: fix data corruption due to network jitter
In function RGWRados::Object::Write::_do_write_meta rgw_rados_operate may return -ETIMEDOUT due to network jitter.
But head obj may eventually be written successfully even if return -ETIMEDOUT. Due to r < 0, meta.canceled be set true.
In such scenario, all the tail objects will removed in the destructor of RadosWriter, then data corruptted.
To avoid data corruption, when return -ETIMEDOUT, should clear all objects in RadosWriter.

Signed-off-by: Shasha Lu <lu.shasha@aishu.cn>
2022-08-23 09:15:42 +08:00
Casey Bodley
95f6cbfe17
Merge pull request #47613 from cbodley/wip-56920
rgw/coroutine: check for null stack on wakeup

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2022-08-22 21:02:30 -04:00
Patrick Donnelly
4d9be7e13b
Merge PR #47732 into main
* refs/pull/47732/head:
	Revert "Merge pull request #47092 from dparmar18/wip-dparmar-cephadm-simple-1"

Reviewed-by: Adam King <adking@redhat.com>
2022-08-22 20:04:54 -04:00
Casey Bodley
a8250553c6 rgw/coroutine: check for null stack on wakeup
Fixes: https://tracker.ceph.com/issues/56920

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2022-08-22 19:28:19 -04:00
Casey Bodley
c8e6576da3 rgw: remove replace_region_with_zonegroup()
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2022-08-22 17:50:09 -04:00
Casey Bodley
b857860f8d rgw: remove RGWRegionMap and RGWZoneGroupMap
these are leftovers from radosgw-agent. we kept them around for the
conversion logic, but that was only necessary to support upgrades to
jewel and kraken

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2022-08-22 17:50:09 -04:00
Casey Bodley
bc11400f15 rgw: remove RGWOp_ZoneGroupMap_Get from /admin/config API
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2022-08-22 17:50:09 -04:00
Anthony D'Atri
5ce745801b
Merge pull request #47690 from mty22/update-inactive-ceph-mirrors
doc: Remove inactive Ceph mirrors.
2022-08-22 14:16:24 -07:00