Commit Graph

133667 Commits

Author SHA1 Message Date
Venky Shankar
5128cf8e18
Merge pull request #46072 from neesingh-rh/fix_54978
cephfs-top: adding filesystem menu option

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
2022-08-24 13:37:46 +05:30
Yingxin
2c916e1923
Merge pull request #47782 from tchaikov/wip-crimson-os-cleanups
crimson/os: use IsFullKey when appropriate 

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-08-24 16:07:07 +08:00
Venky Shankar
b17f0e5d1e
Merge pull request #46685 from Rethan/perf-limit-dump-loads-depth
mds/MDBalancer: add an arg to limit depth when dump loads for dirfrags

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
2022-08-24 13:31:28 +05:30
Kefu Chai
8663e84938 crimson/os: replace full_key_t<KeyT::VIEW> with key_view_t
and replace full_key_t<KeyT::HOBJ> with key_hobj_t.

there is not need to have this indirection

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-08-24 14:51:21 +08:00
Kefu Chai
cb306cae7b crimson/os: use IsFullKey in staged::insert_size{,at}()
to fade out KeyT, so we can have more straightforward definitions.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-08-24 14:51:21 +08:00
Kefu Chai
0e138d314b crimson/os: use IsFullKey in staged::insert()
to fade out KeyT, so we can have more straightforward definitions.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-08-24 14:51:21 +08:00
Venky Shankar
d8ba839bcd
Merge pull request #46068 from neesingh-rh/change_perf_stats_o/p_structure
mgr/stats: change in structure of perf_stats o/p

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
2022-08-24 11:13:07 +05:30
Yingxin
f91c194431
Merge pull request #47778 from xxhdx1985126/wip-fix-output-error-cleaner
crimson/os/seastore/async_cleaner: fix several log related errors

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-08-24 13:27:30 +08:00
zdover23
02c80b64cd
Merge pull request #47751 from zdover23/wip-doc-2022-08-23-mgr-orchestrator-editorial-pass
doc/mgr: edit orchestrator.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2022-08-24 14:36:48 +10:00
Venky Shankar
49e66ed0c6
Merge pull request #47079 from neesingh-rh/fix_56483
mgr/stats: missing clients in perf stats command output.

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
2022-08-24 09:49:47 +05:30
Kefu Chai
cadd5fcfc0
Merge pull request #47729 from tchaikov/wip-crimson-os-cleanup
crimson/os: use IsFullKey in *::insert_prefix{,_at}()

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-08-24 12:09:41 +08:00
Zac Dover
2172b7ec98 doc/mgr: edit orchestrator.rst
This PR improves the English language in the "Orchestrator CLI"
section of the MGR documentation. It adds a couple of section
headers in order to signpost the information in the document
a bit more than had already been done, but it makes no major
structural changes to the presentation of the information here.

This PR was motivated by feedback from the 2022 Ceph User Survey
in which one of the respondents wrote "better ceph orch documen-
tation".

The final section on this page, "Current Implementation Status",
must be verified by someone who is familiar with the current state
of "ceph orch" and a date stamp should be applied to the top of
the section so that the word "current" has a meaningful referent.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-08-24 13:21:25 +10:00
Yingxin Cheng
67a9109ca9 crimson/os/seastore/cache: workaround to drop delta with mismatched crc
The workaround is unreliable to identify whether the delta is out-dated,
need to drop it once the paddr->journal_seq_t mapping is introduced.

Note: this issue only happens with journal_type_t::CIRCULAR.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-08-24 11:04:04 +08:00
Xuehan Xu
66a8c0d4df crimson/os/seastore/async_cleaner: fix several log related errors
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2022-08-24 11:03:53 +08:00
myoungwon oh
0d941855ff crimson/os/seastore: enable CBJournal trim during transaction_manager unit test
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-08-24 11:00:05 +08:00
Yingxin Cheng
c2b9e770f7 crimson/os/seastore: generalize journal tail calculations
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-08-24 10:59:59 +08:00
Xuehan Xu
b4d7897fc6 crimson/os/seastore/async_cleaner: fill the semantic gap between backref get_mappings and space reclaim
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2022-08-24 10:26:25 +08:00
Xuehan Xu
d050a85ab4 crimson/common: parallel_for_each shouldn't accept rvalue reference of containers
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2022-08-24 10:26:25 +08:00
Xuehan Xu
e82f6714e8 crimson/os/seastore/cache: skip invalid inline extents when completing commits
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2022-08-24 10:26:23 +08:00
Yingxin Cheng
d41297a95c crimson/os/seastore: move journal_type_t to seastore_types.h with shorter names
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-08-24 09:54:57 +08:00
Yingxin
03e45eb506
Merge pull request #47646 from cyx1231st/wip-seastore-move-cleaner-to-epm
crimson/os/seastore: move AsyncCleaner to EPM

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
Reviewed-by: Zhang Song <zhangsong325@gmail.com>
2022-08-24 07:54:15 +08:00
chunmei-liu
eedc47329c crimson/seastore: fix omap empty delta buffer
when rm_key get end iterator, don't do muatate
otherwise delta buffer will be empty and cause assert(delta.bl.lenght())

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
2022-08-23 15:23:06 -07:00
Daniel Gryniewicz
f47cf05c85
Merge pull request #47561 from dang/wip-dang-zipper-cast
RGW - Zipper - Remove a bunch of casts

Reviewed-by: Soumya Koduri <skoduri@redhat.com>
2022-08-23 13:51:06 -04:00
John Mulligan
2a2d044247 doc/mgr: add a tutorial-esque section on object_format python module
It doesn't cover everything but should get most use cases started.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2022-08-23 13:01:45 -04:00
John Mulligan
30d3e5bab5 doc/mgr: fix quoting error in python example
Found by vim syntax highlighting. Thanks vim!

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2022-08-23 13:01:45 -04:00
John Mulligan
481776becf doc/mgr: use subsections for two approaches to exposing commands
This makes the content for each approach clearer and prepares
for a future sub-section.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2022-08-23 13:01:45 -04:00
John Mulligan
61f00ddcb0 pybind/mgr: improve behavior of ErrorResponse.wrap method
The wrap classmethod is intended to turn any exception into something
that can produce a manager response. All exceptions inheriting from
ErrorResponseBase can do that, so instead of losing all that state,
have wrap return those exceptions inheriting from ErrorResponseBase
as-is.

Additionally, only change the sign of errno values that aren't already
negative.

Adds tests for these cases.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2022-08-23 13:01:45 -04:00
John Mulligan
370901a4e6 pybind/mgr: extend return types valid for Responder wrapped functions
One wonders why this wasn't found by the test code, but oh well.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2022-08-23 13:01:45 -04:00
John Mulligan
d4aa1754f8 pybind/mgr: fix incorrect construction of mgr CLI arguments
Instead of adding the extra_args correctly the code was "adding" the
"--format" option with the wrong name - using whatever the last argument
name in the actual arguments of the decorated function.

Updated tests to verify that the format option is added to the "ceph
args" string properly.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2022-08-23 13:01:45 -04:00
John Mulligan
7ef55fef71 pybind/mgr: add test cases for EmptyResponder decorator
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2022-08-23 13:01:45 -04:00
John Mulligan
dfd2213660 pybind/mgr: add test cases for ErrorResponseHandler decorator
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2022-08-23 13:01:45 -04:00
John Mulligan
a41678a4c7 pybind/mgr: add additional decorators for mgr response handling
Add a ErrorResponseHandler decorator for catching and automatically
handling ErrorResponseBase exceptions like Responder does but it *only*
handles exceptions. Normal return value tuples are passed on to the mgr.

Add a EmptyResponder decorator that catches errors but returns "empty"
strings as a response to the mgr. This matches a number of preexisting
functions that don't return json or any other value on success.

Both these decorators are added in order to match behaviors of Responder
decorator without opting into auto formatted responses wholesale. They
are intended to be used when converting older apis to use object_format
module.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2022-08-23 13:01:45 -04:00
Venky Shankar
d1ca282f60
Merge pull request #45949 from neesingh-rh/feature-51434
mgr/volumes: Add volume info command

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Nikhilkumar Shelke <nshelke@redhat.com>
2022-08-23 21:33:09 +05:30
Venky Shankar
b3b6a829e5
Merge pull request #44501 from SMIL-Infra/fix-mds-evicted
mon/MDSMonitor: fix standby-replay mds being removed from MDSMap unexpectedly

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2022-08-23 21:30:18 +05:30
Daniel Gryniewicz
39fae6bdd2
Merge pull request #47678 from dang/wip-dang-admin-user
RGW - Admin - Pass user to created bucket

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-08-23 11:40:50 -04:00
Laura Flores
4cf097d7e0
Merge pull request #47642 from ljflores/wip-librados-fix
qa/workunits/rados: pull librados files from "main" instead of "master"
2022-08-23 10:32:31 -05:00
Kefu Chai
9734b7f32b
Merge pull request #47624 from Mer1997/wip-57138
mgr/snap-schedule: use the right way to check the result returned by…

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-08-23 23:29:06 +08:00
Kefu Chai
7f47ade98a
Merge pull request #47301 from rzarzynski/wip-bug-55851
msg: reset ProtocolV2's frame assembler in appropriate thread

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2022-08-23 23:27:54 +08:00
Kefu Chai
ccff328190
Merge pull request #46943 from kalaspuffar/python39
mgr/diskprediction_local: Support Python 3.9 for disk prediction module.

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-08-23 23:26:07 +08:00
Kefu Chai
a1d8b793e1
Merge pull request #47672 from Matan-B/wip-matanb-buffer-next
include/buffer: clear_and_dispose() fix implicitly-declared operator= usage

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-08-23 23:24:15 +08:00
Kefu Chai
a9ac5438a7
Merge pull request #47710 from tchaikov/denc-concept
include/denc: define is_const_iterator as a concept

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-08-23 23:21:35 +08:00
Kefu Chai
9dda4b4188
Merge pull request #47718 from tchaikov/wip-no-isp2
*: replace functions in intarith.h with the ones provided by standard library

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2022-08-23 23:19:41 +08:00
Matan
2f23b96182
Merge pull request #46419 from Matan-B/wip-matanb-c-snaps
crimson/osd: Snaps IO path

Reviewed-by: Samuel Just <sjust@redhat.com>
2022-08-23 17:45:18 +03:00
Yingxin Cheng
b62f2057fd test/crimson/seastore: fix teardown with cleanups
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-08-23 22:25:01 +08:00
Yingxin Cheng
5131fcdd68 crimson/os/seastore: move AsyncCleaner to EPM
There are two purposes related to generic device tiering:

* Make AsyncCleaner (need to introduce a generic interface class later)
  to hide differences between segment-based tier and RB-based tier
  cleaner implementations.
* Make EPM to coordinate cleaning transactions across tiers with general
  AsyncCleaners.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-08-23 22:22:18 +08:00
Yingxin Cheng
915cfef7e1 test/crimson/seastore: drop unnecessary run_until_halt()
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-08-23 22:10:26 +08:00
Venky Shankar
5ef57ea4a0
Merge pull request #47182 from lxbsz/wip-56638
libcephfs: define AT_NO_ATTR_SYNC back for backward compatibility

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Nikhilkumar Shelke <nshelke@redhat.com>
2022-08-23 19:39:40 +05:30
Yingxin Cheng
e56b2759b4 crimson/os/seastore/async_cleaner: cleanup and sort interfaces
To prepare for a general interface class for device tiering.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-08-23 22:05:25 +08:00
Yingxin Cheng
541a5f11e6 crimson/os/seastore/async_cleaner: cleanup, replace init_complete by explicit states
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-08-23 22:05:19 +08:00
Aswin Toni
351e1ac639 ceph-mixin: fix CephNodeNetworkPacket alerts
Signed-off-by: Aswin Toni <aswin.toni@cern.ch>
2022-08-23 15:26:52 +02:00