Adam C. Emerson
5353d95268
rgw: Fix the last policy use-after-free
...
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2017-08-07 17:48:37 -04:00
Adam C. Emerson
97d026dde6
rgw: Fix another use after free
...
This one was caused by iterator invalidation in set operations. In
this case just replace the set entirely with a bitfield.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2017-08-07 17:48:37 -04:00
Adam C. Emerson
8377ba6525
rgw: Fix use after free in IAM policy parser
...
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2017-08-07 17:48:37 -04:00
Gregory Farnum
5fbd8dcbbb
Merge pull request #16848 from amitkumar50/cov-messages-5
...
messages: Initialization of uninitialized members various classes
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2017-08-07 14:37:09 -07:00
Patrick Donnelly
6b10568732
Merge PR #16876 into master
...
* refs/remotes/upstream/pull/16876/head:
doc: add new fs auth command to release notes
Reviewed-by: Sage Weil <sage@redhat.com>
2017-08-07 12:53:54 -07:00
Sage Weil
973772c11d
Merge pull request #16871 from liewegas/wip-20920
...
mon: fix commands advertised during mon cluster upgrade
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2017-08-07 14:48:58 -05:00
Patrick Donnelly
f2051c0d4f
doc: add new fs auth command to release notes
...
Introduced by #16761 .
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2017-08-07 12:47:08 -07:00
Sage Weil
3e7d157871
qa/suites/upgrade/jewel-x/parallel: fix POOL_APP_NOT_ENABLED disable
...
This code runs on the mgr.
Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-07 15:12:10 -04:00
Sage Weil
7c37c86bb2
mon/MonCommands: mark 'pg force_create_pg' deprecated
...
It's deprecated.
Also, this avoids a dup when we have an upgrading mon cluster
and it's also in PGMonitorCommands.
Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-07 15:12:10 -04:00
Sage Weil
2d9045a9a5
mon: include PGMonitor commands with mixed-version mons
...
While we have a mixed version cluster, we have to advertise our
PGMonitor commands to our peons or else commands like 'pg dump'
won't work.
Once the mon feature flag is set, we can drop that because each
mon will include the mgr commands (either those stored in paxos
or the statically compiled ones until that point).
Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-07 15:12:10 -04:00
Sage Weil
349b3c9bef
mon: use vector<MonCommand> throughput for commands
...
The old code was pretty messy. This is standardizes on std::vector
throughout. We also drop the win_election command args because
when we win an election we always set the leader commands to our
commands, and we can do that inside win_command() without passing
them in from here.
Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-07 15:08:08 -04:00
Jason Dillaman
f0e351b50b
Merge pull request #16642 from dillaman/wip-rbd-mirror-image-ids
...
rbd-mirror: simplify notifications for image assignment
Reviewed-by: Mykola Golub <mgolub@mirantis.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
2017-08-07 14:33:50 -04:00
Sage Weil
a755a0bce8
Merge pull request #16799 from liewegas/wip-smithi-have-4
...
qa/clusters/fixed-[23]: 4 osds per node, not 3
Vasu Kulkarni <vasu@redhat.com>
2017-08-07 12:36:42 -05:00
Sage Weil
387ad56a69
qa/clusters/fixed-[23]: 4 osds per node, not 3
...
Smithi have 4 nvme partitions available for use.
Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-07 13:36:05 -04:00
Sage Weil
b5fae9a9ca
Merge pull request #16873 from liewegas/wip-4-nodes
...
qa/suites: change fixed-2.yaml users to get 4 openstack disks
Reviewed-by: Zack Cerza <zcerza@redhat.com>
2017-08-07 11:27:40 -05:00
Sage Weil
3ffca50824
Merge pull request #16864 from smithfarm/wip-big-openstack
...
qa: big: add openstack.yaml
2017-08-07 11:02:59 -05:00
Sage Weil
f683d2d374
qa/suites: change fixed-2.yaml users to get 4 openstack disks
...
Follow-up for 4203c4f887
Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-07 11:56:33 -04:00
Sage Weil
a872c44be7
Merge pull request #16842 from liewegas/wip-more-ec-map-discon
...
qa/suites/rados/thrash: fix thrashing with ec vs map discon
2017-08-07 10:48:56 -05:00
Haomai Wang
bb772b05a8
Merge pull request #16693 from alex-mikheev/wip_rdma_rxpool_1
...
msg/async/rdma: improves RX buffer management
Reviewed-by: Haomai Wang <haomai@xsky.com>
2017-08-07 23:45:48 +08:00
Sage Weil
03e6f976e7
Merge pull request #16869 from liewegas/wip-crush-ids
...
crush/CrushWrapper: fix out of bounds access
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
2017-08-07 10:35:47 -05:00
Jos Collin
61074a7266
Merge pull request #16845 from amitkumar50/cov-librados-aio
...
test/librados: Initialize member variables in aio.cc
Reviewed-by: Jos Collin <jcollin@redhat.com>
2017-08-07 14:51:13 +00:00
amitkuma
7f7c40771d
test/librados: Initializing left members from aio.cc
...
Fixes the coverity Issue:
** 1322815 Uninitialized pointer field
CID 1322815 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
2. uninit_member: Non-static class member m_sem is not initialized
in this constructor nor in any functions that it calls.
** 1322816 Uninitialized pointer field
CID 1322816 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
2. uninit_member: Non-static class member m_sem is not initialized
in this constructor nor in any functions that it calls.
** 1322817 Uninitialized pointer field
CID 1322817 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
2. uninit_member: Non-static class member m_sem is not initialized
in this constructor nor in any functions that it calls.
Signed-off-by: Amit Kumar amitkuma@redhat.com
2017-08-07 22:21:14 +05:30
Jason Dillaman
36f3c9ae09
rbd-mirror: clean up logging during test shut down
...
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:13:35 -04:00
Jason Dillaman
b38baa9489
rbd-mirror: avoid silently failing to register image replayer admin sockets
...
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:13:34 -04:00
Jason Dillaman
955e7cac4b
rbd-mirror: restore deletion propagation and image replayer cleanup
...
The previous intermediate commits removed handling for deletion
propagation and image replayer cleanup since this logic has been
moved from instance to image replayer. Note that eventually the
policy's release notification will be responsible for the cleanup
of image replayers.
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:13:34 -04:00
Jason Dillaman
eba021c151
rbd-mirror: ensure threads are mockable for testing
...
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:13:34 -04:00
Jason Dillaman
76b676dcb7
rbd-mirror: moved wait for deletion logic within image replayer
...
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:13:34 -04:00
Jason Dillaman
fa58b08292
rbd-mirror: simplified acquire/release notification messages
...
The other instances should already know about the possible peers, so
we can co-opt these messages for use by the policy mapper.
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:13:34 -04:00
Jason Dillaman
d49945242e
rbd-mirror: co-opt image acquire/release notifications
...
This notifications will now be used by the policy when a (re)map is
required.
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:13:33 -04:00
Jason Dillaman
5ae0f6a6b1
rbd-mirror: new 'peer image removed' notification to instance watchers
...
Note: this commit intentionally breaks backwards compatibility with
Luminous RC instance watcher notifications.
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:13:33 -04:00
Jason Dillaman
4e1b834d2d
rbd-mirror: simplify resync handling within image replayer
...
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:13:33 -04:00
Jason Dillaman
028847cb33
rbd-mirror: pre-register image id before creating image
...
This fixes a potential race condition that could occur previously
if rbd-mirror daemon failed between creating an image and recording
the image id to the remote journal.
Fixes: http://tracker.ceph.com/issues/15764
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:13:33 -04:00
Jason Dillaman
2a6cfd8373
rbd-mirror: clean up bootstrap recovery from missing local image
...
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:13:33 -04:00
Jason Dillaman
5dcd9ed0d5
rbd-mirror: image replayer should query remote mirror uuid / image id
...
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:13:33 -04:00
Jason Dillaman
b3dba1c876
rbd-mirror: helper state machine for querying remote peer uuid / image id
...
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:13:31 -04:00
Jason Dillaman
697c1d7a4a
rbd-mirror: helper state machine for retrieving image id from global id
...
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:09:21 -04:00
Jason Dillaman
bde2f9e1ac
Merge pull request #16393 from PCzhangPC/fix3
...
rbd: 'image-meta remove' for missing key does not return error
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:03:20 -04:00
Sage Weil
bf494e9455
crush/CrushWrapper: fix out of bounds access
...
Fixes: http://tracker.ceph.com/issues/20926
Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-07 09:39:18 -04:00
Sage Weil
4f01c8fc91
Merge pull request #16851 from xiexingguo/wip-doc-update-class-cli
...
doc/release-notes: update device class cli
2017-08-07 08:26:35 -05:00
Yuri Weinstein
59a0f3c532
Merge pull request #16551 from fangyuxiangGL/data-notifier-interval
...
rgw: add a separate configuration for data notify interval
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2017-08-07 05:48:54 -07:00
Yuri Weinstein
93a7ae801a
Merge pull request #16726 from theanalyst/rgw-crypt-debug-log
...
rgw_crypt: log error messages during failures
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Adam Kupczyk <akupczyk@mirantis.com>
2017-08-07 05:48:14 -07:00
Yuri Weinstein
1c63af1286
Merge pull request #16770 from tianshan/fix_create_bucket
...
rgw: should not restrict location_constraint same when user not provide
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
2017-08-07 05:45:52 -07:00
Nathan Cutler
8bb3d8444f
qa: big: add openstack.yaml
...
Signed-off-by: Nathan Cutler <ncutler@suse.com>
2017-08-07 12:07:36 +02:00
Jos Collin
e5da05f8f7
Merge pull request #16862 from scienceluo/wip-luo-check-fix-branch
...
common/cmdparse.cc: remove unused variable 'argnum' in dump_cmd_to_json()
Reviewed-by: Jos Collin <jcollin@redhat.com>
2017-08-07 09:30:48 +00:00
Luo Kexue
5d6d22997a
Common: remove variable 'argnum' that is modified but its new value is never used.
...
Signed-off-by: Luo Kexue <luo.kexue@zte.com.cn>
2017-08-07 16:21:16 +08:00
xie xingguo
d066ab2fe6
doc/release-notes: update device class cli
...
These commands are nearly stable and are unlikely to change for now...
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
2017-08-07 12:28:53 +08:00
Jos Collin
6f00f9a71d
Merge pull request #16847 from amitkumar50/cov-1054870
...
rgw: Initialize of member variable admin_specified in RGWUserAdminOpState
Reviewed-by: Jos Collin <jcollin@redhat.com>
2017-08-07 04:01:36 +00:00
Sage Weil
311bfcaf04
Merge pull request #16822 from liewegas/wip-20849
...
os/bluestore: _do_remove: dirty shard individually as each blob is unshared
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
2017-08-06 21:43:22 -05:00
Sage Weil
fce8d83fdf
Merge pull request #16844 from xiexingguo/wip-bluestore-core
...
os/bluestore: default journal media to store media if bluefs is disabled
Reviewed-by: Sage Weil <sage@redhat.com>
2017-08-06 20:17:57 -05:00
Sage Weil
1a9363596d
Merge pull request #14053 from jdurgin/wip-19191
...
osd/PG: reset the missing set when restarting backfill
Reviewed-by: David Zafman <dzafman@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
2017-08-06 14:08:34 -05:00