Commit Graph

84706 Commits

Author SHA1 Message Date
Ricardo Dias
072699d863
mgr: fixes python error handling
The current `handle_pyerror` function implementation relies in the
`traceback.format_exception_only` python function to format the
exception object. The problem is that this python function might also
raise an exception. This commit fixes it by enclosing that python
function call in try...catch block.

Fixes: http://tracker.ceph.com/issues/23406

Signed-off-by: Ricardo Dias <rdias@suse.com>
2018-03-26 15:17:15 +01:00
Nathan Cutler
b71eb01705
Merge pull request #19439 from chardan/jfw-wip-14363-normalize-rm
rgw, mon: normalize delete/remove in admin console (cleanup 22444)

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Joao Eduardo Luis <joao@suse.de>
2018-03-26 15:35:40 +02:00
Lenz Grimmer
765b346aee
Merge pull request #21011 from tspmelo/wip-submit-btn
mgr/dashboard: Add submit button component

Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2018-03-26 14:54:51 +02:00
Song Shun
51ac19387c librbd: fix refuse to release lock when cookie is the same at rewatch
fix exclusive auto-mode lock refuse to release.
  when rewatch, owner_id is reset.
  at the same time, there is a chance to produce the same cookie, which should be different.
  code now skips reacquire lock when the cookie is the same, resulting in unsetting owner_id.
  when other clients request lock, client whose owner_id is null is considered invalid and
  refuse to release lock.
  but unluckily, watcher is always alive, so the client requested lock can't get lock.

Signed-off-by: Song Shun <song.shun3@zte.com.cn>
2018-03-26 20:46:54 +08:00
Jos Collin
bf82cb2075
Merge pull request #21032 from simransinghal/fixtypo
rgw: Fix typo in comment

Reviewed-by: Jos Collin <jcollin@redhat.com>
2018-03-26 17:22:38 +05:30
Kefu Chai
0754b797e1
Merge pull request #21020 from trociny/wip-vstart-no-mon-config
stop.sh: use --no-mon-config when trying to unmap rbd devices

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2018-03-26 19:33:56 +08:00
Wido den Hollander
582935f222
mgr/zabbix: Send max, min and avg PGs of OSDs to Zabbix
We already send the max, min and avg fill ratio of OSDs but
knowing the OSD with the highest amount of PGs is also useful.

This allows admins to create a trigger should it happen that there
is a OSD with too many PGs.

This could happen if a lot of OSDs fail and PGs start to move filling
up one or more OSDs with many PGs.

As PGs eat CPU and Memory people usually like to watch out for these
situations.

Signed-off-by: Wido den Hollander <wido@42on.com>
2018-03-26 13:27:27 +02:00
Xie Xingguo
4198558162
Merge pull request #21036 from xiexingguo/wip-wrong-tip
os/bluestore: s/bluefs_total/bluefs_free/

Reviewed-by: Igor Fedotov <ifedotov@mirantis.com>
2018-03-26 18:13:51 +08:00
Ricardo Dias
a392e612cc
Merge pull request #21007 from rjfd/wip-dashboard-fix-py3
mgr/dashboard: fix dashboard python 3 support

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2018-03-26 10:59:17 +01:00
Ricardo Dias
5867292162
Merge pull request #21006 from rjfd/wip-dashboard-fix-auth-py3
mgr/dashboard: fixed password generation in Auth controller

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2018-03-26 10:58:27 +01:00
Ricardo Dias
d5763de318
Merge pull request #20865 from sebastian-philipp/dashboard_v2_pool-create
mgr/dashboard: Add Pool-create to the backend

Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Ricardo Dias <rdias@suse.com>
2018-03-26 10:07:15 +01:00
Tatjana Dehler
33e15ecd39 mgr/dashboard: convert RBD features to a list of strings
Until now the API returns the features provided by an RBD as one comma
separated string. It's more usable for the frontend to receive a list
of strings instead.

Signed-off-by: Tatjana Dehler <tdehler@suse.com>
2018-03-26 09:41:56 +02:00
Gu Zhongyan
c45c81b29f os/bluestore: fix some code formatting
Signed-off-by: Gu Zhongyan <guzhongyan@360.cn>
2018-03-26 15:24:58 +08:00
Rishabh Dave
f723aa1474 doc: use actual entity address for clarity
Fixes: https://tracker.ceph.com/issues/23334
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2018-03-26 12:02:44 +05:30
xie xingguo
81c094b4a1 os/bluestore: s/bluefs_total/bluefs_free/
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
2018-03-26 10:33:24 +08:00
Radoslaw Zarzynski
9e40cade6f os/bluestore: reorder members of bluefs_extent_t to make it smaller.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2018-03-25 18:26:44 +02:00
simransinghal
f3b3bcfbc9 src: Fix typo
Replace "dont" with "don't". "Dont" is not same as "Do not" or "Don't".

Signed-off-by: Simran Singhal <singhalsimran0@gmail.com>
2018-03-25 18:50:23 +05:30
Nathan Cutler
235f211901
Merge pull request #21002 from smithfarm/wip-23437
build/ops: setup-virtualenv.sh: do not hardcode python binary

Reviewed-by: John Spray <john.spray@redhat.com>
Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2018-03-23 23:29:11 +01:00
Tiago Melo
03fa8585ef mgr/dashboard: Add submit button component
This component is to be used inside a form.

It will render a submit button with the given label.
The button will disabled itself and show a loading icon when the user clicks it,
usually initiating a request to the server, and it will stay in that state
until the request is finished.

To indicate that the request failed, returning the button to the enable state,
you need to insert an error in the form with the 'cdSubmitButton' key.

It will also check if the form is valid, when clicking the button, and will
focus on the first invalid input.

Signed-off-by: Tiago Melo <tmelo@suse.com>
2018-03-23 16:40:29 +00:00
Radoslaw Zarzynski
c5859f25e6 qa/tasks/swift: add support for the "force-branch" configurable.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2018-03-23 12:40:05 -04:00
Nathan Cutler
f1936a2702
Merge pull request #21013 from dzafman/wip-remove-bc
test: Replace bc command with printf command

Reviewed-by: Nathan Cutler <ncutler@suse.com>
2018-03-23 17:28:02 +01:00
Sebastian Wagner
cbee371958 mgr/dashboard: Add Teuthology test for /api/pool/_info
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2018-03-23 16:40:18 +01:00
Sebastian Wagner
dd18675e4f mgr/dashboard: Minor tweak to DashboardTestCase._request
Don't fall through silently.

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2018-03-23 16:40:18 +01:00
Sebastian Wagner
623bc8b05f mgr/dashboard: Change crush_rule serialization of Pools from id to name
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2018-03-23 16:40:18 +01:00
Sebastian Wagner
f3300eed97 mgr/dashboard: Add pool/_info api endpoint to fill the create-pool dialog
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2018-03-23 16:40:18 +01:00
Sebastian Wagner
e6c1056ad5 mgr/dashboard: Add create() to Pool controller
Also:

* Added tests.
* Renamed `DashboardTest` to `PoolTest`.
* Added `delete()`.

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2018-03-23 16:40:18 +01:00
Sebastian Wagner
4ea23726ef mgr/dashboard: Changed @RESTController.args_from_json
It now allows any keyword arguments. This is needed for ECP
and Pool creation.

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2018-03-23 16:40:18 +01:00
Sebastian Wagner
a9767a2aa9 mgr/dashboard: Refactor send_command into CephService
* `CephService.send_command` is much easier to use.
* Refactored `CephFSClients.get` and `Dashboard.load_bufer`

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2018-03-23 16:40:17 +01:00
Ricardo Dias
3c5f24a626
Merge pull request #21008 from trociny/wip-23430
vstart: set osd_pool_default_erasure_code_profile in initial ceph.conf

Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
2018-03-23 14:59:58 +00:00
Yuri Weinstein
6a5bab7dd4
Merge pull request #20981 from cbodley/wip-qa-fix-ssl
qa: fix overrides for openssl_keys task

Reviewed-by: Yuri Weinstein <yweins@redhat.com>
2018-03-23 06:55:10 -07:00
Casey Bodley
2a0bb28e20
Merge pull request #20841 from oritwas/wip-rgw-metadata
rgw: trim all spaces inside a metadata value

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
2018-03-23 09:53:28 -04:00
Casey Bodley
6329d44301
Merge pull request #20842 from mkogan1/wip-rgw-23147
rgw: enable 'qlen' & 'qactive' performance counters

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
2018-03-23 09:53:03 -04:00
Casey Bodley
f97159c31d
Merge pull request #20846 from theanalyst/rgw/fix-empty-stats
rgw: radosgw-admin abort early for user stats for empty uids

Reviewed-by: Orit Wasserman <owasserm@redhat.com>
2018-03-23 09:52:38 -04:00
Ricardo Dias
f21ed94d90
Merge pull request #21021 from sebastian-philipp/dashboard-auth-qa-fix
qa/tasks/mgr/dashboard: Fix login expires too soon

Reviewed-by: Ricardo Dias <rdias@suse.com>
2018-03-23 13:48:03 +00:00
Ricardo Dias
9a031bad0f
Merge pull request #20972 from ricardoasmarques/wip-dimless-binary-directive
mgr/dashboard: Add DimlessBinaryDirective

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2018-03-23 12:38:53 +00:00
Ricardo Dias
7a490ac6b4
Merge pull request #20971 from ricardoasmarques/wip-helper-component
mgr/dashboard: Add helper component

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2018-03-23 12:38:31 +00:00
Chang Liu
1d3a67cf16 test: delete asok directories correctly
Signed-off-by: Chang Liu <liuchang0812@gmail.com>
2018-03-23 20:26:03 +08:00
Ricardo Marques
94c5a5e537 mgr/dashboard: Add helper component
Signed-off-by: Ricardo Marques <rimarques@suse.com>
2018-03-23 11:13:44 +00:00
Nathan Cutler
de2f71ada5 tools: setup-virtualenv.sh: improve error message
Signed-off-by: Nathan Cutler <ncutler@suse.com>
2018-03-23 11:34:53 +01:00
Nathan Cutler
2a93474f76 tools: setup-virtualenv.sh: add usage function and --help option
Signed-off-by: Nathan Cutler <ncutler@suse.com>
2018-03-23 11:34:04 +01:00
Ricardo Dias
d101b33bc7 qa/tasks/mgr/dashboard: Fix login expires too soon
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2018-03-23 11:30:16 +01:00
Nathan Cutler
08099019e5 tools: setup-virtualenv.sh: check for mandatory argument
Signed-off-by: Nathan Cutler <ncutler@suse.com>
2018-03-23 11:21:23 +01:00
Nathan Cutler
9f970f9cde build/ops: declare python version when calling setup-virtualenv.sh
This just makes the current Python 2.7 dependency explicit. Making
these statements optionally use Python 3 is left for later.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
2018-03-23 11:21:23 +01:00
Nathan Cutler
a4fd5c42a9 tools: setup-virtualenv.sh: do not hardcode python binary
. . . instead, take a command-line option that defaults to
"python2.7"

Fixes: http://tracker.ceph.com/issues/23437
Signed-off-by: Nathan Cutler <ncutler@suse.com>
2018-03-23 11:21:20 +01:00
Tatjana Dehler
075102468b mgr/dashboard: skip 'test_create_rbd_in_data_pool' without bluestore
Skip the test case 'test_create_rbd_in_data_pool' only if the cluster
does not support bluestore, otherwise run the test. The Ceph mgr
provides the information if the cluster supports bluestore or not, so
the test will be skipped depending on the current cluster.

Signed-off-by: Tatjana Dehler <tdehler@suse.com>
2018-03-23 11:11:27 +01:00
Tatjana Dehler
25a0ed93ec mgr/dashboard: add 'osd metadata' command call
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
2018-03-23 11:11:17 +01:00
Ricardo Marques
134fab7070 mgr/dashboard: Add DimlessBinaryDirective
Signed-off-by: Ricardo Marques <rimarques@suse.com>
2018-03-23 09:41:40 +00:00
Mykola Golub
6c722cd5f3 stop.sh: use --no-mon-config when trying to unmap rbd devices
Otherwise if stop.sh is run for already stopped cluster it will get
stuck trying to get mon config.

Signed-off-by: Mykola Golub <mgolub@suse.com>
2018-03-23 11:10:14 +02:00
Mykola Golub
f0b780f616
Merge pull request #21019 from majianpeng/fix-vstart
vstart: fix initial start when there is no ceph.conf

Reviewed-by: Mykola Golub <mgolub@suse.com>
2018-03-23 11:08:47 +02:00
Jianpeng Ma
5de320b890 vstart.sh: Avoiding ceph-conf error when create a new cluster.
This partly revert commit:f437598cfcabbd66c372bc8.
Before firstly creating a ceph cluster, there is no ceph.conf.
If specify a non-exist ceph.conf, ceph-conf will meet error.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
2018-03-23 23:30:44 +08:00